@pnp/cli-microsoft365 6.0.0-beta.4e32416 → 6.0.0-beta.55cbe4a

package/dist/m365/spo/commands/contenttype/contenttype-field-remove.js

@@ -15,10 +15,11 @@ var __classPrivateFieldGet = (this && this.__classPrivateFieldGet) || function (
 };
 var _SpoContentTypeFieldRemoveCommand_instances, _SpoContentTypeFieldRemoveCommand_initTelemetry, _SpoContentTypeFieldRemoveCommand_initOptions, _SpoContentTypeFieldRemoveCommand_initValidators, _SpoContentTypeFieldRemoveCommand_initTypes;
 Object.defineProperty(exports, "__esModule", { value: true });
-const cli_1 = require("../../../../cli");
-const Command_1 = require("../../../../Command");
+const Cli_1 = require("../../../../cli/Cli");
 const request_1 = require("../../../../request");
-const utils_1 = require("../../../../utils");
+const formatting_1 = require("../../../../utils/formatting");
+const spo_1 = require("../../../../utils/spo");
+const validation_1 = require("../../../../utils/validation");
 const SpoCommand_1 = require("../../../base/SpoCommand");
 const commands_1 = require("../../commands");
 class SpoContentTypeFieldRemoveCommand extends SpoCommand_1.default {
@@ -36,123 +37,106 @@ class SpoContentTypeFieldRemoveCommand extends SpoCommand_1.default {
     get description() {
         return 'Removes a column from a site- or list content type';
     }
-    commandAction(logger, args, cb) {
-        let webId = '';
-        let siteId = '';
-        let listId = '';
-        const removeFieldLink = () => {
-            if (this.debug) {
-                logger.logToStderr(`Get SiteId required by ProcessQuery endpoint.`);
-            }
-            // GET SiteId
-            const requestOptions = {
-                url: `${args.options.webUrl}/_api/site?$select=Id`,
-                headers: {
-                    accept: 'application/json;odata=nometadata'
-                },
-                responseType: 'json'
-            };
-            request_1.default
-                .get(requestOptions)
-                .then((res) => {
-                siteId = res.Id;
-                if (this.debug) {
-                    logger.logToStderr(`SiteId: ${siteId}`);
-                    logger.logToStderr(`Get WebId required by ProcessQuery endpoint.`);
-                }
-                // GET WebId
-                const requestOptions = {
-                    url: `${args.options.webUrl}/_api/web?$select=Id`,
-                    headers: {
-                        accept: 'application/json;odata=nometadata'
-                    },
-                    responseType: 'json'
-                };
-                return request_1.default.get(requestOptions);
-            })
-                .then((res) => {
-                webId = res.Id;
-                if (this.debug) {
-                    logger.logToStderr(`WebId: ${webId}`);
-                }
-                // If ListTitle is provided
-                if (!args.options.listTitle) {
-                    return Promise.resolve(undefined);
-                }
-                // Request for the ListId
-                const requestOptions = {
-                    url: `${args.options.webUrl}/_api/lists/GetByTitle('${utils_1.formatting.encodeQueryParameter(args.options.listTitle)}')?$select=Id`,
-                    headers: {
-                        accept: 'application/json;odata=nometadata'
-                    },
-                    responseType: 'json'
-                };
-                return request_1.default.get(requestOptions);
-            })
-                .then((res) => {
-                if (res) {
-                    listId = res.Id;
+    commandAction(logger, args) {
+        return __awaiter(this, void 0, void 0, function* () {
+            const removeFieldLink = () => __awaiter(this, void 0, void 0, function* () {
+                try {
                     if (this.debug) {
-                        logger.logToStderr(`ListId: ${listId}`);
+                        logger.logToStderr(`Get SiteId required by ProcessQuery endpoint.`);
+                    }
+                    // GET SiteId
+                    let requestOptions = {
+                        url: `${args.options.webUrl}/_api/site?$select=Id`,
+                        headers: {
+                            accept: 'application/json;odata=nometadata'
+                        },
+                        responseType: 'json'
+                    };
+                    const site = yield request_1.default.get(requestOptions);
+                    const siteId = site.Id;
+                    if (this.debug) {
+                        logger.logToStderr(`SiteId: ${siteId}`);
+                        logger.logToStderr(`Get WebId required by ProcessQuery endpoint.`);
+                    }
+                    // GET WebId
+                    requestOptions = {
+                        url: `${args.options.webUrl}/_api/web?$select=Id`,
+                        headers: {
+                            accept: 'application/json;odata=nometadata'
+                        },
+                        responseType: 'json'
+                    };
+                    const web = yield request_1.default.get(requestOptions);
+                    const webId = web.Id;
+                    if (this.debug) {
+                        logger.logToStderr(`WebId: ${webId}`);
+                    }
+                    let listId = undefined;
+                    // If ListTitle is provided
+                    if (args.options.listTitle) {
+                        // Request for the ListId
+                        const requestOptions = {
+                            url: `${args.options.webUrl}/_api/lists/GetByTitle('${formatting_1.formatting.encodeQueryParameter(args.options.listTitle)}')?$select=Id`,
+                            headers: {
+                                accept: 'application/json;odata=nometadata'
+                            },
+                            responseType: 'json'
+                        };
+                        const list = yield request_1.default.get(requestOptions);
+                        listId = list.Id;
+                        if (this.debug) {
+                            logger.logToStderr(`ListId: ${listId}`);
+                        }
+                    }
+                    const reqDigest = yield spo_1.spo.getRequestDigest(args.options.webUrl);
+                    const requestDigest = reqDigest.FormDigestValue;
+                    const updateChildContentTypes = args.options.listTitle ? false : args.options.updateChildContentTypes === true;
+                    if (this.debug) {
+                        const additionalLog = args.options.listTitle ? `; ListTitle='${args.options.listTitle}'` : ` ; UpdateChildContentTypes='${updateChildContentTypes}`;
+                        logger.logToStderr(`Remove FieldLink from ContentType. FieldLinkId='${args.options.fieldLinkId}' ; ContentTypeId='${args.options.contentTypeId}' ${additionalLog}`);
+                        logger.logToStderr(`Execute ProcessQuery.`);
+                        logger.logToStderr('');
+                    }
+                    let requestBody = '';
+                    if (listId) {
+                        requestBody = `<Request AddExpandoFieldTypeSuffix="true" SchemaVersion="15.0.0.0" LibraryVersion="16.0.0.0" ApplicationName=".NET Library" xmlns="http://schemas.microsoft.com/sharepoint/clientquery/2009"><Actions><ObjectPath Id="18" ObjectPathId="17" /><ObjectPath Id="20" ObjectPathId="19" /><Method Name="DeleteObject" Id="21" ObjectPathId="19" /><Method Name="Update" Id="22" ObjectPathId="15"><Parameters><Parameter Type="Boolean">${updateChildContentTypes}</Parameter></Parameters></Method></Actions><ObjectPaths><Property Id="17" ParentId="15" Name="FieldLinks" /><Method Id="19" ParentId="17" Name="GetById"><Parameters><Parameter Type="Guid">{${formatting_1.formatting.escapeXml(args.options.fieldLinkId)}}</Parameter></Parameters></Method><Identity Id="15" Name="09eec89e-709b-0000-558c-c222dcaf9162|740c6a0b-85e2-48a0-a494-e0f1759d4aa7:site:${siteId}:web:${webId}:list:${listId}:contenttype:${formatting_1.formatting.escapeXml(args.options.contentTypeId)}" /></ObjectPaths></Request>`;
+                    }
+                    else {
+                        requestBody = `<Request AddExpandoFieldTypeSuffix="true" SchemaVersion="15.0.0.0" LibraryVersion="16.0.0.0" ApplicationName=".NET Library" xmlns="http://schemas.microsoft.com/sharepoint/clientquery/2009"><Actions><ObjectPath Id="77" ObjectPathId="76" /><ObjectPath Id="79" ObjectPathId="78" /><Method Name="DeleteObject" Id="80" ObjectPathId="78" /><Method Name="Update" Id="81" ObjectPathId="24"><Parameters><Parameter Type="Boolean">${updateChildContentTypes}</Parameter></Parameters></Method></Actions><ObjectPaths><Property Id="76" ParentId="24" Name="FieldLinks" /><Method Id="78" ParentId="76" Name="GetById"><Parameters><Parameter Type="Guid">{${formatting_1.formatting.escapeXml(args.options.fieldLinkId)}}</Parameter></Parameters></Method><Identity Id="24" Name="6b3ec69e-00a7-0000-55a3-61f8d779d2b3|740c6a0b-85e2-48a0-a494-e0f1759d4aa7:site:${siteId}:web:${webId}:contenttype:${formatting_1.formatting.escapeXml(args.options.contentTypeId)}" /></ObjectPaths></Request>`;
+                    }
+                    requestOptions = {
+                        url: `${args.options.webUrl}/_vti_bin/client.svc/ProcessQuery`,
+                        headers: {
+                            'X-RequestDigest': requestDigest
+                        },
+                        data: requestBody
+                    };
+                    const res = yield request_1.default.post(requestOptions);
+                    const json = JSON.parse(res);
+                    const response = json[0];
+                    if (response.ErrorInfo) {
+                        throw response.ErrorInfo.ErrorMessage;
                     }
                 }
-                return utils_1.spo.getRequestDigest(args.options.webUrl);
-            })
-                .then((res) => {
-                const requestDigest = res.FormDigestValue;
-                const updateChildContentTypes = args.options.listTitle ? false : args.options.updateChildContentTypes === true;
-                if (this.debug) {
-                    const additionalLog = args.options.listTitle ? `; ListTitle='${args.options.listTitle}'` : ` ; UpdateChildContentTypes='${updateChildContentTypes}`;
-                    logger.logToStderr(`Remove FieldLink from ContentType. FieldLinkId='${args.options.fieldLinkId}' ; ContentTypeId='${args.options.contentTypeId}' ${additionalLog}`);
-                    logger.logToStderr(`Execute ProcessQuery.`);
-                    logger.logToStderr('');
-                }
-                let requestBody = '';
-                if (listId) {
-                    requestBody = `<Request AddExpandoFieldTypeSuffix="true" SchemaVersion="15.0.0.0" LibraryVersion="16.0.0.0" ApplicationName=".NET Library" xmlns="http://schemas.microsoft.com/sharepoint/clientquery/2009"><Actions><ObjectPath Id="18" ObjectPathId="17" /><ObjectPath Id="20" ObjectPathId="19" /><Method Name="DeleteObject" Id="21" ObjectPathId="19" /><Method Name="Update" Id="22" ObjectPathId="15"><Parameters><Parameter Type="Boolean">${updateChildContentTypes}</Parameter></Parameters></Method></Actions><ObjectPaths><Property Id="17" ParentId="15" Name="FieldLinks" /><Method Id="19" ParentId="17" Name="GetById"><Parameters><Parameter Type="Guid">{${utils_1.formatting.escapeXml(args.options.fieldLinkId)}}</Parameter></Parameters></Method><Identity Id="15" Name="09eec89e-709b-0000-558c-c222dcaf9162|740c6a0b-85e2-48a0-a494-e0f1759d4aa7:site:${siteId}:web:${webId}:list:${listId}:contenttype:${utils_1.formatting.escapeXml(args.options.contentTypeId)}" /></ObjectPaths></Request>`;
-                }
-                else {
-                    requestBody = `<Request AddExpandoFieldTypeSuffix="true" SchemaVersion="15.0.0.0" LibraryVersion="16.0.0.0" ApplicationName=".NET Library" xmlns="http://schemas.microsoft.com/sharepoint/clientquery/2009"><Actions><ObjectPath Id="77" ObjectPathId="76" /><ObjectPath Id="79" ObjectPathId="78" /><Method Name="DeleteObject" Id="80" ObjectPathId="78" /><Method Name="Update" Id="81" ObjectPathId="24"><Parameters><Parameter Type="Boolean">${updateChildContentTypes}</Parameter></Parameters></Method></Actions><ObjectPaths><Property Id="76" ParentId="24" Name="FieldLinks" /><Method Id="78" ParentId="76" Name="GetById"><Parameters><Parameter Type="Guid">{${utils_1.formatting.escapeXml(args.options.fieldLinkId)}}</Parameter></Parameters></Method><Identity Id="24" Name="6b3ec69e-00a7-0000-55a3-61f8d779d2b3|740c6a0b-85e2-48a0-a494-e0f1759d4aa7:site:${siteId}:web:${webId}:contenttype:${utils_1.formatting.escapeXml(args.options.contentTypeId)}" /></ObjectPaths></Request>`;
-                }
-                const requestOptions = {
-                    url: `${args.options.webUrl}/_vti_bin/client.svc/ProcessQuery`,
-                    headers: {
-                        'X-RequestDigest': requestDigest
-                    },
-                    data: requestBody
-                };
-                return request_1.default.post(requestOptions);
-            })
-                .then((res) => {
-                const json = JSON.parse(res);
-                const response = json[0];
-                if (response.ErrorInfo) {
-                    cb(new Command_1.CommandError(response.ErrorInfo.ErrorMessage));
-                    return;
+                catch (err) {
+                    this.handleRejectedODataJsonPromise(err);
                 }
-                cb();
-            }, (error) => {
-                this.handleRejectedODataJsonPromise(error, logger, cb);
             });
-        };
-        if (args.options.confirm) {
-            removeFieldLink();
-        }
-        else {
-            cli_1.Cli.prompt({
-                type: 'confirm',
-                name: 'continue',
-                default: false,
-                message: `Are you sure you want to remove the column ${args.options.fieldLinkId} from content type ${args.options.contentTypeId}?`
-            }, (result) => {
-                if (!result.continue) {
-                    cb();
-                }
-                else {
-                    removeFieldLink();
+            if (args.options.confirm) {
+                yield removeFieldLink();
+            }
+            else {
+                const result = yield Cli_1.Cli.prompt({
+                    type: 'confirm',
+                    name: 'continue',
+                    default: false,
+                    message: `Are you sure you want to remove the column ${args.options.fieldLinkId} from content type ${args.options.contentTypeId}?`
+                });
+                if (result.continue) {
+                    yield removeFieldLink();
                 }
-            });
-        }
+            }
+        });
     }
 }
 _SpoContentTypeFieldRemoveCommand_instances = new WeakSet(), _SpoContentTypeFieldRemoveCommand_initTelemetry = function _SpoContentTypeFieldRemoveCommand_initTelemetry() {
@@ -179,10 +163,10 @@ _SpoContentTypeFieldRemoveCommand_instances = new WeakSet(), _SpoContentTypeFiel
     });
 }, _SpoContentTypeFieldRemoveCommand_initValidators = function _SpoContentTypeFieldRemoveCommand_initValidators() {
     this.validators.push((args) => __awaiter(this, void 0, void 0, function* () {
-        if (!utils_1.validation.isValidGuid(args.options.fieldLinkId)) {
+        if (!validation_1.validation.isValidGuid(args.options.fieldLinkId)) {
             return `${args.options.fieldLinkId} is not a valid GUID`;
         }
-        return utils_1.validation.isValidSharePointUrl(args.options.webUrl);
+        return validation_1.validation.isValidSharePointUrl(args.options.webUrl);
     }));
 }, _SpoContentTypeFieldRemoveCommand_initTypes = function _SpoContentTypeFieldRemoveCommand_initTypes() {
     this.types.string.push('i', 'contentTypeId');

package/dist/m365/spo/commands/contenttype/contenttype-field-set.js

@@ -15,10 +15,11 @@ var __classPrivateFieldGet = (this && this.__classPrivateFieldGet) || function (
 };
 var _SpoContentTypeFieldSetCommand_instances, _SpoContentTypeFieldSetCommand_initTelemetry, _SpoContentTypeFieldSetCommand_initOptions, _SpoContentTypeFieldSetCommand_initValidators, _SpoContentTypeFieldSetCommand_initTypes;
 Object.defineProperty(exports, "__esModule", { value: true });
-const Command_1 = require("../../../../Command");
 const config_1 = require("../../../../config");
 const request_1 = require("../../../../request");
-const utils_1 = require("../../../../utils");
+const formatting_1 = require("../../../../utils/formatting");
+const spo_1 = require("../../../../utils/spo");
+const validation_1 = require("../../../../utils/validation");
 const SpoCommand_1 = require("../../../base/SpoCommand");
 const commands_1 = require("../../commands");
 class SpoContentTypeFieldSetCommand extends SpoCommand_1.default {
@@ -40,156 +41,131 @@ class SpoContentTypeFieldSetCommand extends SpoCommand_1.default {
     get description() {
         return 'Adds or updates a site column reference in a site content type';
     }
-    commandAction(logger, args, cb) {
-        let schemaXmlWithResourceTokens = '';
-        if (this.verbose) {
-            logger.logToStderr(`Retrieving field link for field ${args.options.id}...`);
-        }
-        const requestOptions = {
-            url: `${args.options.webUrl}/_api/web/contenttypes('${encodeURIComponent(args.options.contentTypeId)}')/fieldlinks('${args.options.id}')`,
-            headers: {
-                accept: 'application/json;odata=nometadata'
-            },
-            responseType: 'json'
-        };
-        request_1.default
-            .get(requestOptions)
-            .then((res) => {
-            if (res["odata.null"] !== true) {
+    commandAction(logger, args) {
+        return __awaiter(this, void 0, void 0, function* () {
+            try {
+                let schemaXmlWithResourceTokens = '';
                 if (this.verbose) {
-                    logger.logToStderr('Field link found');
+                    logger.logToStderr(`Retrieving field link for field ${args.options.id}...`);
+                }
+                let requestOptions = {
+                    url: `${args.options.webUrl}/_api/web/contenttypes('${encodeURIComponent(args.options.contentTypeId)}')/fieldlinks('${args.options.id}')`,
+                    headers: {
+                        accept: 'application/json;odata=nometadata'
+                    },
+                    responseType: 'json'
+                };
+                const fieldLink = yield request_1.default.get(requestOptions);
+                if (fieldLink["odata.null"] !== true) {
+                    if (this.verbose) {
+                        logger.logToStderr('Field link found');
+                    }
+                    this.fieldLink = fieldLink;
+                }
+                else {
+                    if (this.verbose) {
+                        logger.logToStderr('Field link not found. Creating...');
+                        logger.logToStderr(`Retrieving information about site column ${args.options.id}...`);
+                    }
+                    requestOptions = {
+                        url: `${args.options.webUrl}/_api/web/fields('${args.options.id}')?$select=SchemaXmlWithResourceTokens`,
+                        headers: {
+                            accept: 'application/json;odata=nometadata'
+                        },
+                        responseType: 'json'
+                    };
+                    const field = yield request_1.default.get(requestOptions);
+                    schemaXmlWithResourceTokens = field.SchemaXmlWithResourceTokens;
+                    yield this.createFieldLink(logger, args, schemaXmlWithResourceTokens);
+                }
+                if (!this.fieldLink) {
+                    if (this.verbose) {
+                        logger.logToStderr(`Retrieving information about field link for field ${args.options.id}...`);
+                    }
+                    requestOptions = {
+                        url: `${args.options.webUrl}/_api/web/contenttypes('${encodeURIComponent(args.options.contentTypeId)}')/fieldlinks('${args.options.id}')`,
+                        headers: {
+                            accept: 'application/json;odata=nometadata'
+                        },
+                        responseType: 'json'
+                    };
+                    const fieldLinkResult = yield request_1.default.get(requestOptions);
+                    if (fieldLinkResult && fieldLinkResult["odata.null"] !== true) {
+                        this.fieldLink = fieldLinkResult;
+                    }
+                }
+                if (!this.fieldLink) {
+                    throw `Couldn't find field link for field ${args.options.id}`;
+                }
+                let updateHidden = false;
+                let updateRequired = false;
+                if (typeof args.options.hidden !== 'undefined' &&
+                    this.fieldLink.Hidden !== (args.options.hidden === 'true')) {
+                    updateHidden = true;
+                }
+                if (typeof args.options.required !== 'undefined' &&
+                    this.fieldLink.Required !== (args.options.required === 'true')) {
+                    updateRequired = true;
+                }
+                if (!updateHidden && !updateRequired) {
+                    if (this.verbose) {
+                        logger.logToStderr('Field link already up-to-date');
+                    }
+                    throw 'DONE';
+                }
+                if (!this.siteId) {
+                    if (this.verbose) {
+                        logger.logToStderr(`Retrieving site collection id...`);
+                    }
+                    requestOptions = {
+                        url: `${args.options.webUrl}/_api/site?$select=Id`,
+                        headers: {
+                            accept: 'application/json;odata=nometadata'
+                        },
+                        responseType: 'json'
+                    };
+                    const site = yield request_1.default.get(requestOptions);
+                    this.siteId = site.Id;
+                }
+                if (!this.webId) {
+                    if (this.verbose) {
+                        logger.logToStderr(`Retrieving site id...`);
+                    }
+                    requestOptions = {
+                        url: `${args.options.webUrl}/_api/web?$select=Id`,
+                        headers: {
+                            accept: 'application/json;odata=nometadata'
+                        },
+                        responseType: 'json'
+                    };
+                    const web = yield request_1.default.get(requestOptions);
+                    this.webId = web.Id;
                 }
-                this.fieldLink = res;
-                return Promise.resolve(undefined);
-            }
-            if (this.verbose) {
-                logger.logToStderr('Field link not found. Creating...');
-                logger.logToStderr(`Retrieving information about site column ${args.options.id}...`);
-            }
-            const requestOptions = {
-                url: `${args.options.webUrl}/_api/web/fields('${args.options.id}')?$select=SchemaXmlWithResourceTokens`,
-                headers: {
-                    accept: 'application/json;odata=nometadata'
-                },
-                responseType: 'json'
-            };
-            return request_1.default.get(requestOptions);
-        })
-            .then((res) => {
-            if (!res) {
-                return Promise.resolve();
-            }
-            schemaXmlWithResourceTokens = res.SchemaXmlWithResourceTokens;
-            return this.createFieldLink(logger, args, schemaXmlWithResourceTokens);
-        })
-            .then(() => {
-            if (this.fieldLink) {
-                return Promise.resolve(undefined);
-            }
-            if (this.verbose) {
-                logger.logToStderr(`Retrieving information about field link for field ${args.options.id}...`);
-            }
-            const requestOptions = {
-                url: `${args.options.webUrl}/_api/web/contenttypes('${encodeURIComponent(args.options.contentTypeId)}')/fieldlinks('${args.options.id}')`,
-                headers: {
-                    accept: 'application/json;odata=nometadata'
-                },
-                responseType: 'json'
-            };
-            return request_1.default.get(requestOptions);
-        })
-            .then((res) => {
-            if (res && res["odata.null"] !== true) {
-                this.fieldLink = res;
-            }
-            if (!this.fieldLink) {
-                return Promise.reject(`Couldn't find field link for field ${args.options.id}`);
-            }
-            let updateHidden = false;
-            let updateRequired = false;
-            if (typeof args.options.hidden !== 'undefined' &&
-                this.fieldLink.Hidden !== (args.options.hidden === 'true')) {
-                updateHidden = true;
-            }
-            if (typeof args.options.required !== 'undefined' &&
-                this.fieldLink.Required !== (args.options.required === 'true')) {
-                updateRequired = true;
-            }
-            if (!updateHidden && !updateRequired) {
                 if (this.verbose) {
-                    logger.logToStderr('Field link already up-to-date');
+                    logger.logToStderr(`Updating field link...`);
+                }
+                const requiredProperty = typeof args.options.required !== 'undefined' &&
+                    this.fieldLink.Required !== (args.options.required === 'true') ? `<SetProperty Id="122" ObjectPathId="121" Name="Required"><Parameter Type="Boolean">${args.options.required}</Parameter></SetProperty>` : '';
+                const hiddenProperty = typeof args.options.hidden !== 'undefined' &&
+                    this.fieldLink.Hidden !== (args.options.hidden === 'true') ? `<SetProperty Id="123" ObjectPathId="121" Name="Hidden"><Parameter Type="Boolean">${args.options.hidden}</Parameter></SetProperty>` : '';
+                requestOptions = {
+                    url: `${args.options.webUrl}/_vti_bin/client.svc/ProcessQuery`,
+                    headers: {
+                        'X-RequestDigest': this.requestDigest
+                    },
+                    data: `<Request AddExpandoFieldTypeSuffix="true" SchemaVersion="15.0.0.0" LibraryVersion="16.0.0.0" ApplicationName="${config_1.default.applicationName}" xmlns="http://schemas.microsoft.com/sharepoint/clientquery/2009"><Actions>${requiredProperty}${hiddenProperty}<Method Name="Update" Id="124" ObjectPathId="19"><Parameters><Parameter Type="Boolean">true</Parameter></Parameters></Method></Actions><ObjectPaths><Identity Id="121" Name="716a7b9e-3012-0000-22fb-84acfcc67d04|740c6a0b-85e2-48a0-a494-e0f1759d4aa7:site:${this.siteId}:web:${this.webId}:contenttype:${formatting_1.formatting.escapeXml(args.options.contentTypeId)}:fl:${this.fieldLink.Id}" /><Identity Id="19" Name="716a7b9e-3012-0000-22fb-84acfcc67d04|740c6a0b-85e2-48a0-a494-e0f1759d4aa7:site:${this.siteId}:web:${this.webId}:contenttype:${formatting_1.formatting.escapeXml(args.options.contentTypeId)}" /></ObjectPaths></Request>`
+                };
+                const res = yield request_1.default.post(requestOptions);
+                const json = JSON.parse(res);
+                const response = json[0];
+                if (response.ErrorInfo) {
+                    throw response.ErrorInfo.ErrorMessage;
                 }
-                return Promise.reject('DONE');
-            }
-            if (this.siteId) {
-                return Promise.resolve(undefined);
-            }
-            if (this.verbose) {
-                logger.logToStderr(`Retrieving site collection id...`);
-            }
-            const requestOptions = {
-                url: `${args.options.webUrl}/_api/site?$select=Id`,
-                headers: {
-                    accept: 'application/json;odata=nometadata'
-                },
-                responseType: 'json'
-            };
-            return request_1.default.get(requestOptions);
-        })
-            .then((res) => {
-            if (res) {
-                this.siteId = res.Id;
-            }
-            if (this.webId) {
-                return Promise.resolve(undefined);
-            }
-            if (this.verbose) {
-                logger.logToStderr(`Retrieving site id...`);
-            }
-            const requestOptions = {
-                url: `${args.options.webUrl}/_api/web?$select=Id`,
-                headers: {
-                    accept: 'application/json;odata=nometadata'
-                },
-                responseType: 'json'
-            };
-            return request_1.default.get(requestOptions);
-        })
-            .then((res) => {
-            if (res) {
-                this.webId = res.Id;
-            }
-            if (this.verbose) {
-                logger.logToStderr(`Updating field link...`);
-            }
-            const requiredProperty = typeof args.options.required !== 'undefined' &&
-                this.fieldLink.Required !== (args.options.required === 'true') ? `<SetProperty Id="122" ObjectPathId="121" Name="Required"><Parameter Type="Boolean">${args.options.required}</Parameter></SetProperty>` : '';
-            const hiddenProperty = typeof args.options.hidden !== 'undefined' &&
-                this.fieldLink.Hidden !== (args.options.hidden === 'true') ? `<SetProperty Id="123" ObjectPathId="121" Name="Hidden"><Parameter Type="Boolean">${args.options.hidden}</Parameter></SetProperty>` : '';
-            const requestOptions = {
-                url: `${args.options.webUrl}/_vti_bin/client.svc/ProcessQuery`,
-                headers: {
-                    'X-RequestDigest': this.requestDigest
-                },
-                data: `<Request AddExpandoFieldTypeSuffix="true" SchemaVersion="15.0.0.0" LibraryVersion="16.0.0.0" ApplicationName="${config_1.default.applicationName}" xmlns="http://schemas.microsoft.com/sharepoint/clientquery/2009"><Actions>${requiredProperty}${hiddenProperty}<Method Name="Update" Id="124" ObjectPathId="19"><Parameters><Parameter Type="Boolean">true</Parameter></Parameters></Method></Actions><ObjectPaths><Identity Id="121" Name="716a7b9e-3012-0000-22fb-84acfcc67d04|740c6a0b-85e2-48a0-a494-e0f1759d4aa7:site:${this.siteId}:web:${this.webId}:contenttype:${utils_1.formatting.escapeXml(args.options.contentTypeId)}:fl:${this.fieldLink.Id}" /><Identity Id="19" Name="716a7b9e-3012-0000-22fb-84acfcc67d04|740c6a0b-85e2-48a0-a494-e0f1759d4aa7:site:${this.siteId}:web:${this.webId}:contenttype:${utils_1.formatting.escapeXml(args.options.contentTypeId)}" /></ObjectPaths></Request>`
-            };
-            return request_1.default.post(requestOptions);
-        })
-            .then((res) => {
-            const json = JSON.parse(res);
-            const response = json[0];
-            if (response.ErrorInfo) {
-                cb(new Command_1.CommandError(response.ErrorInfo.ErrorMessage));
-            }
-            else {
-                cb();
-            }
-        }, (error) => {
-            if (error === 'DONE') {
-                cb();
             }
-            else {
-                this.handleRejectedODataJsonPromise(error, logger, cb);
+            catch (err) {
+                if (err !== 'DONE') {
+                    this.handleRejectedODataJsonPromise(err);
+                }
             }
         });
     }
@@ -248,7 +224,7 @@ class SpoContentTypeFieldSetCommand extends SpoCommand_1.default {
                     headers: {
                         'X-RequestDigest': this.requestDigest
                     },
-                    data: `<Request AddExpandoFieldTypeSuffix="true" SchemaVersion="15.0.0.0" LibraryVersion="16.0.0.0" ApplicationName="${config_1.default.applicationName}" xmlns="http://schemas.microsoft.com/sharepoint/clientquery/2009"><Actions><ObjectPath Id="5" ObjectPathId="4" /><ObjectIdentityQuery Id="6" ObjectPathId="4" /><Method Name="Update" Id="7" ObjectPathId="1"><Parameters><Parameter Type="Boolean">true</Parameter></Parameters></Method></Actions><ObjectPaths><Identity Id="2" Name="d6667b9e-50fb-0000-2693-032ae7a0df25|740c6a0b-85e2-48a0-a494-e0f1759d4aa7:site:${this.siteId}:web:${this.webId}:field:${args.options.id}" /><Method Id="4" ParentId="3" Name="Add"><Parameters><Parameter TypeId="{63fb2c92-8f65-4bbb-a658-b6cd294403f4}"><Property Name="Field" ObjectPathId="2" /></Parameter></Parameters></Method><Identity Id="1" Name="d6667b9e-80f4-0000-2693-05528ff416bf|740c6a0b-85e2-48a0-a494-e0f1759d4aa7:site:${this.siteId}:web:${this.webId}:contenttype:${utils_1.formatting.escapeXml(args.options.contentTypeId)}" /><Property Id="3" ParentId="1" Name="FieldLinks" /></ObjectPaths></Request>`
+                    data: `<Request AddExpandoFieldTypeSuffix="true" SchemaVersion="15.0.0.0" LibraryVersion="16.0.0.0" ApplicationName="${config_1.default.applicationName}" xmlns="http://schemas.microsoft.com/sharepoint/clientquery/2009"><Actions><ObjectPath Id="5" ObjectPathId="4" /><ObjectIdentityQuery Id="6" ObjectPathId="4" /><Method Name="Update" Id="7" ObjectPathId="1"><Parameters><Parameter Type="Boolean">true</Parameter></Parameters></Method></Actions><ObjectPaths><Identity Id="2" Name="d6667b9e-50fb-0000-2693-032ae7a0df25|740c6a0b-85e2-48a0-a494-e0f1759d4aa7:site:${this.siteId}:web:${this.webId}:field:${args.options.id}" /><Method Id="4" ParentId="3" Name="Add"><Parameters><Parameter TypeId="{63fb2c92-8f65-4bbb-a658-b6cd294403f4}"><Property Name="Field" ObjectPathId="2" /></Parameter></Parameters></Method><Identity Id="1" Name="d6667b9e-80f4-0000-2693-05528ff416bf|740c6a0b-85e2-48a0-a494-e0f1759d4aa7:site:${this.siteId}:web:${this.webId}:contenttype:${formatting_1.formatting.escapeXml(args.options.contentTypeId)}" /><Property Id="3" ParentId="1" Name="FieldLinks" /></ObjectPaths></Request>`
                 };
                 return request_1.default.post(requestOptions);
             })
@@ -315,7 +291,7 @@ class SpoContentTypeFieldSetCommand extends SpoCommand_1.default {
             if (this.debug) {
                 logger.logToStderr('Retrieving request digest...');
             }
-            utils_1.spo
+            spo_1.spo
                 .getRequestDigest(siteUrl)
                 .then((res) => {
                 this.requestDigest = res.FormDigestValue;
@@ -347,7 +323,7 @@ _SpoContentTypeFieldSetCommand_instances = new WeakSet(), _SpoContentTypeFieldSe
     });
 }, _SpoContentTypeFieldSetCommand_initValidators = function _SpoContentTypeFieldSetCommand_initValidators() {
     this.validators.push((args) => __awaiter(this, void 0, void 0, function* () {
-        if (!utils_1.validation.isValidGuid(args.options.id)) {
+        if (!validation_1.validation.isValidGuid(args.options.id)) {
             return `${args.options.id} is not a valid GUID`;
         }
         if (typeof args.options.required !== 'undefined') {
@@ -362,7 +338,7 @@ _SpoContentTypeFieldSetCommand_instances = new WeakSet(), _SpoContentTypeFieldSe
                 return `${args.options.hidden} is not a valid boolean value. Allowed values are true|false`;
             }
         }
-        return utils_1.validation.isValidSharePointUrl(args.options.webUrl);
+        return validation_1.validation.isValidSharePointUrl(args.options.webUrl);
     }));
 }, _SpoContentTypeFieldSetCommand_initTypes = function _SpoContentTypeFieldSetCommand_initTypes() {
     this.types.string.push('contentTypeId', 'c');