@pnp/cli-microsoft365 5.7.0 → 5.8.0-beta.119711d

package/dist/m365/spfx/commands/package/package-generate.js

@@ -37,119 +37,126 @@ class SpfxPackageGenerateCommand extends AnonymousCommand_1.default {
     get description() {
         return 'Generates SharePoint Framework solution package with a no-framework web part rendering the specified HTML snippet';
     }
-    commandAction(logger, args, cb) {
-        const supportedHosts = ['SharePointWebPart'];
-        if (args.options.enableForTeams === 'tab' || args.options.enableForTeams === 'all') {
-            supportedHosts.push('TeamsTab');
-        }
-        if (args.options.enableForTeams === 'personalApp' || args.options.enableForTeams === 'all') {
-            supportedHosts.push('TeamsPersonalApp');
-        }
-        const tokens = {
-            clientSideAssetsFeatureId: SpfxPackageGenerateCommand.generateNewId(),
-            developerName: args.options.developerName || 'Contoso',
-            developerWebsiteUrl: args.options.developerWebsiteUrl || 'https://contoso.com/my-app',
-            developerPrivacyUrl: args.options.developerPrivacyUrl || 'https://contoso.com/privacy',
-            developerTermsOfUseUrl: args.options.developerTermsOfUseUrl || 'https://contoso.com/terms-of-use',
-            developerMpnId: args.options.developerMpnId || '000000',
-            exposePageContextGlobally: args.options.exposePageContextGlobally ? '!0' : '!1',
-            exposeTeamsContextGlobally: args.options.exposeTeamsContextGlobally ? '!0' : '!1',
-            html: args.options.html.replace(/"/g, '\\"').replace(/\r\n/g, ' ').replace(/\n/g, ' '),
-            packageName: SpfxPackageGenerateCommand.getSafePackageName(args.options.webPartTitle),
-            productId: SpfxPackageGenerateCommand.generateNewId(),
-            skipFeatureDeployment: (args.options.allowTenantWideDeployment === true).toString(),
-            supportedHosts: JSON.stringify(supportedHosts).replace(/"/g, '"'),
-            webPartId: SpfxPackageGenerateCommand.generateNewId(),
-            webPartFeatureName: `${args.options.webPartTitle} Feature`,
-            webPartFeatureDescription: `A feature which activates the Client-Side WebPart named ${args.options.webPartTitle}`,
-            webPartAlias: SpfxPackageGenerateCommand.getWebPartAlias(args.options.webPartTitle),
-            webPartName: args.options.webPartTitle,
-            webPartSafeName: SpfxPackageGenerateCommand.getSafeWebPartName(args.options.webPartTitle),
-            webPartDescription: args.options.webPartDescription,
-            webPartModule: SpfxPackageGenerateCommand.getSafePackageName(args.options.webPartTitle)
-        };
-        let tmpDir = undefined;
-        let error;
-        try {
-            if (this.verbose) {
-                logger.log(`Creating temp folder...`);
-            }
-            tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'cli-spfx'));
-            if (this.debug) {
-                logger.log(`Temp folder created at ${tmpDir}`);
+    commandAction(logger, args) {
+        return __awaiter(this, void 0, void 0, function* () {
+            const supportedHosts = ['SharePointWebPart'];
+            if (args.options.enableForTeams === 'tab' || args.options.enableForTeams === 'all') {
+                supportedHosts.push('TeamsTab');
             }
-            if (this.verbose) {
-                logger.log('Copying files...');
+            if (args.options.enableForTeams === 'personalApp' || args.options.enableForTeams === 'all') {
+                supportedHosts.push('TeamsPersonalApp');
             }
-            const src = path.join(__dirname, 'package-generate', 'assets');
-            utils_1.fsUtil.copyRecursiveSync(src, tmpDir, s => SpfxPackageGenerateCommand.replaceTokens(s, tokens));
-            const files = utils_1.fsUtil.readdirR(tmpDir);
-            if (this.verbose) {
-                logger.log('Processing files...');
-            }
-            files.forEach(filePath => {
+            const tokens = {
+                clientSideAssetsFeatureId: SpfxPackageGenerateCommand.generateNewId(),
+                developerName: args.options.developerName || 'Contoso',
+                developerWebsiteUrl: args.options.developerWebsiteUrl || 'https://contoso.com/my-app',
+                developerPrivacyUrl: args.options.developerPrivacyUrl || 'https://contoso.com/privacy',
+                developerTermsOfUseUrl: args.options.developerTermsOfUseUrl || 'https://contoso.com/terms-of-use',
+                developerMpnId: args.options.developerMpnId || '000000',
+                exposePageContextGlobally: args.options.exposePageContextGlobally ? '!0' : '!1',
+                exposeTeamsContextGlobally: args.options.exposeTeamsContextGlobally ? '!0' : '!1',
+                html: args.options.html.replace(/"/g, '\\"').replace(/\r\n/g, ' ').replace(/\n/g, ' '),
+                packageName: SpfxPackageGenerateCommand.getSafePackageName(args.options.webPartTitle),
+                productId: SpfxPackageGenerateCommand.generateNewId(),
+                skipFeatureDeployment: (args.options.allowTenantWideDeployment === true).toString(),
+                supportedHosts: JSON.stringify(supportedHosts).replace(/"/g, '"'),
+                webPartId: SpfxPackageGenerateCommand.generateNewId(),
+                webPartFeatureName: `${args.options.webPartTitle} Feature`,
+                webPartFeatureDescription: `A feature which activates the Client-Side WebPart named ${args.options.webPartTitle}`,
+                webPartAlias: SpfxPackageGenerateCommand.getWebPartAlias(args.options.webPartTitle),
+                webPartName: args.options.webPartTitle,
+                webPartSafeName: SpfxPackageGenerateCommand.getSafeWebPartName(args.options.webPartTitle),
+                webPartDescription: args.options.webPartDescription,
+                webPartModule: SpfxPackageGenerateCommand.getSafePackageName(args.options.webPartTitle)
+            };
+            let tmpDir = undefined;
+            let error;
+            try {
+                if (this.verbose) {
+                    logger.log(`Creating temp folder...`);
+                }
+                tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'cli-spfx'));
                 if (this.debug) {
-                    logger.log(`Processing ${filePath}...`);
+                    logger.log(`Temp folder created at ${tmpDir}`);
                 }
-                if (!SpfxPackageGenerateCommand.isBinaryFile(filePath)) {
-                    if (this.verbose) {
-                        logger.log('Replacing tokens...');
-                    }
-                    let fileContents = fs.readFileSync(filePath, 'utf-8');
+                if (this.verbose) {
+                    logger.log('Copying files...');
+                }
+                const src = path.join(__dirname, 'package-generate', 'assets');
+                utils_1.fsUtil.copyRecursiveSync(src, tmpDir, s => SpfxPackageGenerateCommand.replaceTokens(s, tokens));
+                const files = utils_1.fsUtil.readdirR(tmpDir);
+                if (this.verbose) {
+                    logger.log('Processing files...');
+                }
+                files.forEach(filePath => {
                     if (this.debug) {
-                        logger.log('Before:');
-                        logger.log(fileContents);
+                        logger.log(`Processing ${filePath}...`);
                     }
-                    fileContents = SpfxPackageGenerateCommand.replaceTokens(fileContents, tokens);
-                    if (this.debug) {
-                        logger.log('After:');
-                        logger.log(fileContents);
+                    if (!SpfxPackageGenerateCommand.isBinaryFile(filePath)) {
+                        if (this.verbose) {
+                            logger.log('Replacing tokens...');
+                        }
+                        let fileContents = fs.readFileSync(filePath, 'utf-8');
+                        if (this.debug) {
+                            logger.log('Before:');
+                            logger.log(fileContents);
+                        }
+                        fileContents = SpfxPackageGenerateCommand.replaceTokens(fileContents, tokens);
+                        if (this.debug) {
+                            logger.log('After:');
+                            logger.log(fileContents);
+                        }
+                        fs.writeFileSync(filePath, fileContents, { encoding: 'utf-8' });
+                    }
+                    else {
+                        if (this.verbose) {
+                            logger.log(`Binary file. Skipping replacing tokens in contents`);
+                        }
                     }
-                    fs.writeFileSync(filePath, fileContents, { encoding: 'utf-8' });
+                });
+                if (this.verbose) {
+                    logger.log('Creating .sppkg file...');
+                }
+                // we need this to be able to inject mock AdmZip for testing
+                /* c8 ignore next 3 */
+                if (!this.archive) {
+                    this.archive = new AdmZip();
                 }
-                else {
-                    if (this.verbose) {
-                        logger.log(`Binary file. Skipping replacing tokens in contents`);
+                const filesToZip = utils_1.fsUtil.readdirR(tmpDir);
+                filesToZip.forEach(f => {
+                    if (this.debug) {
+                        logger.log(`Adding ${f} to archive...`);
                     }
+                    this.archive.addLocalFile(f, path.relative(tmpDir, path.dirname(f)), path.basename(f));
+                });
+                if (this.debug) {
+                    logger.log('Writing archive...');
                 }
-            });
-            if (this.verbose) {
-                logger.log('Creating .sppkg file...');
+                this.archive.writeZip(`${args.options.packageName}.sppkg`);
             }
-            // we need this to be able to inject mock AdmZip for testing
-            /* c8 ignore next 3 */
-            if (!this.archive) {
-                this.archive = new AdmZip();
+            catch (err) {
+                error = err.message;
             }
-            const filesToZip = utils_1.fsUtil.readdirR(tmpDir);
-            filesToZip.forEach(f => {
-                if (this.debug) {
-                    logger.log(`Adding ${f} to archive...`);
+            finally {
+                try {
+                    if (tmpDir) {
+                        if (this.verbose) {
+                            logger.log(`Deleting temp folder at ${tmpDir}...`);
+                        }
+                        fs.rmdirSync(tmpDir, { recursive: true });
+                    }
+                    if (error) {
+                        throw error;
+                    }
                 }
-                this.archive.addLocalFile(f, path.relative(tmpDir, path.dirname(f)), path.basename(f));
-            });
-            if (this.debug) {
-                logger.log('Writing archive...');
-            }
-            this.archive.writeZip(`${args.options.packageName}.sppkg`);
-        }
-        catch (err) {
-            error = err.message;
-        }
-        finally {
-            try {
-                if (tmpDir) {
-                    if (this.verbose) {
-                        logger.log(`Deleting temp folder at ${tmpDir}...`);
+                catch (ex) {
+                    if (ex === error) {
+                        throw ex;
                     }
-                    fs.rmdirSync(tmpDir, { recursive: true });
+                    throw `An error has occurred while removing the temp folder at ${tmpDir}. Please remove it manually.`;
                 }
-                cb(error);
             }
-            catch (ex) {
-                cb(`An error has occurred while removing the temp folder at ${tmpDir}. Please remove it manually.`);
-            }
-        }
+        });
     }
     static replaceTokens(s, tokens) {
         return s.replace(/\$([^\$]+)\$/g, (substring, token) => {

package/dist/m365/spfx/commands/project/project-doctor/doctor-1.16.0-beta.1.js

@@ -0,0 +1,23 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const FN001008_DEP_react_1 = require("./rules/FN001008_DEP_react");
+const FN001009_DEP_react_dom_1 = require("./rules/FN001009_DEP_react_dom");
+const FN001022_DEP_office_ui_fabric_react_1 = require("./rules/FN001022_DEP_office_ui_fabric_react");
+const FN002004_DEVDEP_gulp_1 = require("./rules/FN002004_DEVDEP_gulp");
+const FN002007_DEVDEP_ajv_1 = require("./rules/FN002007_DEVDEP_ajv");
+const FN002013_DEVDEP_types_webpack_env_1 = require("./rules/FN002013_DEVDEP_types_webpack_env");
+const FN002015_DEVDEP_types_react_1 = require("./rules/FN002015_DEVDEP_types_react");
+const FN002016_DEVDEP_types_react_dom_1 = require("./rules/FN002016_DEVDEP_types_react_dom");
+const FN002019_DEVDEP_microsoft_rush_stack_compiler_1 = require("./rules/FN002019_DEVDEP_microsoft_rush_stack_compiler");
+module.exports = [
+    new FN001008_DEP_react_1.FN001008_DEP_react('16'),
+    new FN001009_DEP_react_dom_1.FN001009_DEP_react_dom('16'),
+    new FN001022_DEP_office_ui_fabric_react_1.FN001022_DEP_office_ui_fabric_react('7.192.0'),
+    new FN002004_DEVDEP_gulp_1.FN002004_DEVDEP_gulp('4.0.2'),
+    new FN002007_DEVDEP_ajv_1.FN002007_DEVDEP_ajv('^6.12.5'),
+    new FN002013_DEVDEP_types_webpack_env_1.FN002013_DEVDEP_types_webpack_env('~1.15.2'),
+    new FN002015_DEVDEP_types_react_1.FN002015_DEVDEP_types_react('16'),
+    new FN002016_DEVDEP_types_react_dom_1.FN002016_DEVDEP_types_react_dom('16'),
+    new FN002019_DEVDEP_microsoft_rush_stack_compiler_1.FN002019_DEVDEP_microsoft_rush_stack_compiler(['4.5'])
+];
+//# sourceMappingURL=doctor-1.16.0-beta.1.js.map

package/dist/m365/spfx/commands/project/project-doctor.js

@@ -61,7 +61,8 @@ class SpfxProjectDoctorCommand extends base_project_command_1.BaseProjectCommand
             '1.13.1',
             '1.14.0',
             '1.15.0',
-            '1.15.2'
+            '1.15.2',
+            '1.16.0-beta.1'
         ];
         __classPrivateFieldGet(this, _SpfxProjectDoctorCommand_instances, "m", _SpfxProjectDoctorCommand_initTelemetry).call(this);
         __classPrivateFieldGet(this, _SpfxProjectDoctorCommand_instances, "m", _SpfxProjectDoctorCommand_initOptions).call(this);
@@ -73,113 +74,110 @@ class SpfxProjectDoctorCommand extends base_project_command_1.BaseProjectCommand
     get description() {
         return 'Validates correctness of a SharePoint Framework project';
     }
-    commandAction(logger, args, cb) {
-        this.projectRootPath = this.getProjectRoot(process.cwd());
-        if (this.projectRootPath === null) {
-            cb(new Command_1.CommandError(`Couldn't find project root folder`, SpfxProjectDoctorCommand.ERROR_NO_PROJECT_ROOT_FOLDER));
-            return;
-        }
-        this.packageManager = args.options.packageManager || 'npm';
-        if (this.verbose) {
-            logger.logToStderr('Collecting project...');
-        }
-        const project = this.getProject(this.projectRootPath);
-        if (this.debug) {
-            logger.logToStderr('Collected project');
-            logger.logToStderr(project);
-        }
-        project.version = this.getProjectVersion();
-        if (!project.version) {
-            cb(new Command_1.CommandError(`Unable to determine the version of the current SharePoint Framework project`, SpfxProjectDoctorCommand.ERROR_NO_VERSION));
-            return;
-        }
-        if (!this.supportedVersions.includes(project.version)) {
-            cb(new Command_1.CommandError(`CLI for Microsoft 365 doesn't support validating projects built using SharePoint Framework v${project.version}`, SpfxProjectDoctorCommand.ERROR_UNSUPPORTED_VERSION));
-            return;
-        }
-        if (this.verbose) {
-            logger.logToStderr(`Project built using SPFx v${project.version}`);
-        }
-        const rules = [...generic_rules_1.rules];
-        try {
-            const versionRules = require(`./project-doctor/doctor-${project.version}`);
-            rules.push(...versionRules);
-        }
-        catch (e) {
-            cb(new Command_1.CommandError(e.message));
-            return;
-        }
-        rules.forEach(r => {
-            r.visit(project, this.allFindings);
-        });
-        if (this.packageManager === 'npm') {
-            const npmDedupeRule = new FN017001_MISC_npm_dedupe_1.FN017001_MISC_npm_dedupe();
-            npmDedupeRule.visit(project, this.allFindings);
-        }
-        // remove superseded findings
-        this.allFindings
-            // get findings that supersede other findings
-            .filter(f => f.supersedes.length > 0)
-            .forEach(f => {
-            f.supersedes.forEach(s => {
-                // find the superseded finding
-                const i = this.allFindings.findIndex(f1 => f1.id === s);
-                if (i > -1) {
-                    // ...and remove it from findings
-                    this.allFindings.splice(i, 1);
-                }
-            });
-        });
-        // flatten
-        const findingsToReport = [].concat.apply([], this.allFindings.map(f => {
-            return f.occurrences.map(o => {
-                return {
-                    description: f.description,
-                    id: f.id,
-                    file: o.file,
-                    position: o.position,
-                    resolution: o.resolution,
-                    resolutionType: f.resolutionType,
-                    severity: f.severity,
-                    title: f.title
-                };
-            });
-        }));
-        // replace package operation tokens with command for the specific package manager
-        findingsToReport.forEach(f => {
-            // matches must be in this particular order to avoid false matches, eg.
-            // uninstallDev contains install
-            if (f.resolution.startsWith('uninstallDev')) {
-                f.resolution = f.resolution.replace('uninstallDev', utils_1.packageManager.getPackageManagerCommand('uninstallDev', this.packageManager));
-                return;
+    commandAction(logger, args) {
+        return __awaiter(this, void 0, void 0, function* () {
+            this.projectRootPath = this.getProjectRoot(process.cwd());
+            if (this.projectRootPath === null) {
+                throw new Command_1.CommandError(`Couldn't find project root folder`, SpfxProjectDoctorCommand.ERROR_NO_PROJECT_ROOT_FOLDER);
+            }
+            this.packageManager = args.options.packageManager || 'npm';
+            if (this.verbose) {
+                logger.logToStderr('Collecting project...');
             }
-            if (f.resolution.startsWith('installDev')) {
-                f.resolution = f.resolution.replace('installDev', utils_1.packageManager.getPackageManagerCommand('installDev', this.packageManager));
-                return;
+            const project = this.getProject(this.projectRootPath);
+            if (this.debug) {
+                logger.logToStderr('Collected project');
+                logger.logToStderr(project);
             }
-            if (f.resolution.startsWith('uninstall')) {
-                f.resolution = f.resolution.replace('uninstall', utils_1.packageManager.getPackageManagerCommand('uninstall', this.packageManager));
-                return;
+            project.version = this.getProjectVersion();
+            if (!project.version) {
+                throw new Command_1.CommandError(`Unable to determine the version of the current SharePoint Framework project`, SpfxProjectDoctorCommand.ERROR_NO_VERSION);
             }
-            if (f.resolution.startsWith('install')) {
-                f.resolution = f.resolution.replace('install', utils_1.packageManager.getPackageManagerCommand('install', this.packageManager));
-                return;
+            if (!this.supportedVersions.includes(project.version)) {
+                throw new Command_1.CommandError(`CLI for Microsoft 365 doesn't support validating projects built using SharePoint Framework v${project.version}`, SpfxProjectDoctorCommand.ERROR_UNSUPPORTED_VERSION);
+            }
+            if (this.verbose) {
+                logger.logToStderr(`Project built using SPFx v${project.version}`);
+            }
+            const rules = [...generic_rules_1.rules];
+            try {
+                const versionRules = require(`./project-doctor/doctor-${project.version}`);
+                rules.push(...versionRules);
+            }
+            catch (e) {
+                throw new Command_1.CommandError(e.message);
+            }
+            rules.forEach(r => {
+                r.visit(project, this.allFindings);
+            });
+            if (this.packageManager === 'npm') {
+                const npmDedupeRule = new FN017001_MISC_npm_dedupe_1.FN017001_MISC_npm_dedupe();
+                npmDedupeRule.visit(project, this.allFindings);
+            }
+            // remove superseded findings
+            this.allFindings
+                // get findings that supersede other findings
+                .filter(f => f.supersedes.length > 0)
+                .forEach(f => {
+                f.supersedes.forEach(s => {
+                    // find the superseded finding
+                    const i = this.allFindings.findIndex(f1 => f1.id === s);
+                    if (i > -1) {
+                        // ...and remove it from findings
+                        this.allFindings.splice(i, 1);
+                    }
+                });
+            });
+            // flatten
+            const findingsToReport = [].concat.apply([], this.allFindings.map(f => {
+                return f.occurrences.map(o => {
+                    return {
+                        description: f.description,
+                        id: f.id,
+                        file: o.file,
+                        position: o.position,
+                        resolution: o.resolution,
+                        resolutionType: f.resolutionType,
+                        severity: f.severity,
+                        title: f.title
+                    };
+                });
+            }));
+            // replace package operation tokens with command for the specific package manager
+            findingsToReport.forEach(f => {
+                // matches must be in this particular order to avoid false matches, eg.
+                // uninstallDev contains install
+                if (f.resolution.startsWith('uninstallDev')) {
+                    f.resolution = f.resolution.replace('uninstallDev', utils_1.packageManager.getPackageManagerCommand('uninstallDev', this.packageManager));
+                    return;
+                }
+                if (f.resolution.startsWith('installDev')) {
+                    f.resolution = f.resolution.replace('installDev', utils_1.packageManager.getPackageManagerCommand('installDev', this.packageManager));
+                    return;
+                }
+                if (f.resolution.startsWith('uninstall')) {
+                    f.resolution = f.resolution.replace('uninstall', utils_1.packageManager.getPackageManagerCommand('uninstall', this.packageManager));
+                    return;
+                }
+                if (f.resolution.startsWith('install')) {
+                    f.resolution = f.resolution.replace('install', utils_1.packageManager.getPackageManagerCommand('install', this.packageManager));
+                    return;
+                }
+            });
+            switch (args.options.output) {
+                case 'text':
+                    logger.log(this.getTextReport(findingsToReport));
+                    break;
+                case 'tour':
+                    this.writeReportTourFolder(this.getTourReport(findingsToReport));
+                    break;
+                case 'md':
+                    logger.log(this.getMdReport(findingsToReport));
+                    break;
+                default:
+                    logger.log(findingsToReport);
             }
         });
-        switch (args.options.output) {
-            case 'text':
-                logger.log(this.getTextReport(findingsToReport));
-                break;
-            case 'tour':
-                this.writeReportTourFolder(this.getTourReport(findingsToReport));
-                break;
-            case 'md':
-                logger.log(this.getMdReport(findingsToReport));
-                break;
-            default:
-                logger.log(findingsToReport);
-        }
-        cb();
     }
     writeReportTourFolder(findingsToReport) {
         const toursFolder = path.join(this.projectRootPath, '.tours');

package/dist/m365/spfx/commands/project/project-externalize.js

@@ -1,4 +1,13 @@
 "use strict";
+var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
+    function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
+    return new (P || (P = Promise))(function (resolve, reject) {
+        function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } }
+        function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } }
+        function step(result) { result.done ? resolve(result.value) : adopt(result.value).then(fulfilled, rejected); }
+        step((generator = generator.apply(thisArg, _arguments || [])).next());
+    });
+};
 var __classPrivateFieldGet = (this && this.__classPrivateFieldGet) || function (receiver, state, kind, f) {
     if (kind === "a" && !f) throw new TypeError("Private accessor was defined without a getter");
     if (typeof state === "function" ? receiver !== state || !f : !state.has(receiver)) throw new TypeError("Cannot read private member from an object whose class did not declare it");
@@ -50,44 +59,42 @@ class SpfxProjectExternalizeCommand extends base_project_command_1.BaseProjectCo
     get description() {
         return 'Externalizes SharePoint Framework project dependencies';
     }
-    commandAction(logger, args, cb) {
-        if (args.options.output !== 'json' || this.verbose) {
-            logger.logToStderr(`This command is currently in preview. Feedback welcome at https://github.com/pnp/cli-microsoft365/issues${os.EOL}`);
-        }
-        this.projectRootPath = this.getProjectRoot(process.cwd());
-        if (this.projectRootPath === null) {
-            cb(new Command_1.CommandError(`Couldn't find project root folder`, SpfxProjectExternalizeCommand.ERROR_NO_PROJECT_ROOT_FOLDER));
-            return;
-        }
-        this.projectVersion = this.getProjectVersion();
-        if (!this.projectVersion) {
-            cb(new Command_1.CommandError(`Unable to determine the version of the current SharePoint Framework project`, SpfxProjectExternalizeCommand.ERROR_NO_VERSION));
-            return;
-        }
-        if (this.projectVersion && this.supportedVersions.indexOf(this.projectVersion) < 0) {
-            cb(new Command_1.CommandError(`CLI for Microsoft 365 doesn't support externalizing dependencies of SharePoint Framework projects of version ${this.projectVersion}. Supported versions are ${this.supportedVersions.join(', ')}`, SpfxProjectExternalizeCommand.ERROR_UNSUPPORTED_VERSION));
-            return;
-        }
-        if (this.verbose) {
-            logger.logToStderr('Collecting project...');
-        }
-        const project = this.getProject(this.projectRootPath);
-        if (this.debug) {
-            logger.logToStderr('Collected project');
-            logger.logToStderr(project);
-        }
-        const asyncRulesResults = rules.map(r => r.visit(project));
-        Promise
-            .all(asyncRulesResults)
-            .then((rulesResults) => {
-            this.allFindings.push(...rulesResults.map(x => x.entries).reduce((x, y) => [...x, ...y]));
-            this.allEditSuggestions.push(...rulesResults.map(x => x.suggestions).reduce((x, y) => [...x, ...y]));
-            //removing duplicates
-            this.allFindings = this.allFindings.filter((x, i) => this.allFindings.findIndex(y => y.key === x.key) === i);
-            this.writeReport(this.allFindings, this.allEditSuggestions, logger, args.options);
-            cb();
-        }).catch((err) => {
-            cb(new Command_1.CommandError(err));
+    commandAction(logger, args) {
+        return __awaiter(this, void 0, void 0, function* () {
+            if (args.options.output !== 'json' || this.verbose) {
+                logger.logToStderr(`This command is currently in preview. Feedback welcome at https://github.com/pnp/cli-microsoft365/issues${os.EOL}`);
+            }
+            this.projectRootPath = this.getProjectRoot(process.cwd());
+            if (this.projectRootPath === null) {
+                throw new Command_1.CommandError(`Couldn't find project root folder`, SpfxProjectExternalizeCommand.ERROR_NO_PROJECT_ROOT_FOLDER);
+            }
+            this.projectVersion = this.getProjectVersion();
+            if (!this.projectVersion) {
+                throw new Command_1.CommandError(`Unable to determine the version of the current SharePoint Framework project`, SpfxProjectExternalizeCommand.ERROR_NO_VERSION);
+            }
+            if (this.projectVersion && this.supportedVersions.indexOf(this.projectVersion) < 0) {
+                throw new Command_1.CommandError(`CLI for Microsoft 365 doesn't support externalizing dependencies of SharePoint Framework projects of version ${this.projectVersion}. Supported versions are ${this.supportedVersions.join(', ')}`, SpfxProjectExternalizeCommand.ERROR_UNSUPPORTED_VERSION);
+            }
+            if (this.verbose) {
+                logger.logToStderr('Collecting project...');
+            }
+            const project = this.getProject(this.projectRootPath);
+            if (this.debug) {
+                logger.logToStderr('Collected project');
+                logger.logToStderr(project);
+            }
+            const asyncRulesResults = rules.map(r => r.visit(project));
+            try {
+                const rulesResults = yield Promise.all(asyncRulesResults);
+                this.allFindings.push(...rulesResults.map(x => x.entries).reduce((x, y) => [...x, ...y]));
+                this.allEditSuggestions.push(...rulesResults.map(x => x.suggestions).reduce((x, y) => [...x, ...y]));
+                //removing duplicates
+                this.allFindings = this.allFindings.filter((x, i) => this.allFindings.findIndex(y => y.key === x.key) === i);
+                this.writeReport(this.allFindings, this.allEditSuggestions, logger, args.options);
+            }
+            catch (err) {
+                throw new Command_1.CommandError(err);
+            }
         });
     }
     writeReport(findingsToReport, editsToReport, logger, options) {