@pnp/cli-microsoft365 5.3.0-beta.24cd8e4 → 5.3.0-beta.2a76d05

package/dist/m365/search/commands.js

@@ -2,6 +2,7 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 const prefix = 'search';
 exports.default = {
-    EXTERNALCONNECTION_ADD: `${prefix} externalconnection add`
+    EXTERNALCONNECTION_ADD: `${prefix} externalconnection add`,
+    EXTERNALCONNECTION_LIST: `${prefix} externalconnection list`
 };
 //# sourceMappingURL=commands.js.map

package/dist/m365/spo/commands/eventreceiver/eventreceiver-get.js

@@ -0,0 +1,119 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const request_1 = require("../../../../request");
+const utils_1 = require("../../../../utils");
+const SpoCommand_1 = require("../../../base/SpoCommand");
+const commands_1 = require("../../commands");
+class SpoEventreceiverGetCommand extends SpoCommand_1.default {
+    get name() {
+        return commands_1.default.EVENTRECEIVER_GET;
+    }
+    get description() {
+        return 'Gets a specific event receiver attached to the web, site or list (if any of the list options are filled in) by receiver name of id';
+    }
+    getTelemetryProperties(args) {
+        const telemetryProps = super.getTelemetryProperties(args);
+        telemetryProps.listId = typeof args.options.listId !== 'undefined';
+        telemetryProps.listTitle = typeof args.options.listTitle !== 'undefined';
+        telemetryProps.listUrl = typeof args.options.listUrl !== 'undefined';
+        telemetryProps.scope = typeof args.options.scope !== 'undefined';
+        telemetryProps.id = typeof args.options.id !== 'undefined';
+        telemetryProps.name = typeof args.options.name !== 'undefined';
+        return telemetryProps;
+    }
+    commandAction(logger, args, cb) {
+        let requestUrl = `${args.options.webUrl}/_api/`;
+        let listUrl = '';
+        let filter = '?$filter=';
+        if (args.options.listId) {
+            listUrl = `lists(guid'${encodeURIComponent(args.options.listId)}')/`;
+        }
+        else if (args.options.listTitle) {
+            listUrl = `lists/getByTitle('${encodeURIComponent(args.options.listTitle)}')/`;
+        }
+        else if (args.options.listUrl) {
+            const listServerRelativeUrl = utils_1.urlUtil.getServerRelativePath(args.options.webUrl, args.options.listUrl);
+            listUrl = `GetList('${encodeURIComponent(listServerRelativeUrl)}')/`;
+        }
+        if (!args.options.scope || args.options.scope === 'web') {
+            requestUrl += `web/${listUrl}eventreceivers`;
+        }
+        else {
+            requestUrl += 'site/eventreceivers';
+        }
+        if (args.options.id) {
+            filter += `receiverid eq (guid'${args.options.id}')`;
+        }
+        else {
+            filter += `receivername eq '${args.options.name}'`;
+        }
+        const requestOptions = {
+            url: requestUrl + filter,
+            headers: {
+                'accept': 'application/json;odata=nometadata'
+            },
+            responseType: 'json'
+        };
+        request_1.default
+            .get(requestOptions)
+            .then((res) => {
+            logger.log(res.value);
+            cb();
+        }, (err) => this.handleRejectedODataJsonPromise(err, logger, cb));
+    }
+    options() {
+        const options = [
+            {
+                option: '-u, --webUrl <webUrl>'
+            },
+            {
+                option: '--listTitle [listTitle]'
+            },
+            {
+                option: '--listId  [listId]'
+            },
+            {
+                option: '--listUrl [listUrl]'
+            },
+            {
+                option: '-n, --name [name]'
+            },
+            {
+                option: '-i, --id [id]'
+            },
+            {
+                option: '-s, --scope [scope]',
+                autocomplete: ['web', 'site']
+            }
+        ];
+        const parentOptions = super.options();
+        return options.concat(parentOptions);
+    }
+    optionSets() {
+        return [
+            ['name', 'id']
+        ];
+    }
+    validate(args) {
+        const isValidSharePointUrl = utils_1.validation.isValidSharePointUrl(args.options.webUrl);
+        if (isValidSharePointUrl !== true) {
+            return isValidSharePointUrl;
+        }
+        const listOptions = [args.options.listId, args.options.listTitle, args.options.listUrl];
+        if (listOptions.some(item => item !== undefined) && listOptions.filter(item => item !== undefined).length > 1) {
+            return `Specify either list id or title or list url`;
+        }
+        if (args.options.listId && !utils_1.validation.isValidGuid(args.options.listId)) {
+            return `${args.options.listId} is not a valid GUID`;
+        }
+        if (args.options.scope && ['web', 'site'].indexOf(args.options.scope) === -1) {
+            return `${args.options.scope} is not a valid type value. Allowed values web|site.`;
+        }
+        if (args.options.scope && args.options.scope === 'site' && (args.options.listId || args.options.listUrl || args.options.listTitle)) {
+            return 'Scope cannot be set to site when retrieving list event receivers.';
+        }
+        return true;
+    }
+}
+module.exports = new SpoEventreceiverGetCommand();
+//# sourceMappingURL=eventreceiver-get.js.map

package/dist/m365/spo/commands/list/list-view-add.js

@@ -0,0 +1,113 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const utils_1 = require("../../../../utils");
+const request_1 = require("../../../../request");
+const SpoCommand_1 = require("../../../base/SpoCommand");
+const commands_1 = require("../../commands");
+class SpoListViewAddCommand extends SpoCommand_1.default {
+    get name() {
+        return commands_1.default.LIST_VIEW_ADD;
+    }
+    get description() {
+        return 'Adds a new view to a SharePoint list.';
+    }
+    getTelemetryProperties(args) {
+        const telemetryProps = super.getTelemetryProperties(args);
+        telemetryProps.listId = typeof args.options.listId !== 'undefined';
+        telemetryProps.listTitle = typeof args.options.listTitle !== 'undefined';
+        telemetryProps.listUrl = typeof args.options.listUrl !== 'undefined';
+        telemetryProps.title = typeof args.options.title !== 'undefined';
+        telemetryProps.personal = !!args.options.personal;
+        telemetryProps.default = !!args.options.default;
+        telemetryProps.orderedView = !!args.options.orderedView;
+        telemetryProps.paged = !!args.options.paged;
+        telemetryProps.rowLimit = typeof args.options.rowLimit !== 'undefined';
+        return telemetryProps;
+    }
+    commandAction(logger, args, cb) {
+        const requestOptions = {
+            url: this.getRestUrl(args.options),
+            headers: {
+                'content-type': 'application/json;odata=verbose',
+                accept: 'application/json;odata=nometadata'
+            },
+            responseType: 'json',
+            data: {
+                parameters: {
+                    Title: args.options.title,
+                    ViewFields: {
+                        results: args.options.fields.split(',')
+                    },
+                    PersonalView: !!args.options.personal,
+                    SetAsDefaultView: !!args.options.default,
+                    Paged: !!args.options.paged,
+                    RowLimit: args.options.rowLimit ? +args.options.rowLimit : 30
+                }
+            }
+        };
+        request_1.default
+            .post(requestOptions)
+            .then((result) => {
+            logger.log(result);
+            cb();
+        }, (err) => this.handleRejectedODataJsonPromise(err, logger, cb));
+    }
+    getRestUrl(options) {
+        let result = `${options.webUrl}/_api/web/`;
+        if (options.listId) {
+            result += `lists(guid'${encodeURIComponent(options.listId)}')`;
+        }
+        else if (options.listTitle) {
+            result += `lists/getByTitle('${encodeURIComponent(options.listTitle)}')`;
+        }
+        else if (options.listUrl) {
+            result += `GetList('${encodeURIComponent(utils_1.urlUtil.getServerRelativePath(options.webUrl, options.listUrl))}')`;
+        }
+        result += '/views/add';
+        return result;
+    }
+    optionSets() {
+        return [
+            ['listId', 'listTitle', 'listUrl']
+        ];
+    }
+    options() {
+        const options = [
+            { option: '-u, --webUrl <webUrl>' },
+            { option: '--listId [listId]' },
+            { option: '--listTitle [listTitle]' },
+            { option: '--listUrl [listUrl]' },
+            { option: '--title <title>' },
+            { option: '--fields <fields>' },
+            { option: '--personal' },
+            { option: '--default' },
+            { option: '--paged' },
+            { option: '--rowLimit [rowLimit]' }
+        ];
+        const parentOptions = super.options();
+        return options.concat(parentOptions);
+    }
+    validate(args) {
+        const webUrlValidation = utils_1.validation.isValidSharePointUrl(args.options.webUrl);
+        if (webUrlValidation !== true) {
+            return webUrlValidation;
+        }
+        if (args.options.listId && !utils_1.validation.isValidGuid(args.options.listId)) {
+            return `${args.options.listId} in option listId is not a valid GUID`;
+        }
+        if (args.options.rowLimit !== undefined) {
+            if (isNaN(args.options.rowLimit)) {
+                return `${args.options.rowLimit} is not a number`;
+            }
+            if (+args.options.rowLimit <= 0) {
+                return 'rowLimit option must be greater than 0.';
+            }
+        }
+        if (args.options.personal && args.options.default) {
+            return 'Default view cannot be a personal view.';
+        }
+        return true;
+    }
+}
+module.exports = new SpoListViewAddCommand();
+//# sourceMappingURL=list-view-add.js.map

package/dist/m365/spo/commands.js

@@ -35,6 +35,7 @@ exports.default = {
     CUSTOMACTION_SET: `${prefix} customaction set`,
     CUSTOMACTION_LIST: `${prefix} customaction list`,
     CUSTOMACTION_REMOVE: `${prefix} customaction remove`,
+    EVENTRECEIVER_GET: `${prefix} eventreceiver get`,
     EXTERNALUSER_LIST: `${prefix} externaluser list`,
     FEATURE_DISABLE: `${prefix} feature disable`,
     FEATURE_ENABLE: `${prefix} feature enable`,
@@ -100,6 +101,7 @@ exports.default = {
     LIST_ROLEINHERITANCE_RESET: `${prefix} list roleinheritance reset`,
     LIST_SET: `${prefix} list set`,
     LIST_SITESCRIPT_GET: `${prefix} list sitescript get`,
+    LIST_VIEW_ADD: `${prefix} list view add`,
     LIST_VIEW_GET: `${prefix} list view get`,
     LIST_VIEW_LIST: `${prefix} list view list`,
     LIST_VIEW_REMOVE: `${prefix} list view remove`,

package/dist/m365/teams/commands/app/app-list.js

@@ -76,7 +76,7 @@ class TeamsAppListCommand extends GraphCommand_1.default {
     commandAction(logger, args, cb) {
         this
             .getEndpointUrl(args)
-            .then(endpoint => utils_1.odata.getAllItems(endpoint, logger))
+            .then(endpoint => utils_1.odata.getAllItems(endpoint))
             .then((items) => {
             if (args.options.teamId || args.options.teamName) {
                 items.forEach(t => {

package/dist/m365/teams/commands/channel/channel-list.js

@@ -53,7 +53,7 @@ class TeamsChannelListCommand extends GraphCommand_1.default {
             if (args.options.type) {
                 endpoint += `?$filter=membershipType eq '${args.options.type}'`;
             }
-            return utils_1.odata.getAllItems(endpoint, logger);
+            return utils_1.odata.getAllItems(endpoint);
         })
             .then((items) => {
             logger.log(items);

package/dist/m365/teams/commands/channel/channel-member-add.js

@@ -153,8 +153,11 @@ class TeamsChannelMemberAddCommand extends GraphCommand_1.default {
             if (!channelItem) {
                 return Promise.reject(`The specified channel '${args.options.channelName}' does not exist in the Microsoft Teams team with ID '${teamId}'`);
             }
+            if (channelItem.membershipType !== "private") {
+                return Promise.reject(`The specified channel is not a private channel`);
+            }
             return Promise.resolve(channelItem.id);
-        }, err => { return Promise.reject(err); });
+        });
     }
     getUserId(args) {
         if (args.options.userId) {

package/dist/m365/teams/commands/channel/channel-member-list.js

@@ -40,7 +40,7 @@ class TeamsChannelMemberListCommand extends GraphCommand_1.default {
         })
             .then((channelId) => {
             const endpoint = `${this.resource}/v1.0/teams/${this.teamId}/channels/${channelId}/members`;
-            return utils_1.odata.getAllItems(endpoint, logger);
+            return utils_1.odata.getAllItems(endpoint);
         })
             .then((memberships) => {
             if (args.options.role) {

package/dist/m365/teams/commands/channel/channel-member-remove.js

@@ -135,6 +135,9 @@ class TeamsChannelMemberRemoveCommand extends GraphCommand_1.default {
             if (!channelItem) {
                 return Promise.reject(`The specified channel does not exist in the Microsoft Teams team`);
             }
+            if (channelItem.membershipType !== "private") {
+                return Promise.reject(`The specified channel is not a private channel`);
+            }
             return Promise.resolve(channelItem.id);
         });
     }

package/dist/m365/teams/commands/channel/channel-member-set.js

@@ -103,6 +103,9 @@ class TeamsChannelMemberSetCommand extends GraphCommand_1.default {
             if (!channelItem) {
                 return Promise.reject(`The specified channel does not exist in the Microsoft Teams team`);
             }
+            if (channelItem.membershipType !== "private") {
+                return Promise.reject(`The specified channel is not a private channel`);
+            }
             return Promise.resolve(channelItem.id);
         });
     }

package/dist/m365/teams/commands/chat/chat-get.js

@@ -33,7 +33,7 @@ class TeamsChatGetCommand extends GraphCommand_1.default {
     }
     commandAction(logger, args, cb) {
         this
-            .getChatId(logger, args)
+            .getChatId(args)
             .then(chatId => this.getChatDetailsById(chatId))
             .then((chat) => {
             logger.log(chat);
@@ -83,14 +83,14 @@ class TeamsChatGetCommand extends GraphCommand_1.default {
         }
         return true;
     }
-    getChatId(logger, args) {
+    getChatId(args) {
         return __awaiter(this, void 0, void 0, function* () {
             if (args.options.id) {
                 return args.options.id;
             }
             return args.options.participants
-                ? this.getChatIdByParticipants(args.options.participants, logger)
-                : this.getChatIdByName(args.options.name, logger);
+                ? this.getChatIdByParticipants(args.options.participants)
+                : this.getChatIdByName(args.options.name);
         });
     }
     getChatDetailsById(id) {
@@ -105,11 +105,11 @@ class TeamsChatGetCommand extends GraphCommand_1.default {
             return request_1.default.get(requestOptions);
         });
     }
-    getChatIdByParticipants(participantsString, logger) {
+    getChatIdByParticipants(participantsString) {
         return __awaiter(this, void 0, void 0, function* () {
             const participants = chatUtil_1.chatUtil.convertParticipantStringToArray(participantsString);
             const currentUserEmail = accessToken_1.accessToken.getUserNameFromAccessToken(Auth_1.default.service.accessTokens[this.resource].accessToken).toLowerCase();
-            const existingChats = yield chatUtil_1.chatUtil.findExistingChatsByParticipants([currentUserEmail, ...participants], logger);
+            const existingChats = yield chatUtil_1.chatUtil.findExistingChatsByParticipants([currentUserEmail, ...participants]);
             if (!existingChats || existingChats.length === 0) {
                 throw new Error('No chat conversation was found with these participants.');
             }
@@ -122,9 +122,9 @@ class TeamsChatGetCommand extends GraphCommand_1.default {
             throw new Error(`Multiple chat conversations with these participants found. Please disambiguate:${os.EOL}${disambiguationText}`);
         });
     }
-    getChatIdByName(name, logger) {
+    getChatIdByName(name) {
         return __awaiter(this, void 0, void 0, function* () {
-            const existingChats = yield chatUtil_1.chatUtil.findExistingGroupChatsByName(name, logger);
+            const existingChats = yield chatUtil_1.chatUtil.findExistingGroupChatsByName(name);
             if (!existingChats || existingChats.length === 0) {
                 throw new Error('No chat conversation was found with this name.');
             }

package/dist/m365/teams/commands/chat/chat-list.js

@@ -17,7 +17,7 @@ class TeamsChatListCommand extends GraphCommand_1.default {
         const filter = args.options.type !== undefined ? `?$filter=chatType eq '${args.options.type}'` : '';
         const endpoint = `${this.resource}/v1.0/chats${filter}`;
         utils_1.odata
-            .getAllItems(endpoint, logger)
+            .getAllItems(endpoint)
             .then((items) => {
             logger.log(items);
             cb();

package/dist/m365/teams/commands/chat/chat-member-list.js

@@ -16,7 +16,7 @@ class TeamsChatMemberListCommand extends GraphCommand_1.default {
     commandAction(logger, args, cb) {
         const endpoint = `${this.resource}/v1.0/chats/${args.options.chatId}/members`;
         utils_1.odata
-            .getAllItems(endpoint, logger)
+            .getAllItems(endpoint)
             .then((items) => {
             logger.log(items);
             cb();

package/dist/m365/teams/commands/chat/chat-message-list.js

@@ -16,7 +16,7 @@ class TeamsChatMessageListCommand extends GraphCommand_1.default {
     commandAction(logger, args, cb) {
         const endpoint = `${this.resource}/v1.0/chats/${args.options.chatId}/messages`;
         utils_1.odata
-            .getAllItems(endpoint, logger)
+            .getAllItems(endpoint)
             .then((items) => {
             if (args.options.output !== 'json') {
                 items.forEach(i => {

package/dist/m365/teams/commands/chat/chat-message-send.js

@@ -93,15 +93,15 @@ class TeamsChatMessageSendCommand extends GraphCommand_1.default {
                 return args.options.chatId;
             }
             return args.options.userEmails
-                ? this.ensureChatIdByUserEmails(args.options.userEmails, logger)
-                : this.getChatIdByName(args.options.chatName, logger);
+                ? this.ensureChatIdByUserEmails(args.options.userEmails)
+                : this.getChatIdByName(args.options.chatName);
         });
     }
-    ensureChatIdByUserEmails(userEmailsOption, logger) {
+    ensureChatIdByUserEmails(userEmailsOption) {
         return __awaiter(this, void 0, void 0, function* () {
             const userEmails = chatUtil_1.chatUtil.convertParticipantStringToArray(userEmailsOption);
             const currentUserEmail = utils_1.accessToken.getUserNameFromAccessToken(Auth_1.default.service.accessTokens[this.resource].accessToken).toLowerCase();
-            const existingChats = yield chatUtil_1.chatUtil.findExistingChatsByParticipants([currentUserEmail, ...userEmails], logger);
+            const existingChats = yield chatUtil_1.chatUtil.findExistingChatsByParticipants([currentUserEmail, ...userEmails]);
             if (!existingChats || existingChats.length === 0) {
                 const chat = yield this.createConversation([currentUserEmail, ...userEmails]);
                 return chat.id;
@@ -115,9 +115,9 @@ class TeamsChatMessageSendCommand extends GraphCommand_1.default {
             throw new Error(`Multiple chat conversations with this name found. Please disambiguate:${os.EOL}${disambiguationText}`);
         });
     }
-    getChatIdByName(chatName, logger) {
+    getChatIdByName(chatName) {
         return __awaiter(this, void 0, void 0, function* () {
-            const existingChats = yield chatUtil_1.chatUtil.findExistingGroupChatsByName(chatName, logger);
+            const existingChats = yield chatUtil_1.chatUtil.findExistingGroupChatsByName(chatName);
             if (!existingChats || existingChats.length === 0) {
                 throw new Error('No chat conversation was found with this name.');
             }

package/dist/m365/teams/commands/chat/chatUtil.js

@@ -17,12 +17,12 @@ exports.chatUtil = {
      * @param expectedMemberEmails a string array of participant emailaddresses
      * @param logger a logger to pipe into the graph request odata helper.
      */
-    findExistingChatsByParticipants(expectedMemberEmails, logger) {
+    findExistingChatsByParticipants(expectedMemberEmails) {
         return __awaiter(this, void 0, void 0, function* () {
             const chatType = expectedMemberEmails.length === 2 ? 'oneOnOne' : 'group';
             const endpoint = `https://graph.microsoft.com/v1.0/chats?$filter=chatType eq '${chatType}'&$expand=members&$select=id,topic,createdDateTime,members`;
             const foundChats = [];
-            const chats = yield odata_1.odata.getAllItems(endpoint, logger);
+            const chats = yield odata_1.odata.getAllItems(endpoint);
             for (const chat of chats) {
                 const chatMembers = chat.members;
                 if (chatMembers.length === expectedMemberEmails.length) {
@@ -40,10 +40,10 @@ exports.chatUtil = {
      * @param name the name of the chat conversation to find
      * @param logger a logger to pipe into the graph request odata helper.
      */
-    findExistingGroupChatsByName(name, logger) {
+    findExistingGroupChatsByName(name) {
         return __awaiter(this, void 0, void 0, function* () {
             const endpoint = `https://graph.microsoft.com/v1.0/chats?$filter=topic eq '${encodeURIComponent(name).replace("'", "''")}'&$expand=members&$select=id,topic,createdDateTime,chatType`;
-            return odata_1.odata.getAllItems(endpoint, logger);
+            return odata_1.odata.getAllItems(endpoint);
         });
     },
     /**

package/dist/m365/teams/commands/message/message-list.js

@@ -17,7 +17,7 @@ class TeamsMessageListCommand extends GraphCommand_1.default {
         const deltaExtension = args.options.since !== undefined ? `/delta?$filter=lastModifiedDateTime gt ${args.options.since}` : '';
         const endpoint = `${this.resource}/v1.0/teams/${args.options.teamId}/channels/${args.options.channelId}/messages${deltaExtension}`;
         utils_1.odata
-            .getAllItems(endpoint, logger)
+            .getAllItems(endpoint)
             .then((items) => {
             if (args.options.output !== 'json') {
                 items.forEach(i => {

package/dist/m365/teams/commands/message/message-reply-list.js

@@ -16,7 +16,7 @@ class TeamsMessageReplyListCommand extends GraphCommand_1.default {
     commandAction(logger, args, cb) {
         const endpoint = `${this.resource}/v1.0/teams/${args.options.teamId}/channels/${args.options.channelId}/messages/${args.options.messageId}/replies`;
         utils_1.odata
-            .getAllItems(endpoint, logger)
+            .getAllItems(endpoint)
             .then((items) => {
             if (args.options.output !== 'json') {
                 items.forEach(i => {

package/dist/m365/teams/commands/tab/tab-list.js

@@ -16,7 +16,7 @@ class TeamsTabListCommand extends GraphCommand_1.default {
     commandAction(logger, args, cb) {
         const endpoint = `${this.resource}/v1.0/teams/${args.options.teamId}/channels/${encodeURIComponent(args.options.channelId)}/tabs?$expand=teamsApp`;
         utils_1.odata
-            .getAllItems(endpoint, logger)
+            .getAllItems(endpoint)
             .then((items) => {
             items.forEach(i => {
                 i.teamsAppTabId = i.teamsApp.id;

package/dist/m365/teams/commands/team/team-list.js

@@ -22,7 +22,7 @@ class TeamsTeamListCommand extends GraphCommand_1.default {
             endpoint = `${this.resource}/v1.0/me/joinedTeams`;
         }
         utils_1.odata
-            .getAllItems(endpoint, logger)
+            .getAllItems(endpoint)
             .then((items) => {
             if (args.options.joined) {
                 return Promise.resolve(items);

package/dist/m365/teams/commands/user/user-app-list.js

@@ -24,7 +24,7 @@ class TeamsUserAppListCommand extends GraphCommand_1.default {
             .then((_userId) => {
             userId = _userId.value;
             const endpoint = `${this.resource}/v1.0/users/${encodeURIComponent(userId)}/teamwork/installedApps?$expand=teamsAppDefinition`;
-            return utils_1.odata.getAllItems(endpoint, logger);
+            return utils_1.odata.getAllItems(endpoint);
         })
             .then((items) => {
             items.forEach(i => {

package/dist/m365/teams/commands/user/user-list.js

@@ -42,7 +42,7 @@ class TeamsUserListCommand extends GraphCommand_1.default {
     }
     getOwners(logger, groupId) {
         const endpoint = `${this.resource}/v1.0/groups/${groupId}/owners?$select=id,displayName,userPrincipalName,userType`;
-        return utils_1.odata.getAllItems(endpoint, logger).then((items) => {
+        return utils_1.odata.getAllItems(endpoint).then((items) => {
             this.items = this.items.concat(items);
             // Currently there is a bug in the Microsoft Graph that returns Owners as
             // userType 'member'. We therefore update all returned user as owner
@@ -53,7 +53,7 @@ class TeamsUserListCommand extends GraphCommand_1.default {
     }
     getMembersAndGuests(logger, groupId) {
         const endpoint = `${this.resource}/v1.0/groups/${groupId}/members?$select=id,displayName,userPrincipalName,userType`;
-        return utils_1.odata.getAllItems(endpoint, logger);
+        return utils_1.odata.getAllItems(endpoint);
     }
     options() {
         const options = [

package/dist/m365/tenant/commands/serviceannouncement/serviceannouncement-healthissue-list.js

@@ -19,7 +19,7 @@ class TenantServiceAnnouncementHealthIssueListCommand extends GraphCommand_1.def
             endpoint += `?$filter=service eq '${encodeURIComponent(args.options.service)}'`;
         }
         utils_1.odata
-            .getAllItems(endpoint, logger)
+            .getAllItems(endpoint)
             .then((items) => {
             logger.log(items);
             cb();

package/dist/m365/tenant/commands/serviceannouncement/serviceannouncement-message-list.js

@@ -19,7 +19,7 @@ class TenantServiceAnnouncementMessageListCommand extends GraphCommand_1.default
             endpoint += `?$filter=services/any(c:c+eq+'${encodeURIComponent(args.options.service)}')`;
         }
         utils_1.odata
-            .getAllItems(endpoint, logger)
+            .getAllItems(endpoint)
             .then((items) => {
             logger.log(items);
             cb();

package/dist/m365/todo/commands/list/list-list.js

@@ -15,7 +15,7 @@ class TodoListListCommand extends GraphCommand_1.default {
     }
     commandAction(logger, args, cb) {
         utils_1.odata
-            .getAllItems(`${this.resource}/v1.0/me/todo/lists`, logger)
+            .getAllItems(`${this.resource}/v1.0/me/todo/lists`)
             .then((items) => {
             logger.log(items);
             cb();

package/dist/m365/todo/commands/task/task-list.js

@@ -45,7 +45,7 @@ class TodoTaskListCommand extends GraphCommand_1.default {
             .getTodoListId(args)
             .then((listId) => {
             const endpoint = `${this.resource}/v1.0/me/todo/lists/${listId}/tasks`;
-            return utils_1.odata.getAllItems(endpoint, logger);
+            return utils_1.odata.getAllItems(endpoint);
         })
             .then((items) => {
             if (args.options.output === 'json') {

package/dist/utils/formatting.js

@@ -30,8 +30,9 @@ exports.formatting = {
         return JSON.parse(s.replace(/^\uFEFF/, ''));
     },
     filterObject(obj, propertiesToInclude) {
-        return Object.keys(obj)
-            .filter(key => propertiesToInclude.includes(key))
+        const objKeys = Object.keys(obj);
+        return propertiesToInclude
+            .filter(prop => objKeys.includes(prop))
             .reduce((filtered, key) => {
             filtered[key] = obj[key];
             return filtered;
@@ -64,6 +65,14 @@ exports.formatting = {
     },
     splitAndTrim(s) {
         return s.split(',').map(c => c.trim());
+    },
+    openTypesEncoder(value) {
+        return value
+            .replace(/\%/g, '%25')
+            .replace(/\./g, '%2E')
+            .replace(/:/g, '%3A')
+            .replace(/@/g, '%40')
+            .replace(/#/g, '%23');
     }
 };
 //# sourceMappingURL=formatting.js.map

package/dist/utils/odata.js

@@ -12,7 +12,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.odata = void 0;
 const request_1 = require("../request");
 exports.odata = {
-    getAllItems(url, logger, metadata) {
+    getAllItems(url, metadata) {
         var _a;
         return __awaiter(this, void 0, void 0, function* () {
             let items = [];
@@ -27,7 +27,7 @@ exports.odata = {
             items = res.value;
             const nextLink = (_a = res['@odata.nextLink']) !== null && _a !== void 0 ? _a : res.nextLink;
             if (nextLink) {
-                const nextPageItems = yield exports.odata.getAllItems(nextLink, logger, metadata);
+                const nextPageItems = yield exports.odata.getAllItems(nextLink, metadata);
                 items = items.concat(nextPageItems);
             }
             return items;