@pmelab/gtd 58.1.0 → 59.0.0

package/src/workflows/shared/threads.test.ts

@@ -1,129 +0,0 @@
-import { afterEach, describe, expect, it } from "vitest"
-import {
-  hasThreadFor,
-  installContext,
-  requireReplies,
-  requireThreadsClosed,
-  type CodeThreadInfo,
-  type ThreadInfo,
-} from "../../flows/index.js"
-
-const withThreads = (
-  list: readonly ThreadInfo[],
-  run: () => void,
-  code: readonly CodeThreadInfo[] = [],
-): void => {
-  installContext({
-    refuse: (message: string): never => {
-      throw new Error(message)
-    },
-    read: () => "doc",
-    threads: () => list,
-    codeThreads: () => code,
-  } as never)
-  run()
-}
-
-afterEach(() => installContext(undefined))
-
-const open: ThreadInfo = { name: "a", line: 3, waitingOn: "human", faults: [] }
-const asked: ThreadInfo = { name: "b", line: 9, waitingOn: "agent", faults: [] }
-const faulty: ThreadInfo = {
-  ...asked,
-  name: "c",
-  line: 14,
-  faults: ['Footnote thread "[^c]": two consecutive "H:" entries — entries must alternate'],
-}
-
-describe("requireThreadsClosed", () => {
-  it("refuses while any thread waits on the human, naming each", () => {
-    withThreads([open, asked, { name: "c", line: 12, waitingOn: "human", faults: [] }], () => {
-      expect(() => requireThreadsClosed("f.md")).toThrow(/f\.md:3: \[\^a\][\s\S]*f\.md:12: \[\^c\]/)
-      expect(() => requireThreadsClosed("f.md")).toThrow(/reply with a conclusion, or delete/)
-    })
-  })
-
-  it("passes with no open thread", () => {
-    withThreads([asked], () => expect(() => requireThreadsClosed("f.md")).not.toThrow())
-  })
-
-  it("refuses a thread with a syntax fault even when it waits on the agent", () => {
-    withThreads([faulty], () => {
-      expect(() => requireThreadsClosed("f.md")).toThrow(/f\.md:14: \[\^c\][\s\S]*two consecutive/)
-    })
-  })
-})
-
-describe("requireReplies", () => {
-  it("refuses while any thread waits on the agent, naming each", () => {
-    withThreads([open, asked], () => {
-      expect(() => requireReplies("f.md")).toThrow(/f\.md:9: \[\^b\]/)
-    })
-  })
-
-  it("passes when every thread has the agent's reply", () => {
-    withThreads([open], () => expect(() => requireReplies("f.md")).not.toThrow())
-  })
-
-  it("refuses a thread with a syntax fault even when it waits on the human", () => {
-    withThreads([{ ...faulty, waitingOn: "human" }], () => {
-      expect(() => requireReplies("f.md")).toThrow(/f\.md:14: \[\^c\][\s\S]*two consecutive/)
-    })
-  })
-})
-
-const codeOpen: CodeThreadInfo = {
-  path: "src/a.ts",
-  line: 7,
-  waitingOn: "human",
-  first: "why?",
-  faults: [],
-}
-const codeAsked: CodeThreadInfo = { ...codeOpen, line: 20, waitingOn: "agent", first: "how?" }
-const codeFaulty: CodeThreadInfo = {
-  ...codeOpen,
-  line: 30,
-  first: "x",
-  faults: ['Code thread at src/a.ts:30: two consecutive "H:" entries'],
-}
-
-describe("code threads at the gates", () => {
-  it("an open code thread refuses landing, naming path:line and first entry", () => {
-    withThreads(
-      [],
-      () => expect(() => requireThreadsClosed("f.md")).toThrow(/src\/a\.ts:7: why\?/),
-      [codeOpen, codeAsked],
-    )
-  })
-
-  it("a code thread waiting on the agent does not refuse landing", () => {
-    withThreads([], () => expect(() => requireThreadsClosed("f.md")).not.toThrow(), [codeAsked])
-  })
-
-  it("a code thread waiting on the agent refuses an agent turn, naming path:line", () => {
-    withThreads(
-      [],
-      () => {
-        expect(() => requireReplies("f.md")).toThrow(/src\/a\.ts:20: how\?/)
-        expect(() => requireReplies("f.md")).toThrow(/one "A:" comment line/)
-      },
-      [codeOpen, codeAsked],
-    )
-  })
-
-  it("a fault refuses both ways", () => {
-    withThreads([], () => expect(() => requireThreadsClosed("f.md")).toThrow(/src\/a\.ts:30/), [
-      codeFaulty,
-    ])
-    withThreads([], () => expect(() => requireReplies("f.md")).toThrow(/two consecutive/), [
-      codeFaulty,
-    ])
-  })
-
-  it("hasThreadFor combines footnote and code threads", () => {
-    withThreads([], () => expect(hasThreadFor("agent", "f.md")).toBe(true), [codeAsked])
-    withThreads([asked], () => expect(hasThreadFor("agent", "f.md")).toBe(true))
-    withThreads([open], () => expect(hasThreadFor("agent", "f.md")).toBe(false), [codeOpen])
-    withThreads([open], () => expect(hasThreadFor("human")).toBe(false))
-  })
-})

package/src/workflows/shared/vars.ts

@@ -1,47 +0,0 @@
-// The bundled workflow's settings, in two kinds. A process setting changes
-// which step comes next, so it is pinned for the whole process at its start;
-// an environment setting only changes how a step runs on this machine, so it
-// is read live on every invocation. A factory option, `--var` (process
-// settings only) and `GTD_<NAME>` override either.
-
-/** The refactor guard's fixed list, and `seamAllow`'s default minus `.gtd/**`. */
-export const testFileGlobs: readonly string[] = [
-  "**/*.test.*",
-  "**/*.spec.*",
-  "**/*.feature",
-  "**/tests/**",
-  "**/test/**",
-  "**/__tests__/**",
-]
-
-export const defaultFlagRegistry = "src/flags/index.ts"
-
-/** Process settings. */
-export const defaults: Readonly<Record<string, string>> = {
-  reviewBase: "",
-  judgeBudgetBytes: "32768",
-  judgeIdenticalMinP: "0.7",
-  reviewNoteActionable: "0.7",
-  reviewSeverityMinP: "0.7",
-  qualityTriageMinP: "0.7",
-  // How sure the judge must be that an answer at the review gate is a reusable standard.
-  standardMinP: "0.8",
-  refactorFlagPattern: "\\bGTD_FLAG_\\w+",
-  seamAllow: [...testFileGlobs, ".gtd/**"].join(", "),
-  // A person tries every green naive pass at `seam.try` before anything builds on it.
-  naiveTest: "false",
-  // GTD_FLAG_RISK_TIER, recorded at process start; only "1" is on.
-  flag_risk_tier: "0",
-  // Decides the turn count: one `build.quality.<lens>` scope per entry, each
-  // keyed in `./skills.ts`.
-  qualityReviews:
-    "correctness, owasp-security, ponytail-review, test-audit, conventions, spec-challenge, criteria-coverage",
-  refactorQualityReviews: "correctness, ponytail-review, conventions",
-}
-
-/** Environment settings. */
-export const envDefaults: Readonly<Record<string, string>> = {
-  testCommand: "npm test",
-  plannerModel: "smart",
-  coderModel: "base",
-}

package/src/workflows/shared/workflows.steps.ts

@@ -1,54 +0,0 @@
-import { After, Given, Then } from "quickpickle"
-import { CONFIG_SCAFFOLD } from "../../install/index.js"
-import assert from "node:assert"
-import type { TestkitWorld } from "../../testkit/index.js"
-
-Given("the shipped workflows, as gtd install scaffolds them", (world: TestkitWorld) => {
-  world.configure(CONFIG_SCAFFOLD)
-})
-
-// Ambient, not explicit: the repository's own env is fixed when it is created,
-// and only a real environment variable can change between two steps of one process.
-const restores: (() => void)[] = []
-
-Given(
-  "the ambient environment variable {string} is {string}",
-  (_: TestkitWorld, name: string, value: string) => {
-    const before = process.env[name]
-    restores.push(() => {
-      if (before === undefined) delete process.env[name]
-      else process.env[name] = before
-    })
-    process.env[name] = value
-  },
-)
-
-After(() => {
-  while (restores.length > 0) restores.pop()!()
-})
-
-Then("the last commit body contains {string}", (world: TestkitWorld, text: string) => {
-  const message = world.repo().messages().at(-1) ?? ""
-  assert.ok(message.includes(text), message)
-})
-
-Then(
-  "the commit {string} has a body containing {string}",
-  (world: TestkitWorld, subject: string, text: string) => {
-    // Every commit with the subject, so a repeated step is not judged by its first match.
-    const matching = world
-      .repo()
-      .messages()
-      .filter((m) => m.split("\n")[0] === subject)
-    assert.ok(matching.length > 0, `no commit "${subject}"`)
-    for (const message of matching) assert.ok(message.includes(text), message)
-  },
-)
-
-Then("no commit body contains {string}", (world: TestkitWorld, text: string) => {
-  const hit = world
-    .repo()
-    .messages()
-    .find((m) => m.includes(text))
-  assert.ok(hit === undefined, `a commit body contains "${text}":\n${hit}`)
-})