@pmelab/gtd 57.0.0 → 58.1.0

package/src/{testkit/steps.ts → gherkin/index.ts}

@@ -11,7 +11,15 @@ import {
 } from "quickpickle"
 import assert from "node:assert"
 import type { TestContext } from "vitest"
-import { runsItsScript, testRepo, type Actor, type TestRepo } from "./TestRepo.js"
+import { resolve } from "node:path"
+import { pathToFileURL } from "node:url"
+import {
+  runsItsScript,
+  testRepo,
+  type Actor,
+  type TestRepo,
+  type WorkflowModule,
+} from "../testkit/index.js"
 
 export class TestkitWorld extends QuickPickleWorld {
   // Re-declared: under `nodenext` a subclass loses the base's members from TS's view.
@@ -21,7 +29,7 @@ export class TestkitWorld extends QuickPickleWorld {
     super(context, info)
   }
 
-  private gtdConfig: string | undefined = undefined
+  private gtdConfig: WorkflowModule | undefined = undefined
   private env: Record<string, string> = {}
   /** Per step, what its scripted actor does, in the order the scenario declared it. */
   actions = new Map<string, Actor[]>()
@@ -33,7 +41,7 @@ export class TestkitWorld extends QuickPickleWorld {
   // The repository is created on first use and keeps the config and
   // environment it was created with, so a later change to either is refused
   // rather than silently ignored.
-  configure(config: string): void {
+  configure(config: WorkflowModule): void {
     this.assertNotCreated("a gtd config")
     this.gtdConfig = config
   }
@@ -41,6 +49,8 @@ export class TestkitWorld extends QuickPickleWorld {
   extendConfig(tail: string): void {
     this.assertNotCreated("a gtd config")
     if (this.gtdConfig === undefined) throw new Error("no gtd config to extend")
+    if (typeof this.gtdConfig !== "string")
+      throw new Error("a gtd config from a module cannot be extended")
     this.gtdConfig += `\n${tail}`
   }
 
@@ -108,6 +118,13 @@ Given("a gtd config with:", (world: TestkitWorld, source: string) => {
   world.configure(withNewline(source))
 })
 
+// Imported by the test runner itself, from the working directory: the module and
+// the engine share one `@pmelab/gtd/flows`, and a config source string could
+// import only files written into the in-memory repository.
+Given("a gtd config from the module {string}", async (world: TestkitWorld, path: string) => {
+  world.configure({ ...(await import(pathToFileURL(resolve(path)).href)) })
+})
+
 Given("the gtd config ends with:", (world: TestkitWorld, source: string) => {
   world.extendConfig(withNewline(source))
 })

package/src/gherkin/module-config.feature

@@ -0,0 +1,24 @@
+@inmem
+Feature: a scenario runs a workflow module from disk
+
+  The test runner imports the module, so it shares the engine's runtime and
+  may import anything on disk. A config written as source can import only
+  files inside the in-memory repository.
+
+  Scenario: the module's default export starts on a change in the tree
+    Given a gtd config from the module "src/gherkin/tiny.fixture.ts"
+    And a file "IDEA.md" with:
+      """
+      a calculator
+      """
+    And step "plan" writes "PLAN.md" with:
+      """
+      add two numbers
+      """
+    When the process is driven
+    Then the process rests at "sign-off"
+    And the commit subjects end with:
+      """
+      gtd(agent): plan → sign-off
+      """
+

package/src/gherkin/tiny.fixture.ts

@@ -0,0 +1,8 @@
+import { agent, human } from "../flows/index.js"
+
+export const tiny = async (): Promise<void> => {
+  await agent("plan", "Write PLAN.md.")
+  await human("sign-off")
+}
+
+export default tiny

package/src/platform/Git.test.ts

@@ -7,11 +7,11 @@ import { Cause, Effect, Exit, Option } from "effect"
 import { describe, expect, it } from "vitest"
 import { GitService, InvalidRefError, resolvedRefOrCorrupted } from "./Git.js"
 import { Host } from "./index.js"
-import { gitTiers, runGitServiceContract, runGitScriptContract } from "../testkit/index.js"
+import { gitTiers, runGitServiceContract, runGitScriptContract } from "../twins/index.js"
 
 /**
  * The `GitOperations` contract, run identically against both the Live and
- * InMemory tiers (`src/testkit/GitTiers.ts`) — 20 operations × 2 tiers.
+ * InMemory tiers (`src/twins/GitTiers.ts`) — 20 operations × 2 tiers.
  */
 for (const makeTier of gitTiers) {
   const name = makeTier().name

package/src/platform/RetainedHistory.test.ts

@@ -1,6 +1,6 @@
 import { Effect, Option } from "effect"
 import { describe, expect, it, vi } from "vitest"
-import { strictGitOperations as stubGit } from "../testkit/index.js"
+import { strictGitOperations as stubGit } from "../twins/index.js"
 import {
   clearRetainedHistory,
   HISTORY_REF,
@@ -13,7 +13,7 @@ import {
 
 /**
  * Unit coverage for the retention edge module (`src/platform/RetainedHistory.ts`),
- * using `strictGitOperations` (`src/testkit/StrictGitOperations.ts`) as its
+ * using `strictGitOperations` (`src/twins/StrictGitOperations.ts`) as its
  * `GitOperations` double — a Proxy failing on any method a test didn't
  * override, so an unexpected call fails loudly instead of silently succeeding.
  */

package/src/platform/Workspace.test.ts

@@ -15,7 +15,7 @@ import { afterEach, describe, expect, it, vi } from "vitest"
 import { Effect, Layer } from "effect"
 import { NodeContext } from "@effect/platform-node"
 import { GitService, Host, Workspace, type WorkspaceOps } from "./index.js"
-import { InMemRepo, makeInMemoryWorkspaceOps } from "../testkit/index.js"
+import { InMemRepo, makeInMemoryWorkspaceOps } from "../twins/index.js"
 
 // `execFileSync` is a named export of the built-in `node:child_process` ESM
 // module — not configurable, so `vi.spyOn` can't wrap it directly. `vi.mock`
@@ -31,7 +31,7 @@ vi.mock("node:child_process", async (importOriginal) => {
 })
 
 /**
- * One `Workspace` tier, in the shape `src/testkit/GitTiers.ts` establishes
+ * One `Workspace` tier, in the shape `src/twins/GitTiers.ts` establishes
  * for `GitOperations`: a `root`, a way to seed working-tree/committed
  * content, and `provide` to run an Effect against this tier's `Workspace`.
  */

package/src/platform/WorktreeState.test.ts

@@ -16,7 +16,7 @@ import { NodeContext } from "@effect/platform-node"
 import { describe, expect, it } from "vitest"
 import { loopLogPath, worktreeGitDir } from "./WorktreeState.js"
 import { GitService, Host, Workspace } from "./index.js"
-import { InMemRepo, testLayers } from "../testkit/index.js"
+import { InMemRepo, testLayers } from "../twins/index.js"
 
 const provide = <A>(
   eff: Effect.Effect<A, never, Host | Workspace>,

package/src/step/planStart.test.ts

@@ -1,7 +1,7 @@
 import { Effect } from "effect"
 import { describe, expect, it } from "vitest"
 import { planStart, type StartOutcome } from "./planStart.js"
-import { InMemRepo, testLayers } from "../testkit/index.js"
+import { InMemRepo, testLayers } from "../twins/index.js"
 import { ConfigService } from "../workflow/index.js"
 
 const WORKFLOW = `import { agent, human } from "@pmelab/gtd/flows"

package/src/testkit/TestRepo.ts

@@ -2,10 +2,13 @@ import { Effect } from "effect"
 import { PassThrough } from "node:stream"
 import { runCli } from "../cli/index.js"
 import { EXIT_OK, type BeatDocument } from "../wire/index.js"
-import { makeCapturingCliIo, type CapturedCliResult } from "./cliIo.js"
-import { applyEmittedScript } from "./EmittedScriptRecognizer.js"
-import { applyFlowScript } from "./FlowScripts.js"
-import { InMemRepo } from "./InMemRepo.js"
+import {
+  applyEmittedScript,
+  applyFlowScript,
+  InMemRepo,
+  makeCapturingCliIo,
+  type CapturedCliResult,
+} from "../twins/index.js"
 
 /**
  * The repository's `gtd.config.ts`: its source, or the module itself. A module

package/src/testkit/index.ts

@@ -1,9 +1,15 @@
-export { runsItsScript, testRepo, type Actor, type TestRepo } from "./TestRepo.js"
-export { InMemRepo } from "./InMemRepo.js"
-export { makeInMemoryWorkspaceOps, testLayers, type ScriptedCommand } from "./Layers.js"
-export { makeCapturingCliIo } from "./cliIo.js"
-export { applyEmittedScript } from "./EmittedScriptRecognizer.js"
-export { gitTiers, runGitServiceContract, runGitScriptContract, type GitTier } from "./GitTiers.js"
-export { strictGitOperations } from "./StrictGitOperations.js"
-export { fakeGitOperations } from "./FakeGitOperations.js"
-export type { TestkitWorld } from "./steps.js"
+// The public testkit: runs any workflow against the real engine in an in-memory
+// repository. It imports no test runner, so any runner can use it; the
+// gherkin steps are the opt-in \`@pmelab/gtd/testkit/gherkin\`.
+export {
+  runsItsScript,
+  testRepo,
+  type Actor,
+  type Actors,
+  type DriveOptions,
+  type TestRepo,
+  type TestRepoOptions,
+  type WorkflowModule,
+} from "./TestRepo.js"
+export { InMemRepo, type CapturedCliResult } from "../twins/index.js"
+export type { TestkitWorld } from "../gherkin/index.js"

package/src/{testkit → twins}/Layers.ts

@@ -4,7 +4,7 @@
 // gtd itself spawns no subprocess at all any more (`gtd renders; the driver
 // executes`) — a mode's `format:`/`validate:` command is emitted text, never
 // run in-process. `ScriptedCommand` below still exists for the world's own
-// fake-shell interpreter (`src/testkit/EmittedScriptRecognizer.ts`), which
+// fake-shell interpreter (`src/twins/EmittedScriptRecognizer.ts`), which
 // simulates a driver running gtd's emitted scripts against the in-memory
 // worktree — a wholly separate mechanism from any gtd-internal layer.
 
@@ -193,7 +193,7 @@ export interface TestWorldOptions {
    * Effect test has no `--verbose` flag of its own to gate on.
    */
   readonly narrate?: (line: string) => void
-  /** Gates `narrate` above — defaults to `true` (fires whenever a sink is given) since these tests aren't exercising `Cli.ts`'s own `--verbose` gate. `src/testkit/cliIo.ts` overrides this with the real decoded flag. */
+  /** Gates `narrate` above — defaults to `true` (fires whenever a sink is given) since these tests aren't exercising `Cli.ts`'s own `--verbose` gate. `src/twins/cliIo.ts` overrides this with the real decoded flag. */
   readonly verbose?: boolean
   /** Real or fake driver and tool commands — each one left out fails when called. */
   readonly tools?: Partial<ToolCommands["Type"]>

package/src/twins/index.ts

@@ -0,0 +1,8 @@
+export { InMemRepo } from "./InMemRepo.js"
+export { makeInMemoryWorkspaceOps, testLayers, type ScriptedCommand } from "./Layers.js"
+export { makeCapturingCliIo, type CapturedCliResult } from "./cliIo.js"
+export { applyEmittedScript } from "./EmittedScriptRecognizer.js"
+export { applyFlowScript } from "./FlowScripts.js"
+export { gitTiers, runGitServiceContract, runGitScriptContract, type GitTier } from "./GitTiers.js"
+export { strictGitOperations } from "./StrictGitOperations.js"
+export { fakeGitOperations } from "./FakeGitOperations.js"

package/src/workflow/discovery.test.ts

@@ -6,7 +6,7 @@ import { NodeContext } from "@effect/platform-node"
 import { Effect, Layer } from "effect"
 import { afterEach, describe, expect, it } from "vitest"
 import { GitService, Host, Narrator, Workspace } from "../platform/index.js"
-import { InMemRepo, testLayers } from "../testkit/index.js"
+import { InMemRepo, testLayers } from "../twins/index.js"
 import { ConfigDiscovery, ConfigService } from "./index.js"
 
 // A config and the local modules it imports load the same from disk, where

package/src/workflow/discovery.ts

@@ -38,7 +38,7 @@ export const WORKFLOW_MODULE = "gtd.config.ts"
  * The file names gtd read repository settings from before `gtd.config.ts` took
  * them over. Still looked for, only to refuse them: a leftover one would
  * otherwise be silently ignored. Shared with the in-memory counterpart in
- * `src/testkit/Layers.ts`, so both tiers refuse the same names.
+ * `src/twins/Layers.ts`, so both tiers refuse the same names.
  */
 export const LEGACY_RC_FILES = [
   ".gtdrc",
@@ -71,7 +71,7 @@ const legacyRcFileAt = (path: string): LegacyRcFile | undefined => {
  * the user's home dir (inclusive, when it is an ancestor) or after reaching the
  * filesystem root — whichever comes first. Returned innermost→outermost.
  * Exported (via the barrel) for the same reason `SEARCH_PLACES` is — one
- * shared implementation, not a second copy in `src/testkit/Layers.ts` that
+ * shared implementation, not a second copy in `src/twins/Layers.ts` that
  * could silently diverge.
  */
 export const walkUp = (from: string, home: string): ReadonlyArray<string> => {
@@ -115,7 +115,7 @@ const workflowModule = (
  * reads; discovery is effectful and environment-dependent: `.Live` reads
  * REAL disk, so an `@inmem` scenario's fake
  * `Workspace` — a pure in-memory `Map`, no real files anywhere on disk —
- * cannot back it. `src/testkit/Layers.ts` provides the in-memory
+ * cannot back it. `src/twins/Layers.ts` provides the in-memory
  * counterpart instead, mirroring how `Workspace`/`Host`/`GitService` already
  * each have a production and a fake layer behind one Tag.
  */

package/src/workflow/load.ts

@@ -357,14 +357,14 @@ const shippedModules = (): Promise<ShippedModules> =>
     return { modules, missing }
   })())
 
-/** The file each subpath a config may import serves: all but `flows`, the engine's own, and `testkit`. */
+/** The file each subpath a config may import serves: all but `flows`, the engine's own, and the testkit's. */
 const subpathFiles = (condition: string): ReadonlyMap<string, string> => {
   const { root, pkg } = ownPackage()
   const files = new Map<string, string>()
   for (const [subpath, target] of Object.entries(pkg.exports)) {
     const file = typeof target === "string" ? target : target[condition]
-    // testkit imports the consumer's test runner, and no config runs one.
-    if (subpath === "./flows" || subpath === "./testkit" || file === undefined) continue
+    // A config runs no tests, and the gherkin steps import the consumer's test runner.
+    if (subpath === "./flows" || subpath.startsWith("./testkit") || file === undefined) continue
     files.set(`${PACKAGE}/${subpath.replace(/^\.\//, "")}`, join(root, file))
   }
   return files

package/src/workflows/feature/acceptance-criteria.feature

@@ -39,6 +39,10 @@ Feature: acceptance criteria carry stable IDs, and a sketch that states clear on
 
         - the greeting module
 
+        ## Release Flag
+
+        new
+
         ## Acceptance Criteria
 
         - AC-1: `greeting` reads "Hello, world".
@@ -67,6 +71,10 @@ Feature: acceptance criteria carry stable IDs, and a sketch that states clear on
 
         - the greeting module
 
+        ## Release Flag
+
+        new
+
         ## Acceptance Criteria
 
         - `greeting` reads "Hello, world".
@@ -82,6 +90,10 @@ Feature: acceptance criteria carry stable IDs, and a sketch that states clear on
 
         - the greeting module
 
+        ## Release Flag
+
+        new
+
         ## Acceptance Criteria
 
         - AC-1: `greeting` reads "Hello, world".
@@ -98,6 +110,10 @@ Feature: acceptance criteria carry stable IDs, and a sketch that states clear on
 
         - the greeting module
 
+        ## Release Flag
+
+        new
+
         ## Acceptance Criteria
 
         - AC-1: `greeting` reads "Hello, world".
@@ -131,6 +147,10 @@ Feature: acceptance criteria carry stable IDs, and a sketch that states clear on
 
         - the greeting module
 
+        ## Release Flag
+
+        new
+
         ## Acceptance Criteria
 
         - AC-1: `greeting` reads "Hi".
@@ -150,6 +170,10 @@ Feature: acceptance criteria carry stable IDs, and a sketch that states clear on
         """
         # Requirements
 
+        ## Release Flag
+
+        new
+
         ## Acceptance Criteria
 
         - AC-1: `greeting` reads "Hello, world".
@@ -178,6 +202,10 @@ Feature: acceptance criteria carry stable IDs, and a sketch that states clear on
 
         - the greeting module
 
+        ## Release Flag
+
+        new
+
         ## Acceptance Criteria
 
         - AC-1: `greeting` reads "Hi".
@@ -226,6 +254,10 @@ Feature: acceptance criteria carry stable IDs, and a sketch that states clear on
 
         - the greeting module
 
+        ## Release Flag
+
+        new
+
         ## Acceptance Criteria
 
         - AC-1: `greeting` reads "Hello, world".

package/src/workflows/feature/criteria-coverage.feature

@@ -8,7 +8,6 @@ Feature: the criteria-coverage lens checks the change's tests against its criter
   Background:
     Given the shipped workflows, as gtd install scaffolds them
     And an environment variable "GTD_QUALITYREVIEWS" set to "criteria-coverage"
-    And an environment variable "GTD_FLAGMODE" set to "false"
     And a file "src/calc.ts" with:
       """
       export const add = (a: number, b: number) => a + b

package/src/workflows/feature/criteria.ts

@@ -13,6 +13,7 @@ import {
 import { HEADING, ITEM, markFenced } from "../shared/fences.js"
 import { planner, REQUIREMENTS } from "../shared/steps.js"
 import * as t from "../shared/text.js"
+import { requireReleaseFlag } from "./release-flag.js"
 
 export interface Criterion {
   readonly id: string
@@ -137,16 +138,20 @@ export const requireCriteria = (file: string): void => {
 const isImpactHeading = (h: RegExpExecArray | null): boolean =>
   h !== null && h[1]!.length === 2 && /^impact$/i.test(h[2]!.trim())
 
+// The skip path's impact turn may write both: a sketch can ask for a flag.
+const isImpactTurnHeading = (h: RegExpExecArray | null): boolean =>
+  h !== null && h[1]!.length === 2 && /^(impact|release flag)$/i.test(h[2]!.trim())
+
 /** Whether `text` has an unfenced, level-2 `## Impact` heading. */
 export const hasImpact = (text: string): boolean =>
   markFenced(text).some((l) => !l.fenced && isImpactHeading(HEADING.exec(l.line)))
 
-/** `text` without its `## Impact` section, whitespace collapsed. */
+/** `text` without its `## Impact` and `## Release Flag` sections, whitespace collapsed. */
 const withoutImpact = (text: string): string => {
   let inImpact = false
   const kept = markFenced(text).filter((l) => {
     const h = l.fenced ? null : HEADING.exec(l.line)
-    if (h !== null && h[1]!.length <= 2) inImpact = isImpactHeading(h)
+    if (h !== null && h[1]!.length <= 2) inImpact = isImpactTurnHeading(h)
     return !inImpact
   })
   return kept
@@ -172,13 +177,13 @@ export const requireImpact = (file: string): void => {
   )
 }
 
-/** Refuse a turn that changed `file` beyond its `## Impact` section. */
+/** Refuse a turn that changed `file` beyond its `## Impact` and `## Release Flag` sections. */
 export const requireImpactOnly = (file: string): void => {
   const change = changes().get(file)
   if (change === undefined) return
   if (withoutImpact(change.before ?? "") === withoutImpact(change.after ?? "")) return
   refuse(
-    `gtd land: impact-only: this turn may only add "## Impact" to ${file} — restore everything else`,
+    `gtd land: impact-only: this turn may only add "## Impact" (and "## Release Flag") to ${file} — restore everything else`,
   )
 }
 
@@ -240,6 +245,7 @@ const impact = async (): Promise<void> => {
   requireCriteriaFrozen(REQUIREMENTS)
   requireImpact(REQUIREMENTS)
   requireImpactOnly(REQUIREMENTS)
+  requireReleaseFlag(REQUIREMENTS)
 }
 
 /**

package/src/workflows/feature/fast-path.feature

@@ -41,6 +41,10 @@ Feature: a trivial change takes the same few beats at either risk tier
 
       - the greeting module
 
+      ## Release Flag
+
+      new
+
       ## Acceptance Criteria
 
       - AC-1: the change behaves as described.

package/src/workflows/feature/feature.test.ts

@@ -302,38 +302,9 @@ describe("an in-flight process from before the architecture path was removed", (
   })
 })
 
-describe("flagMode", () => {
-  const config = (workflow: string): string =>
-    [
-      'import { feature } from "@pmelab/gtd/workflows/feature"',
-      'export { summary, steering, skills, access } from "@pmelab/gtd/workflows/feature"',
-      `export default ${workflow}`,
-      "",
-    ].join("\n")
-
-  const designed = async (workflow: string, env: Record<string, string> = {}) => {
-    const repo = testRepo({ workflow, env: { GTD_QUALITYREVIEWS: "", ...env } })
-    repo.write("src/calc.ts", CALC)
-    repo.commit("feat: add calculator")
-    repo.write("TODO.md", "# Add subtract\n")
-    return repo.drive({
-      unwind: () => undefined,
-      "start-gate.check": () => undefined,
-      "design.triage": (_, r) =>
-        r.write(
-          ".gtd/REQUIREMENTS.md",
-          "# Requirements\n\n## Concerns\n\n### S\n\n- `s`\n\n## Impact\n\n- the module\n\n## Acceptance Criteria\n\n- AC-1: done\n",
-        ),
-      "design.gate.answer": () => undefined,
-    })
-  }
-
-  it("set on explicitly, runs the naive pass like the default", async () => {
-    expect((await designed(config("feature({ flagMode: true })"))).state).toBe("seam.naive")
-  })
-
-  it("off through GTD_FLAGMODE=false, lands the naive pass with no seam judge", async () => {
-    const repo = testRepo({ workflow: CONFIG_SCAFFOLD, env: { GTD_FLAGMODE: "false" } })
+describe("release flag", () => {
+  it("with no Release Flag section, lands the naive pass with no seam judge", async () => {
+    const repo = testRepo({ workflow: CONFIG_SCAFFOLD })
     repo.write("src/calc.ts", CALC)
     repo.commit("feat: add calculator")
     repo.write("TODO.md", "# Add subtract\n")
@@ -357,13 +328,6 @@ describe("flagMode", () => {
     expect(repo.read("src/calc.ts")).toBe(`${CALC}// naive\n`)
     expect(repo.subjects().some((subject) => subject.includes("seam.judge"))).toBe(false)
   })
-
-  it("refuses a value other than true or false before the process starts", async () => {
-    const repo = testRepo({ workflow: CONFIG_SCAFFOLD, env: { GTD_FLAGMODE: "off" } })
-    repo.write("TODO.md", "# Add subtract\n")
-    await expect(repo.drive({})).rejects.toThrow('flagMode must be "true" or "false", got "off"')
-    expect(repo.subjects()).toEqual(["chore: initial commit"])
-  })
 })
 
 // pins the public re-exports from the feature entry point

package/src/workflows/feature/feature.ts

@@ -9,7 +9,7 @@ import {
   start,
 } from "../../flows/index.js"
 import { gate } from "../shared/health.js"
-import { flagModeOn, naiveTestOn, shipped } from "../shared/options.js"
+import { naiveTestOn, shipped } from "../shared/options.js"
 import { FEEDBACK, REQUIREMENTS } from "../shared/steps.js"
 import { refusePendingHandOff } from "../shared/tail.js"
 import * as t from "../shared/text.js"
@@ -29,7 +29,7 @@ import { recordRisk, riskTierOn } from "./tier.js"
 // The ordinary start. Any change to the tree starts a process: `idle` →
 // `unwind` reverts the sketch (its intent survives in history) → a
 // green-baseline gate → design → a naive pass, tried by a person with
-// `naiveTest` on and judged with `flagMode` on: it
+// `naiveTest` on and judged when the requirements ask for a release flag: it
 // lands as the implementation, or (refactoring first when the judge asks) is
 // built fresh from → the health loop → the triaged quality lap and its finding gate → a
 // reviewer's walkthrough of the whole change for the human, which signs off
@@ -46,7 +46,7 @@ export const unwind = (): Promise<void> => {
 export { reUnwind }
 
 /**
- * A naive pass (judged only with `flagMode` on), then implement and the
+ * A naive pass (judged only when a release flag is asked for), then implement and the
  * quality lap, then the review; design must have run since `firstBase`.
  */
 export const buildFeature = async (firstBase: string): Promise<void> => {
@@ -139,7 +139,6 @@ export const ordinaryStart = async (): Promise<void> => {
   await human("idle", { message: t.idleMessage(), label: "Idle", file: ".gtd/TODO.md" })
   refusePendingHandOff()
   // Read right after idle, so a bad value refuses the landing that would pin it.
-  flagModeOn()
   naiveTestOn()
   const stated = statedCriteria(changes(), head())
   await unwind()

package/src/workflows/feature/lens-models.feature

@@ -11,7 +11,6 @@ Feature: each quality lens runs on its own model hint
       import { feature } from "@pmelab/gtd/workflows/feature"
       export { summary, steering, skills, access } from "@pmelab/gtd/workflows/feature"
       export default feature({
-        flagMode: false,
         qualityReviews: "correctness, conventions, test-audit=opus",
       })
       """

package/src/workflows/feature/lens-review.feature

@@ -12,7 +12,6 @@ Feature: the quality lap's findings are triaged, then decided at the finding gat
   Background:
     Given the shipped workflows, as gtd install scaffolds them
     And an environment variable "GTD_QUALITYREVIEWS" set to "correctness"
-    And an environment variable "GTD_FLAGMODE" set to "false"
     And a file "src/calc.ts" with:
       """
       export const add = (a: number, b: number) => a + b

package/src/workflows/feature/naive-acceptance.feature

@@ -31,6 +31,10 @@ Feature: a naive pass ends only when its tests reach no file it added and the su
 
       - the greeting module
 
+      ## Release Flag
+
+      new
+
       ## Acceptance Criteria
 
       - AC-1: `subtract(5, 3)` returns 2.

package/src/workflows/feature/naive-test.feature

@@ -4,19 +4,20 @@ Feature: a person tries the naive pass by hand before anything builds on it
   `naiveTest` is a factory option of the shipped workflows, off by default. On,
   every green naive pass is applied to the working tree and the process rests
   at `seam.try`. A clean landing signs it off and the process goes on — to the
-  seam judge, or straight to the implementation with `flagMode` off. Notes in
+  seam judge when the requirements ask for a release flag, else straight to the
+  implementation. Notes in
   `.gtd/NAIVE-TEST.md`, a code edit or a requirements edit send it back: the
   pass and the person's code edits leave the tree again, and the next naive
   pass gets the notes and the edits. Every lap ends at the gate again.
 
-  Rule: with flagMode off
+  Rule: with no release flag asked for
 
     Background:
       Given a gtd config with:
         """
         import { feature } from "@pmelab/gtd/workflows/feature"
         export { summary, steering, skills, access } from "@pmelab/gtd/workflows/feature"
-        export default feature({ flagMode: false, naiveTest: true })
+        export default feature({ naiveTest: true })
         """
       And an environment variable "GTD_QUALITYREVIEWS" set to ""
       And a file "src/calc.ts" with:
@@ -177,7 +178,7 @@ Feature: a person tries the naive pass by hand before anything builds on it
         gtd(check): seam.applying → seam.try
         """
 
-  Rule: with flagMode on
+  Rule: with a release flag asked for
 
     Background:
       Given a gtd config with:
@@ -208,7 +209,11 @@ Feature: a person tries the naive pass by hand before anything builds on it
 
         - the calculator module
 
-        ## Acceptance Criteria
+        ## Release Flag
+
+      new
+
+      ## Acceptance Criteria
 
         - AC-1: subtract(a, b) returns a - b.
         """
@@ -226,7 +231,7 @@ Feature: a person tries the naive pass by hand before anything builds on it
       And step "seam.applying" runs its script
       And step "seam.restoring" runs its script
 
-    Scenario: with flagMode on the person tries the pass before the seam judge rules
+    Scenario: the person tries the pass before the seam judge rules
       When the process is driven
       Then the process rests at "seam.try"
       And the resting step's content contains "the seam judge rules on its shape"

package/src/workflows/feature/one-step-land.feature

@@ -39,6 +39,10 @@ Feature: a naive pass the judge rules land is itself the implementation
 
       - the greeting module
 
+      ## Release Flag
+
+      new
+
       ## Acceptance Criteria
 
       - AC-1: the change behaves as described.