@pmelab/gtd 54.0.0 → 55.0.0

package/dist/workflows/feature.mjs

@@ -1,8 +1,8 @@
 import { agent, answered, applyScript, changes, changesSince, check, codeChanges, env, hasThreadFor, head, human, judge, judgeDiffShape, kept, mark, matches, quote, read, refuse, removeScript, requireAnswers, requireProgress, requireReplies, requireThreadsClosed, revertScript, run, scope, start, vars, wrote } from "../flows.mjs";
 import { lensEntriesOf } from "../workflow-kit.mjs";
-import { $ as observableMessage, B as designGateAnswerMessage, Ct as testerSystem, D as planner, Dt as unwindFailure, Et as unwindFailedMessage, H as designSystem, I as clearCriteriaMessage, J as implementBuildingPrompt, L as clearCriteriaQuestion, M as buildReviewCollectingPrompt, Mt as envDefaults, Nt as testFileGlobs, P as builderSystem, Q as normaliseCriteriaScript, S as collecting, St as startGateBlockedMessage, U as designTriagePrompt, V as designImpactPrompt, X as naiveApplyFailure, Y as implementFixPrompt, Z as naivePassPrompt, _ as REQUIREMENTS, a as flagModeOn, bt as seamByHandMessage, ct as refactorBuildingPrompt, d as healthy, dt as refactorNotePrompt, et as observableQuestion, f as FEEDBACK, ft as refactorRules, g as REFACTOR_NOTE, h as REFACTOR, i as skills, it as prototypeUnguidedMessage, j as agentWithSkills, jt as defaults, l as gate, lt as refactorDroppedRefusal, n as summary, nt as prototypeOpenMessage, p as PROTOTYPE, q as idleMessage, r as access, rt as prototypeTestingPrompt, s as shipped, t as steering, tt as prototypeFixingPrompt, ut as refactorFixPrompt, w as fixNits, x as coder, xt as seamSteerMessage, y as answerReviewQuestions, yt as reviewerSystem, z as criterionLine } from "../chunks/reserved-CQ7amcKG.mjs";
-import { a as refusePendingHandOff, o as tail } from "../chunks/tail-JZ9PAOwp.mjs";
-import { i as reUnwind, n as humanReview, r as isCode$1, t as buildTail } from "../chunks/review-CXzUXJHL.mjs";
+import { $ as observableMessage, B as designGateAnswerMessage, Ct as testerSystem, D as planner, Dt as unwindFailure, Et as unwindFailedMessage, H as designSystem, I as clearCriteriaMessage, J as implementBuildingPrompt, L as clearCriteriaQuestion, M as buildReviewCollectingPrompt, Mt as envDefaults, Nt as testFileGlobs, P as builderSystem, Q as normaliseCriteriaScript, S as collecting, St as startGateBlockedMessage, U as designTriagePrompt, V as designImpactPrompt, X as naiveApplyFailure, Y as implementFixPrompt, Z as naivePassPrompt, _ as REQUIREMENTS, a as flagModeOn, bt as seamByHandMessage, ct as refactorBuildingPrompt, d as healthy, dt as refactorNotePrompt, et as observableQuestion, f as FEEDBACK, ft as refactorRules, g as REFACTOR_NOTE, h as REFACTOR, i as skills, it as prototypeUnguidedMessage, j as agentWithSkills, jt as defaults, l as gate, lt as refactorDroppedRefusal, n as summary, nt as prototypeOpenMessage, p as PROTOTYPE, q as idleMessage, r as access, rt as prototypeTestingPrompt, s as shipped, t as steering, tt as prototypeFixingPrompt, ut as refactorFixPrompt, w as fixNits, x as coder, xt as seamSteerMessage, y as answerReviewQuestions, yt as reviewerSystem, z as criterionLine } from "../chunks/reserved-DHafcW7t.mjs";
+import { a as refusePendingHandOff, o as tail } from "../chunks/tail-B9Hw2AFB.mjs";
+import { i as reUnwind, n as humanReview, r as isCode$1, t as buildTail } from "../chunks/review-BJGKwlYv.mjs";
 import { posix } from "node:path";
 //#region src/workflows/shared/fences.ts
 const markFenced = (text) => {
@@ -304,16 +304,13 @@ const design = (base, guard) => scope("design", async () => {
 });
 //#endregion
 //#region src/workflows/feature/green.ts
-const green = (guard) => healthy(() => agentWithSkills("fix.suite.fixing", implementFixPrompt(), {
+const green = () => healthy(() => agentWithSkills("fix.suite.fixing", implementFixPrompt(), {
 	label: "Fixing the check",
 	file: FEEDBACK,
 	model: coder(),
 	system: builderSystem()
 }), {
-	guard: () => {
-		requireCriteriaFrozen(REQUIREMENTS);
-		guard?.();
-	},
+	guard: () => requireCriteriaFrozen(REQUIREMENTS),
 	guardRests: false
 });
 //#endregion
@@ -403,7 +400,7 @@ const testing = async (ids, retest) => {
 	});
 	return requireReport(ids, retest);
 };
-const fixing = async (guard) => {
+const fixing = async () => {
 	await scope("fix", () => agentWithSkills("fixing", prototypeFixingPrompt(), {
 		label: "Fixing what the hands-on test found",
 		file: PROTOTYPE,
@@ -413,7 +410,6 @@ const fixing = async (guard) => {
 	}));
 	if (changes().some((c) => c.path === ".gtd/PROTOTYPE.md")) refuse(`gtd land: prototype-fix: leave ${PROTOTYPE} as it is — the next round re-tests from it`);
 	frozen();
-	guard?.();
 };
 /** A person's rest; resolves `true` when they changed something to test again, `false` on a clean overrule. */
 const askPerson = async (name, message, label) => {
@@ -431,10 +427,9 @@ const askPerson = async (name, message, label) => {
 * Use the change by hand: a testing turn reports on every criterion a person
 * can observe, a fix turn takes each failure, and the change is tested again —
 * until the report is clean, or `prototypeRounds` fixes are spent and a person
-* decides. A change with no such criterion is not tested by hand. `guard`
-* holds every fix turn, as it holds the implementation's.
+* decides. A change with no such criterion is not tested by hand.
 */
-const prototypeTest = async (guard) => {
+const prototypeTest = async () => {
 	const cap = prototypeRounds();
 	if (cap === 0) return;
 	await scope("prototype", async () => {
@@ -450,12 +445,12 @@ const prototypeTest = async (guard) => {
 			} else if (open.length === 0) return;
 			else if (fixes < cap && open.some((i) => i.verdict === "fail")) {
 				fixes++;
-				await fixing(guard);
+				await fixing();
 			} else {
 				if (!await askPerson("open", prototypeOpenMessage(open, fixes), "Hands-on test still failing")) return;
 				fixes = 0;
 			}
-			await green(guard);
+			await green();
 		}
 	});
 };
@@ -755,69 +750,25 @@ const importsOf = (test) => [...(test.after ?? "").replace(COMMENT, "").matchAll
 	}));
 });
 const reaches = (imports, added) => namesOf(added).some((name) => imports.some(({ path, tail }) => name === path || tail && name.endsWith(`/${path}`)));
-const named = (id, text) => new RegExp(`(?<![\\w-])${id}(?!\\d)`).test(text);
-/** The lines `change` added: an ID an earlier change left in the file does not count. */
-const addedLines = (change) => {
-	const before = new Set((change.before ?? "").split("\n"));
-	return change.after.split("\n").filter((line) => !before.has(line)).join("\n");
-};
 const acceptanceTests = (changes) => changes.filter((c) => c.after !== void 0 && isCode$1(c.path) && isTestFile(c.path));
-const idsOf = (file) => criterionIds(read(file) ?? "");
-const unnamed = (ids, tests) => {
-	const lines = tests.map(addedLines);
-	return ids.filter((id) => !lines.some((text) => named(id, text)));
-};
 /**
-* Why `tip`'s tests fall short, or `undefined`: a criterion ID of `file` no
-* test line of the pass names, or a test importing a file the pass added —
-* naive structure a reset and refactor replaces, which the tests must survive.
+* Why `tip`'s tests fall short, or `undefined`: a test importing a file the
+* pass added — naive structure a reset and refactor replaces, which the tests
+* must survive.
 */
-const acceptanceFault = (file, tip) => {
-	const tests = acceptanceTests(tip.changes);
-	const untested = unnamed(idsOf(file), tests);
-	if (untested.length > 0) return `acceptance-tests: no test of the naive pass names ${untested.join(", ")} — write a behaviour-level test for each criterion with its ID in the test or scenario name, e.g. "[${untested[0]}] …"`;
+const acceptanceFault = (tip) => {
 	const added = tip.changes.filter((c) => c.status === "added" && isCode$1(c.path) && !isTestFile(c.path)).map((c) => c.path);
-	const reaching = tests.filter((test) => holdsCallSites(test.path)).flatMap((test) => {
+	const reaching = acceptanceTests(tip.changes).filter((test) => holdsCallSites(test.path)).flatMap((test) => {
 		const imports = importsOf(test);
 		return added.filter((path) => reaches(imports, path)).map((path) => `  - ${test.path} → ${path}`);
 	});
 	if (reaching.length > 0) return `acceptance-internals: these tests import files the naive pass added — test through code that existed before it (a public entry point, an existing module's exports):\n${reaching.join("\n")}`;
 };
-/** What a rebuild carries over from the naive pass `tip`: the IDs its tests name, and those test files. */
-const naiveAcceptance = (tip) => {
-	const ids = idsOf(REQUIREMENTS);
-	const perTest = acceptanceTests(tip.changes).map((c) => {
-		const lines = addedLines(c);
-		return {
-			path: c.path,
-			ids: ids.filter((id) => named(id, lines))
-		};
-	});
-	return {
-		hash: tip.hash,
-		tests: perTest.filter((c) => c.ids.length > 0).map((c) => c.path),
-		ids: ids.filter((id) => perTest.some((c) => c.ids.includes(id)))
-	};
-};
-/**
-* Refuse a rebuild whose test changes since `since` leave out an ID the naive
-* pass's tests named. A skipped test still counts: the gate reads text, never runs it.
-*/
-const requireAcceptance = (acceptance, since) => {
-	const missing = unnamed(acceptance.ids, acceptanceTests(changesSince(since)));
-	if (missing.length === 0) return;
-	refuse(`gtd land: rebuild-acceptance: the rebuild's tests leave out ${missing.join(", ")} — carry over the naive pass's acceptance tests (\`git show ${acceptance.hash} -- ${acceptance.tests.map(quote).join(" ")}\`), each with its ID in the test or scenario name`);
-};
-/**
-* Refuse a fix turn that, on its own, drops an ID the naive pass's tests named
-* from a test file. Turn-local, so a person's edit at an escalation rest never
-* wedges later fix turns.
-*/
-const requireAcceptanceKept = (acceptance) => {
-	const dropped = acceptance.ids.filter((id) => changes().filter((c) => isCode$1(c.path) && isTestFile(c.path)).some((c) => named(id, c.before ?? "") && !named(id, c.after ?? "")));
-	if (dropped.length === 0) return;
-	refuse(`gtd land: rebuild-acceptance: this turn drops ${dropped.join(", ")} from the tests — the naive pass's acceptance tests stay; fix the code, not them`);
-};
+/** What a rebuild carries over from the naive pass `tip`: every test file it added or changed. */
+const naiveAcceptance = (tip) => ({
+	hash: tip.hash,
+	tests: acceptanceTests(tip.changes).map((c) => c.path)
+});
 const restore = (path) => `if git cat-file -e ${quote(`HEAD:${path}`)} 2>/dev/null; then git checkout -q HEAD -- ${quote(path)}; else rm -f -- ${quote(path)}; fi`;
 /**
 * Run the suite with `tip`'s diff applied, then take it out again; resolves
@@ -854,11 +805,6 @@ const applied = async (tip) => {
 	await run("applying", applyScript(tip, FEEDBACK, naiveApplyFailure(tip), [".gtd"]), { label: "Applying the naive pass" });
 	return !wrote(".gtd/FEEDBACK.md") && codeChanges().length > 0;
 };
-/** `carried` limited to the criteria `.gtd/REQUIREMENTS.md` lists now; a file listing none narrows nothing. */
-const settled = (carried) => {
-	const listed = idsOf(REQUIREMENTS);
-	return listed.length === 0 ? carried : carried.filter((id) => listed.includes(id));
-};
 const build = async (options) => {
 	await agentWithSkills("building", implementBuildingPrompt(options.reference, options.tier, options.amend, options.afterRefactor, flagModeOn(), options.rebuild), {
 		label: "Implementing",
@@ -877,18 +823,10 @@ async function implement(first, tier, amend) {
 }
 /** `implement`, resolving with the criterion IDs the requirements listed when it closed. */
 const implementing = (options) => scope("implement", async () => {
-	const since = head();
-	const acceptance = options.rebuild?.acceptance;
-	const built = options.naive === void 0 || !await applied(options.naive);
-	if (built) await build(options);
+	if (options.naive === void 0 || !await applied(options.naive)) await build(options);
 	else requireCriteriaFrozen(REQUIREMENTS);
-	if (built && acceptance !== void 0) requireAcceptance({
-		...acceptance,
-		ids: settled(acceptance.ids)
-	}, since);
-	const keepsTests = built && acceptance !== void 0 ? () => requireAcceptanceKept(acceptance) : void 0;
-	await green(keepsTests);
-	await prototypeTest(keepsTests);
+	await green();
+	await prototypeTest();
 	const ids = criterionIds(read(".gtd/REQUIREMENTS.md") ?? "");
 	await run("closing", removeScript([
 		REQUIREMENTS,
@@ -928,7 +866,7 @@ const budget = () => {
 };
 /** Sends a pass whose tests fall short or run red back (`undefined`: it goes on, an overruled one as it is). */
 const vetted = async (tip, vetting) => {
-	const fault = vetting.waived ? void 0 : acceptanceFault(REQUIREMENTS, tip);
+	const fault = vetting.waived ? void 0 : acceptanceFault(tip);
 	if (fault !== void 0) {
 		const verdict = await vetting.again({
 			fault,
@@ -1048,6 +986,7 @@ const buildFeature = async (firstBase) => {
 	const handedOut = new Set(listedIds());
 	const seam = await seamBuild(firstBase);
 	const used = gather(handedOut);
+	const requirements = read(REQUIREMENTS);
 	const closed = await implementing({
 		reference: seam.reference,
 		tier,
@@ -1057,7 +996,7 @@ const buildFeature = async (firstBase) => {
 	});
 	const carried = seam.rebuild?.acceptance?.tests ?? [];
 	const base = seam.refactored === true && !changesSince(seam.base).some((c) => isCode$1(c.path) && !carried.includes(c.path)) ? firstBase : seam.base;
-	const outcome = await reviewedTail(base, base);
+	const outcome = await reviewedTail(base, base, requirements);
 	await featureFeedback(outcome, base, {
 		closed,
 		used
@@ -1069,13 +1008,14 @@ const gather = (handedOut) => {
 	return [...handedOut];
 };
 /** The quality lap, then a reviewer's walkthrough since `base` for the human. */
-const reviewedTail = (base, lensBase, lap = "first") => tail((escalations, report) => humanReview(base, escalations, {
+const reviewedTail = (base, lensBase, requirements, lap = "first") => tail((escalations, report) => humanReview(base, escalations, {
 	report,
 	walkthrough: true,
 	lap
 }), {
 	green: true,
-	lensBase
+	lensBase,
+	requirements
 });
 const featureFeedback = async (first, lensBase, ids) => {
 	let outcome = first;
@@ -1091,11 +1031,13 @@ const featureFeedback = async (first, lensBase, ids) => {
 			requireStableIds(REQUIREMENTS, lap);
 			gather(handedOut);
 		});
+		const tier = riskTierOn() ? recordRisk() : void 0;
+		const requirements = read(REQUIREMENTS);
 		closed = await implementing({
-			tier: riskTierOn() ? recordRisk() : void 0,
+			tier,
 			amend: true
 		});
-		outcome = await reviewedTail(outcome.base, lensBase, "feedback");
+		outcome = await reviewedTail(outcome.base, lensBase, requirements, "feedback");
 	}
 };
 /** Design — skipped when the sketch's own criteria are judged clear — then `buildFeature`. */
@@ -1109,11 +1051,16 @@ const afterTail = async (first) => {
 	while (outcome.verdict === "feedback") {
 		await reUnwind(outcome);
 		await design(outcome.base);
+		const tier = riskTierOn() ? recordRisk() : void 0;
+		const requirements = read(REQUIREMENTS);
 		await implement({
-			tier: riskTierOn() ? recordRisk() : void 0,
+			tier,
 			amend: true
 		});
-		outcome = await buildTail(outcome.base, { green: true });
+		outcome = await buildTail(outcome.base, {
+			green: true,
+			requirements
+		});
 	}
 };
 /** An ordinary start: wait at `idle`, unwind the sketch, check the baseline, then plan and build. */
@@ -1141,4 +1088,4 @@ const feature = shipped(ordinaryStart);
 //#region src/workflows/feature/index.ts
 var feature_default = feature;
 //#endregion
-export { COMMENT, REFACTOR_PACKAGE, acceptanceFault, access, afterTail, answerProductQuestions, answerReviewQuestions, buildFeature, buildTail, collecting, criteriaOf, criterionIds, feature_default as default, defaults, design, envDefaults, feature, fixNits, handsOnIds, hasImpact, holdsCallSites, implement, implementing, isTestFile, judgeSeam, naiveAcceptance, naivePass, ordinaryStart, planAndBuild, reUnwind, refactorCollecting, refactorFirst, refactorNote, refactorStrays, requireAcceptance, requireAcceptanceKept, requireCriteria, requireCriteriaFrozen, requireImpact, requireImpactOnly, requireNoNewFlags, requireNoTestFiles, requireStableIds, requireTestCallSitesOnly, requireWithin, reviewedRefactor, seamBuild, skills, skipDesign, statedCriteria, steering, summary, triage, unstableIds, unwind };
+export { COMMENT, REFACTOR_PACKAGE, acceptanceFault, access, afterTail, answerProductQuestions, answerReviewQuestions, buildFeature, buildTail, collecting, criteriaOf, criterionIds, feature_default as default, defaults, design, envDefaults, feature, fixNits, handsOnIds, hasImpact, holdsCallSites, implement, implementing, isTestFile, judgeSeam, naiveAcceptance, naivePass, ordinaryStart, planAndBuild, reUnwind, refactorCollecting, refactorFirst, refactorNote, refactorStrays, requireCriteria, requireCriteriaFrozen, requireImpact, requireImpactOnly, requireNoNewFlags, requireNoTestFiles, requireStableIds, requireTestCallSitesOnly, requireWithin, reviewedRefactor, seamBuild, skills, skipDesign, statedCriteria, steering, summary, triage, unstableIds, unwind };

package/dist/workflows/fix.mjs

@@ -1,7 +1,7 @@
 import { read, refuse, removeScript, run, scope, start } from "../flows.mjs";
 import { _ as reviewNotes, v as reviewRisks } from "../chunks/steering-CLhu8C7q.mjs";
-import { G as fixReviewNotesPrompt, Mt as envDefaults, W as finisherSystem, c as baseline, i as skills, j as agentWithSkills, jt as defaults, n as summary, r as access, s as shipped, t as steering, v as REVIEW, x as coder } from "../chunks/reserved-CQ7amcKG.mjs";
-import { r as handOffTail, t as REVIEW_ORIG } from "../chunks/tail-JZ9PAOwp.mjs";
+import { G as fixReviewNotesPrompt, Mt as envDefaults, W as finisherSystem, c as baseline, i as skills, j as agentWithSkills, jt as defaults, n as summary, r as access, s as shipped, t as steering, v as REVIEW, x as coder } from "../chunks/reserved-DHafcW7t.mjs";
+import { r as handOffTail, t as REVIEW_ORIG } from "../chunks/tail-B9Hw2AFB.mjs";
 //#region src/workflows/fix/fix.ts
 /**
 * Fix every note a human left in a handed-off `.gtd/REVIEW.md` and every

package/dist/workflows/review.mjs

@@ -1,7 +1,7 @@
 import { read, refuse, removeScript, run, start } from "../flows.mjs";
-import { Mt as envDefaults, W as finisherSystem, _ as REQUIREMENTS, gt as reviewGateBlockedMessage, ht as reviewFeedbackFixPrompt, i as skills, j as agentWithSkills, jt as defaults, l as gate, n as summary, r as access, s as shipped, t as steering, x as coder } from "../chunks/reserved-CQ7amcKG.mjs";
-import { a as refusePendingHandOff } from "../chunks/tail-JZ9PAOwp.mjs";
-import { i as reUnwind, t as buildTail } from "../chunks/review-CXzUXJHL.mjs";
+import { Mt as envDefaults, W as finisherSystem, _ as REQUIREMENTS, gt as reviewGateBlockedMessage, ht as reviewFeedbackFixPrompt, i as skills, j as agentWithSkills, jt as defaults, l as gate, n as summary, r as access, s as shipped, t as steering, x as coder } from "../chunks/reserved-DHafcW7t.mjs";
+import { a as refusePendingHandOff } from "../chunks/tail-B9Hw2AFB.mjs";
+import { i as reUnwind, t as buildTail } from "../chunks/review-BJGKwlYv.mjs";
 //#region src/workflows/review/review.ts
 const fixFeedback = async () => {
 	await agentWithSkills("feedback.fixing", reviewFeedbackFixPrompt(), {

package/dist/workflows/rollout.mjs

@@ -1,5 +1,5 @@
 import { agent, changesSince, glob, head, mark, read, refuse, removeScript, run, scope, vars } from "../flows.mjs";
-import { Gt as flipProblems, Mt as envDefaults, Ut as flagMentions, f as FEEDBACK, i as skills, jt as defaults, l as gate, n as summary, o as flagShipped, qt as requireFlag, r as access, t as steering, x as coder } from "../chunks/reserved-CQ7amcKG.mjs";
+import { Gt as flipProblems, Mt as envDefaults, Ut as flagMentions, f as FEEDBACK, i as skills, jt as defaults, l as gate, n as summary, o as flagShipped, qt as requireFlag, r as access, t as steering, x as coder } from "../chunks/reserved-DHafcW7t.mjs";
 //#region src/workflows/rollout/rollout.ts
 const flippingPrompt = (name, registry) => `Roll out the release flag "${name}": in ${registry}, set \`defaultOn: true\` on its entry. Change nothing else — no other entry, no other field, no other file, no comments.`;
 const suiteBlockedMessage = () => "The suite is red after the rollout. Fix it by hand — a rollout may only touch the flag's registry entry — then land.";