@pmelab/gtd 52.0.0 → 52.1.0

package/src/workflows/feature/prototype.feature

@@ -30,6 +30,10 @@ Feature: every observable criterion is tested by hand before the quality lap
       """
       # Requirements
 
+      ## Impact
+
+      - the greeting module
+
       ## Acceptance Criteria
 
       - AC-1: subtract(a, b) returns a - b.
@@ -236,6 +240,10 @@ Feature: every observable criterion is tested by hand before the quality lap
       """
       # Requirements
 
+      ## Impact
+
+      - the greeting module
+
       ## Acceptance Criteria
 
       - AC-2: add is unchanged.

package/src/workflows/feature/refactor-absorbs.feature

@@ -37,6 +37,10 @@ Feature: a refactor that carried the whole feature still gets a quality lap over
 
       - `subtract(a, b)` returns `a - b`.
 
+      ## Impact
+
+      - the greeting module
+
       ## Acceptance Criteria
 
       - AC-1: the change behaves as described.

package/src/workflows/feature/refactor-first.feature

@@ -36,6 +36,10 @@ Feature: a refactor-first judgment walks one fixed path to the review gate
 
       - `subtract(a, b)` returns `a - b`.
 
+      ## Impact
+
+      - the greeting module
+
       ## Acceptance Criteria
 
       - AC-1: the change behaves as described.

package/src/workflows/feature/refactor-lens-models.feature

@@ -29,6 +29,10 @@ Feature: the refactor review's lenses take their model hints from refactorQualit
 
       - `subtract(a, b)` returns `a - b`.
 
+      ## Impact
+
+      - the greeting module
+
       ## Acceptance Criteria
 
       - AC-1: the change behaves as described.

package/src/workflows/feature/refactor-rebuild.feature

@@ -37,6 +37,10 @@ Feature: refactor-first writes a refactor note, refactors on its own, then rebui
 
       - `subtract(a, b)` returns `a - b`.
 
+      ## Impact
+
+      - the greeting module
+
       ## Acceptance Criteria
 
       - AC-1: subtract returns the difference.

package/src/workflows/feature/refactor-review.feature

@@ -48,6 +48,10 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
 
       - `subtract(a, b)` returns `a - b`.
 
+      ## Impact
+
+      - the greeting module
+
       ## Acceptance Criteria
 
       - AC-1: the change behaves as described.
@@ -146,6 +150,10 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
 
       - `subtract(a, b)` returns `a - b`.
 
+      ## Impact
+
+      - the greeting module
+
       ## Acceptance Criteria
 
       - AC-1: the change behaves as described.
@@ -245,6 +253,10 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
 
         - `subtract(a, b)` returns `a - b`.
 
+        ## Impact
+
+        - the greeting module
+
         ## Acceptance Criteria
 
         - AC-1: the change behaves as described.
@@ -1210,6 +1222,10 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
 
         - `subtract(a, b)` returns `a - b`.
 
+        ## Impact
+
+        - the greeting module
+
         ## Acceptance Criteria
 
         - AC-1: the change behaves as described.
@@ -1337,6 +1353,10 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
 
         - `subtract(a, b)` returns `a - b`.
 
+        ## Impact
+
+        - the greeting module
+
         ## Acceptance Criteria
 
         - AC-1: the change behaves as described.

package/src/workflows/feature/review-answers.feature

@@ -36,6 +36,10 @@ Feature: every note in the review is answered with one tick
 
       - `subtract(a, b)` returns `a - b`.
 
+      ## Impact
+
+      - the greeting module
+
       ## Acceptance Criteria
 
       - AC-1: subtract(a, b) returns a - b.

package/src/workflows/feature/review-gate.feature

@@ -36,6 +36,10 @@ Feature: a feature process ends at the human review
 
       - `subtract(a, b)` returns `a - b`.
 
+      ## Impact
+
+      - the greeting module
+
       ## Acceptance Criteria
 
       - AC-1: subtract(a, b) returns a - b.
@@ -192,6 +196,10 @@ Feature: a feature process ends at the human review
 
         - `multiply(a, b)` returns `a * b`.
 
+        ## Impact
+
+        - the greeting module
+
         ## Acceptance Criteria
 
         - AC-1: subtract(a, b) returns a - b.
@@ -238,6 +246,10 @@ Feature: a feature process ends at the human review
 
         - `multiply(a, b)` returns `a * b`.
 
+        ## Impact
+
+        - the greeting module
+
         ## Acceptance Criteria
 
         - AC-0: multiply(a, b) returns a * b.

package/src/workflows/feature/reviewer-walkthrough.feature

@@ -31,6 +31,10 @@ Feature: a reviewer walks the human through the feature's code
       """
       # Requirements
 
+      ## Impact
+
+      - the greeting module
+
       ## Acceptance Criteria
 
       - AC-1: subtract(a, b) returns a - b.

package/src/workflows/feature/risk-tier.feature

@@ -50,6 +50,10 @@ Feature: the risk tier is proposed at triage and recorded behind GTD_FLAG_RISK_T
 
         low — trivial copy change
 
+        ## Impact
+
+        - the greeting module
+
         ## Acceptance Criteria
 
         - AC-1: the change behaves as described.
@@ -69,6 +73,10 @@ Feature: the risk tier is proposed at triage and recorded behind GTD_FLAG_RISK_T
 
         high — touches payments
 
+        ## Impact
+
+        - the greeting module
+
         ## Acceptance Criteria
 
         - AC-1: the change behaves as described.
@@ -89,6 +97,10 @@ Feature: the risk tier is proposed at triage and recorded behind GTD_FLAG_RISK_T
 
         ### Subtract
 
+        ## Impact
+
+        - the greeting module
+
         ## Acceptance Criteria
 
         - AC-1: the change behaves as described.
@@ -118,6 +130,10 @@ Feature: the risk tier is proposed at triage and recorded behind GTD_FLAG_RISK_T
         - error rate on /subtract stays flat
         - p95 latency
 
+        ## Impact
+
+        - the greeting module
+
         ## Acceptance Criteria
 
         - AC-1: the change behaves as described.
@@ -142,6 +158,10 @@ Feature: the risk tier is proposed at triage and recorded behind GTD_FLAG_RISK_T
 
         low — trivial copy change
 
+        ## Impact
+
+        - the greeting module
+
         ## Acceptance Criteria
 
         - AC-1: the change behaves as described.
@@ -187,6 +207,10 @@ Feature: the risk tier is proposed at triage and recorded behind GTD_FLAG_RISK_T
 
         ### Subtract
 
+        ## Impact
+
+        - the greeting module
+
         ## Acceptance Criteria
 
         - AC-1: the change behaves as described.
@@ -233,6 +257,10 @@ Feature: the risk tier is proposed at triage and recorded behind GTD_FLAG_RISK_T
 
         - error rate stays flat
 
+        ## Impact
+
+        - the greeting module
+
         ## Acceptance Criteria
 
         - AC-1: the change behaves as described.
@@ -258,6 +286,10 @@ Feature: the risk tier is proposed at triage and recorded behind GTD_FLAG_RISK_T
 
         low — trivial
 
+        ## Impact
+
+        - the greeting module
+
         ## Acceptance Criteria
 
         - AC-1: the change behaves as described.

package/src/workflows/feature/seam-rejection.feature

@@ -35,6 +35,10 @@ Feature: rejected naive passes walk one fixed path through the steer gate to the
 
       - `subtract(a, b)` returns `a - b`.
 
+      ## Impact
+
+      - the greeting module
+
       ## Acceptance Criteria
 
       - AC-1: the change behaves as described.
@@ -76,6 +80,10 @@ Feature: rejected naive passes walk one fixed path through the steer gate to the
 
       - `subtract(a, b)` returns `a - b`, in the calculator module.
 
+      ## Impact
+
+      - the greeting module
+
       ## Acceptance Criteria
 
       - AC-1: the change behaves as described.

package/src/workflows/feature/seam.feature

@@ -45,6 +45,10 @@ Feature: the naive pass and seam judge decide how a feature is built
 
       - `subtract(a, b)` returns `a - b`.
 
+      ## Impact
+
+      - the greeting module
+
       ## Acceptance Criteria
 
       - AC-1: the change behaves as described.
@@ -234,6 +238,10 @@ Feature: the naive pass and seam judge decide how a feature is built
 
       - `subtract(a, b)` returns `a - b`, in a new module.
 
+      ## Impact
+
+      - the greeting module
+
       ## Acceptance Criteria
 
       - AC-1: the change behaves as described.

package/src/workflows/feature/seam.test.ts

@@ -109,7 +109,8 @@ describe("naivePass", () => {
 })
 
 describe("naiveAcceptance and requireAcceptance", () => {
-  const requirements = "# R\n\n## Acceptance Criteria\n\n- AC-1: adds.\n- AC-2: subtracts.\n"
+  const requirements =
+    "# R\n\n## Impact\n\n- the module\n\n## Acceptance Criteria\n\n- AC-1: adds.\n- AC-2: subtracts.\n"
   const file = (path: string, before: string | undefined, after: string): Change => ({
     path,
     status: before === undefined ? "added" : "modified",
@@ -170,7 +171,8 @@ describe("naiveAcceptance and requireAcceptance", () => {
 })
 
 describe("acceptanceFault", () => {
-  const requirements = "# R\n\n## Acceptance Criteria\n\n- AC-1: adds.\n- AC-2: subtracts.\n"
+  const requirements =
+    "# R\n\n## Impact\n\n- the module\n\n## Acceptance Criteria\n\n- AC-1: adds.\n- AC-2: subtracts.\n"
   const file = (path: string, status: Change["status"], after: string): Change => ({
     path,
     status,

package/src/workflows/feature/severity-budget.feature

@@ -28,6 +28,10 @@ Feature: the review's ranking is batched to the judge's budget
       """
       # Requirements
 
+      ## Impact
+
+      - the greeting module
+
       ## Acceptance Criteria
 
       - AC-1: subtract(a, b) returns a - b.

package/src/workflows/feature/severity-sorted-review.feature

@@ -31,6 +31,10 @@ Feature: the final review lists the findings that matter most first
       """
       # Requirements
 
+      ## Impact
+
+      - the greeting module
+
       ## Acceptance Criteria
 
       - AC-1: subtract(a, b) returns a - b.

package/src/workflows/feature/slice-findings.feature

@@ -30,6 +30,10 @@ Feature: every slice's quality lap is triaged, and its leftovers wait for the re
       """
       # Requirements
 
+      ## Impact
+
+      - the greeting module
+
       ## Acceptance Criteria
 
       - AC-1: subtract(a, b) returns a - b.

package/src/workflows/feature/slicing.feature

@@ -36,6 +36,10 @@ Feature: a change with more criteria than the cap is built in coarse slices
       """
       # Requirements
 
+      ## Impact
+
+      - the greeting module
+
       ## Acceptance Criteria
 
       - AC-1: subtract(a, b) returns a - b.
@@ -70,6 +74,10 @@ Feature: a change with more criteria than the cap is built in coarse slices
       """
       # Requirements
 
+      ## Impact
+
+      - the greeting module
+
       ## Acceptance Criteria
 
       - AC-1: subtract(a, b) returns a - b.
@@ -133,6 +141,10 @@ Feature: a change with more criteria than the cap is built in coarse slices
       """
       # Requirements
 
+      ## Impact
+
+      - the greeting module
+
       ## Acceptance Criteria
 
       - AC-1: subtract(a, b) returns a - b.
@@ -156,6 +168,10 @@ Feature: a change with more criteria than the cap is built in coarse slices
       """
       # Requirements
 
+      ## Impact
+
+      - the greeting module
+
       ## Acceptance Criteria
 
       - AC-1: subtract(a, b) returns a - b.
@@ -181,6 +197,10 @@ Feature: a change with more criteria than the cap is built in coarse slices
       """
       # Requirements
 
+      ## Impact
+
+      - the greeting module
+
       ## Acceptance Criteria
 
       - AC-1: subtract(a, b) returns a - b.
@@ -191,6 +211,10 @@ Feature: a change with more criteria than the cap is built in coarse slices
       """
       # Requirements
 
+      ## Impact
+
+      - the greeting module
+
       ## Acceptance Criteria
 
       - AC-1: subtract(a, b) returns a - b.
@@ -215,6 +239,10 @@ Feature: a change with more criteria than the cap is built in coarse slices
       """
       # Requirements
 
+      ## Impact
+
+      - the greeting module
+
       ## Acceptance Criteria
 
       - AC-1: subtract(a, b) returns a - b.
@@ -244,6 +272,10 @@ Feature: a change with more criteria than the cap is built in coarse slices
       """
       # Requirements
 
+      ## Impact
+
+      - the greeting module
+
       ## Acceptance Criteria
 
       - AC-1: subtract(a, b) returns a - b.

package/src/workflows/feature/standards.feature

@@ -37,6 +37,10 @@ Feature: the review learns standards from the human's answers
 
       - `subtract(a, b)` returns `a - b`.
 
+      ## Impact
+
+      - the greeting module
+
       ## Acceptance Criteria
 
       - AC-1: subtract(a, b) returns a - b.

package/src/workflows/feature/tier-pin.feature

@@ -34,6 +34,10 @@ Feature: a process keeps the risk tier setting it started with when GTD_FLAG_RIS
 
       low — a new pure function
 
+      ## Impact
+
+      - the greeting module
+
       ## Acceptance Criteria
 
       - AC-1: the change behaves as described.

package/src/workflows/shared/text.test.ts

@@ -4,6 +4,8 @@ import { tmpdir } from "node:os"
 import { join } from "node:path"
 import { afterEach, describe, expect, it } from "vitest"
 import {
+  designImpactPrompt,
+  prototypeFixingPrompt,
   buildReviewTriageMessage,
   buildReviewReviewingPrompt,
   agentWithSkills,
@@ -24,6 +26,7 @@ import {
   implementBuildingPrompt,
   implementFixPrompt,
   naivePassPrompt,
+  slicingPrompt,
   refactorBuildingPrompt,
   refactorDroppedRefusal,
   refactorFixPrompt,
@@ -922,6 +925,29 @@ describe("buildReviewReviewingPrompt scenarios", () => {
   })
 })
 
+describe("Impact in prompts", () => {
+  it("[AC-4] the slicing prompt slices along the units Impact names", () => {
+    const prompt = renderText(() => slicingPrompt(8))
+    expect(prompt).toContain("## Impact")
+    expect(prompt).toMatch(/slice\s+along\s+the\s+units\s+it\s+names/)
+  })
+
+  it.each([
+    ["naive", () => naivePassPrompt()],
+    ["implement", () => implementBuildingPrompt(undefined)],
+    ["prototype fixing", () => prototypeFixingPrompt(undefined)],
+  ])("[AC-5] [AC-7] the %s prompt gives Impact as hints, not allowed files", (_n, prompt) => {
+    const p = renderText(prompt).replace(/\s+/g, " ")
+    expect(p).toContain("`## Impact`")
+    expect(p).toContain("not a list of allowed files")
+  })
+
+  it("the prototype testing prompt, which changes no code, carries no Impact hints", () => {
+    const p = renderText(() => prototypeTestingPrompt(undefined, [], false))
+    expect(p).not.toContain("not a list of allowed files")
+  })
+})
+
 describe("the seam phase's texts", () => {
   const rejection = { strays: ["src/flows/helpers.ts", "src/flows/runtime.ts"], p: 0.85 }
 
@@ -1641,3 +1667,17 @@ describe("rankedReview", () => {
     expect(unranked(unranked(review))).toBe(unranked(review))
   })
 })
+
+describe("impact prompts", () => {
+  it.each([
+    ["triage", () => renderText(() => designTriagePrompt("abc123"))],
+    ["design.impact", () => renderText(() => designImpactPrompt())],
+  ])("[AC-2] the %s prompt asks for a `## Impact` section", (_n, prompt) => {
+    expect(prompt()).toContain("`## Impact`")
+  })
+
+  it("[AC-3] the triage prompt names where a return lap reads the human's Impact edit", () => {
+    const p = renderText(() => designTriagePrompt("abc123")).replace(/\s+/g, " ")
+    expect(p).toContain("`git log -1 -p -- .gtd/REQUIREMENTS.md`")
+  })
+})

package/src/workflows/shared/text.ts

@@ -515,6 +515,20 @@ Leave the tag off whatever a person can see by running the change. A
 tag the human added or removed at the gate stays as they left it.
 `
 
+const impactBlock = `
+## Impact
+
+\`.gtd/REQUIREMENTS.md\` carries a \`## Impact\` section: explore the
+codebase (not just the start diff) and name the units and boundaries
+this change touches, the public surfaces it affects (CLI commands and
+flags, config keys, driver protocol, exported API), and anything
+surprising. Name the project's own declared units first —
+dependency-cruiser rules, workspace packages, module boundaries named
+in its docs or agent instructions (\`AGENTS.md\`, \`CLAUDE.md\`). When
+none is declared, fall back to directories and packages. Landing is
+refused while the section is missing.
+`
+
 const riskTierBlock = `
 ## Risk tier and production signals
 
@@ -556,7 +570,14 @@ ${footnoteFoldIn}${codeThreadReplies()}
   or both
 - Whichever lap this is, leave \`.gtd/REQUIREMENTS.md\`
   uncommitted and finish once it reflects this lap's own work
-${acceptanceCriteriaBlock}
+${acceptanceCriteriaBlock}${impactBlock}
+Every lap re-explores and leaves \`## Impact\` present. On a return
+lap or review loop-back the human may have edited \`## Impact\` (or
+footnoted it): read that edit from history (\`git log -1 -p --
+.gtd/REQUIREMENTS.md\`), keep the human's correction, and
+re-explore from it. A surprise the human must settle becomes an
+entry under \`## Open Questions\`.
+
 ## First lap
 
 \`.gtd/REQUIREMENTS.md\` does not exist yet (or holds whatever the
@@ -612,6 +633,23 @@ ${questionBarReturn}
   everything else — the build assumes the suite started green
 ${riskTier ? riskTierBlock : ""}`
 
+export const designImpactPrompt = (): string =>
+  `${styleBlock}
+
+${styleFormatContract}
+
+${stateFileRules}
+- The only state file this turn touches is \`.gtd/REQUIREMENTS.md\`
+  — no other files for notes or output
+- \`.gtd/REQUIREMENTS.md\` already holds the settled acceptance
+  criteria. Add a \`## Impact\` section and change nothing else — a
+  turn that touches anything outside it is refused
+- No human reviews this before the build: put any surprise in the
+  Impact prose, never as a question
+${impactBlock}
+- Leave \`.gtd/REQUIREMENTS.md\` uncommitted and finish once it holds \`## Impact\`
+`
+
 export const clearCriteriaQuestion: JudgeQuestion = {
   id: "clear",
   primitive: "noul",
@@ -665,9 +703,9 @@ export const slicingPrompt = (cap: number): string =>
 - Read \`.gtd/REQUIREMENTS.md\`: its \`## Acceptance Criteria\` are settled
   and more than ${cap}, too many to build in one slice
 - Group them into slices in \`.gtd/SLICES.md\`, one \`## <title>\` heading per
-  slice over a \`- AC-<n>\` list item per criterion it builds. Put criteria of
-  the same flow or subsystem together; every criterion in exactly one slice,
-  at most ${cap} per slice
+  slice over a \`- AC-<n>\` list item per criterion it builds. Read the
+  \`## Impact\` section of \`.gtd/REQUIREMENTS.md\` and slice along the units it
+  names; every criterion in exactly one slice, at most ${cap} per slice
 - Keep it coarse: as few slices as the cap allows, never one per criterion
 - Order the slices so each builds on the ones before: they run in that order,
   each from where the previous one landed
@@ -1620,6 +1658,11 @@ const isFault = (retry: NaiveRetry): retry is NaiveFault => "fault" in retry
 const pickUp = (hash: string, exclude?: string): string =>
   `Pick it up — \`git diff --binary --no-color --no-ext-diff --no-textconv ${hash}^ ${hash}${exclude === undefined ? "" : ` -- ${quote(":(top)")} ${quote(`:(top,exclude)${exclude}`)}`} | git apply\``
 
+// Agent-written without a gate on the stated-criteria path, so never claim a human signed it off.
+const impactHints = `- Its \`## Impact\` section maps where the change lands — reviewed at the design
+  gate when design ran. A starting point and hints, not a list of allowed files
+  — change whatever the work needs`
+
 const criteriaBinding = (refused: boolean): string =>
   `- Its \`## Acceptance Criteria\` (\`AC-<n>\`) bind this turn: re-read them from
   the file, never from memory, and stop only when each one holds. They are
@@ -1714,6 +1757,7 @@ export const naivePassPrompt = (
 ): string =>
   `${stateFileRules}
 - Read \`.gtd/REQUIREMENTS.md\`: the settled requirements for this change
+${impactHints}
 ${sliceLine(slice)}${criteriaBinding(false)}
 - Implement them the quickest way that works — the naive version. Do not
   restructure, abstract or refactor around the change; it may land exactly as
@@ -1853,6 +1897,7 @@ export const implementBuildingPrompt = (
 ): string =>
   `${stateFileRules}
 - Read \`.gtd/REQUIREMENTS.md\`: the settled requirements for this change
+${impactHints}
 ${sliceLine(slice)}${criteriaBinding(true)}
 ${afterRefactor === true ? afterRefactorLine(rebuild) : ""}${
     amend === true
@@ -2045,6 +2090,7 @@ ${
 export const prototypeFixingPrompt = (slice: readonly string[] | undefined): string =>
   `${stateFileRules}
 - Read \`.gtd/REQUIREMENTS.md\`: the settled requirements for this change
+${impactHints}
 ${sliceLine(slice)}${criteriaBinding(true)}
 - Read \`.gtd/PROTOTYPE.md\`: a hands-on test of the change. Fix every
   \`fail\` chunk of this change's criteria${slice === undefined ? "" : " (this slice's only)"} or a problem found