@pmelab/gtd 51.0.1 → 52.1.0

package/src/workflows/feature/refactor-review.feature

@@ -48,6 +48,10 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
 
       - `subtract(a, b)` returns `a - b`.
 
+      ## Impact
+
+      - the greeting module
+
       ## Acceptance Criteria
 
       - AC-1: the change behaves as described.
@@ -146,6 +150,10 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
 
       - `subtract(a, b)` returns `a - b`.
 
+      ## Impact
+
+      - the greeting module
+
       ## Acceptance Criteria
 
       - AC-1: the change behaves as described.
@@ -245,6 +253,10 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
 
         - `subtract(a, b)` returns `a - b`.
 
+        ## Impact
+
+        - the greeting module
+
         ## Acceptance Criteria
 
         - AC-1: the change behaves as described.
@@ -303,9 +315,9 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
 
         <!-- base: 0000000 -->
 
-        ## calc
+        ## Walkthrough
 
-        _critical: judge unsure_
+        ### calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op[^why]
@@ -342,9 +354,9 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
 
         <!-- base: 0000000 -->
 
-        ## calc
+        ## Walkthrough
 
-        _critical: judge unsure_
+        ### calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op
@@ -382,9 +394,9 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
 
         <!-- base: 0000000 -->
 
-        ## calc
+        ## Walkthrough
 
-        _critical: judge unsure_
+        ### calc
 
         - [ ] ./src/calc.ts#1-1
           why a shared op?
@@ -475,9 +487,9 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
 
         <!-- base: 0000000 -->
 
-        ## calc
+        ## Walkthrough
 
-        _critical: judge unsure_
+        ### calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op — this should change behaviour, not just structure
@@ -521,9 +533,9 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
 
         <!-- base: 0000000 -->
 
-        ## calc
+        ## Walkthrough
 
-        _critical: judge unsure_
+        ### calc
 
         - [ ] ./src/calc.ts#1-2 rename the helper
           add built on the shared op
@@ -550,9 +562,9 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
 
         <!-- base: 0000000 -->
 
-        ## calc
+        ## Walkthrough
 
-        _critical: judge unsure_
+        ### calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op, lovely work
@@ -571,9 +583,9 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
 
         <!-- base: 0000000 -->
 
-        ## calc
+        ## Walkthrough
 
-        _critical: judge unsure_
+        ### calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op[^q]
@@ -615,10 +627,6 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
         """
       And step "implement.health.check" changes nothing
       And step "implement.closing" runs its script
-      And judge step "implement.coverage" answers:
-        """
-        [{"id":"AC-1","answer":"yes","p":0.9}]
-        """
       When the process is driven
       Then the process rests at "refactor.build.review.await-review"
       Given a file ".gtd/REVIEW.md" with:
@@ -627,9 +635,9 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
 
         <!-- base: 0000000 -->
 
-        ## calc
+        ## Walkthrough
 
-        _critical: judge unsure_
+        ### calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op[^q]
@@ -661,9 +669,9 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
 
         <!-- base: 0000000 -->
 
-        ## calc
+        ## Walkthrough
 
-        _critical: judge unsure_
+        ### calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op[^q]
@@ -702,10 +710,6 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
         """
       And step "implement.health.check" changes nothing
       And step "implement.closing" runs its script
-      And judge step "implement.coverage" answers:
-        """
-        [{"id":"AC-1","answer":"yes","p":0.9}]
-        """
       When the process is driven
       Then the process rests at "refactor.build.review.await-review"
       Given a file ".gtd/REVIEW.md" with:
@@ -714,9 +718,9 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
 
         <!-- base: 0000000 -->
 
-        ## calc
+        ## Walkthrough
 
-        _critical: judge unsure_
+        ### calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op[^n1]
@@ -742,9 +746,9 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
 
         <!-- base: 0000000 -->
 
-        ## calc
+        ## Walkthrough
 
-        _critical: judge unsure_
+        ### calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op[^n1]
@@ -771,9 +775,9 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
 
         <!-- base: 0000000 -->
 
-        ## calc
+        ## Walkthrough
 
-        _critical: judge unsure_
+        ### calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op[^q]
@@ -805,9 +809,9 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
 
         <!-- base: 0000000 -->
 
-        ## calc
+        ## Walkthrough
 
-        _critical: judge unsure_
+        ### calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op[^n1]
@@ -833,9 +837,9 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
 
         <!-- base: 0000000 -->
 
-        ## calc
+        ## Walkthrough
 
-        _critical: judge unsure_
+        ### calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op - this should change behaviour, not just structure[^q]
@@ -867,9 +871,9 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
 
         <!-- base: 0000000 -->
 
-        ## calc
+        ## Walkthrough
 
-        _critical: judge unsure_
+        ### calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op - this should change behaviour, not just structure[^q]
@@ -914,9 +918,9 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
 
         <!-- base: 0000000 -->
 
-        ## calc
+        ## Walkthrough
 
-        _critical: judge unsure_
+        ### calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op[^q]
@@ -948,9 +952,9 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
 
         <!-- base: 0000000 -->
 
-        ## calc
+        ## Walkthrough
 
-        _critical: judge unsure_
+        ### calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op[^q]
@@ -988,10 +992,6 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
         """
       And step "implement.health.check" changes nothing
       And step "implement.closing" runs its script
-      And judge step "implement.coverage" answers:
-        """
-        [{"id":"AC-1","answer":"yes","p":0.9}]
-        """
       When the process is driven
       Then the process rests at "refactor.build.review.await-review"
       Given a file ".gtd/REVIEW.md" with:
@@ -1000,9 +1000,9 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
 
         <!-- base: 0000000 -->
 
-        ## calc
+        ## Walkthrough
 
-        _critical: judge unsure_
+        ### calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op, lovely work[^q]
@@ -1034,9 +1034,9 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
 
         <!-- base: 0000000 -->
 
-        ## calc
+        ## Walkthrough
 
-        _critical: judge unsure_
+        ### calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op, lovely work[^q]
@@ -1079,10 +1079,6 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
         """
       And step "implement.health.check" changes nothing
       And step "implement.closing" runs its script
-      And judge step "implement.coverage" answers:
-        """
-        [{"id":"AC-1","answer":"yes","p":0.9}]
-        """
       When the process is driven
       Then the process rests at "refactor.build.review.await-review"
       Given a file ".gtd/REVIEW.md" with:
@@ -1091,9 +1087,9 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
 
         <!-- base: 0000000 -->
 
-        ## calc
+        ## Walkthrough
 
-        _critical: judge unsure_
+        ### calc
 
         - [x] ./src/calc.ts#1-2
           add built on the shared op
@@ -1116,9 +1112,9 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
 
         <!-- base: 0000000 -->
 
-        ## calc
+        ## Walkthrough
 
-        _critical: judge unsure_
+        ### calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op — rename `sign` to `direction`
@@ -1147,9 +1143,9 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
 
         <!-- base: 0000000 -->
 
-        ## calc
+        ## Walkthrough
 
-        _critical: judge unsure_
+        ### calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op — rename `sign` to `direction`
@@ -1180,9 +1176,9 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
       Then the process rests at "refactor.build.review.await-review"
       And ".gtd/REVIEW.md" contains:
         """
-        ## calc
+        ## Walkthrough
 
-        _critical: judge unsure_
+        ### calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op
@@ -1226,6 +1222,10 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
 
         - `subtract(a, b)` returns `a - b`.
 
+        ## Impact
+
+        - the greeting module
+
         ## Acceptance Criteria
 
         - AC-1: the change behaves as described.
@@ -1292,10 +1292,6 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
         """
       And step "implement.health.check" changes nothing
       And step "implement.closing" runs its script
-      And judge step "implement.coverage" answers:
-        """
-        [{"id":"AC-1","answer":"yes","p":0.9}]
-        """
       When the process is driven
       Then the process rests at "refactor.build.review.await-review"
       Given a file ".gtd/REVIEW.md" with:
@@ -1304,9 +1300,9 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
 
         <!-- base: 0000000 -->
 
-        ## calc
+        ## Walkthrough
 
-        _critical: judge unsure_
+        ### calc
 
         - [x] ./src/calc.ts#1-2
           add built on the shared op
@@ -1357,6 +1353,10 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
 
         - `subtract(a, b)` returns `a - b`.
 
+        ## Impact
+
+        - the greeting module
+
         ## Acceptance Criteria
 
         - AC-1: the change behaves as described.
@@ -1495,9 +1495,9 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
 
         <!-- base: 0000000 -->
 
-        ## calc
+        ## Walkthrough
 
-        _critical: judge unsure_
+        ### calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op[^why]
@@ -1537,9 +1537,9 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
 
         <!-- base: 0000000 -->
 
-        ## calc
+        ## Walkthrough
 
-        _critical: judge unsure_
+        ### calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op

package/src/workflows/feature/review-answers.feature

@@ -36,6 +36,10 @@ Feature: every note in the review is answered with one tick
 
       - `subtract(a, b)` returns `a - b`.
 
+      ## Impact
+
+      - the greeting module
+
       ## Acceptance Criteria
 
       - AC-1: subtract(a, b) returns a - b.
@@ -54,10 +58,6 @@ Feature: every note in the review is answered with one tick
     And step "implement.applying" runs its script
     And step "implement.health.check" changes nothing
     And step "implement.closing" runs its script
-    And judge step "implement.coverage" answers:
-      """
-      [{"id":"AC-1","answer":"yes","p":0.9}]
-      """
     And step "build.quality.correctness.reviewing" writes ".gtd/QUALITY.md" with:
       """
       # Quality
@@ -125,7 +125,9 @@ Feature: every note in the review is answered with one tick
     Then the process rests at "build.review.await-review"
     And ".gtd/REVIEW.md" contains:
       """
-      ## AC-1 ignores floating point
+      ## Findings
+
+      ### AC-1 ignores floating point
 
       _critical: judge unsure_
 
@@ -233,3 +235,90 @@ Feature: every note in the review is answered with one tick
     And the text "- [ ] fix as suggested" in ".gtd/REVIEW.md" is replaced with ""
     And the text "Tick exactly one:" in ".gtd/REVIEW.md" is replaced with ""
     Then landing is refused with "its answer boxes were deleted"
+
+  Scenario: a review still in the flat layout, every chunk a `## `, is answered by its ticks
+    Given judge step "build.review.standards.judge" answers:
+      """
+      [{"id":"standard-1","answer":"no","p":0.9}]
+      """
+    When the process is driven
+    Then the process rests at "build.review.await-review"
+    Given a file ".gtd/REVIEW.md" with:
+      """
+      # Review: abc1234
+
+      <!-- base: 0000000 -->
+
+      ## AC-1 ignores floating point
+
+      _critical: judge unsure_
+
+      Should subtract round? The criterion does not say.
+
+      In the code:
+
+      - [ ] ./src/calc.ts#2-2 — returns the raw difference
+
+      Tick exactly one:
+
+      - [ ] fix as suggested
+      - [x] won't fix
+      - [ ] _your answer_
+
+      ## Subtract
+
+      - [ ] ./src/calc.ts#2-2 — subtract(a, b)
+      """
+    When gtd lands
+    And the process is driven
+    Then the process rests at "idle"
+    And the commit "gtd(human): build.review.await-review → build.review.standards.judge" has a body containing "Gtd-Mark: wontfix=AC-1 ignores floating point"
+    And no commit body contains "build.review.triage"
+
+  Scenario: boxes ticked in the walkthrough answer nothing
+    Given judge step "build.review.standards.judge" answers:
+      """
+      [{"id":"standard-1","answer":"no","p":0.9}]
+      """
+    When the process is driven
+    Then the process rests at "build.review.await-review"
+    Given a file ".gtd/REVIEW.md" with:
+      """
+      # Review: abc1234
+
+      <!-- base: 0000000 -->
+
+      ## Findings
+
+      ### AC-1 ignores floating point
+
+      _critical: judge unsure_
+
+      Should subtract round? The criterion does not say.
+
+      In the code:
+
+      - [ ] ./src/calc.ts#2-2 — returns the raw difference
+
+      Tick exactly one:
+
+      - [ ] fix as suggested
+      - [x] won't fix
+      - [ ] _your answer_
+
+      ## Walkthrough
+
+      ### Subtract
+
+      - [ ] ./src/calc.ts#2-2 — subtract(a, b)
+
+      Tick exactly one:
+
+      - [x] fix as suggested
+      - [ ] won't fix
+      - [ ] _your answer_
+      """
+    When gtd lands
+    And the process is driven
+    Then the process rests at "idle"
+    And no commit body contains "build.review.fix.nits.fixing"

package/src/workflows/feature/review-gate.feature

@@ -4,8 +4,8 @@ Feature: a feature process ends at the human review
   After the last slice's quality lap the process rests at the review gate,
   `.gtd/REVIEW.md`. A sign-off ends the process. A note asking for a change in
   behaviour starts a feedback lap — design, then implement with no new naive
-  pass or seam judge, the coverage judge over every criterion, the quality lap
-  — and the review again. Its design keeps a built criterion's ID and numbers
+  pass or seam judge, the hands-on test, the quality lap — and the review
+  again. Its design keeps a built criterion's ID and numbers
   new behaviour above every ID handed out.
 
   Background:
@@ -36,6 +36,10 @@ Feature: a feature process ends at the human review
 
       - `subtract(a, b)` returns `a - b`.
 
+      ## Impact
+
+      - the greeting module
+
       ## Acceptance Criteria
 
       - AC-1: subtract(a, b) returns a - b.
@@ -54,10 +58,6 @@ Feature: a feature process ends at the human review
     And step "implement.applying" runs its script
     And step "implement.health.check" changes nothing
     And step "implement.closing" runs its script
-    And judge step "implement.coverage" answers:
-      """
-      [{"id":"AC-1","answer":"yes","p":0.9}]
-      """
     And step "build.review.reviewing" writes ".gtd/REVIEW.md" with:
       """
       # Review: abc1234
@@ -83,7 +83,7 @@ Feature: a feature process ends at the human review
     And the resting step's content contains the hash of the commit "feat: add calculator"
     And the commit subjects end with:
       """
-      gtd(judge): implement.coverage → implement.closing
+      gtd(check): implement.health.check → implement.closing
       gtd(check): implement.closing → build.review.reviewing
       gtd(agent): build.review.reviewing → build.review.ranking
       gtd(judge): build.review.ranking → build.review.carrying
@@ -99,9 +99,9 @@ Feature: a feature process ends at the human review
 
       <!-- base: 0000000 -->
 
-      ## calc
+      ## Walkthrough
 
-      _critical: judge unsure_
+      ### calc
 
       - [x] ./src/calc.ts#2-2
         new subtract function
@@ -156,9 +156,9 @@ Feature: a feature process ends at the human review
 
         <!-- base: 0000000 -->
 
-        ## calc
+        ## Walkthrough
 
-        _critical: judge unsure_
+        ### calc
 
         - [ ] ./src/calc.ts#2-2
           new subtract function[^why]
@@ -176,15 +176,15 @@ Feature: a feature process ends at the human review
 
         <!-- base: 0000000 -->
 
-        ## calc
+        ## Walkthrough
 
-        _critical: judge unsure_
+        ### calc
 
         - [ ] ./src/calc.ts#2-2
           new subtract function
         """
 
-    Scenario: the lap keeps AC-1, adds AC-2, and covers both before the next review
+    Scenario: the lap keeps AC-1, adds AC-2, and builds both before the next review
       Given step "design.triage" from now on changes nothing
       And step "design.triage" writes ".gtd/REQUIREMENTS.md" with:
         """
@@ -196,6 +196,10 @@ Feature: a feature process ends at the human review
 
         - `multiply(a, b)` returns `a * b`.
 
+        ## Impact
+
+        - the greeting module
+
         ## Acceptance Criteria
 
         - AC-1: subtract(a, b) returns a - b.
@@ -211,15 +215,10 @@ Feature: a feature process ends at the human review
         """
         it("[AC-2] multiplies", () => {})
         """
-      And judge step "implement.coverage" answers:
-        """
-        [{"id":"AC-1","answer":"yes","p":0.9},{"id":"AC-2","answer":"yes","p":0.9}]
-        """
       When gtd lands
       And the process is driven
       Then the process rests at "build.review.await-review"
       And ".gtd/REQUIREMENTS.md" does not exist
-      And the commit "gtd(judge): implement.coverage → implement.closing" has a body containing "Gtd-Mark: covers=AC-1"
       And the commit subjects end with:
         """
         gtd(human): build.review.await-review → build.review.closing
@@ -228,8 +227,7 @@ Feature: a feature process ends at the human review
         gtd(agent): design.triage → design.gate.answer
         gtd(human): design.gate.answer → implement.building
         gtd(agent): implement.building → implement.health.check
-        gtd(check): implement.health.check → implement.coverage
-        gtd(judge): implement.coverage → implement.closing
+        gtd(check): implement.health.check → implement.closing
         gtd(check): implement.closing → build.review.reviewing
         gtd(agent): build.review.reviewing → build.review.ranking
         gtd(judge): build.review.ranking → build.review.carrying
@@ -248,42 +246,14 @@ Feature: a feature process ends at the human review
 
         - `multiply(a, b)` returns `a * b`.
 
-        ## Acceptance Criteria
-
-        - AC-0: multiply(a, b) returns a * b.
-        - AC-1: subtract(a, b) returns a - b.
-        """
-      When gtd lands
-      Then driving the process is refused with "criteria-ids"
-
-    Scenario: the lap holds a new criterion to coverage
-      Given step "design.triage" from now on changes nothing
-      And step "design.triage" writes ".gtd/REQUIREMENTS.md" with:
-        """
-        # Requirements
-
-        ## Concerns
-
-        ### Multiply
+        ## Impact
 
-        - `multiply(a, b)` returns `a * b`.
+        - the greeting module
 
         ## Acceptance Criteria
 
+        - AC-0: multiply(a, b) returns a * b.
         - AC-1: subtract(a, b) returns a - b.
-        - AC-2: multiply(a, b) returns a * b.
-        """
-      And step "implement.building" writes "src/calc.ts" with:
-        """
-        export const add = (a: number, b: number) => a + b
-        export const subtract = (a: number, b: number) => a - b
-        export const multiply = (a: number, b: number) => a * b
-        """
-      And judge step "implement.coverage" answers:
-        """
-        [{"id":"AC-1","answer":"yes","p":0.9},{"id":"AC-2","answer":"no","p":0.9}]
         """
       When gtd lands
-      And the process is driven
-      Then the process rests at "implement.covering"
-      And the resting step's content contains "AC-2"
+      Then driving the process is refused with "criteria-ids"