@pmelab/gtd 45.2.0 → 46.0.0

package/dist/workflows.mjs

@@ -17197,11 +17197,6 @@ const testFileGlobs = [
 	"**/__tests__/**"
 ];
 const defaultFlagRegistry = "src/flags/index.ts";
-/** The `tests` workflow's own process settings: where it looks for skipped tests, and how a skip reads. */
-const testsDefaults = {
-	testFiles: testFileGlobs.join(", "),
-	skipPattern: "^\\s*(?:(?:describe|context|suite|it|test|specify)\\.(?:skip|todo)\\b|x(?:describe|context|it|test|specify)\\s*\\(|(?:@\\S+\\s+)*@(?:skip|ignore)(?:\\s|$))"
-};
 /** Process settings. */
 const defaults = {
 	reviewBase: "",
@@ -17534,7 +17529,7 @@ const composedReview = (base, report) => {
 		return name;
 	};
 	const chunk = (title, body) => `## ${title}\n\n${body.trim()}`;
-	const answerBoxes = ([fix, wontFix] = [ANSWER_FIX, ANSWER_WONT_FIX]) => `${ANSWER_LEAD}\n\n- [ ] ${fix}\n- [ ] ${wontFix}\n- [ ] ${FREE_TEXT_PLACEHOLDER}`;
+	const answerBoxes = `${ANSWER_LEAD}\n\n- [ ] ${ANSWER_FIX}\n- [ ] ${ANSWER_WONT_FIX}\n- [ ] ${FREE_TEXT_PLACEHOLDER}`;
 	const conflicts = (report.standards?.undecided ?? []).map((c) => chunk(unique(conflictTitle(c)), conflictBody(c)));
 	const added = report.standards?.added ?? [];
 	const notes = report.notes.map((n) => ({
@@ -17546,7 +17541,7 @@ const composedReview = (base, report) => {
 		...report.nitFix === void 0 ? [] : [chunk("Fixed from your notes", `Your nits and fix-as-suggested notes were worked on in ${short(report.nitFix)}; the notes you answered are left out — check the diff.`)],
 		...weakened.length === 0 ? [] : [chunk("Weakened scenarios", `These scenarios lost an assertion the review base had:\n\n${weakened.join("\n")}`)],
 		...conflicts,
-		...notes.map((n) => chunk(n.title, `${n.unresolved === true ? `_The fixer left this unresolved._\n\n${unboxed(n.body)}` : n.unclear === true ? `_A fix turn removed this while renaming another finding — check whether it was fixed._\n\n${unboxed(n.body)}` : unboxed(n.body) || "_No detail given._"}\n\n${answerBoxes(n.answers)}`)),
+		...notes.map((n) => chunk(n.title, `${n.unresolved === true ? `_The fixer left this unresolved._\n\n${unboxed(n.body)}` : n.unclear === true ? `_A fix turn removed this while renaming another finding — check whether it was fixed._\n\n${unboxed(n.body)}` : unboxed(n.body) || "_No detail given._"}\n\n${answerBoxes}`)),
 		...report.fixed.length === 0 ? [] : [chunk("Fixed automatically", report.fixed.map((f) => `- ${f.title} (${short(f.commit)})`).join("\n"))],
 		...added.length === 0 ? [] : [chunk("Standards added", `Learned from your answers and kept in \`${STANDARDS}\`:\n\n${added.map((s) => `- ${s}`).join("\n")}`)],
 		...report.noise.length === 0 ? [] : [chunk("Dropped as noise", report.noise.map((f) => `- ${f.title} (p=${f.p})`).join("\n"))]
@@ -38233,24 +38228,6 @@ const flagShipped = (flow, name) => defineWorkflow(standardSchemaV1(FlagOptions,
 		base: void 0
 	};
 });
-const TestsOptions = Struct({
-	...ShippedOptions.fields,
-	testFiles: setting$1,
-	skipPattern: setting$1
-});
-const testsShipped = (flow) => defineWorkflow(standardSchemaV1(TestsOptions, {
-	onExcessProperty: "error",
-	errors: "all"
-}), ({ contextLimit, ...options }) => ({
-	flow: limited(flow, contextLimit),
-	defaults: over({
-		...defaults,
-		...testsDefaults
-	}, options),
-	envDefaults: over(envDefaults, options),
-	doors: { tests: {} },
-	base: void 0
-}));
 //#endregion
 //#region src/workflows/shared/lenses.ts
 const NO_FINDINGS = {
@@ -38259,7 +38236,7 @@ const NO_FINDINGS = {
 	noise: []
 };
 const UNTITLED = "Quality findings";
-const below$1 = (section) => section.split("\n").slice(1).join("\n").trim();
+const below = (section) => section.split("\n").slice(1).join("\n").trim();
 const strayProse = (text, sections) => sections.reduce((rest, body) => rest.replace(body, "\n"), text).split("\n").filter((line) => !/^#\s/.test(line)).join("\n").trim();
 /** The findings in `text`, one per `## ` section, in file order, numbered `Q<n>`. */
 const findingsOf = (text) => {
@@ -38270,7 +38247,7 @@ const findingsOf = (text) => {
 		body: stray
 	}], ...sections.map((s) => ({
 		title: s.title,
-		body: below$1(s.body)
+		body: below(s.body)
 	}))].map((f, i) => ({
 		id: `Q${i + 1}`,
 		...f
@@ -39048,7 +39025,7 @@ const composing = (base, report, carry, nitFix, answered = /* @__PURE__ */ new S
 * praise dropped.
 */
 const humanReview = (base, escalations = { rounds: 0 }, options = {}) => {
-	const { guard, guardRests, fixAccess, rules, awaitMessage } = options;
+	const { guard, guardRests, fixAccess, rules } = options;
 	const feedback = options.feedback ?? {
 		file: ".gtd/REQUIREMENTS.md",
 		collecting,
@@ -39073,7 +39050,7 @@ const humanReview = (base, escalations = { rounds: 0 }, options = {}) => {
 			guardRests,
 			rules
 		}),
-		awaitReview: (b) => awaitReview(b, awaitMessage?.(b)),
+		awaitReview,
 		reviewMissing,
 		collecting: feedback.collecting,
 		triage: triage$1(severities),
@@ -39133,17 +39110,6 @@ const callForm = (first, second, [third, fourth, ...extra]) => {
 	if (typeof second === "string") return legacyForm(first, second, third, fourth);
 	if (typeof first === "string") return currentForm(first, second, third, fourth);
 };
-/** Build the concerns a review round collected into `.gtd/REQUIREMENTS.md`, then remove it. */
-const fixFeedback = async () => {
-	await agentWithSkills("feedback.fixing", reviewFeedbackFixPrompt(), {
-		label: "Fixing your review feedback",
-		file: REQUIREMENTS,
-		model: coder(),
-		system: finisherSystem(),
-		allowEmpty: true
-	});
-	await run("feedback.closing", removeScript([REQUIREMENTS]), { label: "Closing the feedback" });
-};
 /**
 * Undo the human's review-round code edits. A path changed since the human
 * left it is not overwritten; requireRevert names it instead.
@@ -40157,8 +40123,6 @@ const skills = (vars) => {
 		design: ["spec-driven-development", "planning-and-task-breakdown"],
 		notes: ["incremental-implementation", "code-simplification"],
 		feedback: ["test-driven-development", "incremental-implementation"],
-		tests: ["test-audit", "test-driven-development"],
-		"tests.health": ["debugging-and-error-recovery"],
 		...build,
 		...Object.fromEntries(Object.entries(build).map(([name, list]) => [`refactor.${name}`, list])),
 		refactor: ["ponytail"],
@@ -40192,6 +40156,16 @@ const steering = {
 };
 //#endregion
 //#region src/workflows/review/review.ts
+const fixFeedback = async () => {
+	await agentWithSkills("feedback.fixing", reviewFeedbackFixPrompt(), {
+		label: "Fixing your review feedback",
+		file: REQUIREMENTS,
+		model: coder(),
+		system: finisherSystem(),
+		allowEmpty: true
+	});
+	await run("feedback.closing", removeScript([REQUIREMENTS]), { label: "Closing the feedback" });
+};
 /**
 * The feature's review of everything since `reviewBase` — a green gate, the
 * triaged quality lap, then the human review — with no design phase: a
@@ -40325,191 +40299,6 @@ const cleanupFlow = async () => {
 };
 const cleanup = flagShipped(cleanupFlow, "cleanup");
 //#endregion
-//#region src/workflows/tests/tests.ts
-const TESTS = ".gtd/TESTS.md";
-const RETIRE = ".gtd/RETIRE.md";
-/** The first two answer boxes of a deletion proposal; the third stays the human's own answer. */
-const RETIRE_ANSWERS = ["delete it", "keep it skipped"];
-testsDefaults.skipPattern;
-/** `skipPattern` as a per-line expression; refuses one that is blank, invalid, or matches every line. */
-const skipExpression = (pattern) => {
-	if (pattern.trim() === "") return refuse("gtd: skipPattern must not be blank");
-	let expression;
-	try {
-		expression = new RegExp(pattern);
-	} catch (error) {
-		return refuse(`gtd: skipPattern is not a valid regular expression: ${String(error)}`);
-	}
-	if (expression.test("")) return refuse("gtd: skipPattern must not match the empty string");
-	return expression;
-};
-/** Every line of `files` the expression calls skipped, in file then line order. */
-const skipsIn = (files, expression) => files.flatMap(({ path, text }) => text.split("\n").flatMap((line, i) => expression.test(line) ? [{
-	path,
-	line: i + 1,
-	text: line.trim()
-}] : []));
-const testPaths = () => {
-	const globs = (vars.testFiles ?? testsDefaults.testFiles).split(",").map((g) => g.trim()).filter((g) => g !== "");
-	return [...new Set(globs.flatMap((g) => glob(g)))].filter(isCode$1).sort();
-};
-const scan = (paths, expression) => skipsIn(paths.map((path) => ({
-	path,
-	text: read(path) ?? ""
-})), expression);
-/** A section title as a repository path: backticks and a leading `./` dropped. */
-const pathOf = (title) => title.replace(/`/g, "").trim().replace(/^\.\//, "");
-const below = (section) => section.split("\n").slice(1).join("\n").trim();
-const sweepingPrompt = (skips) => `Sweep this repository's tests for ones to revive.
-
-Skipped tests gtd found:
-
-${skips.length === 0 ? "- none" : skips.map((s) => `- ${s.path}:${s.line} — ${s.text}`).join("\n")}
-
-- Audit every test in the repository with the test-audit skill — the whole
-  suite, not a recent change
-- Write \`${TESTS}\`: \`# Tests\`, then one \`## <path>\` section per test file
-  that needs work — every file listed above, and each file the audit found
-  worth rewriting — saying which tests are skipped and what the audit found
-- Change nothing else; write nothing when there is nothing to do
-- Leave everything uncommitted and finish your turn`;
-const rewritingPrompt = (path, found) => `Rewrite the tests in \`${path}\` until none is skipped and the suite is green.
-
-What the sweep found:
-
-${found || "_Nothing more than the skipped tests._"}
-
-- Unskip every skipped test in the file and make it pass, rewriting it where
-  it rotted, and fix what the audit found
-- A test that is obsolete — what it tests is gone, or another test already
-  covers it — stays skipped: never delete it. Propose its deletion in
-  \`${RETIRE}\` instead: a \`## <title>\` section naming \`${path}\`, the test,
-  and why it should go. A person decides. Propose a line gtd misread as
-  skipped (fixture text, a comment) the same way, saying so
-- Delete no test file
-- Leave everything uncommitted and finish your turn`;
-const gateMessage = () => `The test baseline is red — gtd will not revive skipped tests on a broken suite.
-\`.gtd/FEEDBACK.md\` holds the failing output.
-
-What each change does next (then run \`gtd land\`):
-- **Retry check** — edit the code and/or \`.gtd/FEEDBACK.md\` to fix the failing tests (**tests-gate.check**).
-`;
-const awaitMessage = (base) => `\`.gtd/REVIEW.md\` holds one chunk per test the sweep would delete. Each ends in
-three boxes — tick exactly one: \`delete it\` (the test is deleted, then the
-suite runs), \`keep it skipped\` (dropped, recorded in the commit), or write your
-own answer over \`_your answer_\` and tick it (judged like a note). Every
-landing here is refused until each proposal holds exactly one tick. An agent
-turn that deleted a test file was refused; check the diff for tests removed
-inside a file.
-
-Review the revived tests yourself:
-
-    git diff ${base}
-
-Then run \`gtd land\`. A note or code edit of your own is read as feedback and
-built before you review again.
-`;
-/** A proposal's own text, made a request the nit fixer acts on once the human ticks `delete it`. */
-const proposals = (text) => sectionBodies(text).map((s, i) => ({
-	id: `R${i + 1}`,
-	title: s.title,
-	body: `Delete this skipped test.\n\n${below(s.body)}`,
-	answers: RETIRE_ANSWERS
-}));
-/** Sections of `text` that name `path` as a whole token — a trailing full stop still counts. */
-const naming = (text, path) => {
-	const token = new RegExp(`(?<![\\w./-])${path.replace(/[.*+?^${}()|[\]\\]/g, "\\$&")}(?![\\w/-])`);
-	return sectionBodies(text).filter((s) => token.test(s.body.replace(/(^|[^\w.])\.\//g, "$1"))).length;
-};
-/** Refuses a test file a turn deleted, and a skip left in the file being rewritten that `.gtd/RETIRE.md` does not name. */
-const guardFor = (known, expression, path) => () => {
-	const deleted = changes().filter((c) => c.status === "deleted" && known.has(c.path)).map((c) => c.path);
-	if (deleted.length > 0) refuse(`gtd land: tests: ${deleted.join(", ")} deleted — a test goes only once a person ticks "delete it" at the review`);
-	if (path === void 0) return;
-	const left = scan([path], expression).slice(naming(read(RETIRE) ?? "", path));
-	if (left.length > 0) refuse(`gtd land: tests: ${left.map((s) => `${s.path}:${s.line}`).join(", ")} still skipped — revive it, or propose its deletion in ${RETIRE}`);
-};
-/** The sweep's packages, refused when it changed more than its plan or the plan misses a file. */
-const planned = (skips, known) => {
-	const strays = changes().filter((c) => c.path !== TESTS);
-	if (strays.length > 0) refuse(`gtd land: tests: the sweep changed ${strays.map((c) => c.path).join(", ")} — it writes only ${TESTS}`);
-	const packages = sectionBodies(read(TESTS) ?? "").map((s) => ({
-		path: pathOf(s.title),
-		found: below(s.body)
-	}));
-	const missing = [...packages.filter((p) => !known.has(p.path)).map((p) => `"${p.path}" is no test file`), ...[...new Set(skips.map((s) => s.path))].filter((path) => !packages.some((p) => p.path === path)).map((path) => `${path} has no section`)];
-	if (missing.length > 0) refuse(`gtd land: tests: in ${TESTS}, ${missing.join("; ")}`);
-	return packages;
-};
-/**
-* Revive or retire skipped tests: a sweep plans one package per test file, each
-* is rewritten until unskipped and green, and what an agent calls obsolete
-* reaches the human review as a deletion proposal only a person can tick.
-*/
-const testsFlow = async () => {
-	refusePendingHandOff();
-	for (const file of [
-		REQUIREMENTS,
-		TESTS,
-		RETIRE
-	]) if (read(file) !== void 0) refuse(`gtd: ${file} is left over — finish or remove it first.`);
-	const expression = skipExpression(vars.skipPattern ?? testsDefaults.skipPattern);
-	await gate("tests-gate", gateMessage());
-	const base = start();
-	const known = new Set(testPaths());
-	const guard = guardFor(known, expression);
-	const report = await scope("tests", async () => {
-		const skips = scan([...known], expression);
-		await agentWithSkills("sweeping", sweepingPrompt(skips), {
-			label: "Sweeping the tests",
-			file: TESTS,
-			model: coder(),
-			system: finisherSystem(),
-			allowEmpty: true
-		});
-		guard();
-		const packages = planned(skips, known);
-		for (const { path, found } of packages) {
-			const guarded = guardFor(known, expression, path);
-			await agentWithSkills("rewriting", rewritingPrompt(path, found), {
-				label: `Rewriting ${path}`,
-				file: RETIRE,
-				model: coder(),
-				system: finisherSystem(),
-				allowEmpty: true
-			});
-			guarded();
-			if (!changes().some((c) => isCode$1(c.path))) continue;
-			await healthy(() => fixCheck(), {
-				guard: guarded,
-				guardRests: false
-			});
-		}
-		const retired = proposals(read(RETIRE) ?? "");
-		if (read(TESTS) !== void 0 || read(RETIRE) !== void 0) await run("closing", removeScript([TESTS, RETIRE]), { label: "Closing the sweep" });
-		const changed = changesSince(base).paths.some(isCode$1);
-		return retired.length === 0 && !changed ? void 0 : {
-			notes: retired,
-			fixed: [],
-			noise: []
-		};
-	});
-	if (report === void 0) return;
-	let outcome = await tail((escalations) => humanReview(base, escalations, {
-		report,
-		awaitMessage: report.notes.length > 0 ? awaitMessage : void 0
-	}), {
-		lenses: [],
-		green: true
-	});
-	while (outcome.verdict === "feedback") {
-		await reUnwind(outcome);
-		await fixFeedback();
-		outcome = await tail((escalations) => humanReview(base, escalations), { lenses: [] });
-	}
-};
-const tests = testsShipped(testsFlow);
-//#endregion
 //#region src/workflows/index.ts
 var workflows_default = feature;
 /**
@@ -40519,4 +40308,4 @@ var workflows_default = feature;
 */
 const doors = {};
 //#endregion
-export { COMMENT, ESCALATION, FEEDBACK, FIX_CAP, FlagOptions, HANDOFF, QUALITY, REFACTOR, REFACTOR_NOTE, REFACTOR_PACKAGE, REQUIREMENTS, REVIEW, REVIEW_ORIG, SLICES, ShippedOptions, TestsOptions, acceptanceFault, access, afterTail, agentWithSkills, answerProductQuestions, answerReviewQuestions, awaitReview, base, baseline, buildFeature, buildTail, builtInLenses, cleanup, cleanupFlow, closeOut, closeReview, coder, collecting, criteriaOf, criterionIds, workflows_default as default, defaults, describeEscalation, design, doors, envDefaults, escalate, escalation, escalationExhausted, feature, fix, fixCheck, fixFlow, fixNits, fixQuality, fixQualityFindings, fixReviewNotes, fixRisks, gate, guarded, handOffReview, handOffTail, healthy, holdsCallSites, implement, implementing, isTestFile, judgeSeam, lensEntriesOf, lensOf, lensesOf, naiveAcceptance, naivePass, ordinaryStart, planAndBuild, planner, qualityLap, reUnwind, recheck, refactorCollecting, refactorFirst, refactorNote, refactorStrays, requireAcceptance, requireAcceptanceKept, requireCriteria, requireCriteriaFrozen, requireCriteriaIfEdited, requireNoNewFlags, requireNoTestFiles, requireSlices, requireStableIds, requireTestCallSitesOnly, requireWithin, retryQuestion, review, reviewFlow, reviewMissing, reviewQuality, reviewedRefactor, reviewing, rollout, rolloutFlow, seamBuild, skills, skipDesign, sliceCap, sliceCriteria, sliceIds, slicesOf, slicing, statedCriteria, steering, summary, tail, tests, testsFlow, threads, triage, unstableIds, unwind };
+export { COMMENT, ESCALATION, FEEDBACK, FIX_CAP, FlagOptions, HANDOFF, QUALITY, REFACTOR, REFACTOR_NOTE, REFACTOR_PACKAGE, REQUIREMENTS, REVIEW, REVIEW_ORIG, SLICES, ShippedOptions, acceptanceFault, access, afterTail, agentWithSkills, answerProductQuestions, answerReviewQuestions, awaitReview, base, baseline, buildFeature, buildTail, builtInLenses, cleanup, cleanupFlow, closeOut, closeReview, coder, collecting, criteriaOf, criterionIds, workflows_default as default, defaults, describeEscalation, design, doors, envDefaults, escalate, escalation, escalationExhausted, feature, fix, fixCheck, fixFlow, fixNits, fixQuality, fixQualityFindings, fixReviewNotes, fixRisks, gate, guarded, handOffReview, handOffTail, healthy, holdsCallSites, implement, implementing, isTestFile, judgeSeam, lensEntriesOf, lensOf, lensesOf, naiveAcceptance, naivePass, ordinaryStart, planAndBuild, planner, qualityLap, reUnwind, recheck, refactorCollecting, refactorFirst, refactorNote, refactorStrays, requireAcceptance, requireAcceptanceKept, requireCriteria, requireCriteriaFrozen, requireCriteriaIfEdited, requireNoNewFlags, requireNoTestFiles, requireSlices, requireStableIds, requireTestCallSitesOnly, requireWithin, retryQuestion, review, reviewFlow, reviewMissing, reviewQuality, reviewedRefactor, reviewing, rollout, rolloutFlow, seamBuild, skills, skipDesign, sliceCap, sliceCriteria, sliceIds, slicesOf, slicing, statedCriteria, steering, summary, tail, threads, triage, unstableIds, unwind };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pmelab/gtd",
-  "version": "45.2.0",
+  "version": "46.0.0",
   "private": false,
   "description": "Git-aware CLI that emits the next prompt for an autonomous coding agent based on the current repository state",
   "bin": {
@@ -62,11 +62,6 @@
       "source": "./src/workflows/cleanup/index.ts",
       "default": "./dist/workflows/cleanup.mjs"
     },
-    "./workflows/tests": {
-      "types": "./src/workflows/tests/index.ts",
-      "source": "./src/workflows/tests/index.ts",
-      "default": "./dist/workflows/tests.mjs"
-    },
     "./testkit": {
       "types": "./src/testkit/index.ts",
       "source": "./src/testkit/index.ts",

package/src/install/ConfigScaffold.ts

@@ -6,8 +6,7 @@ export const CONFIG_SCAFFOLD = `// The workflows gtd runs here: gtd's shipped fe
 // its own doors: \`gtd door review [base]\` and \`gtd door fix\`. Export \`rollout\`
 // from \`@pmelab/gtd/workflows/rollout\` and \`cleanup\` from
 // \`@pmelab/gtd/workflows/cleanup\` to add \`gtd door rollout <flag>\` and
-// \`gtd door cleanup <flag>\`, and \`tests\` from \`@pmelab/gtd/workflows/tests\`
-// to add \`gtd door tests\`.
+// \`gtd door cleanup <flag>\`.
 export {
   feature as default,
   feature,

package/src/install/Install.ts

@@ -516,11 +516,10 @@ rather than starting the review; \`gtd-door fix\` on a GREEN suite is a no-op
 straight back to \`idle\` — the exec'd \`gtd-build\` exits immediately on it.
 \`gtd doors\` lists the doors a repository offers (those of the workflows its
 config exports — the bundled \`fix\` and \`review [base]\`, plus the opt-in
-\`rollout <flag>\` (turn a release flag default-on), \`cleanup <flag>\`
-(remove it) and \`tests\` (revive skipped tests), which a config adds by
-exporting \`rollout\` from \`@pmelab/gtd/workflows/rollout\`, \`cleanup\` from
-\`@pmelab/gtd/workflows/cleanup\` and \`tests\` from
-\`@pmelab/gtd/workflows/tests\` — plus any it declares). Refuses with
+\`rollout <flag>\` (turn a release flag default-on) and \`cleanup <flag>\`
+(remove it), which a config adds by exporting \`rollout\` from
+\`@pmelab/gtd/workflows/rollout\` and \`cleanup\` from
+\`@pmelab/gtd/workflows/cleanup\` — plus any it declares). Refuses with
 \`usage: gtd-door <name> [args...]\` on stderr and exit \`2\` when the name is
 missing — nothing was even attempted. Default path: \`~/.local/bin/gtd-door\`.
 

package/src/workflows/index.ts

@@ -5,7 +5,7 @@ import { feature } from "./feature/feature.js"
 
 export { threads, type ThreadInfo } from "../flows/index.js"
 export * from "./shared/reserved.js"
-export { FlagOptions, ShippedOptions, TestsOptions } from "./shared/options.js"
+export { FlagOptions, ShippedOptions } from "./shared/options.js"
 export { agentWithSkills, type ReviewRange } from "./shared/text.js"
 export * from "./shared/steps.js"
 export * from "./shared/health.js"
@@ -38,7 +38,6 @@ export { base, review, reviewFlow } from "./review/review.js"
 export { fix, fixFlow, fixReviewNotes } from "./fix/fix.js"
 export { rollout, rolloutFlow } from "./rollout/rollout.js"
 export { cleanup, cleanupFlow } from "./cleanup/cleanup.js"
-export { tests, testsFlow } from "./tests/tests.js"
 
 export default feature
 

package/src/workflows/review/review.ts

@@ -1,11 +1,23 @@
-import { read, refuse, start, type WorkflowBase } from "../../flows/index.js"
-import { buildTail, fixFeedback, reUnwind } from "../shared/review.js"
+import { read, refuse, removeScript, run, start, type WorkflowBase } from "../../flows/index.js"
+import { buildTail, reUnwind } from "../shared/review.js"
 import { gate } from "../shared/health.js"
 import { shipped } from "../shared/options.js"
-import { REQUIREMENTS } from "../shared/steps.js"
+import { coder, REQUIREMENTS } from "../shared/steps.js"
 import { refusePendingHandOff } from "../shared/tail.js"
 import * as t from "../shared/text.js"
 
+const fixFeedback = async (): Promise<void> => {
+  await t.agentWithSkills("feedback.fixing", t.reviewFeedbackFixPrompt(), {
+    label: "Fixing your review feedback",
+    file: REQUIREMENTS,
+    model: coder(),
+    system: t.finisherSystem(),
+    // An earlier nit fix may already have built the concern.
+    allowEmpty: true,
+  })
+  await run("feedback.closing", removeScript([REQUIREMENTS]), { label: "Closing the feedback" })
+}
+
 /**
  * The feature's review of everything since `reviewBase` — a green gate, the
  * triaged quality lap, then the human review — with no design phase: a

package/src/workflows/shared/lenses.ts

@@ -29,11 +29,7 @@ type FindingKind = "mechanical" | "noise" | "design"
 /** What the triaged quality lap did with its findings, for the review to list. */
 export interface LensReport {
   /** Design findings, then the mechanical ones the fix cap left. */
-  readonly notes: readonly (Finding & {
-    readonly unresolved?: true
-    readonly unclear?: true
-    readonly answers?: readonly [string, string]
-  })[]
+  readonly notes: readonly (Finding & { readonly unresolved?: true; readonly unclear?: true })[]
   readonly fixed: readonly (Finding & { readonly commit: string })[]
   readonly noise: readonly (Finding & { readonly p: number })[]
 }

package/src/workflows/shared/options.ts

@@ -9,7 +9,7 @@ import {
   scope,
   vars,
 } from "../../flows/index.js"
-import { defaultFlagRegistry, defaults, envDefaults, testsDefaults } from "./vars.js"
+import { defaultFlagRegistry, defaults, envDefaults } from "./vars.js"
 
 const setting = Schema.optionalWith(Schema.String, { exact: true })
 
@@ -107,23 +107,3 @@ export const flagShipped = (
       }
     },
   )
-
-export const TestsOptions = Schema.Struct({
-  ...ShippedOptions.fields,
-  testFiles: setting,
-  skipPattern: setting,
-})
-
-export type TestsOptions = Schema.Schema.Encoded<typeof TestsOptions>
-
-export const testsShipped = (flow: Flow): WorkflowFactory<TestsOptions> =>
-  defineWorkflow(
-    Schema.standardSchemaV1(TestsOptions, { onExcessProperty: "error", errors: "all" }),
-    ({ contextLimit, ...options }) => ({
-      flow: limited(flow, contextLimit),
-      defaults: over({ ...defaults, ...testsDefaults }, options),
-      envDefaults: over(envDefaults, options),
-      doors: { tests: {} },
-      base: undefined,
-    }),
-  )

package/src/workflows/shared/review.ts

@@ -5,7 +5,6 @@ import {
   judge,
   numeric,
   read,
-  removeScript,
   requireRevert,
   restoreScript,
   run,
@@ -23,7 +22,6 @@ import { NO_FINDINGS, type LensReport } from "./lenses.js"
 import {
   answerReviewQuestions,
   awaitReview,
-  coder,
   collecting,
   fixCheck,
   fixNits,
@@ -220,7 +218,7 @@ export const humanReview = (
   escalations: EscalationCount = { rounds: 0 },
   options: Omit<BuildTailOptions, "fixFirst" | "green"> = {},
 ): Promise<kit.ReviewOutcome> => {
-  const { guard, guardRests, fixAccess, rules, awaitMessage } = options
+  const { guard, guardRests, fixAccess, rules } = options
   const feedback: FeedbackTarget = options.feedback ?? {
     file: REQUIREMENTS,
     collecting,
@@ -243,7 +241,7 @@ export const humanReview = (
     },
     fixRisks: guarded((notes) => fixRisks(notes, fixAccess, rules), guard),
     keepGreen: () => healthy(() => fixCheck(rules), { escalations, guard, guardRests, rules }),
-    awaitReview: (b) => awaitReview(b, awaitMessage?.(b)),
+    awaitReview,
     reviewMissing,
     collecting: feedback.collecting,
     triage: triage(severities),
@@ -305,8 +303,6 @@ export interface BuildTailOptions extends TailOptions {
   readonly lap?: t.ReviewRange | undefined
   /** What the triaged quality lap left for the review; absent: nothing. */
   readonly report?: LensReport | undefined
-  /** The review gate's message for the review base; absent: the quality lap's. */
-  readonly awaitMessage?: ((base: string) => string) | undefined
 }
 
 /** The build tail: fix (when entered red), keep green unless `green`, the triaged quality lap, then human review since `base`. */
@@ -372,19 +368,6 @@ const callForm = (
   return undefined
 }
 
-/** Build the concerns a review round collected into `.gtd/REQUIREMENTS.md`, then remove it. */
-export const fixFeedback = async (): Promise<void> => {
-  await t.agentWithSkills("feedback.fixing", t.reviewFeedbackFixPrompt(), {
-    label: "Fixing your review feedback",
-    file: REQUIREMENTS,
-    model: coder(),
-    system: t.finisherSystem(),
-    // An earlier nit fix may already have built the concern.
-    allowEmpty: true,
-  })
-  await run("feedback.closing", removeScript([REQUIREMENTS]), { label: "Closing the feedback" })
-}
-
 /**
  * Undo the human's review-round code edits. A path changed since the human
  * left it is not overwritten; requireRevert names it instead.

package/src/workflows/shared/skills.test.ts

@@ -22,8 +22,6 @@ describe("the bundled workflow's skills export", () => {
         "build.review.fix.risks",
         "notes",
         "feedback",
-        "tests",
-        "tests.health",
         "refactor",
         "refactor.fix.suite",
         "refactor.health",

package/src/workflows/shared/skills.ts

@@ -24,9 +24,6 @@ export const skills = (
     notes: ["incremental-implementation", "code-simplification"],
     // `review`'s turn building what a review round collected.
     feedback: ["test-driven-development", "incremental-implementation"],
-    // The `tests` workflow's sweep and rewrites.
-    tests: ["test-audit", "test-driven-development"],
-    "tests.health": ["debugging-and-error-recovery"],
     // The refactor's own turns load `ponytail`; `refactor.build.*` carry the `build.*` lists.
     ...build,
     ...Object.fromEntries(Object.entries(build).map(([name, list]) => [`refactor.${name}`, list])),

package/src/workflows/shared/text.ts

@@ -124,8 +124,6 @@ export interface ComposedReview {
     readonly unresolved?: true
     /** A fix turn removed its chunk while renaming another. */
     readonly unclear?: true
-    /** Labels for the first two boxes; absent: fix as suggested, won't fix. Read by position, so only the wording changes. */
-    readonly answers?: readonly [string, string]
   }[]
   readonly fixed: readonly { readonly title: string; readonly commit: string }[]
   readonly noise: readonly { readonly title: string; readonly p: number }[]
@@ -172,8 +170,7 @@ export const composedReview = (base: string, report: ComposedReview): string =>
   }
   const chunk = (title: string, body: string): string => `## ${title}\n\n${body.trim()}`
   // The lead-in line keeps a body that ends in a list from absorbing the boxes.
-  const answerBoxes = ([fix, wontFix]: readonly [string, string] = [ANSWER_FIX, ANSWER_WONT_FIX]) =>
-    `${ANSWER_LEAD}\n\n- [ ] ${fix}\n- [ ] ${wontFix}\n- [ ] ${FREE_TEXT_PLACEHOLDER}`
+  const answerBoxes = `${ANSWER_LEAD}\n\n- [ ] ${ANSWER_FIX}\n- [ ] ${ANSWER_WONT_FIX}\n- [ ] ${FREE_TEXT_PLACEHOLDER}`
   const conflicts = (report.standards?.undecided ?? []).map((c) =>
     chunk(unique(conflictTitle(c)), conflictBody(c)),
   )
@@ -211,7 +208,7 @@ export const composedReview = (base: string, report: ComposedReview): string =>
             : n.unclear === true
               ? `_A fix turn removed this while renaming another finding — check whether it was fixed._\n\n${unboxed(n.body)}`
               : unboxed(n.body) || "_No detail given._"
-        }\n\n${answerBoxes(n.answers)}`,
+        }\n\n${answerBoxes}`,
       ),
     ),
     ...(report.fixed.length === 0

package/src/workflows/shared/vars.ts

@@ -16,14 +16,6 @@ export const testFileGlobs: readonly string[] = [
 
 export const defaultFlagRegistry = "src/flags/index.ts"
 
-/** The `tests` workflow's own process settings: where it looks for skipped tests, and how a skip reads. */
-export const testsDefaults: Readonly<Record<string, string>> = {
-  testFiles: testFileGlobs.join(", "),
-  // JS/TS runners' `.skip`/`.todo` and `x`-prefixed blocks, and cucumber's skip tags.
-  skipPattern:
-    "^\\s*(?:(?:describe|context|suite|it|test|specify)\\.(?:skip|todo)\\b|x(?:describe|context|it|test|specify)\\s*\\(|(?:@\\S+\\s+)*@(?:skip|ignore)(?:\\s|$))",
-}
-
 /** Process settings. */
 export const defaults: Readonly<Record<string, string>> = {
   reviewBase: "",