@pmelab/gtd 43.0.0 → 45.0.0

package/dist/chunks/review-BmoH-9im.mjs

@@ -0,0 +1,408 @@
+import { answered, changesSince, head, judge, numeric, read, requireRevert, restoreScript, run, showScript, vars, writeScript } from "../flows.mjs";
+import { removedAssertions, review } from "../workflow-kit.mjs";
+import { A as reviewMissing, At as conflictTitle, Dt as STANDARDS, E as fixNits, F as buildReviewTriageMessage, Ft as standardKey, Mt as oneLine, Nt as parseStandards, O as fixRisks, Ot as conflictBody, Pt as renderStandards, S as awaitReview, T as fixCheck, d as guarded, dt as reviewEditNotesCapture, f as healthy, ft as reviewEditsCapture, h as QUALITY, ht as reviewNotesCapture, jt as isConflictTitle, kt as conflictFor, w as collecting, x as answerReviewQuestions, y as REVIEW, z as composedReview } from "./reserved-ty1mtlnS.mjs";
+import { i as isOptionalObject, n as closeReview, o as tail, s as NO_FINDINGS } from "./tail-CM3sVoAb.mjs";
+//#region src/workflows/shared/learn.ts
+const SUMMARY_MAX = 200;
+const BANNER = /^_(?:The fixer left this unresolved\.|A fix turn removed this while renaming another finding — check whether it was fixed\.|No detail given\.)_\s*/;
+const summary = (body) => {
+	const text = oneLine(body).replace(BANNER, "");
+	return text.length > SUMMARY_MAX ? `${text.slice(0, SUMMARY_MAX - 1)}…` : text;
+};
+/** The standard a won't-fix or an own answer would make; a fix states none. */
+const candidateOf = (d) => {
+	const anchor = oneLine(d.anchor);
+	if (d.choice === "wontfix") {
+		const why = summary(d.body);
+		return [{
+			decision: d,
+			text: `Won't fix: ${anchor}${why === "" ? "" : ` — ${why}`}`
+		}];
+	}
+	if (d.choice === "answer") return [{
+		decision: d,
+		text: `${oneLine(d.text)} (re: ${anchor})`
+	}];
+	return [];
+};
+const without = (list, drop) => {
+	const keys = new Set(drop.map(standardKey));
+	return list.filter((s) => !keys.has(standardKey(s)));
+};
+const adding = (list, text) => list.some((s) => standardKey(s) === standardKey(text)) ? [...list] : [...list, text];
+/**
+* Keep the new one, keep the old one, or replace both with the human's own
+* wording. Another open conflict stops naming a replaced standard: the human
+* never judged it against the replacement, so keeping it must not drop that.
+*/
+const resolve = (standards, d) => {
+	const c = conflictFor(standards, d.anchor);
+	if (c === void 0) return standards;
+	const others = standards.undecided.filter((u) => u !== c);
+	if (d.choice === "wontfix") return {
+		decided: standards.decided,
+		undecided: others
+	};
+	const kept = d.choice === "fix" ? c.text : oneLine(d.text);
+	const undecided = others.map((u) => ({
+		text: u.text,
+		olds: without(u.olds, c.olds)
+	}));
+	return {
+		decided: adding(without(standards.decided, c.olds), kept),
+		undecided
+	};
+};
+const contradicts = (i, id, other) => ({
+	id: `standard-${i}.contradicts-${id}`,
+	primitive: "noul",
+	instructions: `Does the "Standard:" line of evidence "standard-${i}" contradict ${other}?`,
+	criteria: "yes: following one breaks the other. no: both can be followed — they are compatible or unrelated."
+});
+const questionsFor = (i, anchor, decided) => [
+	{
+		id: `standard-${i}`,
+		primitive: "noul",
+		instructions: `Is the human's answer to review note "${anchor}" (evidence "standard-${i}") a reusable standard for this codebase — a rule later changes and reviews should follow — rather than a call about this one note? Its "Standard:" line is the wording gtd would keep.`,
+		criteria: "yes: it states a rule or preference that applies beyond this note. no: it is specific to this note, a one-off call, or unclear."
+	},
+	...decided.map((_, k) => contradicts(i, `${k + 1}`, `kept standard ${k + 1} (evidence "kept-${k + 1}")`)),
+	...Array.from({ length: i - 1 }, (_, j) => contradicts(i, `new-${j + 1}`, `the "Standard:" line of evidence "standard-${j + 1}"`))
+];
+const evidenceOf = (c) => [
+	`Note: ${c.decision.anchor}`,
+	`Reviewer's text: ${c.decision.body}`,
+	`Human's answer: ${c.decision.choice === "wontfix" ? "won't fix" : c.decision.text}`,
+	`Standard: ${c.text}`
+].join("\n");
+/**
+* One judge rest over every candidate. Only a confident `yes` on uncut
+* evidence makes a standard; a contradiction the judge does not confidently
+* rule out goes to the human instead of overwriting what they decided before.
+* A cut kept standard leaves the round unlearned: raise `judgeBudgetBytes`.
+*/
+const judged = async (candidates, decided, minP) => {
+	const { answers, truncated } = await judge("review.standards.judge", {
+		questions: candidates.flatMap((c, i) => questionsFor(i + 1, c.decision.anchor, decided)),
+		evidence: Object.fromEntries([...candidates.map((c, i) => [`standard-${i + 1}`, evidenceOf(c)]), ...decided.map((s, k) => [`kept-${k + 1}`, s])]),
+		message: "Judging whether your answers are standards to keep: run `gtd judge run`, or land without a verdict, which keeps none.",
+		label: "Learning your standards"
+	});
+	const ruledOut = (i, id) => answered(answers[`standard-${i}.contradicts-${id}`], "no", minP);
+	const added = [];
+	const raised = [];
+	candidates.forEach((c, n) => {
+		const i = n + 1;
+		if (truncated.includes(`standard-${i}`)) return;
+		if (decided.some((_, k) => truncated.includes(`kept-${k + 1}`))) return;
+		if (!answered(answers[`standard-${i}`], "yes", minP)) return;
+		const olds = [...decided.filter((_, k) => !ruledOut(i, `${k + 1}`)), ...added.filter((a) => !ruledOut(i, `new-${a.i}`)).map((a) => a.text)];
+		if (olds.length === 0) added.push({
+			i,
+			text: c.text
+		});
+		else raised.push({
+			text: c.text,
+			olds
+		});
+	});
+	return {
+		added: added.map((a) => a.text),
+		raised
+	};
+};
+/**
+* Settles every answer to a standard conflict, then learns standards from
+* the won't-fix ticks and own answers: kept in `.gtd/STANDARDS.md`, a
+* contradicting one as a new conflict note in `.gtd/REVIEW.md`.
+*/
+const learnStandards = async (decisions) => {
+	const before = parseStandards(read(".gtd/STANDARDS.md") ?? "");
+	const rest = decisions.filter((d) => !isConflictTitle(d.anchor));
+	const settled = decisions.filter((d) => isConflictTitle(d.anchor)).reduce(resolve, before);
+	const known = new Set([...settled.decided, ...settled.undecided.map((c) => c.text)].map(standardKey));
+	const candidates = rest.flatMap(candidateOf).filter((c) => {
+		const key = standardKey(c.text);
+		if (known.has(key)) return false;
+		known.add(key);
+		return true;
+	});
+	const minP = numeric(vars.standardMinP, Infinity);
+	const { added, raised } = candidates.length === 0 || !Number.isFinite(minP) ? {
+		added: [],
+		raised: []
+	} : await judged(candidates, settled.decided, minP);
+	const after = {
+		decided: [...settled.decided, ...added],
+		undecided: [...settled.undecided, ...raised]
+	};
+	if (renderStandards(after) !== renderStandards(before)) await run("review.standards.recording", writeScript(STANDARDS, renderStandards(after)), { label: "Recording your standards" });
+	if (raised.length > 0) {
+		const chunks = raised.map((c) => `## ${conflictTitle(c)}\n\n${conflictBody(c)}`);
+		await run("review.standards.raising", writeScript(REVIEW, `${(read(".gtd/REVIEW.md") ?? "").trimEnd()}\n\n${chunks.join("\n\n")}\n`), {
+			label: "Asking about a contradicting standard",
+			file: REVIEW
+		});
+	}
+};
+const settlesStandard = (d) => isConflictTitle(d.anchor);
+const standardsPending = () => parseStandards(read(".gtd/STANDARDS.md") ?? "").undecided.length > 0;
+const standardsAddedSince = (base) => {
+	const change = changesSince(base).get(STANDARDS);
+	if (change === void 0) return [];
+	const was = new Set(parseStandards(change.before ?? "").decided);
+	return parseStandards(change.after ?? "").decided.filter((s) => !was.has(s));
+};
+//#endregion
+//#region src/workflows/shared/review.ts
+const VERDICTS = [
+	"edit",
+	"question",
+	"nit",
+	"praise"
+];
+/** One four-way choice per note the human added to `.gtd/REVIEW.md`. */
+const verdictQuestion = (note) => ({
+	id: note.id,
+	primitive: "choice",
+	instructions: `Classify the human's note on review item "${note.anchor}" (in .gtd/REVIEW.md). Its evidence holds the anchor, the reviewer's text and the human's text.`,
+	criteria: "edit: a request to change behaviour, design or scope — anything needing a plan, or any note you are unsure about. question: asks something and wants an answer, with no change requested. nit: a small, local, unambiguous fix (naming, typo, formatting, comment wording) needing no re-plan. praise: an approving remark with nothing to do."
+});
+const TIER_ORDER = {
+	critical: 0,
+	should: 1,
+	could: 2
+};
+/** Capture order: critical, should, could; within a tier one-way doors, then new concepts. */
+const captureKey = (s) => s === void 0 ? 2 : TIER_ORDER[s.tier] * 3 + s.rank;
+const SEVERITY_ANSWERS = {
+	security: ["yes", "no"],
+	reversibility: ["one-way", "two-way"],
+	blastRadius: [
+		"local",
+		"module",
+		"contract"
+	],
+	newConcept: ["yes", "no"]
+};
+/** Anything unanswered, unrecognised, cut or below `minP` is `critical`, never `could`. */
+const severityOf = (note, judgment, minP) => {
+	const ans = (q) => judgment.answers[`${note.id}.${q}`];
+	const a = (q) => ans(q)?.answer;
+	const rank = () => a("reversibility") === "one-way" ? 0 : a("newConcept") === "yes" ? 1 : 2;
+	if (note.forced) return {
+		tier: "critical",
+		reason: "critical: forced by `!`",
+		rank: 2
+	};
+	if (judgment.truncated.includes(note.id) || Object.entries(SEVERITY_ANSWERS).some(([q, allowed]) => !allowed.includes(a(q) ?? "") || !((ans(q)?.p ?? NaN) >= minP))) return {
+		tier: "critical",
+		reason: "critical: judge unsure",
+		rank: 2
+	};
+	const critical = [...a("security") === "yes" ? ["security"] : [], ...a("reversibility") === "one-way" ? ["one-way door"] : []];
+	if (critical.length > 0) return {
+		tier: "critical",
+		reason: `critical: ${critical.join(", ")}`,
+		rank: rank()
+	};
+	const should = [...a("blastRadius") === "contract" ? ["contract"] : [], ...a("newConcept") === "yes" ? ["new concept"] : []];
+	if (should.length > 0) return {
+		tier: "should",
+		reason: `should: ${should.join(", ")}`,
+		rank: rank()
+	};
+	return {
+		tier: "could",
+		reason: "could",
+		rank: 2
+	};
+};
+const severityQuestions = (note) => [
+	{
+		id: `${note.id}.security`,
+		primitive: "noul",
+		instructions: `Does the change the human asks for in note "${note.id}" (on "${note.anchor}") touch security — authentication, authorisation, secrets, untrusted input or data exposure?`,
+		criteria: "yes: it changes or could weaken a security property. no: it does not."
+	},
+	{
+		id: `${note.id}.reversibility`,
+		primitive: "choice",
+		instructions: `Once the change in note "${note.id}" ships, can it be undone without breaking anyone who already depends on it?`,
+		criteria: "one-way: a published API, file format, persisted data, protocol or other contract that cannot be taken back. two-way: can be reverted freely."
+	},
+	{
+		id: `${note.id}.blastRadius`,
+		primitive: "choice",
+		instructions: `How far does the change in note "${note.id}" reach?`,
+		criteria: "local: one function or file. module: a whole module or several files. contract: a public interface other code or users depend on."
+	},
+	{
+		id: `${note.id}.newConcept`,
+		primitive: "noul",
+		instructions: `Does the change in note "${note.id}" introduce a concept new to this codebase — a new abstraction, entity or term? Judge from the evidence, never a glossary; reusing or extending an existing concept is not new.`,
+		criteria: "yes: a genuinely new concept. no: reuses or extends an existing one."
+	}
+];
+/**
+* One judge rest: a verdict per unforced note (a forced note is asked
+* nothing) plus four severity answers. Dismissing a note is the risky
+* direction, so only a confident non-`edit` verdict on uncut evidence counts;
+* a cut, unanswered or below-floor note is an `edit`. Severity answers on a
+* non-`edit` note are ignored; on an `edit` they order the collecting turn.
+*/
+const triage = (severities) => async (notes) => {
+	const asked = notes.filter((n) => !n.forced);
+	const judgment = asked.length === 0 ? {
+		answers: {},
+		truncated: []
+	} : await judge("review.triage", {
+		questions: asked.flatMap((n) => [verdictQuestion(n), ...severityQuestions(n)]),
+		evidence: Object.fromEntries(asked.map((n) => [n.id, `Anchor: ${n.anchor}\nReviewer's text: ${n.before}\nHuman's text: ${n.text}`])),
+		message: buildReviewTriageMessage(),
+		label: "Judging each note"
+	});
+	const { answers, truncated } = judgment;
+	const minP = numeric(vars.reviewNoteActionable, Infinity);
+	const severityMinP = numeric(vars.reviewSeverityMinP, Infinity);
+	severities.clear();
+	return new Map(notes.map((n) => {
+		const verdict = n.forced ? void 0 : VERDICTS.find((v) => v !== "edit" && answered(answers[n.id], v, minP));
+		if (verdict !== void 0 && !truncated.includes(n.id)) return [n.id, verdict];
+		severities.set(n.id, severityOf(n, judgment, severityMinP));
+		return [n.id, "edit"];
+	}));
+};
+const isCode = (path) => path !== ".gtd" && !path.startsWith(".gtd/");
+/**
+* gtd writes `.gtd/REVIEW.md` from the quality lap's `report` — no reviewer
+* turn — and removes what the fixer left in `.gtd/QUALITY.md`. A re-review
+* after fixed nits restores the doc as committed at `carry`, answers kept;
+* a fresh one leaves out the notes the human already answered.
+*/
+const composing = (base, report, carry, nitFix, answered = /* @__PURE__ */ new Set()) => run("review.composing", carry === void 0 ? writeScript(REVIEW, composedReview(base, {
+	...report,
+	weakened: removedAssertions(changesSince(base)),
+	nitFix,
+	answered,
+	standards: {
+		added: standardsAddedSince(base),
+		undecided: parseStandards(read(".gtd/STANDARDS.md") ?? "").undecided
+	}
+}), [QUALITY]) : showScript(carry, REVIEW, REVIEW), {
+	label: "Composing the review",
+	file: REVIEW,
+	base
+});
+/**
+* The quality lap's notes reach a human over everything since `base`, who
+* answers each one — fix as suggested, won't fix, or their own answer — and
+* may comment. A fix joins the nit batch, a won't-fix is dropped, and an own
+* answer or comment is judged: edits end the review as `feedback` for the
+* caller to build, questions are answered in place, nits fixed in one batch,
+* praise dropped.
+*/
+const humanReview = (base, escalations = { rounds: 0 }, options = {}) => {
+	const { guard, guardRests, fixAccess, rules } = options;
+	const feedback = options.feedback ?? {
+		file: ".gtd/REQUIREMENTS.md",
+		collecting,
+		unmatched: "gtd land: no declared pattern matches the pending changes — write .gtd/REQUIREMENTS.md from the feedback, or change nothing when it asks for nothing"
+	};
+	const severities = /* @__PURE__ */ new Map();
+	let nitFix;
+	const answered = /* @__PURE__ */ new Set();
+	return review(base, {
+		file: REVIEW,
+		feedback: feedback.file,
+		isCode,
+		reviewing: (b, carry) => {
+			const fixedAt = nitFix;
+			nitFix = void 0;
+			return composing(b, options.report ?? NO_FINDINGS, carry, fixedAt, answered);
+		},
+		fixRisks: guarded((notes) => fixRisks(notes, fixAccess, rules), guard),
+		keepGreen: () => healthy(() => fixCheck(rules), {
+			escalations,
+			guard,
+			guardRests,
+			rules
+		}),
+		awaitReview: (b) => awaitReview(b),
+		reviewMissing,
+		collecting: feedback.collecting,
+		triage: triage(severities),
+		decided: (decisions) => decisions.forEach((d) => answered.add(d.anchor)),
+		settles: settlesStandard,
+		learn: learnStandards,
+		pending: standardsPending,
+		answerQuestions: answerReviewQuestions,
+		fixNits: async (notes) => {
+			await guarded((n) => fixNits(n, fixAccess, rules), guard)(notes);
+			nitFix = head();
+		},
+		close: closeReview,
+		captures: {
+			edits: reviewEditsCapture,
+			notes: reviewNotesCapture,
+			editNotes: (round, edits, answeredAt) => reviewEditNotesCapture(round, edits.map((n, i) => ({
+				n,
+				i,
+				s: severities.get(n.id),
+				key: captureKey(severities.get(n.id))
+			})).sort((x, y) => x.key - y.key || x.i - y.i).map(({ n, s }) => ({
+				id: n.id,
+				anchor: n.anchor,
+				text: n.forced ? n.text.replace(/^!\s*/, "") : n.text,
+				...s === void 0 ? {} : { label: s.reason }
+			})), answeredAt)
+		},
+		refusals: {
+			deleted: "gtd land: review-doc: .gtd/REVIEW.md was deleted — restore it, or leave a note (or edit code) to request changes.",
+			unmatched: feedback.unmatched,
+			...feedback.dropped === void 0 ? {} : { dropped: feedback.dropped }
+		}
+	});
+};
+function buildTail(first, second, ...rest) {
+	const options = callForm(first, second, rest);
+	if (options === void 0) return Promise.reject(/* @__PURE__ */ new Error("buildTail takes buildTail(base, options?) or the deprecated buildTail(fixFirst, base, green?, options?); this call fits neither"));
+	const [base, form] = options;
+	return tail((escalations, report) => humanReview(base, escalations, {
+		...form,
+		report
+	}), {
+		...form,
+		triage: true
+	});
+}
+const isOptionalBoolean = (value) => value == null || typeof value === "boolean";
+const legacyForm = (fixFirst, base, green, options) => isOptionalBoolean(fixFirst) && isOptionalBoolean(green) && isOptionalObject(options) ? [base, {
+	...options,
+	fixFirst: fixFirst ?? void 0,
+	green: green ?? void 0
+}] : void 0;
+const currentForm = (base, options, third, fourth) => isOptionalObject(options) && third == null && fourth == null ? [base, options ?? {}] : void 0;
+const callForm = (first, second, [third, fourth, ...extra]) => {
+	if (extra.some((value) => value != null)) return void 0;
+	if (typeof second === "string") return legacyForm(first, second, third, fourth);
+	if (typeof first === "string") return currentForm(first, second, third, fourth);
+};
+/**
+* Undo the human's review-round code edits. A path changed since the human
+* left it is not overwritten; requireRevert names it instead.
+*/
+const reUnwind = async (feedback) => {
+	const { base, restoreFrom, edited } = feedback;
+	await run("re-unwind", restoreScript(base, {
+		restore: edited.filter((c) => c.status !== "added").map((c) => c.path),
+		remove: edited.filter((c) => c.status === "added").map((c) => c.path)
+	}, restoreFrom), {
+		label: "Re-unwinding your review edit",
+		file: REVIEW,
+		base
+	});
+	requireRevert(edited, base);
+};
+//#endregion
+export { reUnwind as i, humanReview as n, isCode as r, buildTail as t };

package/dist/chunks/{tail-C_xn8U7U.mjs → tail-CM3sVoAb.mjs}

@@ -1,6 +1,6 @@
 import { answered, head, judge, mark, numeric, read, refuse, removeScript, run, scope, sectionBodies, showScript, vars, writeScript } from "../flows.mjs";
 import { fixFindings, lensEntriesOf, lensOf, qualityLap as qualityLap$1, reviewToHandOff } from "../workflow-kit.mjs";
-import { C as fixCheck, D as reviewMissing, J as handOffAwaitReviewMessage, O as reviewQuality, T as fixRisks, d as guarded, f as healthy, h as QUALITY, k as reviewing, l as escalation, nt as qualityFindingsFile, rt as qualityTriageMessage, w as fixQuality, x as awaitReview, y as REVIEW } from "./reserved-COEMFEpy.mjs";
+import { A as reviewMissing, D as fixQuality, M as reviewing, O as fixRisks, S as awaitReview, T as fixCheck, Y as handOffAwaitReviewMessage, d as guarded, f as healthy, h as QUALITY, it as qualityTriageMessage, j as reviewQuality, l as escalation, rt as qualityFindingsFile, y as REVIEW } from "./reserved-ty1mtlnS.mjs";
 //#region src/workflows/shared/lenses.ts
 const NO_FINDINGS = {
 	notes: [],
@@ -217,7 +217,7 @@ const runTail = (finish, options) => scope("build", async () => {
 	return finish(escalations, NO_FINDINGS);
 });
 /**
-* The review and fix workflows' human review since `base`: a sign-off closes
+* The fix workflow's human review since `base`: a sign-off closes
 * `.gtd/REVIEW.md`; a note leaves it, with the reviewer's own version as
 * `REVIEW_ORIG`, for the next `fix` to read — never a re-plan.
 */
@@ -237,7 +237,7 @@ const handOffReview = (base, escalations, guard) => reviewToHandOff(base, {
 	unparsed: "gtd land: review-doc: your edit to .gtd/REVIEW.md contains no note fix can read — restore the deleted chunk, or write the note as a line under its entry.",
 	deleted: "gtd land: review-doc: .gtd/REVIEW.md was deleted — restore it, or leave a note to hand to fix."
 });
-/** The tail the review and fix workflows run: ends at the hand-off review since `base`. */
+/** The tail the fix workflow runs: ends at the hand-off review since `base`. */
 const handOffTail = (fixFirst, base, guard) => tail((escalations) => handOffReview(base, escalations, guard), {
 	fixFirst,
 	guard

package/dist/workflow-kit.mjs

@@ -233,14 +233,20 @@ const record = (p, decisions) => {
 	p.decided?.(decisions);
 	for (const d of decisions) if (d.choice === "wontfix") mark("wontfix", oneLine(d.anchor));
 };
+const routed = (p, answers) => answers.filter((d) => p.settles?.(d) !== true);
+/** Record the routed answers on the gate's commit, then hand every answer to `learn`. */
+const recordAndLearn = async (p, decisions, answers) => {
+	record(p, decisions);
+	if (answers.length > 0 && p.learn !== void 0) await p.learn(answers);
+};
 /**
 * Judge every note, then run each verdict's route: answers, then nit fixes,
 * then the edits' lap. Of the human's `decisions`, a fix joins the nit batch
 * unjudged, an own answer is judged like a note, and a won't-fix is dropped
 * with a `Gtd-Mark` on the gate's commit.
 */
-const routeNotes = async (p, notes, r, decisions = []) => {
-	record(p, decisions);
+const routeNotes = async (p, notes, r, decisions = [], answers = decisions) => {
+	await recordAndLearn(p, decisions, answers);
 	const of = (c) => decisions.filter((d) => d.choice === c);
 	const fixes = of("fix").map((d, i) => decisionNote(d, `fix-${i + 1}`, d.body));
 	const judged = [...notes, ...of("answer").map((d, i) => decisionNote(d, `answer-${i + 1}`, d.text))];
@@ -294,9 +300,8 @@ const settledAfter = (p, collectedAt) => ({
 	folded: collectedAt !== void 0 && read(p.feedback) !== void 0,
 	settled: collectedAt !== void 0 && changesSince(collectedAt).every((c) => !isCodeEdit(p, c)) && !notedSince(p, collectedAt)
 });
-const finishNotes = async (p, before, decisions, reopened, ctx) => {
-	const notes = reviewNotes(before ?? "", read(p.file) ?? "");
-	if (notes.length + decisions.length > 0) return routeNotes(p, notes, ctx, decisions);
+const finishNotes = async (p, notes, answers, reopened, ctx) => {
+	if (notes.length + answers.length > 0) return routeNotes(p, notes, ctx, routed(p, answers), answers);
 	if (reopened) return ctx.unfolded();
 	await ctx.close();
 	return ctx.outcome(await collect(p, p.captures.notes(ctx.round), "notes"));
@@ -311,6 +316,7 @@ const decisionsSince = (p, since) => {
 	const after = read(p.file) ?? "";
 	return reviewDecisions(since.get(p.file)?.before ?? after, after);
 };
+const notesSince = (p, since) => reviewNotes(since.get(p.file)?.before ?? "", read(p.file) ?? "");
 const finish = async (p, reviewed, collectedAt) => {
 	const round = head();
 	const since = changesSince(reviewed);
@@ -331,23 +337,29 @@ const finish = async (p, reviewed, collectedAt) => {
 		settled,
 		folded
 	});
-	const decisions = decisionsSince(p, since);
-	if (settled && !reopened && decisions.length === 0 || edited.length === 0 && !noted) return unfolded();
+	const answers = decisionsSince(p, since);
+	if (settled && !reopened && answers.length === 0 || edited.length === 0 && !noted) return unfolded();
+	const notes = notesSince(p, since);
 	if (edited.length > 0) {
-		record(p, decisions);
+		await recordAndLearn(p, routed(p, answers), answers);
 		await close();
 		return outcome(await collect(p, p.captures.edits(round, reopened ? reviewed : void 0), "edits", {
 			notes: [],
 			paths: edited.map((c) => c.path)
 		}));
 	}
-	return finishNotes(p, since.get(p.file)?.before, decisions, reopened, {
+	return finishNotes(p, notes, answers, reopened, {
 		round,
 		close,
 		outcome,
 		unfolded
 	});
 };
+/** A sign-off while something waits on the human writes the review again instead. */
+const unlessPending = (p, result) => "verdict" in result && result.verdict === "signoff" && p.pending?.() === true ? {
+	next: "rereview",
+	carry: void 0
+} : result;
 /** Write the review; if it marks risks, fix them, keep green, and write it again — once, so the re-review's own risks reach the human unfixed. */
 const reviewOnce = async (p, base, carry) => {
 	await p.reviewing(base, carry);
@@ -373,7 +385,7 @@ const review = async (base, p) => {
 		for (;;) {
 			collectedAt = await converse(p, base, reviewed, collectedAt);
 			if (collectedAt === "missing") break;
-			const result = await finish(p, reviewed, collectedAt);
+			const result = unlessPending(p, await finish(p, reviewed, collectedAt));
 			if (!("next" in result)) return result;
 			if (result.next === "rereview") {
 				carry = result.carry;

package/dist/workflows/cleanup.mjs

@@ -1,6 +1,6 @@
 import { agent, changes, glob, read, refuse, scope, start, vars } from "../flows.mjs";
-import { Ct as envDefaults, Et as flagReferences, Ot as registryEntry, S as coder, St as defaults, i as skills, kt as requireFlag, n as summary, o as flagShipped, r as access, t as steering } from "../chunks/reserved-COEMFEpy.mjs";
-import { a as refusePendingHandOff, r as handOffTail } from "../chunks/tail-C_xn8U7U.mjs";
+import { Bt as requireFlag, C as coder, Lt as flagReferences, Tt as envDefaults, i as skills, n as summary, o as flagShipped, r as access, t as steering, wt as defaults, zt as registryEntry } from "../chunks/reserved-ty1mtlnS.mjs";
+import { a as refusePendingHandOff, r as handOffTail } from "../chunks/tail-CM3sVoAb.mjs";
 //#region src/workflows/cleanup/cleanup.ts
 const removingPrompt = (name, registry) => `Clean up the release flag "${name}", which is default-on: delete its entry in ${registry}, and remove every \`GTD_FLAG_${name.toUpperCase()}\` check from the shipped sources. Keep the flag-on path; delete code only the off path reached, including tests that pin the off path.`;
 const cleanupFlow = async () => {