@pmelab/gtd 38.0.0 → 38.2.0

package/dist/workflows/feature.mjs

@@ -1,7 +1,7 @@
 import { agent, answered, applyScript, changes, changesSince, check, codeChanges, env, hasThreadFor, head, human, judge, judgeDiffShape, kept, mark, matches, numeric, quote, read, refuse, removeScript, requireAnswers, requireProgress, requireReplies, requireRevert, requireThreadsClosed, restoreScript, revertScript, run, scope, slice, start, vars, wrote } from "../flows.mjs";
 import { lensEntriesOf, review as review$1 } from "../workflow-kit.mjs";
-import { $ as naivePassPrompt, A as buildReviewAnswerQuestionsPrompt, B as coveringPrompt, E as reviewMissing, F as builderSystem, G as designTriagePrompt, H as deferNotesScript, I as clearCriteriaMessage, L as clearCriteriaQuestion, M as buildReviewCollectingPrompt, N as buildReviewFixNitsPrompt, O as reviewing, P as buildReviewTriageMessage, Q as naiveApplyFailure, R as coverageMessage, S as fixCheck, T as planner, U as designGateAnswerMessage, V as criterionLine, W as designSystem, X as implementBuildingPrompt, Y as idleMessage, Z as implementFixPrompt, _ as REQUIREMENTS, _t as unwindFailedMessage, a as flagModeOn, at as refactorNotePrompt, b as awaitReview, bt as envDefaults, ct as reviewEditsCapture, d as guarded, dt as reviewerSystem, et as normaliseCriteriaScript, f as healthy, ft as seamByHandMessage, g as REFACTOR_NOTE, gt as uncoveredMessage, h as REFACTOR, ht as startGateBlockedMessage, i as skills, it as refactorFixPrompt, j as buildReviewAwaitAfterDeferMessage, k as agentWithSkills, m as QUALITY, mt as slicingPrompt, n as summary, nt as refactorBuildingPrompt, ot as refactorRules, p as FEEDBACK, pt as seamSteerMessage, r as access, rt as refactorDroppedRefusal, s as shipped, st as reviewEditNotesCapture, t as steering, tt as qualityUnresolvedMessage, u as gate, ut as reviewNotesCapture, v as REVIEW, vt as unwindFailure, w as fixRisks, x as coder, xt as testFileGlobs, y as SLICES, yt as defaults, z as coverageQuestion } from "../chunks/reserved-sfMdy7v7.mjs";
-import { a as refusePendingHandOff, i as isOptionalObject, n as closeReview, o as tail } from "../chunks/tail-Cgca5Gp-.mjs";
+import { $ as naiveApplyFailure, A as agentWithSkills, B as coverageQuestion, C as fixCheck, Ct as testFileGlobs, D as reviewMissing, E as planner, F as buildReviewTriageMessage, G as designSystem, H as criterionLine, I as builderSystem, K as designTriagePrompt, L as clearCriteriaMessage, M as buildReviewAwaitAfterDeferMessage, N as buildReviewCollectingPrompt, P as buildReviewFixNitsPrompt, Q as implementFixPrompt, R as clearCriteriaQuestion, S as coder, St as envDefaults, T as fixRisks, U as deferNotesScript, V as coveringPrompt, W as designGateAnswerMessage, X as idleMessage, Z as implementBuildingPrompt, _ as REFACTOR_NOTE, _t as startGateBlockedMessage, a as flagModeOn, at as refactorDroppedRefusal, b as SLICES, bt as unwindFailure, ct as refactorRules, d as guarded, et as naivePassPrompt, f as healthy, ft as reviewNotesCapture, g as REFACTOR, gt as slicingPrompt, h as QUALITY, ht as seamSteerMessage, i as skills, it as refactorBuildingPrompt, j as buildReviewAnswerQuestionsPrompt, k as reviewing, lt as reviewEditNotesCapture, m as HANDOFF, mt as seamByHandMessage, n as summary, nt as oversizedMessage, ot as refactorFixPrompt, p as FEEDBACK, pt as reviewerSystem, r as access, rt as qualityUnresolvedMessage, s as shipped, st as refactorNotePrompt, t as steering, tt as normaliseCriteriaScript, u as gate, ut as reviewEditsCapture, v as REQUIREMENTS, vt as uncoveredMessage, x as awaitReview, xt as defaults, y as REVIEW, yt as unwindFailedMessage, z as coverageMessage } from "../chunks/reserved-C3PgP7XB.mjs";
+import { a as refusePendingHandOff, i as isOptionalObject, n as closeReview, o as tail } from "../chunks/tail-Bkxki2nK.mjs";
 import { posix } from "node:path";
 //#region src/workflows/shared/fences.ts
 const markFenced = (text) => {
@@ -145,6 +145,13 @@ const skipDesign = (stated) => stated === void 0 ? Promise.resolve(false) : scop
 	});
 	return true;
 });
+/** After a gate that invites narrowing the requirements: an edit must leave valid criteria. */
+const requireCriteriaIfEdited = () => {
+	const change = changes().get(REQUIREMENTS);
+	if (change === void 0) return;
+	if (change.status === "deleted") refuse(`gtd land: criteria-missing: ${REQUIREMENTS} must stay — narrow its criteria, never delete it`);
+	requireCriteria(REQUIREMENTS);
+};
 //#endregion
 //#region src/workflows/feature/tier.ts
 /** GTD_FLAG_RISK_TIER: pinned at process start, so a mid-process flip never moves a process. */
@@ -493,6 +500,53 @@ const reUnwind = async (feedback) => {
 	requireRevert(edited, base);
 };
 //#endregion
+//#region src/workflows/shared/continuation.ts
+const phase = (name, steered) => ({
+	name,
+	spent: false,
+	count: 0,
+	stalled: 0,
+	steered
+});
+const own = (fn) => fn();
+const continued = (fn) => scope("continue", fn);
+const afresh = (fn) => scope("fresh", fn);
+const setting = (name, least) => {
+	const raw = vars[name] ?? defaults[name];
+	const n = Number(raw);
+	if (raw.trim() === "" || !Number.isInteger(n) || n < least) refuse(`gtd: ${name} must be a whole number of at least ${least}, got ${JSON.stringify(raw)}`);
+	return n;
+};
+/**
+* Run `turn` until one ends without a handoff note: each stopped turn is picked
+* up by a continuation in a fresh conversation. Past `continuations` of them in
+* the phase, or after `continuationStall` in a row that close nothing still
+* open, the phase rests at `oversized` for a person; landing there grants a new round.
+*/
+const continuing = async (phase, turn) => {
+	const cap = setting("continuations", 0);
+	const stall = setting("continuationStall", 1);
+	let last = await turn(void 0, phase.spent ? afresh : own);
+	while (last.handoff !== void 0) {
+		phase.spent = true;
+		const from = last.handoff;
+		if (phase.count >= cap || phase.stalled >= stall) {
+			await human("oversized", {
+				message: oversizedMessage(phase.name, from, phase.count >= cap ? { cap } : { stall }, phase.steered !== void 0),
+				label: "Too big for its context",
+				acceptClean: true
+			});
+			phase.steered?.();
+			phase.count = 0;
+			phase.stalled = 0;
+		}
+		last = await turn(from, continued);
+		phase.count++;
+		phase.stalled = from.open.length === 0 || from.open.some((item) => !(last.handoff?.open ?? []).includes(item)) ? 0 : phase.stalled + 1;
+	}
+	return last.result;
+};
+//#endregion
 //#region src/workflows/feature/refactor.ts
 const REFACTOR_PACKAGE = REFACTOR;
 const isCode = (path) => path !== ".gtd" && !path.startsWith(".gtd/");
@@ -638,7 +692,7 @@ const guardOf = ({ pattern, strays }, entry) => () => {
 	requireNoNewFlags(pattern, entry);
 };
 /** Derive, build, check and close one refactor lap; `feedback` is the collected review text of the lap before. */
-const refactorLap = async (p, guard, feedback) => {
+const refactorLap = async (p, guard, refactor, feedback) => {
 	const { pattern, strays, reference, note } = p;
 	await run("deriving", deriveScript([
 		...packageLines(strays, pattern, reference),
@@ -658,32 +712,48 @@ const refactorLap = async (p, guard, feedback) => {
 		label: "Deriving the refactor package",
 		file: REFACTOR_PACKAGE
 	});
-	await agentWithSkills("building", refactorBuildingPrompt({
-		pkg: REFACTOR_PACKAGE,
-		strays,
-		pattern,
-		reference,
-		feedback: feedback !== void 0,
-		note: note !== void 0
-	}), {
-		label: "Refactoring",
-		model: coder(),
-		system: builderSystem()
-	});
-	guard();
-	await healthy(async () => {
-		await agentWithSkills("fix.suite.fixing", refactorFixPrompt(strays, pattern), {
-			label: "Fixing the check",
-			file: FEEDBACK,
+	const reached = /* @__PURE__ */ new Set();
+	await continuing(refactor, async (from, fresh) => {
+		await fresh(() => agentWithSkills("building", refactorBuildingPrompt({
+			pkg: REFACTOR_PACKAGE,
+			strays,
+			pattern,
+			reference,
+			feedback: feedback !== void 0,
+			note: note !== void 0,
+			from
+		}), {
+			label: from === void 0 ? "Refactoring" : "Continuing the refactor",
 			model: coder(),
 			system: builderSystem()
-		});
+		}));
+		const left = read(HANDOFF);
 		guard();
-	}, {
-		describeGuard: guard,
-		rules: refactorRules(strays, pattern)
+		const snapshot = head();
+		for (const c of changes()) reached.add(c.path);
+		await healthy(async () => {
+			await agentWithSkills("fix.suite.fixing", refactorFixPrompt(strays, pattern), {
+				label: "Fixing the check",
+				file: FEEDBACK,
+				model: coder(),
+				system: builderSystem()
+			});
+			guard();
+		}, {
+			describeGuard: guard,
+			rules: refactorRules(strays, pattern)
+		});
+		if (left === void 0) return { result: void 0 };
+		return {
+			result: void 0,
+			handoff: {
+				snapshot,
+				note: left.trim(),
+				open: strays.filter((path) => !reached.has(path))
+			}
+		};
 	});
-	await run("closing", removeScript([REFACTOR_PACKAGE]), { label: "Closing out the refactor" });
+	await run("closing", removeScript([REFACTOR_PACKAGE, HANDOFF]), { label: "Closing out the refactor" });
 };
 const strayAccess = (strays) => ({ write: [
 	...strays,
@@ -697,7 +767,7 @@ const refactorFirst = async (shape, options = {}) => {
 		name: "refactor",
 		access: strayAccess(p.strays)
 	}, async () => {
-		await refactorLap(p, guardOf(p, head()));
+		await refactorLap(p, guardOf(p, head()), phase("refactor"));
 		return true;
 	});
 };
@@ -722,9 +792,10 @@ const reviewedRefactor = async (shape, options = {}) => {
 			unmatched: "gtd land: refactor-feedback: the review feedback changed files but wrote no .gtd/REFACTOR.md — a refactor cannot act on it; revert the change, or `gtd abandon` and restart",
 			dropped: refactorDroppedRefusal
 		};
+		const refactor = phase("refactor");
 		let collected;
 		for (;;) {
-			await refactorLap(p, guard, collected);
+			await refactorLap(p, guard, refactor, collected);
 			const outcome = await buildTail(entry, {
 				green: true,
 				guard,
@@ -835,12 +906,32 @@ const judgeSeam = (tip) => judgeDiffShape("judge", {
 	allow: (vars.seamAllow ?? defaults.seamAllow).split(",").map((glob) => glob.trim()).filter((glob) => glob !== ""),
 	exempt: tip.changes.filter((c) => c.status === "added").map((c) => c.path)
 });
-const naivePass = (retry, slice) => agentWithSkills("naive", naivePassPrompt(retry, sliceIds(slice)), {
-	label: retry === void 0 ? "Writing the naive pass" : "Rewriting the naive pass",
+const naivePass = (retry, slice, from) => agentWithSkills("naive", naivePassPrompt(retry, sliceIds(slice), from), {
+	label: from !== void 0 ? "Continuing the naive pass" : retry === void 0 ? "Writing the naive pass" : "Rewriting the naive pass",
 	keep: true,
 	model: coder(),
 	system: builderSystem()
 });
+const handoffOf = (tip, slice) => {
+	const note = tip.changes.find((c) => c.path === ".gtd/HANDOFF.md" && c.after !== void 0);
+	if (note === void 0) return void 0;
+	return {
+		snapshot: tip.hash,
+		note: note.after.trim(),
+		open: unnamed(idsOf(REQUIREMENTS, slice), acceptanceTests(tip.changes))
+	};
+};
+/** A naive pass, continued until a pass ends without a handoff note: the snapshot is its kept tip. */
+const naiveContinued = (retry, slice, naive) => continuing(naive, async (from, fresh) => {
+	const tip = await fresh(async () => {
+		await naivePass(retry, slice, from);
+		return kept("naive");
+	});
+	return {
+		result: tip,
+		handoff: handoffOf(tip, slice)
+	};
+});
 const IMPORTED = /(?:\bfrom|\bimport|\brequire\s*\(|\bmock\s*\()\s*\(?\s*(["'`])([^"'`\n]+)\1/g;
 const EXTENSION = /\.[\w-]+$/;
 const ALIAS = /^(?:[@~]\/|#)/;
@@ -968,6 +1059,32 @@ const applied = async (tip) => {
 	await run("applying", applyScript(tip, FEEDBACK, naiveApplyFailure(tip), [".gtd"]), { label: "Applying the naive pass" });
 	return !wrote(".gtd/FEEDBACK.md") && codeChanges().length > 0;
 };
+/** `carried` limited to the criteria `.gtd/REQUIREMENTS.md` lists now; a file listing none narrows nothing. */
+const settled = (carried, slice) => {
+	const listed = idsOf(REQUIREMENTS, slice);
+	if (carried === void 0) return listed;
+	return listed.length === 0 ? carried : carried.filter((id) => listed.includes(id));
+};
+const build = (options) => continuing(phase("build", requireCriteriaIfEdited), async (from, fresh) => {
+	await fresh(() => agentWithSkills("building", implementBuildingPrompt(options.reference, options.tier, options.amend, options.afterRefactor, flagModeOn(), options.rebuild, sliceIds(options.slice), from), {
+		label: from === void 0 ? "Implementing" : "Continuing the implementation",
+		model: coder(),
+		system: builderSystem(),
+		...options.afterRefactor === true ? { allowEmpty: true } : {}
+	}));
+	requireCriteriaFrozen(REQUIREMENTS);
+	const note = read(HANDOFF);
+	if (note === void 0) return { result: void 0 };
+	const ids = settled(options.rebuild?.acceptance?.ids, options.slice);
+	return {
+		result: void 0,
+		handoff: {
+			snapshot: head(),
+			note: note.trim(),
+			open: unnamed(ids, acceptanceTests(changesSince(start())))
+		}
+	};
+});
 function implement(first, tier, amend) {
 	const options = typeof first === "object" && first !== null ? first : {
 		reference: first,
@@ -978,14 +1095,12 @@ function implement(first, tier, amend) {
 		const since = head();
 		const acceptance = options.rebuild?.acceptance;
 		const built = options.naive === void 0 || !await applied(options.naive);
-		if (built) await agentWithSkills("building", implementBuildingPrompt(options.reference, options.tier, options.amend, options.afterRefactor, flagModeOn(), options.rebuild, sliceIds(options.slice)), {
-			label: "Implementing",
-			model: coder(),
-			system: builderSystem(),
-			...options.afterRefactor === true ? { allowEmpty: true } : {}
-		});
-		requireCriteriaFrozen(REQUIREMENTS);
-		if (built && acceptance !== void 0) requireAcceptance(acceptance, since);
+		if (built) await build(options);
+		else requireCriteriaFrozen(REQUIREMENTS);
+		if (built && acceptance !== void 0) requireAcceptance({
+			...acceptance,
+			ids: settled(acceptance.ids, options.slice)
+		}, since);
 		await green(built && acceptance !== void 0 ? () => requireAcceptanceKept(acceptance) : void 0);
 		await requireCoverage(options.base, options.slice);
 		await closing(options.more === true);
@@ -994,10 +1109,11 @@ function implement(first, tier, amend) {
 /** The last slice's closing, for a last slice a steer left with no criterion to build. */
 const closeOut = () => scope("implement", () => closing(false));
 /** A slice with `more` after it keeps the criteria and the slicing for the next one. */
-const closing = (more) => run("closing", removeScript(more ? [REFACTOR_NOTE] : [
+const closing = (more) => run("closing", removeScript(more ? [REFACTOR_NOTE, HANDOFF] : [
 	REQUIREMENTS,
 	REFACTOR_NOTE,
-	SLICES
+	SLICES,
+	HANDOFF
 ]), { label: "Closing out the implementation" });
 /** Resolves `true` when the human steered (edited), `false` on a clean overrule. */
 const steer = async (retry) => {
@@ -1069,10 +1185,10 @@ const decide = (slice) => scope("seam", async () => {
 		again: budget(),
 		waived: false
 	};
+	const naive = phase("naive pass", requireCriteriaIfEdited);
 	let retry;
 	for (;;) {
-		await naivePass(retry, slice);
-		const tip = kept("naive");
+		const tip = await naiveContinued(retry, slice, naive);
 		const outcome = await vetted(tip, vetting, slice) ?? (flagModeOn() ? await ruled(tip, vetting.again) : {
 			reference: tip.hash,
 			tip
@@ -1328,4 +1444,4 @@ const feature = shipped(ordinaryStart);
 //#region src/workflows/feature/index.ts
 var feature_default = feature;
 //#endregion
-export { COMMENT, REFACTOR_PACKAGE, acceptanceFault, access, afterTail, answerProductQuestions, answerReviewQuestions, buildFeature, buildTail, closeOut, collecting, criteriaOf, criterionIds, feature_default as default, defaults, deferNotes, design, envDefaults, feature, fixNits, holdsCallSites, implement, isTestFile, judgeSeam, naiveAcceptance, naivePass, ordinaryStart, planAndBuild, reUnwind, refactorCollecting, refactorFirst, refactorNote, refactorStrays, requireAcceptance, requireAcceptanceKept, requireCriteria, requireCriteriaFrozen, requireNoNewFlags, requireNoTestFiles, requireSlices, requireTestCallSitesOnly, requireWithin, reviewedRefactor, seamBuild, skills, skipDesign, sliceCap, sliceCriteria, sliceIds, slicesOf, slicing, statedCriteria, steering, summary, triage, unwind };
+export { COMMENT, REFACTOR_PACKAGE, acceptanceFault, access, afterTail, answerProductQuestions, answerReviewQuestions, buildFeature, buildTail, closeOut, collecting, criteriaOf, criterionIds, feature_default as default, defaults, deferNotes, design, envDefaults, feature, fixNits, holdsCallSites, implement, isTestFile, judgeSeam, naiveAcceptance, naivePass, ordinaryStart, planAndBuild, reUnwind, refactorCollecting, refactorFirst, refactorNote, refactorStrays, requireAcceptance, requireAcceptanceKept, requireCriteria, requireCriteriaFrozen, requireCriteriaIfEdited, requireNoNewFlags, requireNoTestFiles, requireSlices, requireTestCallSitesOnly, requireWithin, reviewedRefactor, seamBuild, skills, skipDesign, sliceCap, sliceCriteria, sliceIds, slicesOf, slicing, statedCriteria, steering, summary, triage, unwind };

package/dist/workflows/fix.mjs

@@ -1,7 +1,7 @@
 import { read, refuse, removeScript, run, scope, start } from "../flows.mjs";
 import { d as reviewNotes, f as reviewRisks } from "../chunks/steering-DVILanVf.mjs";
-import { K as finisherSystem, bt as envDefaults, c as baseline, i as skills, k as agentWithSkills, n as summary, q as fixReviewNotesPrompt, r as access, s as shipped, t as steering, v as REVIEW, x as coder, yt as defaults } from "../chunks/reserved-sfMdy7v7.mjs";
-import { r as handOffTail, t as REVIEW_ORIG } from "../chunks/tail-Cgca5Gp-.mjs";
+import { A as agentWithSkills, J as fixReviewNotesPrompt, S as coder, St as envDefaults, c as baseline, i as skills, n as summary, q as finisherSystem, r as access, s as shipped, t as steering, xt as defaults, y as REVIEW } from "../chunks/reserved-C3PgP7XB.mjs";
+import { r as handOffTail, t as REVIEW_ORIG } from "../chunks/tail-Bkxki2nK.mjs";
 //#region src/workflows/fix/fix.ts
 /**
 * Fix every note a human left in a handed-off `.gtd/REVIEW.md` and every

package/dist/workflows/review.mjs

@@ -1,6 +1,6 @@
 import { start } from "../flows.mjs";
-import { bt as envDefaults, i as skills, lt as reviewGateBlockedMessage, n as summary, r as access, s as shipped, t as steering, u as gate, yt as defaults } from "../chunks/reserved-sfMdy7v7.mjs";
-import { a as refusePendingHandOff, r as handOffTail } from "../chunks/tail-Cgca5Gp-.mjs";
+import { St as envDefaults, dt as reviewGateBlockedMessage, i as skills, n as summary, r as access, s as shipped, t as steering, u as gate, xt as defaults } from "../chunks/reserved-C3PgP7XB.mjs";
+import { a as refusePendingHandOff, r as handOffTail } from "../chunks/tail-Bkxki2nK.mjs";
 //#region src/workflows/review/review.ts
 /**
 * Pure review of everything since `reviewBase`: a green gate, the quality

package/dist/workflows/rollout.mjs

@@ -1,5 +1,5 @@
 import { agent, changesSince, glob, head, mark, read, refuse, removeScript, run, scope, vars } from "../flows.mjs";
-import { Et as requireFlag, St as flagMentions, bt as envDefaults, i as skills, n as summary, o as flagShipped, p as FEEDBACK, r as access, t as steering, u as gate, wt as flipProblems, x as coder, yt as defaults } from "../chunks/reserved-sfMdy7v7.mjs";
+import { Et as flipProblems, Ot as requireFlag, S as coder, St as envDefaults, i as skills, n as summary, o as flagShipped, p as FEEDBACK, r as access, t as steering, u as gate, wt as flagMentions, xt as defaults } from "../chunks/reserved-C3PgP7XB.mjs";
 //#region src/workflows/rollout/rollout.ts
 const flippingPrompt = (name, registry) => `Roll out the release flag "${name}": in ${registry}, set \`defaultOn: true\` on its entry. Change nothing else — no other entry, no other field, no other file, no comments.`;
 const suiteBlockedMessage = () => "The suite is red after the rollout. Fix it by hand — a rollout may only touch the flag's registry entry — then land.";