@pmelab/gtd 32.0.0 → 33.0.0

package/src/workflows/feature/naive-acceptance.feature

@@ -0,0 +1,140 @@
+@inmem
+Feature: a naive pass ends only when a test names every criterion and the suite is green
+
+  `seam.naive` writes behaviour-level acceptance tests, each naming its
+  criterion's ID. A pass whose tests leave an ID out or import a file the
+  pass added is sent back; `seam.check` then runs the suite with the kept
+  pass applied, and a red run sends it back too, before the judge sees it.
+  Three failed attempts rest at `seam.steer`.
+
+  Background:
+    Given the shipped workflows, as gtd install scaffolds them
+    And an environment variable "GTD_QUALITYREVIEWS" set to ""
+    And an environment variable "GTD_FLAG_RISK_TIER" set to "0"
+    And a file "src/calc.ts" with:
+      """
+      export const add = (a: number, b: number) => a + b
+      """
+    And the working tree is committed as "feat: add calculator"
+    And a file "TODO.md" with:
+      """
+      # Add subtract
+
+      subtract(a, b) returns the difference.
+      """
+    And step "unwind" changes nothing
+    And step "start-gate.check" changes nothing
+    And step "design.triage" writes ".gtd/REQUIREMENTS.md" with:
+      """
+      # Requirements
+
+      ## Acceptance Criteria
+
+      - AC-1: `subtract(5, 3)` returns 2.
+      - AC-2: `add` still adds.
+      """
+    And step "design.gate.answer" changes nothing
+    And step "seam.naive" writes "src/calc.ts" with:
+      """
+      export const add = (a: number, b: number) => a + b
+      export const subtract = (a: number, b: number) => a - b
+      """
+
+  Scenario: a pass whose tests leave a criterion's ID out is sent back, and an overrule runs the check and sticks
+    Given step "seam.naive" writes "tests/calc.test.ts" with:
+      """
+      import { add, subtract } from "../src/calc.js"
+      it("[AC-1] subtracts", () => expect(subtract(5, 3)).toBe(2))
+      """
+    When the process is driven
+    Then the process rests at "seam.steer"
+    And the resting step's content contains "acceptance-tests: no test of the naive pass names AC-2"
+
+    Given step "seam.check" changes nothing
+    When gtd lands
+    And the process is driven
+    Then the process rests at "seam.judge"
+    And the commit subjects end with:
+      """
+      gtd(human): design.gate.answer → seam.naive
+      gtd(agent): seam.naive
+      gtd(agent): seam.naive
+      gtd(agent): seam.naive → seam.steer
+      gtd(human): seam.steer → seam.check
+      gtd(check): seam.check → seam.judge
+      """
+
+    Given judge step "seam.judge" answers:
+      """
+      [{"id":"shape","answer":"reject","p":0.9}]
+      """
+    When the process is driven
+    Then the process rests at "seam.steer"
+    And the resting step's content contains "rejected the last attempt"
+    And the commit subjects end with:
+      """
+      gtd(check): seam.check → seam.judge
+      gtd(judge): seam.judge → seam.naive
+      gtd(agent): seam.naive → seam.check
+      gtd(check): seam.check → seam.judge
+      gtd(judge): seam.judge → seam.naive
+      gtd(agent): seam.naive → seam.check
+      gtd(check): seam.check → seam.judge
+      gtd(judge): seam.judge → seam.steer
+      """
+
+  Scenario: a test importing a file the pass added is sent back
+    Given step "seam.naive" writes "src/subtract.ts" with:
+      """
+      export const subtract = (a: number, b: number) => a - b
+      """
+    And step "seam.naive" writes "src/subtract.test.ts" with:
+      """
+      import { subtract } from "./subtract.js"
+      it("[AC-1] subtracts", () => expect(subtract(5, 3)).toBe(2))
+      it("[AC-2] still adds", () => {})
+      """
+    When the process is driven
+    Then the process rests at "seam.steer"
+    And the resting step's content contains "src/subtract.test.ts → src/subtract.ts"
+
+  Scenario: a red suite sends the pass back, and it moves on only once green
+    Given step "seam.naive" writes "tests/calc.test.ts" with:
+      """
+      import { add, subtract } from "../src/calc.js"
+      it("[AC-1] subtracts", () => expect(subtract(5, 3)).toBe(2))
+      it("[AC-2] still adds", () => expect(add(1, 1)).toBe(2))
+      """
+    When the process is driven
+    Then the process rests at "seam.check"
+    And the resting step's content contains "git checkout -q HEAD --"
+    And the resting step's content does not contain "'^'"
+    And the resting step's content contains "npm test"
+
+    Given step "seam.naive" is no longer scripted
+    And step "seam.check" writes ".gtd/FEEDBACK.md" with:
+      """
+      FAIL tests/calc.test.ts > [AC-1] subtracts
+      """
+    When the process is driven
+    Then the process rests at "seam.naive"
+    And the resting step's content contains "left the suite red"
+    And ".gtd/FEEDBACK.md" contains "[AC-1] subtracts"
+
+    Given step "seam.naive" writes "tests/calc.test.ts" with:
+      """
+      import { add, subtract } from "../src/calc.js"
+      it("[AC-1] subtracts", () => expect(subtract(5, 3)).toBe(2))
+      it("[AC-2] still adds", () => expect(add(2, 2)).toBe(4))
+      """
+    And step "seam.check" from now on changes nothing
+    When the process is driven
+    Then the process rests at "implement.building"
+    And the commit subjects end with:
+      """
+      gtd(human): design.gate.answer → seam.naive
+      gtd(agent): seam.naive → seam.check
+      gtd(check): seam.check → seam.naive
+      gtd(agent): seam.naive → seam.check
+      gtd(check): seam.check → implement.building
+      """

package/src/workflows/feature/one-step-land.feature

@@ -40,6 +40,11 @@ Feature: a naive pass the judge rules land goes straight to implement with no se
       - AC-1: the change behaves as described.
       """
     And step "design.gate.answer" changes nothing
+    And step "seam.check" changes nothing
+    And step "seam.naive" writes "src/acceptance.test.ts" with:
+      """
+      it("[AC-1] holds", () => {})
+      """
     And step "seam.naive" writes "src/greeting.ts" with:
       """
       export const greeting = "Hello, world"
@@ -93,7 +98,8 @@ Feature: a naive pass the judge rules land goes straight to implement with no se
       gtd(check): start-gate.check → design.triage
       gtd(agent): design.triage → design.gate.answer
       gtd(human): design.gate.answer → seam.naive
-      gtd(agent): seam.naive → seam.judge
+      gtd(agent): seam.naive → seam.check
+      gtd(check): seam.check → seam.judge
       gtd(judge): seam.judge → implement.building
       gtd(agent): implement.building → implement.health.check
       gtd(check): implement.health.check → implement.closing
@@ -104,7 +110,7 @@ Feature: a naive pass the judge rules land goes straight to implement with no se
       gtd(check): build.review.closing → idle
       """
     And the commit "gtd(human): idle → unwind" has a body containing "Gtd-Var: flag_risk_tier=0"
-    And the commit "gtd(agent): seam.naive → seam.judge" has a body containing "Gtd-Kept:"
+    And the commit "gtd(agent): seam.naive → seam.check" has a body containing "Gtd-Kept:"
     And the commit "gtd(judge): seam.judge → implement.building" has a body containing "\"answer\":\"land\""
     And no commit body contains "Gtd-Approved:"
     And the output lines of gtd "slices" start with:

package/src/workflows/feature/refactor-absorbs.feature

@@ -43,7 +43,12 @@ Feature: a refactor that carried the whole feature still gets a feature review
     And step "design.gate.answer" changes nothing
 
   Scenario: an empty implement turn after a refactor that did it all reaches review and idle
-    Given step "seam.naive" writes "src/calc.ts" with:
+    Given step "seam.check" changes nothing
+    And step "seam.naive" writes "src/acceptance.test.ts" with:
+      """
+      it("[AC-1] holds", () => {})
+      """
+    And step "seam.naive" writes "src/calc.ts" with:
       """
       export const add = (a: number, b: number) => a + b
       export const subtract = (a: number, b: number) => a - b

package/src/workflows/feature/refactor-first.feature

@@ -42,7 +42,12 @@ Feature: a refactor-first judgment walks one fixed path to idle
     And step "design.gate.answer" changes nothing
 
   Scenario: a refactor-first judgment runs refactor, its review, implement and review to idle
-    Given step "seam.naive" writes "src/calc.ts" with:
+    Given step "seam.check" changes nothing
+    And step "seam.naive" writes "src/acceptance.test.ts" with:
+      """
+      it("[AC-1] holds", () => {})
+      """
+    And step "seam.naive" writes "src/calc.ts" with:
       """
       export const add = (a: number, b: number) => a + b
       export const subtract = (a: number, b: number) => a - b
@@ -141,7 +146,8 @@ Feature: a refactor-first judgment walks one fixed path to idle
       gtd(check): start-gate.check → design.triage
       gtd(agent): design.triage → design.gate.answer
       gtd(human): design.gate.answer → seam.naive
-      gtd(agent): seam.naive → seam.judge
+      gtd(agent): seam.naive → seam.check
+      gtd(check): seam.check → seam.judge
       gtd(judge): seam.judge → refactor.deriving
       gtd(check): refactor.deriving → refactor.building
       gtd(agent): refactor.building → refactor.health.check
@@ -158,7 +164,7 @@ Feature: a refactor-first judgment walks one fixed path to idle
       gtd(check): build.review.closing → idle
       """
     And the commit "gtd(human): idle → unwind" has a body containing "Gtd-Var: flag_risk_tier=0"
-    And the commit "gtd(agent): seam.naive → seam.judge" has a body containing "Gtd-Kept:"
+    And the commit "gtd(agent): seam.naive → seam.check" has a body containing "Gtd-Kept:"
     And the commit "gtd(judge): seam.judge → refactor.deriving" has a body containing "\"answer\":\"refactor-first\""
     And no commit body contains "Gtd-Approved:"
     And the output lines of gtd "slices" start with:

package/src/workflows/feature/refactor-lens-models.feature

@@ -0,0 +1,67 @@
+@inmem
+Feature: the refactor review's lenses take their model hints from refactorQualityReviews alone
+
+  Background:
+    Given the shipped workflows, as gtd install scaffolds them
+    And an environment variable "GTD_QUALITYREVIEWS" set to "correctness=base"
+    And an environment variable "GTD_REFACTORQUALITYREVIEWS" set to "correctness, conventions=opus"
+    And an environment variable "GTD_FLAG_RISK_TIER" set to "0"
+    And a file "src/calc.ts" with:
+      """
+      export const add = (a: number, b: number) => a + b
+      """
+    And the working tree is committed as "feat: add calculator"
+    And a file "TODO.md" with:
+      """
+      # Add subtract
+
+      subtract(a, b) returns the difference.
+      """
+    And step "unwind" changes nothing
+    And step "start-gate.check" changes nothing
+    And step "design.triage" writes ".gtd/REQUIREMENTS.md" with:
+      """
+      # Requirements
+
+      ## Concerns
+
+      ### Subtract
+
+      - `subtract(a, b)` returns `a - b`.
+
+      ## Acceptance Criteria
+
+      - AC-1: the change behaves as described.
+      """
+    And step "design.gate.answer" changes nothing
+
+  Scenario: a refactor lens runs on its refactorQualityReviews hint, else its default
+    Given step "seam.check" changes nothing
+    And step "seam.naive" writes "src/acceptance.test.ts" with:
+      """
+      it("[AC-1] holds", () => {})
+      """
+    And step "seam.naive" writes "src/calc.ts" with:
+      """
+      export const add = (a: number, b: number) => a + b
+      export const subtract = (a: number, b: number) => a - b
+      """
+    And judge step "seam.judge" answers:
+      """
+      [{"id":"shape","answer":"refactor-first","p":0.9}]
+      """
+    And step "refactor.deriving" runs its script
+    And step "refactor.building" writes "src/calc.ts" with:
+      """
+      export const op = (a: number, b: number, sign: number) => a + sign * b
+      export const add = (a: number, b: number) => op(a, b, 1)
+      """
+    And step "refactor.health.check" changes nothing
+    And step "refactor.closing" runs its script
+    When the process is driven
+    Then the process rests at "refactor.build.quality.correctness.reviewing"
+    And the output of gtd "next --json" contains "\"model\":\"smart\""
+    Given step "refactor.build.quality.correctness.reviewing" changes nothing
+    When the process is driven
+    Then the process rests at "refactor.build.quality.conventions.reviewing"
+    And the output of gtd "next --json" contains "\"model\":\"opus\""

package/src/workflows/feature/refactor-review.feature

@@ -52,6 +52,11 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
       - AC-1: the change behaves as described.
       """
     And step "design.gate.answer" changes nothing
+    And step "seam.check" changes nothing
+    And step "seam.naive" writes "src/acceptance.test.ts" with:
+      """
+      it("[AC-1] holds", () => {})
+      """
     And step "seam.naive" writes "src/calc.ts" with:
       """
       export const add = (a: number, b: number) => a + b
@@ -136,6 +141,11 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
       - AC-1: the change behaves as described.
       """
     And step "design.gate.answer" changes nothing
+    And step "seam.check" changes nothing
+    And step "seam.naive" writes "src/acceptance.test.ts" with:
+      """
+      it("[AC-1] holds", () => {})
+      """
     And step "seam.naive" writes "src/calc.ts" with:
       """
       export const add = (a: number, b: number) => a + b
@@ -219,6 +229,11 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
         - AC-1: the change behaves as described.
         """
       And step "design.gate.answer" changes nothing
+      And step "seam.check" changes nothing
+      And step "seam.naive" writes "src/acceptance.test.ts" with:
+        """
+        it("[AC-1] holds", () => {})
+        """
       And step "seam.naive" writes "src/calc.ts" with:
         """
         export const add = (a: number, b: number) => a + b
@@ -1426,6 +1441,11 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
         - AC-1: the change behaves as described.
         """
       And step "design.gate.answer" changes nothing
+      And step "seam.check" changes nothing
+      And step "seam.naive" writes "src/acceptance.test.ts" with:
+        """
+        it("[AC-1] holds", () => {})
+        """
       And step "seam.naive" writes "src/calc.ts" with:
         """
         export const add = (a: number, b: number) => a + b
@@ -1614,7 +1634,12 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
         """
 
     Scenario: a test-file stray is dropped from the derived refactor package
-      Given step "seam.naive" writes "src/calc.ts" with:
+      Given step "seam.check" changes nothing
+      And step "seam.naive" writes "src/acceptance.test.ts" with:
+        """
+        it("[AC-1] holds", () => {})
+        """
+      And step "seam.naive" writes "src/calc.ts" with:
         """
         export const add = (a: number, b: number) => a + b
         export const subtract = (a: number, b: number) => a - b
@@ -1631,7 +1656,12 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
       And ".gtd/REFACTOR.md" does not contain "src/calc.test.ts"
 
     Scenario: the refactor updates an existing test's call sites to the seam's new shape
-      Given step "seam.naive" writes "src/calc.ts" with:
+      Given step "seam.check" changes nothing
+      And step "seam.naive" writes "src/acceptance.test.ts" with:
+        """
+        it("[AC-1] holds", () => {})
+        """
+      And step "seam.naive" writes "src/calc.ts" with:
         """
         export const add = ({ a, b }: { a: number; b: number }) => a + b
         export const subtract = ({ a, b }: { a: number; b: number }) => a - b
@@ -1651,7 +1681,12 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
       Then the process rests at "refactor.health.check"
 
     Scenario: the refactor may not drop an assertion from an existing test
-      Given step "seam.naive" writes "src/calc.ts" with:
+      Given step "seam.check" changes nothing
+      And step "seam.naive" writes "src/acceptance.test.ts" with:
+        """
+        it("[AC-1] holds", () => {})
+        """
+      And step "seam.naive" writes "src/calc.ts" with:
         """
         export const add = (a: number, b: number) => a + b
         export const subtract = (a: number, b: number) => a - b
@@ -1665,7 +1700,12 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
       Then driving the process is refused with "refactor-tests"
 
     Scenario: a refactor-first whose strays are all test files goes straight to implement
-      Given step "seam.naive" writes "src/calc.test.ts" with:
+      Given step "seam.check" changes nothing
+      And step "seam.naive" writes "src/acceptance.test.ts" with:
+        """
+        it("[AC-1] holds", () => {})
+        """
+      And step "seam.naive" writes "src/calc.test.ts" with:
         """
         import { expect, it } from "vitest"
         it("subtracts", () => expect(3 - 1).toBe(2))
@@ -1675,7 +1715,12 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
       And ".gtd/REFACTOR.md" does not exist
 
     Scenario: collected review headings re-derive at ### with the deepest capped at ######
-      Given step "seam.naive" writes "src/calc.ts" with:
+      Given step "seam.check" changes nothing
+      And step "seam.naive" writes "src/acceptance.test.ts" with:
+        """
+        it("[AC-1] holds", () => {})
+        """
+      And step "seam.naive" writes "src/calc.ts" with:
         """
         export const add = (a: number, b: number) => a + b
         export const subtract = (a: number, b: number) => a - b

package/src/workflows/feature/refactor.ts

@@ -13,7 +13,7 @@ import {
   type Change,
   type DiffShapeResult,
 } from "../../flows/index.js"
-import { lensesOf } from "../../workflow-kit/index.js"
+import { lensEntriesOf } from "../../workflow-kit/index.js"
 import { markFenced } from "../shared/fences.js"
 import { healthy, type Guard } from "../shared/health.js"
 import { coder, FEEDBACK, REFACTOR } from "../shared/steps.js"
@@ -42,7 +42,8 @@ export const requireWithin = (allowed: readonly string[]): void => {
 }
 
 // A fixed list, not `seamAllow`: narrowing that setting must not let a test file through.
-const isTestFile = (path: string): boolean => testFileGlobs.some((glob) => matches(path, glob))
+export const isTestFile = (path: string): boolean =>
+  testFileGlobs.some((glob) => matches(path, glob))
 
 // The bundled refactor uses `requireTestCallSitesOnly`; this stays a public export.
 export const requireNoTestFiles = (): void => {
@@ -56,11 +57,11 @@ export const requireNoTestFiles = (): void => {
 }
 
 // Call sites live in code: a `.feature` file or a snapshot holds only expectations.
-const holdsCallSites = (path: string): boolean =>
+export const holdsCallSites = (path: string): boolean =>
   !path.endsWith(".feature") && !path.endsWith(".snap")
 
 // `//` after a `:` (a URL) and `/*` after `*` or `/` (a glob) sit in strings, not comments.
-const COMMENT = /(?<![*/])\/\*[\s\S]*?\*\/|(?<!:)\/\/.*$/gm
+export const COMMENT = /(?<![*/])\/\*[\s\S]*?\*\/|(?<!:)\/\/.*$/gm
 const ASSERTION = /\b(?:expect|assert\w*)\s*[.(]/g
 const TEST_CASE = /(?<![.\w])x?(?:it|test|describe)\s*[.(]/g
 const MODIFIER =
@@ -343,7 +344,7 @@ export const reviewedRefactor = async (
         green: true,
         guard,
         guardRests: false,
-        lenses: lensesOf(vars.refactorQualityReviews ?? ""),
+        lenses: lensEntriesOf(vars.refactorQualityReviews ?? ""),
         feedback,
         fixAccess: strayAccess(p.strays),
         lensBase: entry,

package/src/workflows/feature/risk-tier.feature

@@ -146,6 +146,11 @@ Feature: the risk tier is proposed at triage and recorded behind GTD_FLAG_RISK_T
 
         - AC-1: the change behaves as described.
         """
+      And step "seam.check" changes nothing
+      And step "seam.naive" writes "src/acceptance.test.ts" with:
+        """
+        it("[AC-1] holds", () => {})
+        """
       And step "seam.naive" writes "src/calc.ts" with:
         """
         export const add = (a: number, b: number) => a + b
@@ -254,6 +259,11 @@ Feature: the risk tier is proposed at triage and recorded behind GTD_FLAG_RISK_T
         - AC-1: the change behaves as described.
         """
       And step "design.gate.answer" changes nothing
+      And step "seam.check" changes nothing
+      And step "seam.naive" writes "src/acceptance.test.ts" with:
+        """
+        it("[AC-1] holds", () => {})
+        """
       And step "seam.naive" writes "src/calc.ts" with:
         """
         export const add = (a: number, b: number) => a + b

package/src/workflows/feature/seam-rejection.feature

@@ -41,7 +41,12 @@ Feature: rejected naive passes walk one fixed path through the steer gate to idl
     And step "design.gate.answer" changes nothing
 
   Scenario: three rejects rest at the steer gate, a steered rerun lands and runs to idle
-    Given step "seam.naive" writes "src/calc.ts" with:
+    Given step "seam.check" changes nothing
+    And step "seam.naive" writes "src/acceptance.test.ts" with:
+      """
+      it("[AC-1] holds", () => {})
+      """
+    And step "seam.naive" writes "src/calc.ts" with:
       """
       export const add = (a: number, b: number) => b + a
       """
@@ -87,6 +92,10 @@ Feature: rejected naive passes walk one fixed path through the steer gate to idl
       - AC-1: the change behaves as described.
       """
     And step "seam.naive" from now on changes nothing
+    And step "seam.naive" writes "src/acceptance.test.ts" with:
+      """
+      it("[AC-1] holds", () => {})
+      """
     And step "seam.naive" writes "src/calc.ts" with:
       """
       export const add = (a: number, b: number) => a + b
@@ -127,14 +136,18 @@ Feature: rejected naive passes walk one fixed path through the steer gate to idl
       gtd(check): start-gate.check → design.triage
       gtd(agent): design.triage → design.gate.answer
       gtd(human): design.gate.answer → seam.naive
-      gtd(agent): seam.naive → seam.judge
+      gtd(agent): seam.naive → seam.check
+      gtd(check): seam.check → seam.judge
       gtd(judge): seam.judge → seam.naive
-      gtd(agent): seam.naive → seam.judge
+      gtd(agent): seam.naive → seam.check
+      gtd(check): seam.check → seam.judge
       gtd(judge): seam.judge → seam.naive
-      gtd(agent): seam.naive → seam.judge
+      gtd(agent): seam.naive → seam.check
+      gtd(check): seam.check → seam.judge
       gtd(judge): seam.judge → seam.steer
       gtd(human): seam.steer → seam.naive
-      gtd(agent): seam.naive → seam.judge
+      gtd(agent): seam.naive → seam.check
+      gtd(check): seam.check → seam.judge
       gtd(judge): seam.judge → implement.building
       gtd(agent): implement.building → implement.health.check
       gtd(check): implement.health.check → implement.closing
@@ -144,7 +157,7 @@ Feature: rejected naive passes walk one fixed path through the steer gate to idl
       gtd(check): build.review.closing → idle
       """
     And the commit "gtd(human): idle → unwind" has a body containing "Gtd-Var: flag_risk_tier=0"
-    And the commit "gtd(agent): seam.naive → seam.judge" has a body containing "Gtd-Kept:"
+    And the commit "gtd(agent): seam.naive → seam.check" has a body containing "Gtd-Kept:"
     And the commit "gtd(judge): seam.judge → seam.naive" has a body containing "\"answer\":\"reject\""
     And the commit "gtd(judge): seam.judge → seam.steer" has a body containing "\"answer\":\"reject\""
     And the commit "gtd(judge): seam.judge → implement.building" has a body containing "\"answer\":\"land\""