@pmelab/gtd 30.1.0 → 31.0.0

package/src/workflows/feature/criteria.ts

@@ -0,0 +1,168 @@
+import {
+  answered,
+  changes,
+  judge,
+  read,
+  refuse,
+  run,
+  scope,
+  type Change,
+} from "../../flows/index.js"
+import { markFenced } from "../shared/fences.js"
+import { REQUIREMENTS } from "../shared/steps.js"
+import * as t from "../shared/text.js"
+
+export interface Criterion {
+  readonly id: string
+  readonly text: string
+}
+
+/** Acceptance criteria the human's sketch stated outright, ready to normalise. */
+export interface StatedCriteria {
+  readonly path: string
+  readonly commit: string
+  /** The file as the sketch left it: `unwind` reverts it out of the tree. */
+  readonly text: string
+  readonly criteria: readonly Criterion[]
+}
+
+/** Below this the judge's `yes` is not trusted: a wrong skip builds against criteria nobody can check. */
+const CLEAR_MIN_P = 0.8
+
+const HEADING = /^ {0,3}(#{1,6})\s+(.*?)\s*#*\s*$/
+const ITEM = /^ ?(?:[-*+]|\d+[.)])\s+(?:\[[ xX]\]\s+)?(.*)$/
+const ID = /^(AC-\d+):\s*(.*)$/
+
+/** The list items under the first heading `title` matches (at `level` when given), up to the next heading; wrapped lines joined, fenced lines ignored. */
+const listUnder = (text: string, title: RegExp, level?: number): string[] | undefined => {
+  const lines = markFenced(text)
+  const at = lines.findIndex((l) => {
+    const heading = l.fenced ? null : HEADING.exec(l.line)
+    return (
+      heading !== null &&
+      (level === undefined || heading[1]!.length === level) &&
+      title.test(heading[2]!)
+    )
+  })
+  if (at === -1) return undefined
+  const items: string[] = []
+  let open = false
+  for (const { line, fenced } of lines.slice(at + 1)) {
+    if (fenced) {
+      open = false
+      continue
+    }
+    if (HEADING.test(line)) break
+    const item = ITEM.exec(line)
+    if (item !== null) {
+      items.push(item[1]!.trim())
+      open = true
+    } else if (open && line.trim() !== "") {
+      items[items.length - 1] = `${items.at(-1)!} ${line.trim()}`.trim()
+    } else open = false
+  }
+  return items
+}
+
+/** The `- AC-<n>: …` list of `## Acceptance Criteria`, or `undefined` when the section is missing. */
+export const criteriaOf = (text: string): readonly Criterion[] | undefined =>
+  listUnder(text, /^acceptance criteria$/i, 2)?.map((item) => {
+    const id = ID.exec(item)
+    return id === null ? { id: "", text: item } : { id: id[1]!, text: id[2]! }
+  })
+
+/** Items numbered `AC-1`…, unless every one already carries its own distinct ID. */
+const numbered = (items: readonly string[]): Criterion[] => {
+  const ids = items.map((item) => ID.exec(item))
+  const own = ids.every((id) => id !== null) && new Set(ids.map((id) => id![1])).size === ids.length
+  return items.map((item, i) =>
+    own
+      ? { id: ids[i]![1]!, text: ids[i]![2]! }
+      : { id: `AC-${i + 1}`, text: item.replace(ID, "$2") },
+  )
+}
+
+const STATED = /^acceptance criteria:?$/i
+
+const statedItems = (text: string | undefined): string[] =>
+  text === undefined ? [] : (listUnder(text, STATED) ?? []).filter((item) => item !== "")
+
+/**
+ * The criteria a `TODO.md` in the sketch `sketch` (the idle turn's changes)
+ * added or changed under an `Acceptance criteria` heading. More than one such
+ * file is ambiguous, and any other change in the sketch is input only triage
+ * folds in, so none.
+ */
+export const statedCriteria = (
+  sketch: readonly Change[],
+  commit: string,
+): StatedCriteria | undefined => {
+  const found = sketch.flatMap((change) => {
+    if (!/(^|\/)TODO\.md$/.test(change.path) || change.after === undefined) return []
+    const items = statedItems(change.after)
+    if (items.length === 0 || items.join("\n") === statedItems(change.before).join("\n")) return []
+    return [{ path: change.path, commit, text: change.after, criteria: numbered(items) }]
+  })
+  return found.length === 1 && sketch.length === 1 ? found[0] : undefined
+}
+
+const listing = (criteria: readonly Criterion[]): string => criteria.map(t.criterionLine).join("\n")
+
+/** Refuse a turn that leaves `file` without ID'd acceptance criteria. A deleted file is `requireProgress`'s call. */
+export const requireCriteria = (file: string): void => {
+  const text = read(file)
+  if (text === undefined) return
+  const criteria = criteriaOf(text) ?? []
+  const unnamed = criteria.filter((c) => c.id === "")
+  const ids = criteria.map((c) => c.id).filter((id) => id !== "")
+  const twice = ids.filter((id, i) => ids.indexOf(id) !== i)
+  if (criteria.length > 0 && unnamed.length === 0 && twice.length === 0) return
+  const why =
+    criteria.length === 0
+      ? `no "## Acceptance Criteria" list`
+      : unnamed.length > 0
+        ? `${unnamed.length} criterion without an ID:\n${unnamed.map((c) => `  - ${c.text}`).join("\n")}`
+        : `duplicate IDs: ${[...new Set(twice)].join(", ")}`
+  refuse(
+    `gtd land: acceptance-criteria: ${file} has ${why} — list every criterion under "## Acceptance Criteria" as "- AC-<n>: <checkable criterion>", each ID unique and never reused`,
+  )
+}
+
+/** Refuse a turn that changed the acceptance criteria in `file`: after the design gate only another design lap may. */
+export const requireCriteriaFrozen = (file: string): void => {
+  const change = changes().get(file)
+  if (change === undefined) return
+  const before = listing(criteriaOf(change.before ?? "") ?? [])
+  if (before === listing(criteriaOf(change.after ?? "") ?? [])) return
+  refuse(
+    `gtd land: criteria-frozen: the acceptance criteria in ${file} are settled — restore them; only a design lap changes them`,
+  )
+}
+
+/** Whether the judge trusts `stated` as clear and checkable, every criterion of it. Truncated evidence never is. */
+const clear = async (stated: StatedCriteria): Promise<boolean> => {
+  const { answers, truncated } = await judge("clear", {
+    questions: [t.clearCriteriaQuestion],
+    evidence: { criteria: listing(stated.criteria), sketch: stated.text },
+    message: t.clearCriteriaMessage(),
+    label: "Judging the stated acceptance criteria",
+  })
+  return truncated.length === 0 && answered(answers.clear, "yes", CLEAR_MIN_P)
+}
+
+/**
+ * The skip path: when the sketch stated clear, checkable criteria, write them
+ * to `.gtd/REQUIREMENTS.md` as they are and resolve `true` — no triage, no
+ * design gate. `false` when design must run.
+ */
+export const skipDesign = (stated: StatedCriteria | undefined): Promise<boolean> =>
+  stated === undefined
+    ? Promise.resolve(false)
+    : scope("design", async () => {
+        if (!(await clear(stated))) return false
+        await run("normalise", t.normaliseCriteriaScript(stated), {
+          label: "Recording the stated acceptance criteria",
+          file: REQUIREMENTS,
+        })
+        return true
+      })

package/src/workflows/feature/fast-path.feature

@@ -48,6 +48,10 @@ Feature: a trivial change takes the same few beats at either risk tier, flag-fre
       ## Risk Tier
 
       <tier> — one-line copy fix
+
+      ## Acceptance Criteria
+
+      - AC-1: the change behaves as described.
       """
     When the process is driven
     Then the process rests at "seam.naive"

package/src/workflows/feature/feature.test.ts

@@ -72,7 +72,10 @@ describe("planAndBuild", () => {
           unwind: () => undefined,
           "start-gate.check": () => undefined,
           "design.triage": (_, r) =>
-            r.write(".gtd/REQUIREMENTS.md", "# Requirements\n\n## Concerns\n\n### S\n\n- `s`\n"),
+            r.write(
+              ".gtd/REQUIREMENTS.md",
+              "# Requirements\n\n## Concerns\n\n### S\n\n- `s`\n\n## Acceptance Criteria\n\n- AC-1: done\n",
+            ),
           "design.gate.answer": () => undefined,
           "seam.naive": (_, r) => r.write("src/calc.ts", SUBTRACT),
           "seam.judge": () => '[{"id":"shape","answer":"refactor-first","p":0.9}]',
@@ -102,7 +105,7 @@ describe("planAndBuild", () => {
     const requirements = (_: unknown, r: typeof repo) =>
       r.write(
         ".gtd/REQUIREMENTS.md",
-        "# Requirements\n\n## Concerns\n\n### Subtract\n\n- `subtract`\n",
+        "# Requirements\n\n## Concerns\n\n### Subtract\n\n- `subtract`\n\n## Acceptance Criteria\n\n- AC-1: done\n",
       )
     const lap = {
       unwind: () => undefined,
@@ -134,7 +137,11 @@ describe("planAndBuild", () => {
     const rest = await repo.drive({
       "build.review.closing": runsItsScript,
       "re-unwind": runsItsScript,
-      "design.triage": (_, r) => r.write(".gtd/REQUIREMENTS.md", "# Requirements\n\n- multiply\n"),
+      "design.triage": (_, r) =>
+        r.write(
+          ".gtd/REQUIREMENTS.md",
+          "# Requirements\n\n- multiply\n\n## Acceptance Criteria\n\n- AC-1: done\n",
+        ),
       "design.gate.answer": () => undefined,
     })
     expect(rest.state).toBe("implement.building")
@@ -186,7 +193,10 @@ describe("afterTail feedback lap", () => {
     await repo.land()
     await repo.drive({
       "build.review.collecting": (_, r) => {
-        r.write(".gtd/REQUIREMENTS.md", "# Requirements\n\n- multiply\n")
+        r.write(
+          ".gtd/REQUIREMENTS.md",
+          "# Requirements\n\n- multiply\n\n## Acceptance Criteria\n\n- AC-1: done\n",
+        )
         r.write(".gtd/REVIEW.md", `${review("also export multiply")}    - A: noted.\n`)
       },
     })
@@ -199,7 +209,10 @@ describe("afterTail feedback lap", () => {
     "build.review.closing": runsItsScript,
     "re-unwind": runsItsScript,
     "design.triage": (_: unknown, r: ReturnType<typeof testRepo>) =>
-      r.write(".gtd/REQUIREMENTS.md", "# Requirements\n\n- multiply, designed\n"),
+      r.write(
+        ".gtd/REQUIREMENTS.md",
+        "# Requirements\n\n- multiply, designed\n\n## Acceptance Criteria\n\n- AC-1: done\n",
+      ),
     "design.gate.answer": () => undefined,
   }
 
@@ -221,7 +234,10 @@ describe("afterTail feedback lap", () => {
     expect(prompts[0]).toContain("it covers everything since the base")
     expect(prompts[0]).not.toContain("only what is new since the previous review")
     const writes: Record<string, () => [string, string]> = {
-      "design.triage": () => [".gtd/REQUIREMENTS.md", "# Requirements\n\n- multiply, designed\n"],
+      "design.triage": () => [
+        ".gtd/REQUIREMENTS.md",
+        "# Requirements\n\n- multiply, designed\n\n## Acceptance Criteria\n\n- AC-1: done\n",
+      ],
       "implement.building": () => ["src/calc.ts", `${CALC}// again\n`],
     }
     const actors = new Proxy({} as Record<string, Actor>, {
@@ -295,13 +311,20 @@ describe("an in-flight 28.0.0 naive-pass process", () => {
     from: string,
     to: string,
   ) => {
-    if (from === "seam.steer") repo.write(".gtd/REQUIREMENTS.md", "# Requirements\n\n- steered\n")
+    if (from === "seam.steer")
+      repo.write(
+        ".gtd/REQUIREMENTS.md",
+        "# Requirements\n\n- steered\n\n## Acceptance Criteria\n\n- AC-1: done\n",
+      )
     if (from === "build.review.reviewing") repo.write(".gtd/REVIEW.md", review())
     if (to === "build.review.collecting")
       repo.write(".gtd/REVIEW.md", review("also export multiply"))
     if (from === "build.review.collecting") {
       repo.write(".gtd/REVIEW.md", `${review("also export multiply")}    - A: noted.\n`)
-      repo.write(".gtd/REQUIREMENTS.md", "# Requirements\n\n- multiply\n")
+      repo.write(
+        ".gtd/REQUIREMENTS.md",
+        "# Requirements\n\n- multiply\n\n## Acceptance Criteria\n\n- AC-1: done\n",
+      )
     }
     if (to === "build.review.closing") repo.write(".gtd/REVIEW.md", review())
   }
@@ -313,7 +336,10 @@ describe("an in-flight 28.0.0 naive-pass process", () => {
       unwind: () => undefined,
       "start-gate.check": () => undefined,
       "design.triage": (_, r) =>
-        r.write(".gtd/REQUIREMENTS.md", "# Requirements\n\n## Concerns\n\n### S\n\n- `s`\n"),
+        r.write(
+          ".gtd/REQUIREMENTS.md",
+          "# Requirements\n\n## Concerns\n\n### S\n\n- `s`\n\n## Acceptance Criteria\n\n- AC-1: done\n",
+        ),
       "design.gate.answer": () => undefined,
       "seam.naive": (_, r) => r.write("src/calc.ts", `${CALC}// naive\n`),
     })
@@ -356,7 +382,8 @@ describe("an in-flight 28.0.0 naive-pass process", () => {
 })
 
 describe("an in-flight process from before the architecture path was removed", () => {
-  const REQUIREMENTS = "# Requirements\n\n## Concerns\n\n### Subtract\n\n- `subtract`\n"
+  const REQUIREMENTS =
+    "# Requirements\n\n## Concerns\n\n### Subtract\n\n- `subtract`\n\n## Acceptance Criteria\n\n- AC-1: done\n"
 
   /** Its history up to the design gate, forged with the old opening commit's `flag_naive_pass=0`. */
   const atDesignGate = async () => {
@@ -416,7 +443,10 @@ describe("flagMode", () => {
       unwind: () => undefined,
       "start-gate.check": () => undefined,
       "design.triage": (_, r) =>
-        r.write(".gtd/REQUIREMENTS.md", "# Requirements\n\n## Concerns\n\n### S\n\n- `s`\n"),
+        r.write(
+          ".gtd/REQUIREMENTS.md",
+          "# Requirements\n\n## Concerns\n\n### S\n\n- `s`\n\n## Acceptance Criteria\n\n- AC-1: done\n",
+        ),
       "design.gate.answer": () => undefined,
     })
   }

package/src/workflows/feature/feature.ts

@@ -13,6 +13,7 @@ import { flagModeOn, shipped } from "../shared/options.js"
 import { FEEDBACK } from "../shared/steps.js"
 import { refusePendingHandOff } from "../shared/tail.js"
 import * as t from "../shared/text.js"
+import { skipDesign, statedCriteria, type StatedCriteria } from "./criteria.js"
 import { design } from "./planning.js"
 import { buildTail, isCode, reUnwind, type ReviewOutcome } from "./review.js"
 import { implement, seamBuild, type SeamOutcome } from "./seam.js"
@@ -54,9 +55,10 @@ export const buildFeature = async (firstBase: string): Promise<void> => {
   })
 }
 
-/** Design, then `buildFeature`. */
-export const planAndBuild = async (firstBase: string): Promise<void> => {
-  await design(firstBase)
+/** Design — skipped when the sketch's own criteria are judged clear — then `buildFeature`. */
+export const planAndBuild = async (firstBase: string, stated?: StatedCriteria): Promise<void> => {
+  // GTD_FLAG_RISK_TIER: the tier is proposed at triage and set at the design gate, so no skip.
+  if (!(await skipDesign(riskTierOn() ? undefined : stated))) await design(firstBase)
   await buildFeature(firstBase)
 }
 
@@ -80,6 +82,7 @@ export const ordinaryStart = async (): Promise<void> => {
   refusePendingHandOff()
   // Read right after idle, so a bad value refuses the landing that would pin it.
   flagModeOn()
+  const stated = statedCriteria(changes(), head())
   await unwind()
   if (changes(FEEDBACK).some((c) => c.status !== "deleted")) {
     await human("unwind-failed", {
@@ -89,7 +92,7 @@ export const ordinaryStart = async (): Promise<void> => {
     })
   }
   await gate("start-gate", t.startGateBlockedMessage())
-  await planAndBuild(start())
+  await planAndBuild(start(), stated)
 }
 
 export const feature = shipped(ordinaryStart)

package/src/workflows/feature/flag-mode.feature

@@ -36,6 +36,10 @@ Feature: flag mode off builds a feature with no release flag, seam judge or refa
       ### Subtract
 
       - `subtract(a, b)` returns `a - b`.
+
+      ## Acceptance Criteria
+
+      - AC-1: the change behaves as described.
       """
     And step "design.gate.answer" changes nothing
 
@@ -116,6 +120,10 @@ Feature: flag mode off builds a feature with no release flag, seam judge or refa
       ### Multiply
 
       - Export `multiply()`.
+
+      ## Acceptance Criteria
+
+      - AC-1: the change behaves as described.
       """
     And step "build.review.collecting" writes ".gtd/REVIEW.md" with:
       """

package/src/workflows/feature/index.ts

@@ -1,6 +1,7 @@
 import { feature } from "./feature.js"
 
 export * from "./steps.js"
+export * from "./criteria.js"
 export * from "./planning.js"
 export * from "./refactor.js"
 export * from "./seam.js"

package/src/workflows/feature/one-step-land.feature

@@ -34,6 +34,10 @@ Feature: a naive pass the judge rules land goes straight to implement with no se
       ### Typo
 
       - greeting reads "Hello, world".
+
+      ## Acceptance Criteria
+
+      - AC-1: the change behaves as described.
       """
     And step "design.gate.answer" changes nothing
     And step "seam.naive" writes "src/greeting.ts" with:

package/src/workflows/feature/planning.ts

@@ -8,6 +8,7 @@ import {
   scope,
 } from "../../flows/index.js"
 import { REQUIREMENTS } from "../shared/steps.js"
+import { requireCriteria } from "./criteria.js"
 import { answerProductQuestions, triage } from "./steps.js"
 
 /**
@@ -31,5 +32,6 @@ export const design = (base: string): Promise<void> =>
       await triage(base)
       requireProgress(REQUIREMENTS)
       requireReplies(REQUIREMENTS)
+      requireCriteria(REQUIREMENTS)
     } while (await noteGate(REQUIREMENTS, answerProductQuestions))
   })

package/src/workflows/feature/refactor-absorbs.feature

@@ -35,6 +35,10 @@ Feature: a refactor that carried the whole feature still gets a feature review
       ### Subtract
 
       - `subtract(a, b)` returns `a - b`.
+
+      ## Acceptance Criteria
+
+      - AC-1: the change behaves as described.
       """
     And step "design.gate.answer" changes nothing
 

package/src/workflows/feature/refactor-first.feature

@@ -34,6 +34,10 @@ Feature: a refactor-first judgment walks one fixed path to idle
       ### Subtract
 
       - `subtract(a, b)` returns `a - b`.
+
+      ## Acceptance Criteria
+
+      - AC-1: the change behaves as described.
       """
     And step "design.gate.answer" changes nothing
 

package/src/workflows/feature/refactor-review.feature

@@ -46,6 +46,10 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
       ### Subtract
 
       - `subtract(a, b)` returns `a - b`.
+
+      ## Acceptance Criteria
+
+      - AC-1: the change behaves as described.
       """
     And step "design.gate.answer" changes nothing
     And step "seam.naive" writes "src/calc.ts" with:
@@ -126,6 +130,10 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
       ### Subtract
 
       - `subtract(a, b)` returns `a - b`.
+
+      ## Acceptance Criteria
+
+      - AC-1: the change behaves as described.
       """
     And step "design.gate.answer" changes nothing
     And step "seam.naive" writes "src/calc.ts" with:
@@ -205,6 +213,10 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
         ### Subtract
 
         - `subtract(a, b)` returns `a - b`.
+
+        ## Acceptance Criteria
+
+        - AC-1: the change behaves as described.
         """
       And step "design.gate.answer" changes nothing
       And step "seam.naive" writes "src/calc.ts" with:
@@ -449,6 +461,10 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
         # Requirements
 
         - multiply, designed
+
+        ## Acceptance Criteria
+
+        - AC-1: the change behaves as described.
         """
       And step "implement.building" writes "src/calc.ts" with:
         """
@@ -1404,6 +1420,10 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
         ### Subtract
 
         - `subtract(a, b)` returns `a - b`.
+
+        ## Acceptance Criteria
+
+        - AC-1: the change behaves as described.
         """
       And step "design.gate.answer" changes nothing
       And step "seam.naive" writes "src/calc.ts" with:
@@ -1582,6 +1602,10 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
         ### Subtract
 
         - `subtract(a, b)` returns `a - b`.
+
+        ## Acceptance Criteria
+
+        - AC-1: the change behaves as described.
         """
       And step "design.gate.answer" changes nothing
       And judge step "seam.judge" answers:

package/src/workflows/feature/risk-tier.feature

@@ -49,6 +49,10 @@ Feature: the risk tier is proposed at triage and recorded behind GTD_FLAG_RISK_T
         ## Risk Tier
 
         low — trivial copy change
+
+        ## Acceptance Criteria
+
+        - AC-1: the change behaves as described.
         """
       And step "design.gate.answer" changes nothing
       When the process is driven
@@ -64,6 +68,10 @@ Feature: the risk tier is proposed at triage and recorded behind GTD_FLAG_RISK_T
         ## Risk Tier
 
         high — touches payments
+
+        ## Acceptance Criteria
+
+        - AC-1: the change behaves as described.
         """
       And step "design.gate.answer" changes nothing
       When the process is driven
@@ -80,6 +88,10 @@ Feature: the risk tier is proposed at triage and recorded behind GTD_FLAG_RISK_T
         ## Concerns
 
         ### Subtract
+
+        ## Acceptance Criteria
+
+        - AC-1: the change behaves as described.
         """
       And step "design.gate.answer" changes nothing
       When the process is driven
@@ -105,6 +117,10 @@ Feature: the risk tier is proposed at triage and recorded behind GTD_FLAG_RISK_T
 
         - error rate on /subtract stays flat
         - p95 latency
+
+        ## Acceptance Criteria
+
+        - AC-1: the change behaves as described.
         """
       And step "design.gate.answer" changes nothing
       When the process is driven
@@ -125,6 +141,10 @@ Feature: the risk tier is proposed at triage and recorded behind GTD_FLAG_RISK_T
         ## Risk Tier
 
         low — trivial copy change
+
+        ## Acceptance Criteria
+
+        - AC-1: the change behaves as described.
         """
       And step "seam.naive" writes "src/calc.ts" with:
         """
@@ -157,6 +177,10 @@ Feature: the risk tier is proposed at triage and recorded behind GTD_FLAG_RISK_T
         ## Concerns
 
         ### Subtract
+
+        ## Acceptance Criteria
+
+        - AC-1: the change behaves as described.
         """
       And step "design.gate.answer" changes nothing
       When the process is driven
@@ -199,6 +223,10 @@ Feature: the risk tier is proposed at triage and recorded behind GTD_FLAG_RISK_T
         ## Production Signals
 
         - error rate stays flat
+
+        ## Acceptance Criteria
+
+        - AC-1: the change behaves as described.
         """
       And step "design.gate.answer" changes nothing
       When the process is driven
@@ -220,6 +248,10 @@ Feature: the risk tier is proposed at triage and recorded behind GTD_FLAG_RISK_T
         ## Risk Tier
 
         low — trivial
+
+        ## Acceptance Criteria
+
+        - AC-1: the change behaves as described.
         """
       And step "design.gate.answer" changes nothing
       And step "seam.naive" writes "src/calc.ts" with:

package/src/workflows/feature/seam-rejection.feature

@@ -33,6 +33,10 @@ Feature: rejected naive passes walk one fixed path through the steer gate to idl
       ### Subtract
 
       - `subtract(a, b)` returns `a - b`.
+
+      ## Acceptance Criteria
+
+      - AC-1: the change behaves as described.
       """
     And step "design.gate.answer" changes nothing
 
@@ -77,6 +81,10 @@ Feature: rejected naive passes walk one fixed path through the steer gate to idl
       ### Subtract
 
       - `subtract(a, b)` returns `a - b`, in the calculator module.
+
+      ## Acceptance Criteria
+
+      - AC-1: the change behaves as described.
       """
     And step "seam.naive" from now on changes nothing
     And step "seam.naive" writes "src/calc.ts" with:

package/src/workflows/feature/seam.feature

@@ -43,6 +43,10 @@ Feature: the naive pass and seam judge decide how a feature is built
       ### Subtract
 
       - `subtract(a, b)` returns `a - b`.
+
+      ## Acceptance Criteria
+
+      - AC-1: the change behaves as described.
       """
     And step "design.gate.answer" changes nothing
 
@@ -184,6 +188,10 @@ Feature: the naive pass and seam judge decide how a feature is built
       ### Subtract
 
       - `subtract(a, b)` returns `a - b`, in a new module.
+
+      ## Acceptance Criteria
+
+      - AC-1: the change behaves as described.
       """
     When gtd lands
     Then the process rests at "seam.naive"

package/src/workflows/feature/seam.ts

@@ -16,6 +16,7 @@ import { healthy } from "../shared/health.js"
 import { coder, FEEDBACK, REQUIREMENTS } from "../shared/steps.js"
 import * as t from "../shared/text.js"
 import { defaults } from "../shared/vars.js"
+import { requireCriteria, requireCriteriaFrozen } from "./criteria.js"
 import { refactorStrays, reviewedRefactor } from "./refactor.js"
 import { flagModeOn } from "../shared/options.js"
 import type { RiskTier } from "./tier.js"
@@ -81,13 +82,16 @@ export function implement(
         ...(options.afterRefactor === true ? { allowEmpty: true } : {}),
       },
     )
-    await healthy(() =>
-      t.agentWithSkills("fix.suite.fixing", t.implementFixPrompt(), {
-        label: "Fixing the check",
-        file: FEEDBACK,
-        model: coder(),
-        system: t.builderSystem(),
-      }),
+    requireCriteriaFrozen(REQUIREMENTS)
+    await healthy(
+      () =>
+        t.agentWithSkills("fix.suite.fixing", t.implementFixPrompt(), {
+          label: "Fixing the check",
+          file: FEEDBACK,
+          model: coder(),
+          system: t.builderSystem(),
+        }),
+      { guard: () => requireCriteriaFrozen(REQUIREMENTS), guardRests: false },
     )
     await run("closing", removeScript([REQUIREMENTS]), { label: "Closing out the implementation" })
   })
@@ -124,6 +128,7 @@ const decide = (): Promise<Decision> =>
       })
       // Any edit steers, with a fresh budget and no stale rejection; clean overrules.
       if (changes().length === 0) return { reference: tip.hash }
+      requireCriteria(REQUIREMENTS)
       rejection = undefined
       retries = 0
     }

package/src/workflows/feature/tier-pin.feature

@@ -33,6 +33,10 @@ Feature: a process keeps the risk tier setting it started with when GTD_FLAG_RIS
       ## Risk Tier
 
       low — a new pure function
+
+      ## Acceptance Criteria
+
+      - AC-1: the change behaves as described.
       """
 
   Scenario: a process started with the flag off records no tier after the flag turns on