@pmelab/gtd 29.3.1 → 30.1.0

package/dist/workflows/feature.mjs

@@ -1,7 +1,7 @@
-import { answered, changes, changesSince, glob, hasThreadFor, head, human, judge, judgeDiffShape, kept, mark, matches, numeric, quote, read, refuse, removeScript, requireAnswers, requireProgress, requireReplies, requireRevert, requireThreadsClosed, restoreScript, revertScript, run, scope, slice, start, vars } from "../flows.mjs";
+import { answered, changes, changesSince, hasThreadFor, head, human, judge, judgeDiffShape, kept, mark, matches, numeric, quote, read, refuse, removeScript, requireAnswers, requireProgress, requireReplies, requireRevert, requireThreadsClosed, restoreScript, revertScript, run, scope, slice, start, vars } from "../flows.mjs";
 import { lensesOf, review as review$1 } from "../workflow-kit.mjs";
-import { $ as refactorFixPrompt, A as architectureDecomposePrompt, B as designSystem, C as planner, D as agentWithSkills, E as reviewing, F as buildReviewFixNitsPrompt, G as idleMessage, I as buildReviewTriageMessage, J as naivePassPrompt, K as implementBuildingPrompt, L as builderSystem, M as buildReviewAnswerQuestionsPrompt, N as buildReviewAwaitAfterDeferMessage, O as architectSystem, P as buildReviewCollectingPrompt, Q as refactorDroppedRefusal, R as deferNotesScript, S as fixRisks, V as designTriagePrompt, X as packagesItemFixSuitePrompt, Y as packagesItemBuildingPrompt, Z as refactorBuildingPrompt, _ as REVIEW, at as reviewerSystem, b as fixCheck, ct as startGateBlockedMessage, d as healthy, dt as defaults, et as refactorRules, f as ARCHITECTURE, ft as envDefaults, g as REQUIREMENTS, h as REFACTOR, i as skills, it as reviewNotesCapture, j as architectureGateAnswerMessage, k as architectureAuthorPrompt, l as gate, lt as unwindFailedMessage, n as summary, nt as reviewEditsCapture, o as shipped, ot as seamByHandMessage, p as FEEDBACK, pt as testFileGlobs, q as implementFixPrompt, r as access, st as seamSteerMessage, t as steering, tt as reviewEditNotesCapture, u as guarded, ut as unwindFailure, v as awaitReview, w as reviewMissing, y as coder, z as designGateAnswerMessage } from "../chunks/reserved-Dmpg6dAp.mjs";
-import { a as refusePendingHandOff, i as isOptionalObject, n as closeReview, o as tail } from "../chunks/tail-CLyE5VFR.mjs";
+import { $ as reviewerSystem, A as buildReviewCollectingPrompt, C as planner, D as agentWithSkills, E as reviewing, F as designGateAnswerMessage, G as refactorBuildingPrompt, H as implementBuildingPrompt, I as designSystem, J as refactorRules, K as refactorDroppedRefusal, L as designTriagePrompt, M as buildReviewTriageMessage, N as builderSystem, O as buildReviewAnswerQuestionsPrompt, P as deferNotesScript, Q as reviewNotesCapture, S as fixRisks, U as implementFixPrompt, V as idleMessage, W as naivePassPrompt, X as reviewEditsCapture, Y as reviewEditNotesCapture, _ as REVIEW, a as flagModeOn, at as defaults, b as fixCheck, d as guarded, et as seamByHandMessage, f as healthy, g as REQUIREMENTS, h as REFACTOR, i as skills, it as unwindFailure, j as buildReviewFixNitsPrompt, k as buildReviewAwaitAfterDeferMessage, n as summary, nt as startGateBlockedMessage, ot as envDefaults, p as FEEDBACK, q as refactorFixPrompt, r as access, rt as unwindFailedMessage, s as shipped, st as testFileGlobs, t as steering, tt as seamSteerMessage, u as gate, v as awaitReview, w as reviewMissing, y as coder } from "../chunks/reserved-DDiiAZ8U.mjs";
+import { a as refusePendingHandOff, i as isOptionalObject, n as closeReview, o as tail } from "../chunks/tail-ILPlELuy.mjs";
 //#region src/workflows/shared/fences.ts
 const markFenced = (text) => {
 	let fence;
@@ -18,8 +18,8 @@ const markFenced = (text) => {
 };
 //#endregion
 //#region src/workflows/feature/tier.ts
-/** GTD_FLAG_NAIVE_PASS, GTD_FLAG_RISK_TIER: both pinned at process start, so a mid-process flip never moves a process. */
-const riskTierOn = () => vars.flag_naive_pass === "1" && vars.flag_risk_tier === "1";
+/** GTD_FLAG_RISK_TIER: pinned at process start, so a mid-process flip never moves a process. */
+const riskTierOn = () => vars.flag_risk_tier === "1";
 const sectionLines = (text, title) => {
 	if (text === void 0) return [];
 	const heading = new RegExp(`^##[ \\t]+${title}[ \\t]*$`, "i");
@@ -63,18 +63,6 @@ const triage = (base) => agentWithSkills("triage", designTriagePrompt(base, risk
 	model: planner(),
 	system: designSystem()
 });
-const author = () => agentWithSkills("author", architectureAuthorPrompt(), {
-	label: "Refining the technical plan",
-	file: ARCHITECTURE,
-	mode: "qa",
-	model: planner(),
-	system: architectSystem()
-});
-const decompose = () => agentWithSkills("decompose.decomposing", architectureDecomposePrompt(), {
-	label: "Decomposing into packages",
-	model: planner(),
-	system: architectSystem()
-});
 const answerProductQuestions = () => human("gate.answer", {
 	message: designGateAnswerMessage(riskTierOn()),
 	label: "Awaiting your product answers",
@@ -82,24 +70,6 @@ const answerProductQuestions = () => human("gate.answer", {
 	mode: "qa",
 	acceptClean: true
 });
-const answerTechnicalQuestions = () => human("gate.answer", {
-	message: architectureGateAnswerMessage(),
-	label: "Awaiting your technical answers",
-	file: ARCHITECTURE,
-	mode: "qa",
-	acceptClean: true
-});
-const build = (pkg) => agentWithSkills("building", packagesItemBuildingPrompt(pkg), {
-	label: "Building",
-	model: coder(),
-	system: builderSystem()
-});
-const fixSuite = () => agentWithSkills("fix.suite.fixing", packagesItemFixSuitePrompt(), {
-	label: "Fixing the check",
-	file: FEEDBACK,
-	model: coder(),
-	system: builderSystem()
-});
 /** Answer every `question` note inline in `.gtd/REVIEW.md`. */
 const answerReviewQuestions = (notes) => agentWithSkills("review.answer-review-questions", buildReviewAnswerQuestionsPrompt(notes), {
 	label: "Answering your questions",
@@ -147,113 +117,6 @@ const deferNotes = (notes, round) => run("review.defer", deferNotesScript(notes,
 	file: ".gtd/TODO.md"
 });
 //#endregion
-//#region src/workflows/feature/packages.ts
-const TEST_LINE = /^-\s+(unit|e2e):\s+`([^`]+)`(.*)$/;
-const MARKER = /^[ \t]+\(unchanged\)(?=\s|$)/i;
-const ITEM = /^\s*-\s/;
-/** The `## Tests` entries of a package file; malformed entries are ignored. */
-const declaredTests = (packageText) => {
-	const found = [];
-	let inTests = false;
-	let entry;
-	const flush = () => {
-		const match = entry === void 0 ? null : TEST_LINE.exec(entry);
-		if (match) found.push({
-			level: match[1],
-			path: match[2],
-			unchanged: MARKER.test(match[3])
-		});
-		entry = void 0;
-	};
-	for (const line of packageText.replace(/\r\n?/g, "\n").split("\n")) if (/^##\s/.test(line)) {
-		flush();
-		inTests = /^##\s+Tests\s*$/.test(line);
-	} else if (!inTests) continue;
-	else if (ITEM.test(line)) {
-		flush();
-		entry = line.trim();
-	} else if (entry !== void 0 && /^\s/.test(line) && line.trim() !== "") entry = `${entry} ${line.trim()}`;
-	else flush();
-	flush();
-	return found;
-};
-const diffBucket = (test, status, turn, satisfied) => {
-	if (test.unchanged) {
-		if (turn !== "build") return void 0;
-		if (status === "modified") return "modifiedMarked";
-		return status === "added" ? "addedMarked" : void 0;
-	}
-	return !satisfied && (status === void 0 || status === "deleted") ? "notInDiff" : void 0;
-};
-const treeBucket = (test, status) => {
-	if (read(test.path) !== void 0) return void 0;
-	return test.unchanged && status === "deleted" ? "deletedMarked" : "notInTree";
-};
-const unmetBucket = (test, change, turn, satisfied) => diffBucket(test, change?.status, turn, satisfied) ?? treeBucket(test, change?.status);
-/**
-* Refuse a build or fix turn unless every test `pkg` declares exists and is in the
-* diff since `since`. The package text is read as of `since`, so a builder
-* editing its own `## Tests` (or adding `(unchanged)`) cannot dodge the guard;
-* with `.gtd/SATISFIED.md` written, or the line marked, existing suffices. The
-* build turn must neither modify nor add a marked test; a fix turn may edit it.
-*/
-const requireDeclaredTests = (pkg, since, turn = "fix") => {
-	const range = changesSince(since);
-	const text = range.get(pkg)?.before ?? read(pkg) ?? "";
-	const satisfied = read(".gtd/SATISFIED.md") !== void 0;
-	const buckets = {
-		notInDiff: [],
-		modifiedMarked: [],
-		addedMarked: [],
-		deletedMarked: [],
-		notInTree: []
-	};
-	const entries = declaredTests(text);
-	const seen = /* @__PURE__ */ new Set();
-	for (const test of entries) {
-		if (test.unchanged && entries.some((e) => !e.unchanged && e.path === test.path)) continue;
-		const bucket = unmetBucket(test, range.get(test.path), turn, satisfied);
-		if (bucket && !seen.has(test.path)) {
-			seen.add(test.path);
-			buckets[bucket].push(test.path);
-		}
-	}
-	const { notInDiff, modifiedMarked, addedMarked, deletedMarked, notInTree } = buckets;
-	const reasons = [
-		["not in the package's diff — write them", notInDiff],
-		["marked (unchanged) but modified — revert them", modifiedMarked],
-		["marked (unchanged) but added by this turn — the marker promises an existing test; stop and leave it to a person", addedMarked],
-		["marked (unchanged) but deleted — restore them", deletedMarked],
-		["missing from the tree", notInTree]
-	].filter(([, paths]) => paths.length > 0);
-	if (reasons.length === 0) return;
-	refuse(`gtd land: declared-tests: ${pkg} declares tests this turn left unmet:\n${reasons.map(([reason, paths]) => `${reason}:\n${paths.map((path) => `  - ${path}`).join("\n")}`).join("\n")}`);
-};
-/**
-* Build `pkg`, check its declared tests, keep the full suite green, and close
-* it out, which removes it — and `.gtd/ARCHITECTURE.md` with the last one.
-*/
-const packageItem = async (pkg) => {
-	const from = head();
-	const declared = (turn, kind) => async () => {
-		await turn();
-		requireDeclaredTests(pkg, from, kind);
-	};
-	await declared(() => build(pkg), "build")();
-	await healthy(declared(fixSuite, "fix"));
-	await run("closing", removeScript([
-		pkg,
-		".gtd/SATISFIED.md",
-		...glob(".gtd/packages/*.md").length === 1 ? [ARCHITECTURE] : []
-	]), { label: "Closing out the package" });
-};
-/** The first queued package — the one a package step works on. */
-const nextPackage = () => [...glob(".gtd/packages/*.md")].sort()[0];
-/** Build every package file under `.gtd/packages/`, in name order. */
-const packages = () => scope("packages", async () => {
-	for (let pkg = nextPackage(); pkg !== void 0; pkg = nextPackage()) await scope("item", () => packageItem(pkg));
-});
-//#endregion
 //#region src/workflows/feature/planning.ts
 /**
 * Always stop for the human. Resolves `true` when the round changed anything
@@ -276,16 +139,6 @@ const design = (base) => scope("design", async () => {
 		requireReplies(REQUIREMENTS);
 	} while (await noteGate(REQUIREMENTS, answerProductQuestions));
 });
-/** Work out the technical plan, then decompose it into package files. */
-const architecture = () => scope("architecture", async () => {
-	do {
-		await author();
-		requireReplies(ARCHITECTURE);
-	} while (await noteGate(ARCHITECTURE, answerTechnicalQuestions));
-	await decompose();
-	if (changes(".gtd/packages/**").length === 0) refuse("gtd land: decompose: write at least one package under .gtd/packages/");
-	if (changes(".gtd/ARCHITECTURE.md").some((c) => c.status === "deleted")) refuse("gtd land: decompose: keep .gtd/ARCHITECTURE.md — the packages are built from it; it is removed with the last package");
-});
 //#endregion
 //#region src/workflows/feature/review.ts
 const VERDICTS = [
@@ -772,7 +625,7 @@ function implement(first, tier, amend) {
 		amend
 	};
 	return scope("implement", async () => {
-		await agentWithSkills("building", implementBuildingPrompt(options.reference, options.tier, options.amend, options.afterRefactor), {
+		await agentWithSkills("building", implementBuildingPrompt(options.reference, options.tier, options.amend, options.afterRefactor, flagModeOn()), {
 			label: "Implementing",
 			model: coder(),
 			system: builderSystem(),
@@ -853,29 +706,10 @@ const unwind = () => {
 	const commit = head();
 	return run("unwind", revertScript(commit, FEEDBACK, unwindFailure(commit)), { label: "Unwinding your input" });
 };
-/** Plan, build and review until a review round signs off; feedback re-plans from scratch. */
-const planAndBuild = async (firstBase, firstLap = "first") => {
-	if (vars.flag_naive_pass === "1") return naivePlanAndBuild(firstBase);
-	let base = firstBase;
-	let lap = firstLap;
-	for (;;) {
-		await design(base);
-		await architecture();
-		await packages();
-		const outcome = await buildTail(base, {
-			green: true,
-			lap
-		});
-		if (outcome.verdict === "signoff") return;
-		await reUnwind(outcome);
-		base = outcome.base;
-		lap = "feedback";
-	}
-};
-const naivePlanAndBuild = async (firstBase) => {
-	await design(firstBase);
+/** A judged naive pass (none with `flagMode` off), then implement and review until a review round signs off; design must have run since `firstBase`. */
+const buildFeature = async (firstBase) => {
 	const tier = riskTierOn() ? recordRisk() : void 0;
-	const seam = await seamBuild(firstBase);
+	const seam = flagModeOn() ? await seamBuild(firstBase) : { base: firstBase };
 	await slice("feature", async () => {
 		await implement({
 			reference: seam.reference,
@@ -889,6 +723,11 @@ const naivePlanAndBuild = async (firstBase) => {
 		}), base);
 	});
 };
+/** Design, then `buildFeature`. */
+const planAndBuild = async (firstBase) => {
+	await design(firstBase);
+	await buildFeature(firstBase);
+};
 const featureFeedback = async (first, lensBase) => {
 	let outcome = first;
 	while (outcome.verdict === "feedback") {
@@ -906,12 +745,7 @@ const featureFeedback = async (first, lensBase) => {
 	}
 };
 /** After a tail that skipped planning: stop on sign-off, re-plan on feedback. Opens no slice: slices cannot nest. */
-const afterTail = async (outcome) => {
-	if (outcome.verdict === "signoff") return;
-	if (vars.flag_naive_pass === "1") return featureFeedback(outcome);
-	await reUnwind(outcome);
-	await planAndBuild(outcome.base, "feedback");
-};
+const afterTail = (outcome) => featureFeedback(outcome);
 /** An ordinary start: wait at `idle`, unwind the sketch, check the baseline, then plan and build. */
 const ordinaryStart = async () => {
 	await human("idle", {
@@ -920,6 +754,7 @@ const ordinaryStart = async () => {
 		file: ".gtd/TODO.md"
 	});
 	refusePendingHandOff();
+	flagModeOn();
 	await unwind();
 	if (changes(".gtd/FEEDBACK.md").some((c) => c.status !== "deleted")) await human("unwind-failed", {
 		message: unwindFailedMessage(),
@@ -934,4 +769,4 @@ const feature = shipped(ordinaryStart);
 //#region src/workflows/feature/index.ts
 var feature_default = feature;
 //#endregion
-export { REFACTOR_PACKAGE, access, afterTail, answerProductQuestions, answerReviewQuestions, answerTechnicalQuestions, architecture, author, build, buildTail, collecting, declaredTests, decompose, feature_default as default, defaults, deferNotes, design, envDefaults, feature, fixNits, fixSuite, implement, judgeSeam, naivePass, nextPackage, ordinaryStart, packageItem, packages, planAndBuild, reUnwind, refactorCollecting, refactorFirst, refactorStrays, requireDeclaredTests, requireNoNewFlags, requireNoTestFiles, requireTestCallSitesOnly, requireWithin, reviewedRefactor, seamBuild, skills, steering, summary, triage, unwind };
+export { REFACTOR_PACKAGE, access, afterTail, answerProductQuestions, answerReviewQuestions, buildFeature, buildTail, collecting, feature_default as default, defaults, deferNotes, design, envDefaults, feature, fixNits, implement, judgeSeam, naivePass, ordinaryStart, planAndBuild, reUnwind, refactorCollecting, refactorFirst, refactorStrays, requireNoNewFlags, requireNoTestFiles, requireTestCallSitesOnly, requireWithin, reviewedRefactor, seamBuild, skills, steering, summary, triage, unwind };

package/dist/workflows/fix.mjs

@@ -1,7 +1,7 @@
 import { read, refuse, removeScript, run, scope, start } from "../flows.mjs";
 import { d as reviewNotes, f as reviewRisks } from "../chunks/steering-DVILanVf.mjs";
-import { D as agentWithSkills, H as finisherSystem, U as fixReviewNotesPrompt, _ as REVIEW, dt as defaults, ft as envDefaults, i as skills, n as summary, o as shipped, r as access, s as baseline, t as steering, y as coder } from "../chunks/reserved-Dmpg6dAp.mjs";
-import { r as handOffTail, t as REVIEW_ORIG } from "../chunks/tail-CLyE5VFR.mjs";
+import { D as agentWithSkills, R as finisherSystem, _ as REVIEW, at as defaults, c as baseline, i as skills, n as summary, ot as envDefaults, r as access, s as shipped, t as steering, y as coder, z as fixReviewNotesPrompt } from "../chunks/reserved-DDiiAZ8U.mjs";
+import { r as handOffTail, t as REVIEW_ORIG } from "../chunks/tail-ILPlELuy.mjs";
 //#region src/workflows/fix/fix.ts
 /**
 * Fix every note a human left in a handed-off `.gtd/REVIEW.md` and every

package/dist/workflows/review.mjs

@@ -1,6 +1,6 @@
 import { start } from "../flows.mjs";
-import { dt as defaults, ft as envDefaults, i as skills, l as gate, n as summary, o as shipped, r as access, rt as reviewGateBlockedMessage, t as steering } from "../chunks/reserved-Dmpg6dAp.mjs";
-import { a as refusePendingHandOff, r as handOffTail } from "../chunks/tail-CLyE5VFR.mjs";
+import { Z as reviewGateBlockedMessage, at as defaults, i as skills, n as summary, ot as envDefaults, r as access, s as shipped, t as steering, u as gate } from "../chunks/reserved-DDiiAZ8U.mjs";
+import { a as refusePendingHandOff, r as handOffTail } from "../chunks/tail-ILPlELuy.mjs";
 //#region src/workflows/review/review.ts
 /**
 * Pure review of everything since `reviewBase`: a green gate, the quality

package/dist/workflows/rollout.mjs

@@ -1,5 +1,5 @@
 import { agent, changesSince, glob, head, mark, read, refuse, removeScript, run, scope, vars } from "../flows.mjs";
-import { a as flagShipped, dt as defaults, ft as envDefaults, gt as flipProblems, i as skills, l as gate, mt as flagMentions, n as summary, p as FEEDBACK, r as access, t as steering, vt as requireFlag, y as coder } from "../chunks/reserved-Dmpg6dAp.mjs";
+import { at as defaults, ct as flagMentions, ft as requireFlag, i as skills, n as summary, o as flagShipped, ot as envDefaults, p as FEEDBACK, r as access, t as steering, u as gate, ut as flipProblems, y as coder } from "../chunks/reserved-DDiiAZ8U.mjs";
 //#region src/workflows/rollout/rollout.ts
 const flippingPrompt = (name, registry) => `Roll out the release flag "${name}": in ${registry}, set \`defaultOn: true\` on its entry. Change nothing else — no other entry, no other field, no other file, no comments.`;
 const suiteBlockedMessage = () => "The suite is red after the rollout. Fix it by hand — a rollout may only touch the flag's registry entry — then land.";