@pmelab/gtd 29.2.1 → 29.2.3

package/dist/workflows/feature.mjs

@@ -1,7 +1,7 @@
 import { answered, changes, changesSince, glob, hasThreadFor, head, human, judge, judgeDiffShape, kept, mark, matches, numeric, quote, read, refuse, removeScript, requireAnswers, requireProgress, requireReplies, requireRevert, requireThreadsClosed, restoreScript, revertScript, run, scope, slice, start, vars } from "../flows.mjs";
 import { lensesOf, review as review$1 } from "../workflow-kit.mjs";
-import { $ as refactorFixPrompt, A as architectureDecomposePrompt, B as designSystem, C as planner, D as agentWithSkills, E as reviewing, F as buildReviewFixNitsPrompt, G as idleMessage, I as buildReviewTriageMessage, J as naivePassPrompt, K as implementBuildingPrompt, L as builderSystem, M as buildReviewAnswerQuestionsPrompt, N as buildReviewAwaitAfterDeferMessage, O as architectSystem, P as buildReviewCollectingPrompt, Q as refactorDroppedRefusal, R as deferNotesScript, S as fixRisks, V as designTriagePrompt, X as packagesItemFixSuitePrompt, Y as packagesItemBuildingPrompt, Z as refactorBuildingPrompt, _ as REVIEW, at as reviewerSystem, b as fixCheck, ct as startGateBlockedMessage, d as healthy, dt as defaults, et as refactorRules, f as ARCHITECTURE, ft as envDefaults, g as REQUIREMENTS, h as REFACTOR, i as skills, it as reviewNotesCapture, j as architectureGateAnswerMessage, k as architectureAuthorPrompt, l as gate, lt as unwindFailedMessage, n as summary, nt as reviewEditsCapture, o as shipped, ot as seamByHandMessage, p as FEEDBACK, pt as testFileGlobs, q as implementFixPrompt, r as access, st as seamSteerMessage, t as steering, tt as reviewEditNotesCapture, u as guarded, ut as unwindFailure, v as awaitReview, w as reviewMissing, y as coder, z as designGateAnswerMessage } from "../chunks/reserved-BzeofpoC.mjs";
-import { a as tail, i as refusePendingHandOff, n as closeReview } from "../chunks/tail-eS_ZSImR.mjs";
+import { $ as refactorFixPrompt, A as architectureDecomposePrompt, B as designSystem, C as planner, D as agentWithSkills, E as reviewing, F as buildReviewFixNitsPrompt, G as idleMessage, I as buildReviewTriageMessage, J as naivePassPrompt, K as implementBuildingPrompt, L as builderSystem, M as buildReviewAnswerQuestionsPrompt, N as buildReviewAwaitAfterDeferMessage, O as architectSystem, P as buildReviewCollectingPrompt, Q as refactorDroppedRefusal, R as deferNotesScript, S as fixRisks, V as designTriagePrompt, X as packagesItemFixSuitePrompt, Y as packagesItemBuildingPrompt, Z as refactorBuildingPrompt, _ as REVIEW, at as reviewerSystem, b as fixCheck, ct as startGateBlockedMessage, d as healthy, dt as defaults, et as refactorRules, f as ARCHITECTURE, ft as envDefaults, g as REQUIREMENTS, h as REFACTOR, i as skills, it as reviewNotesCapture, j as architectureGateAnswerMessage, k as architectureAuthorPrompt, l as gate, lt as unwindFailedMessage, n as summary, nt as reviewEditsCapture, o as shipped, ot as seamByHandMessage, p as FEEDBACK, pt as testFileGlobs, q as implementFixPrompt, r as access, st as seamSteerMessage, t as steering, tt as reviewEditNotesCapture, u as guarded, ut as unwindFailure, v as awaitReview, w as reviewMissing, y as coder, z as designGateAnswerMessage } from "../chunks/reserved-BduvUQxQ.mjs";
+import { a as tail, i as refusePendingHandOff, n as closeReview } from "../chunks/tail-pgq1Fbbv.mjs";
 //#region src/workflows/shared/fences.ts
 const markFenced = (text) => {
 	let fence;
@@ -516,6 +516,35 @@ const requireNoTestFiles = () => {
 	if (tests.length === 0) return;
 	refuse(`gtd land: refactor-tests: the refactor may not change a test file — revert these:\n${tests.map((path) => `  - ${path}`).join("\n")}`);
 };
+const holdsCallSites = (path) => !path.endsWith(".feature") && !path.endsWith(".snap");
+const COMMENT = /(?<![*/])\/\*[\s\S]*?\*\/|(?<!:)\/\/.*$/gm;
+const ASSERTION = /\b(?:expect|assert\w*)\s*[.(]/g;
+const TEST_CASE = /(?<![.\w])x?(?:it|test|describe)\s*[.(]/g;
+const MODIFIER = /(?<![.\w])(?:it|test|describe)\.(skip|only|todo|fails|skipIf|runIf)\b|(?<![.\w])(x)(?:it|test|describe)\b/g;
+const counts = (text) => {
+	const live = text.replace(COMMENT, "");
+	const modifiers = [...live.matchAll(MODIFIER)].map((m) => m[1] ?? m[2]).sort();
+	return JSON.stringify([
+		[...live.matchAll(ASSERTION)].length,
+		[...live.matchAll(TEST_CASE)].length,
+		modifiers
+	]);
+};
+const tested = (text) => {
+	const live = text.replace(COMMENT, "");
+	return live.search(ASSERTION) >= 0 || live.search(TEST_CASE) >= 0;
+};
+const callSitesOnly = ({ path, status, before, after }) => status === "modified" && holdsCallSites(path) && before !== void 0 && after !== void 0 && tested(before) && counts(before) === counts(after);
+/**
+* The test-file half of the refactor guard: an existing test may follow a changed call shape,
+* nothing more. Returns the test files it admitted, which the scope check then allows.
+*/
+const requireTestCallSitesOnly = () => {
+	const tests = changes().filter((c) => isCode(c.path) && isTestFile(c.path));
+	const refused = tests.filter((c) => !callSitesOnly(c)).map((c) => c.path);
+	if (refused.length > 0) refuse(`gtd land: refactor-tests: the refactor may update an existing test file's call sites only — never add, delete, skip or comment out a test or an assertion, or touch a snapshot, a .feature file or test data; revert these:\n${refused.map((path) => `  - ${path}`).join("\n")}`);
+	return tests.map((c) => c.path);
+};
 const flagExpression = (pattern) => {
 	if (pattern.trim() === "") throw new Error("gtd: refactorFlagPattern must not be blank");
 	let expression;
@@ -571,12 +600,16 @@ const packageLines = (strays, pattern, reference) => [
 	"## Rules",
 	"",
 	"- The suite's outcome must not change",
-	"- Change only the paths above, and never a test file",
+	"- Change only the paths above, plus an existing test file where a changed call shape reaches it: never add or delete a test file, and never add, remove or alter a test or an assertion",
 	`- Introduce no flag read and add no second read of an existing one (\`${pattern}\`)`,
 	"",
 	"## Reference",
 	"",
-	reference === void 0 ? "None." : `Reading material only, never applied: \`git show ${reference} -- ${strays.map(quote).join(" ")}\``,
+	...reference === void 0 ? ["None."] : [
+		`Reading material only, never applied: \`git show ${reference} -- ${strays.map(quote).join(" ")}\``,
+		"",
+		"Its changes to the existing code above are the seam this refactor exists to land, minus the feature's own behaviour."
+	],
 	""
 ];
 const demoteHeadings = (text) => {
@@ -609,8 +642,7 @@ const plan = (shape, options) => {
 	};
 };
 const guardOf = ({ pattern, strays }, entry) => () => {
-	requireNoTestFiles();
-	requireWithin(strays);
+	requireWithin([...strays, ...requireTestCallSitesOnly()]);
 	requireNoNewFlags(pattern, entry);
 };
 /** Derive, build, check and close one refactor lap; `feedback` is the collected review text of the lap before. */
@@ -651,7 +683,11 @@ const refactorLap = async (p, guard, feedback) => {
 	});
 	await run("closing", removeScript([REFACTOR_PACKAGE]), { label: "Closing out the refactor" });
 };
-const strayAccess = (strays) => ({ write: [...strays, ".gtd/**"] });
+const strayAccess = (strays) => ({ write: [
+	...strays,
+	...testFileGlobs,
+	".gtd/**"
+] });
 const refactorFirst = async (shape, options = {}) => {
 	const p = plan(shape, options);
 	if (p === void 0) return false;
@@ -886,4 +922,4 @@ const feature = shipped(ordinaryStart);
 //#region src/workflows/feature/index.ts
 var feature_default = feature;
 //#endregion
-export { REFACTOR_PACKAGE, access, afterTail, answerProductQuestions, answerReviewQuestions, answerTechnicalQuestions, architecture, author, build, buildTail, collecting, declaredTests, decompose, feature_default as default, defaults, deferNotes, design, envDefaults, feature, fixNits, fixSuite, implement, judgeSeam, naivePass, nextPackage, ordinaryStart, packageItem, packages, planAndBuild, reUnwind, refactorCollecting, refactorFirst, refactorStrays, requireDeclaredTests, requireNoNewFlags, requireNoTestFiles, requireWithin, reviewedRefactor, seamBuild, skills, steering, summary, triage, unwind };
+export { REFACTOR_PACKAGE, access, afterTail, answerProductQuestions, answerReviewQuestions, answerTechnicalQuestions, architecture, author, build, buildTail, collecting, declaredTests, decompose, feature_default as default, defaults, deferNotes, design, envDefaults, feature, fixNits, fixSuite, implement, judgeSeam, naivePass, nextPackage, ordinaryStart, packageItem, packages, planAndBuild, reUnwind, refactorCollecting, refactorFirst, refactorStrays, requireDeclaredTests, requireNoNewFlags, requireNoTestFiles, requireTestCallSitesOnly, requireWithin, reviewedRefactor, seamBuild, skills, steering, summary, triage, unwind };

package/dist/workflows/fix.mjs

@@ -1,7 +1,7 @@
 import { read, refuse, removeScript, run, scope, start } from "../flows.mjs";
 import { d as reviewNotes, f as reviewRisks } from "../chunks/steering-DVILanVf.mjs";
-import { D as agentWithSkills, H as finisherSystem, U as fixReviewNotesPrompt, _ as REVIEW, dt as defaults, ft as envDefaults, i as skills, n as summary, o as shipped, r as access, s as baseline, t as steering, y as coder } from "../chunks/reserved-BzeofpoC.mjs";
-import { r as handOffTail, t as REVIEW_ORIG } from "../chunks/tail-eS_ZSImR.mjs";
+import { D as agentWithSkills, H as finisherSystem, U as fixReviewNotesPrompt, _ as REVIEW, dt as defaults, ft as envDefaults, i as skills, n as summary, o as shipped, r as access, s as baseline, t as steering, y as coder } from "../chunks/reserved-BduvUQxQ.mjs";
+import { r as handOffTail, t as REVIEW_ORIG } from "../chunks/tail-pgq1Fbbv.mjs";
 //#region src/workflows/fix/fix.ts
 /**
 * Fix every note a human left in a handed-off `.gtd/REVIEW.md` and every

package/dist/workflows/review.mjs

@@ -1,6 +1,6 @@
 import { start } from "../flows.mjs";
-import { dt as defaults, ft as envDefaults, i as skills, l as gate, n as summary, o as shipped, r as access, rt as reviewGateBlockedMessage, t as steering } from "../chunks/reserved-BzeofpoC.mjs";
-import { i as refusePendingHandOff, r as handOffTail } from "../chunks/tail-eS_ZSImR.mjs";
+import { dt as defaults, ft as envDefaults, i as skills, l as gate, n as summary, o as shipped, r as access, rt as reviewGateBlockedMessage, t as steering } from "../chunks/reserved-BduvUQxQ.mjs";
+import { i as refusePendingHandOff, r as handOffTail } from "../chunks/tail-pgq1Fbbv.mjs";
 //#region src/workflows/review/review.ts
 /**
 * Pure review of everything since `reviewBase`: a green gate, the quality

package/dist/workflows/rollout.mjs

@@ -1,5 +1,5 @@
 import { agent, changesSince, glob, head, mark, read, refuse, removeScript, run, scope, vars } from "../flows.mjs";
-import { a as flagShipped, dt as defaults, ft as envDefaults, gt as flipProblems, i as skills, l as gate, mt as flagMentions, n as summary, p as FEEDBACK, r as access, t as steering, vt as requireFlag, y as coder } from "../chunks/reserved-BzeofpoC.mjs";
+import { a as flagShipped, dt as defaults, ft as envDefaults, gt as flipProblems, i as skills, l as gate, mt as flagMentions, n as summary, p as FEEDBACK, r as access, t as steering, vt as requireFlag, y as coder } from "../chunks/reserved-BduvUQxQ.mjs";
 //#region src/workflows/rollout/rollout.ts
 const flippingPrompt = (name, registry) => `Roll out the release flag "${name}": in ${registry}, set \`defaultOn: true\` on its entry. Change nothing else — no other entry, no other field, no other file, no comments.`;
 const suiteBlockedMessage = () => "The suite is red after the rollout. Fix it by hand — a rollout may only touch the flag's registry entry — then land.";

package/dist/workflows.mjs

@@ -17554,9 +17554,13 @@ ${fixFeedbackPrompt}
 - Leave everything uncommitted and finish your turn — do not commit
 `;
 const refactorRules = (strays, pattern) => `- Behaviour-neutral: the suite's outcome must not change
-- Change only these paths, nothing else, and never a test file even
-  when it is one of them:
+- Change only these paths, nothing else:
 ${strays.map((path) => `  - \`${displayPath(path)}\``).join("\n")}
+- An existing test file only where a changed call shape reaches it:
+  update its call sites, inside an assertion too;
+  never add or delete a test file,
+  never add, remove or alter a test or an assertion, and never
+  change what an assertion checks, an expected value or a snapshot
 - Introduce no new flag read and add no second read of an existing one:
   every match of \`${pattern}\` may move, never increase in number`;
 const withRules = (rules) => rules === void 0 ? "" : `${rules}\n`;
@@ -17566,8 +17570,13 @@ ${feedback ? `- The package carries a \`## Review feedback\` section: a human's
   last refactor. Act on it, within the rules below
 ` : ""}${refactorRules(strays, pattern)}
 ${reference === void 0 ? "" : `- Reference only: \`git show ${reference} -- ${strays.map(quote).join(" ")}\` shows an
-  earlier attempt at this change. Read it for ideas; never apply,
-  cherry-pick or check it out — write a fresh refactor
+  earlier attempt at this change, and \`git show --stat ${reference}\`
+  lists every file it touched, the test call sites included.
+  Read it; never apply, cherry-pick or check it out
+- Its changes to these paths' existing code are the seam: write that
+  restructuring afresh here, minus the feature's own behaviour. A
+  refactor that touches none of it is wrong, however clean — never
+  swap in an unrelated tidy-up
 `}- Leave everything uncommitted and finish your turn — do not commit
 `;
 const refactorFixPrompt = (strays, pattern) => `${stateFileRules}
@@ -17883,11 +17892,11 @@ const closedFold = (round, target) => round === "edits" ? `- Fold every hand-edi
 /** `refactor` retargets the prompt at `.gtd/REFACTOR.md` and fences it to the strays. A concern outside the fence is not folded; if nothing at all is written the landing is refused, but a partly buildable round drops the rest silently. */
 const buildReviewCollectingPrompt = (capture, refactor) => {
 	const target = refactor ? ".gtd/REFACTOR.md" : ".gtd/REQUIREMENTS.md";
-	const fence = refactor ? `- The next refactor may change only these paths, and never a test file
-  or a flag read:
+	const fence = refactor ? `- The next refactor may change only these paths, plus an existing test
+  file's call sites, and never a flag read:
 ${refactor.strays.map((path) => `  - \`${displayPath(path)}\``).join("\n")}
-  A concern needing any other path, a test file, a new or added flag
-  read, or a change in behaviour (that belongs to the feature, not this
+  A concern needing any other path, a new or changed test or assertion,
+  a new or added flag read, or a change in behaviour (that belongs to the feature, not this
   refactor) cannot be built: do not fold it
 ` : "";
 	const actionable = refactor ? `The round is actionable if the human left a note on
@@ -17991,7 +18000,7 @@ ${removed.map(({ path, lines }) => lines.map((a) => `    ${path} — ${a.scenari
 const lapRange = {
 	first: "it covers everything since the base.",
 	feedback: "it starts at the previous review's boundary, so it covers only what is new since the previous review.",
-	refactor: "it covers the whole refactor since it started, on every round."
+	refactor: "it covers the whole refactor since it started, on every round. A refactor may update an existing test's call sites only: give any test-file hunk its own chunk, and say so if it changes a test, an assertion or an expected value."
 };
 const buildReviewReviewingPrompt = (base, lap, carry, removed = []) => `${styleBlock}
 
@@ -18108,7 +18117,12 @@ ${slice === void 0 ? `- Write the closing message for the process HEAD closes or
   the exact escape or rewrite a committed config needs. A \`!\` on the
   type prefix alone (\`feat!:\`/\`refactor!:\`) is NOT enough: this repo's
   own commit-analyzer has missed that marker before, cutting no release
-  until a follow-up commit carried the literal footer instead
+  until a follow-up commit carried the literal footer instead${slice === void 0 || slice.index === slice.count ? `
+- If the process was started for an issue — its entry commit or
+  \`.gtd/REQUIREMENTS.md\` names one as \`#N\`, \`owner/repo#N\` or an issue
+  URL — end the message with a literal \`Closes #N\` footer per issue
+  (\`Closes owner/repo#N\` for another repository). Name only an issue the
+  work resolves, never one it merely mentions` : ""}
 
 ${slice !== void 0 && slice.index > 1 ? `The process's entry commit is \`${it.entryCommit}\` — outside this slice's range, context
 that states the motivation. ` : `The process's entry commit is \`${it.entryCommit}\`. `}${human}Inspect the range: \`git log ${it.processBase}..${it.processTip}\`
@@ -38339,6 +38353,35 @@ const requireNoTestFiles = () => {
 	if (tests.length === 0) return;
 	refuse(`gtd land: refactor-tests: the refactor may not change a test file — revert these:\n${tests.map((path) => `  - ${path}`).join("\n")}`);
 };
+const holdsCallSites = (path) => !path.endsWith(".feature") && !path.endsWith(".snap");
+const COMMENT = /(?<![*/])\/\*[\s\S]*?\*\/|(?<!:)\/\/.*$/gm;
+const ASSERTION = /\b(?:expect|assert\w*)\s*[.(]/g;
+const TEST_CASE = /(?<![.\w])x?(?:it|test|describe)\s*[.(]/g;
+const MODIFIER = /(?<![.\w])(?:it|test|describe)\.(skip|only|todo|fails|skipIf|runIf)\b|(?<![.\w])(x)(?:it|test|describe)\b/g;
+const counts = (text) => {
+	const live = text.replace(COMMENT, "");
+	const modifiers = [...live.matchAll(MODIFIER)].map((m) => m[1] ?? m[2]).sort();
+	return JSON.stringify([
+		[...live.matchAll(ASSERTION)].length,
+		[...live.matchAll(TEST_CASE)].length,
+		modifiers
+	]);
+};
+const tested = (text) => {
+	const live = text.replace(COMMENT, "");
+	return live.search(ASSERTION) >= 0 || live.search(TEST_CASE) >= 0;
+};
+const callSitesOnly = ({ path, status, before, after }) => status === "modified" && holdsCallSites(path) && before !== void 0 && after !== void 0 && tested(before) && counts(before) === counts(after);
+/**
+* The test-file half of the refactor guard: an existing test may follow a changed call shape,
+* nothing more. Returns the test files it admitted, which the scope check then allows.
+*/
+const requireTestCallSitesOnly = () => {
+	const tests = changes().filter((c) => isCode(c.path) && isTestFile(c.path));
+	const refused = tests.filter((c) => !callSitesOnly(c)).map((c) => c.path);
+	if (refused.length > 0) refuse(`gtd land: refactor-tests: the refactor may update an existing test file's call sites only — never add, delete, skip or comment out a test or an assertion, or touch a snapshot, a .feature file or test data; revert these:\n${refused.map((path) => `  - ${path}`).join("\n")}`);
+	return tests.map((c) => c.path);
+};
 const flagExpression = (pattern) => {
 	if (pattern.trim() === "") throw new Error("gtd: refactorFlagPattern must not be blank");
 	let expression;
@@ -38394,12 +38437,16 @@ const packageLines = (strays, pattern, reference) => [
 	"## Rules",
 	"",
 	"- The suite's outcome must not change",
-	"- Change only the paths above, and never a test file",
+	"- Change only the paths above, plus an existing test file where a changed call shape reaches it: never add or delete a test file, and never add, remove or alter a test or an assertion",
 	`- Introduce no flag read and add no second read of an existing one (\`${pattern}\`)`,
 	"",
 	"## Reference",
 	"",
-	reference === void 0 ? "None." : `Reading material only, never applied: \`git show ${reference} -- ${strays.map(quote).join(" ")}\``,
+	...reference === void 0 ? ["None."] : [
+		`Reading material only, never applied: \`git show ${reference} -- ${strays.map(quote).join(" ")}\``,
+		"",
+		"Its changes to the existing code above are the seam this refactor exists to land, minus the feature's own behaviour."
+	],
 	""
 ];
 const demoteHeadings = (text) => {
@@ -38432,8 +38479,7 @@ const plan = (shape, options) => {
 	};
 };
 const guardOf = ({ pattern, strays }, entry) => () => {
-	requireNoTestFiles();
-	requireWithin(strays);
+	requireWithin([...strays, ...requireTestCallSitesOnly()]);
 	requireNoNewFlags(pattern, entry);
 };
 /** Derive, build, check and close one refactor lap; `feedback` is the collected review text of the lap before. */
@@ -38474,7 +38520,11 @@ const refactorLap = async (p, guard, feedback) => {
 	});
 	await run("closing", removeScript([REFACTOR_PACKAGE]), { label: "Closing out the refactor" });
 };
-const strayAccess = (strays) => ({ write: [...strays, ".gtd/**"] });
+const strayAccess = (strays) => ({ write: [
+	...strays,
+	...testFileGlobs,
+	".gtd/**"
+] });
 const refactorFirst = async (shape, options = {}) => {
 	const p = plan(shape, options);
 	if (p === void 0) return false;
@@ -38900,4 +38950,4 @@ var workflows_default = feature;
 */
 const doors = {};
 //#endregion
-export { ARCHITECTURE, ESCALATION, FEEDBACK, FIX_CAP, FlagOptions, QUALITY, REFACTOR, REFACTOR_PACKAGE, REQUIREMENTS, REVIEW, REVIEW_ORIG, ShippedOptions, access, afterTail, agentWithSkills, answerProductQuestions, answerReviewQuestions, answerTechnicalQuestions, architecture, author, awaitReview, base, baseline, build, buildTail, builtInLenses, cleanup, cleanupFlow, closeReview, coder, collecting, declaredTests, decompose, workflows_default as default, defaults, deferNotes, describeEscalation, design, doors, envDefaults, escalate, escalation, escalationExhausted, feature, fix, fixCheck, fixFlow, fixNits, fixQuality, fixQualityFindings, fixReviewNotes, fixRisks, fixSuite, gate, guarded, handOffReview, handOffTail, healthy, implement, judgeSeam, lensesOf, naivePass, nextPackage, ordinaryStart, packageItem, packages, planAndBuild, planner, qualityLap, reUnwind, refactorCollecting, refactorFirst, refactorStrays, requireDeclaredTests, requireNoNewFlags, requireNoTestFiles, requireWithin, retryQuestion, review, reviewFlow, reviewMissing, reviewQuality, reviewedRefactor, reviewing, rollout, rolloutFlow, seamBuild, skills, steering, summary, tail, threads, triage, unwind };
+export { ARCHITECTURE, ESCALATION, FEEDBACK, FIX_CAP, FlagOptions, QUALITY, REFACTOR, REFACTOR_PACKAGE, REQUIREMENTS, REVIEW, REVIEW_ORIG, ShippedOptions, access, afterTail, agentWithSkills, answerProductQuestions, answerReviewQuestions, answerTechnicalQuestions, architecture, author, awaitReview, base, baseline, build, buildTail, builtInLenses, cleanup, cleanupFlow, closeReview, coder, collecting, declaredTests, decompose, workflows_default as default, defaults, deferNotes, describeEscalation, design, doors, envDefaults, escalate, escalation, escalationExhausted, feature, fix, fixCheck, fixFlow, fixNits, fixQuality, fixQualityFindings, fixReviewNotes, fixRisks, fixSuite, gate, guarded, handOffReview, handOffTail, healthy, implement, judgeSeam, lensesOf, naivePass, nextPackage, ordinaryStart, packageItem, packages, planAndBuild, planner, qualityLap, reUnwind, refactorCollecting, refactorFirst, refactorStrays, requireDeclaredTests, requireNoNewFlags, requireNoTestFiles, requireTestCallSitesOnly, requireWithin, retryQuestion, review, reviewFlow, reviewMissing, reviewQuality, reviewedRefactor, reviewing, rollout, rolloutFlow, seamBuild, skills, steering, summary, tail, threads, triage, unwind };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pmelab/gtd",
-  "version": "29.2.1",
+  "version": "29.2.3",
   "private": false,
   "description": "Git-aware CLI that emits the next prompt for an autonomous coding agent based on the current repository state",
   "bin": {

package/src/workflows/feature/refactor-review.feature

@@ -13,7 +13,7 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
     And an environment variable "GTD_FLAG_NAIVE_PASS" set to "1"
     And an environment variable "GTD_FLAG_RISK_TIER" set to "0"
 
-  Scenario: with a narrowed seamAllow a test-named file written by the refactor is refused
+  Scenario: with a narrowed seamAllow a test file added by the refactor is refused
     Given an environment variable "GTD_REFACTORQUALITYREVIEWS" set to ""
     And an environment variable "GTD_SEAMALLOW" set to "docs/**"
     And a file "src/calc.ts" with:
@@ -85,12 +85,12 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
       import { expect, it } from "vitest"
       it("adds", () => expect(2 + 2).toBe(4))
       """
-    And step "refactor.building" writes "src/calc.test.ts" with:
+    And step "refactor.building" writes "src/calc.spec.ts" with:
       """
       import { expect, it } from "vitest"
       it("adds", () => expect(3 + 3).toBe(6))
       """
-    Then driving the process is refused with "outside its write access"
+    Then driving the process is refused with "refactor-tests"
 
 
   Scenario: refactorQualityReviews picks the refactor's lenses and qualityReviews does not reach them
@@ -1607,6 +1607,40 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
       And ".gtd/REFACTOR.md" contains "src/calc.ts"
       And ".gtd/REFACTOR.md" does not contain "src/calc.test.ts"
 
+    Scenario: the refactor updates an existing test's call sites to the seam's new shape
+      Given step "seam.naive" writes "src/calc.ts" with:
+        """
+        export const add = ({ a, b }: { a: number; b: number }) => a + b
+        export const subtract = ({ a, b }: { a: number; b: number }) => a - b
+        """
+      And step "refactor.deriving" runs its script
+      And step "refactor.building" writes "src/calc.ts" with:
+        """
+        export const add = ({ a, b }: { a: number; b: number }) => a + b
+        """
+      And step "refactor.building" writes "src/calc.test.ts" with:
+        """
+        import { expect, it } from "vitest"
+        import { add } from "./calc"
+        it("adds", () => expect(add({ a: 1, b: 1 })).toBe(2))
+        """
+      When the process is driven
+      Then the process rests at "refactor.health.check"
+
+    Scenario: the refactor may not drop an assertion from an existing test
+      Given step "seam.naive" writes "src/calc.ts" with:
+        """
+        export const add = (a: number, b: number) => a + b
+        export const subtract = (a: number, b: number) => a - b
+        """
+      And step "refactor.deriving" runs its script
+      And step "refactor.building" writes "src/calc.test.ts" with:
+        """
+        import { it } from "vitest"
+        it("adds", () => {})
+        """
+      Then driving the process is refused with "refactor-tests"
+
     Scenario: a refactor-first whose strays are all test files goes straight to implement
       Given step "seam.naive" writes "src/calc.test.ts" with:
         """

package/src/workflows/feature/refactor.test.ts

@@ -13,6 +13,7 @@ import {
   refactorStrays,
   requireNoNewFlags,
   requireNoTestFiles,
+  requireTestCallSitesOnly,
   requireWithin,
   reviewedRefactor,
   REFACTOR_PACKAGE,
@@ -20,6 +21,15 @@ import {
 
 afterEach(() => installContext(undefined))
 
+const testFileGlobs = [
+  "**/*.test.*",
+  "**/*.spec.*",
+  "**/*.feature",
+  "**/tests/**",
+  "**/test/**",
+  "**/__tests__/**",
+]
+
 const change = (
   path: string,
   before: string | undefined,
@@ -131,6 +141,137 @@ describe("requireNoTestFiles", () => {
   })
 })
 
+describe("requireTestCallSitesOnly", () => {
+  it("refuses an added or deleted test path, naming it", () => {
+    const list = [
+      change("tests/unit/b.ts", undefined, "x", "added"),
+      change("src/__tests__/c.ts", "a", undefined, "deleted"),
+      change("src/a.test.ts", "expect(a()).toBe(1)", "expect(a(1)).toBe(1)"),
+    ]
+    const message = withChanges(list, () => requireTestCallSitesOnly())
+    expect(message).toMatch(/^gtd land: refactor-tests: /)
+    expect(message).toContain("  - tests/unit/b.ts")
+    expect(message).toContain("  - src/__tests__/c.ts")
+    expect(message).not.toContain("src/a.test.ts")
+  })
+
+  it("passes a modified test file's call site, non-test paths and .gtd/ paths", () => {
+    const list = [
+      change("src/a.test.ts", "expect(a()).toBe(1)", "expect(a(1)).toBe(1)"),
+      change("src/new.ts", undefined, "x", "added"),
+      change(".gtd/tests/x.md", "", "x", "added"),
+    ]
+    expect(withChanges(list, () => requireTestCallSitesOnly())).toBeUndefined()
+  })
+
+  it("refuses a snapshot change and a dropped test or assertion, naming each", () => {
+    const list = [
+      change("src/__snapshots__/a.test.ts.snap", "a", "b"),
+      change("src/b.test.ts", 'it("a", () => {})\nit("b", () => {})', 'it("a", () => {})'),
+      change("src/c.test.ts", "expect(c()).toBe(1)\nexpect(c()).toBe(1)", "expect(c()).toBe(1)"),
+      change(
+        "d.feature",
+        "Feature: d\n  Scenario: d\n    Then it is\n",
+        "Feature: d\n  Scenario: d\n",
+      ),
+    ]
+    const message = withChanges(list, () => requireTestCallSitesOnly())
+    for (const { path } of list) expect(message).toContain(`  - ${path}`)
+  })
+
+  it.each([
+    [
+      "a skipped test",
+      'it("a", () => expect(a()).toBe(1))',
+      'it.skip("a", () => expect(a()).toBe(1))',
+    ],
+    [
+      "an x-prefixed test",
+      'it("a", () => expect(a()).toBe(1))',
+      'xit("a", () => expect(a()).toBe(1))',
+    ],
+    [
+      "a line-commented assertion",
+      'it("a", () => {\n  expect(a()).toBe(1)\n})',
+      'it("a", () => {\n  // expect(a()).toBe(1)\n})',
+    ],
+    [
+      "a block-commented test",
+      'it("a", () => expect(a()).toBe(1))',
+      '/* it("a", () => expect(a()).toBe(1)) */',
+    ],
+    [
+      "a .skip swapped for an .only",
+      'it.skip("a", () => expect(a()).toBe(1))\nit("b", () => expect(b()).toBe(1))',
+      'it.only("a", () => expect(a()).toBe(1))\nit("b", () => expect(b()).toBe(1))',
+    ],
+    [
+      "an assertion dropped after a URL in a test name",
+      'it("GET http://x", () => expect(get()).toBe(1))',
+      'it("GET http://x", () => {})',
+    ],
+    ["fixture data with no test", '{"sum": 2}', '{"sum": 3}'],
+  ])("refuses %s", (_label, before, after) => {
+    const message = withChanges([change("tests/a.test.ts", before, after)], () =>
+      requireTestCallSitesOnly(),
+    )
+    expect(message).toContain("  - tests/a.test.ts")
+  })
+
+  it("refuses a modified test file whose content cannot be read", () => {
+    const message = withChanges([change("tests/a.test.ts", undefined, "expect(a()).toBe(1)")], () =>
+      requireTestCallSitesOnly(),
+    )
+    expect(message).toContain("  - tests/a.test.ts")
+  })
+
+  it("passes a regex .test( call rewritten at a call site", () => {
+    const list = [
+      change(
+        "src/a.test.ts",
+        'it("a", () => expect(/x/.test(s)).toBe(true))',
+        'it("a", () => expect(has(s)).toBe(true))',
+      ),
+    ]
+    expect(withChanges(list, () => requireTestCallSitesOnly())).toBeUndefined()
+  })
+
+  it("passes a call site rewritten inside an assertion", () => {
+    const list = [
+      change(
+        "src/a.test.ts",
+        'it("adds", () => expect(add(1, 1)).toBe(2))',
+        'it("adds", async () => expect(await add({ a: 1, b: 1 })).toBe(2))',
+      ),
+    ]
+    expect(withChanges(list, () => requireTestCallSitesOnly())).toBeUndefined()
+  })
+
+  it("is not narrowed by a narrowed seamAllow", () => {
+    installContext(
+      fixtureContext(
+        { vars: { seamAllow: "docs/**" } },
+        {
+          changes: () => [change("src/a.test.ts", undefined, "b", "added")],
+          matches: globMatches,
+          refuse: (message) => {
+            throw new Error(message)
+          },
+        },
+      ),
+    )
+    expect(refusal(() => requireTestCallSitesOnly())).toContain("src/a.test.ts")
+  })
+
+  it("does not refuse other naming such as _test.go or test_*.py", () => {
+    const list = [
+      change("pkg/a_test.go", undefined, "b", "added"),
+      change("pkg/test_a.py", undefined, "b", "added"),
+    ]
+    expect(withChanges(list, () => requireTestCallSitesOnly())).toBeUndefined()
+  })
+})
+
 describe("refactorStrays", () => {
   it("refactorStrays drops test files, keeps the rest and ignores a narrowed seamAllow", () => {
     installContext(fixtureContext({ vars: { seamAllow: "docs/**" } }, { matches: globMatches }))
@@ -359,7 +500,7 @@ describe("refactorFirst", () => {
     const body = derive?.kind === "run" ? derive.body : ""
     expect(body).toContain("`src/a.ts`") // gtd-path-exempt: fixture paths
     expect(body).not.toContain("a.test.ts")
-    expect(h.scopes[0]?.access).toEqual({ write: ["src/a.ts", ".gtd/**"] })
+    expect(h.scopes[0]?.access).toEqual({ write: ["src/a.ts", ...testFileGlobs, ".gtd/**"] })
   })
 
   it("throws before any step when a stray holds a flag read the pattern matches zero-length", async () => {
@@ -403,10 +544,13 @@ describe("refactorFirst", () => {
     expect(lines).toEqual(["- `src/z.ts`", "- `src/a.ts`", "- `it's.ts`"]) // gtd-path-exempt: fixture paths
   })
 
-  it("runs inside a refactor scope whose write access is the strays plus .gtd/**", async () => {
+  it("runs inside a refactor scope whose write access is the strays, test files and .gtd/**", async () => {
     const h = await drive(shape())
     expect(h.scopes).toEqual([
-      { name: "refactor", access: { write: ["src/a.ts", "src/b.ts", ".gtd/**"] } },
+      {
+        name: "refactor",
+        access: { write: ["src/a.ts", "src/b.ts", ...testFileGlobs, ".gtd/**"] },
+      },
     ])
   })
 
@@ -439,19 +583,38 @@ describe("refactorFirst", () => {
     expect(names(h)).not.toContain("health.check")
   })
 
-  it("refuses a build turn changing a test file even when it is a stray", async () => {
-    const h = await drive(shape({ strays: ["src/a.ts", "src/a.test.ts"] }), {
-      build: [change("src/a.test.ts", "a", "b")],
+  it("lets a build turn update an existing test file's call sites", async () => {
+    const h = await drive(shape(), {
+      build: [
+        change("src/a.ts", "a", "b"),
+        change("tests/a.test.ts", "expect(a()).toBe(1)", "expect(await a()).toBe(1)"),
+      ],
+    })
+    expect(h.result).toBe(true)
+    expect(names(h)).toContain("health.check")
+  })
+
+  it("refuses a build turn adding a test file", async () => {
+    const h = await drive(shape(), {
+      build: [change("src/a.test.ts", undefined, "b", "added")],
     })
     expect((h.result as Error).message).toContain("refactor-tests")
     expect((h.result as Error).message).toContain("src/a.test.ts")
     expect(names(h)).not.toContain("health.check")
   })
 
-  it("says never a test file in the package rules", async () => {
+  it("lets the package rules admit only an existing test file's call sites", async () => {
     const h = await drive(shape())
-    expect(bodyOf(h, 0)).toContain("never a test file")
-    expect(bodyOf(h, 0)).not.toContain("only when it is one of them")
+    expect(bodyOf(h, 0)).toContain("never add or delete a test file")
+    expect(bodyOf(h, 0)).toContain("never add, remove or alter a test or an assertion")
+  })
+
+  it("names the reference's seam as the change to carry, when there is a reference", async () => {
+    const withRef = await drive(shape(), { reference: "abc1234" })
+    expect(bodyOf(withRef, 0)).toMatch(/seam/)
+    expect(buildingPrompt(withRef)).toMatch(/touches none of it/)
+    const bare = await drive(shape())
+    expect(buildingPrompt(bare)).not.toMatch(/touches none of it/)
   })
 
   it("refuses a build turn adding a flag read", async () => {
@@ -734,7 +897,7 @@ describe("reviewedRefactor", () => {
     const body = derive?.kind === "run" ? derive.body : ""
     expect(body).toContain("`src/a.ts`") // gtd-path-exempt: fixture paths
     expect(body).not.toContain("a.test.ts")
-    expect(h.scopes[0]?.access).toEqual({ write: ["src/a.ts", ".gtd/**"] })
+    expect(h.scopes[0]?.access).toEqual({ write: ["src/a.ts", ...testFileGlobs, ".gtd/**"] })
     const collecting = h.steps.find((s) => s.kind === "agent" && s.name === "review.collecting")
     const prompt = collecting?.kind === "agent" ? collecting.prompt : ""
     expect(prompt).toContain("`src/a.ts`") // gtd-path-exempt: fixture paths
@@ -958,14 +1121,18 @@ describe("reviewedRefactor", () => {
       const h = await driveReviewed(shape({ strays: ["src/a.ts", "src/a.test.ts"] }), {
         notes: ["add — typo"],
         answers: { "note-1": { answer: "nit", p: 0.9 } },
-        turns: { "refactor.build.review.fix.nits.fixing": [change("src/a.test.ts", "a", "b")] },
+        turns: {
+          "refactor.build.review.fix.nits.fixing": [
+            change("src/a.test.ts", undefined, "b", "added"),
+          ],
+        },
       })
       expect((h.result as Error).message).toContain("refactor-tests")
       expect(h.names.at(-1)).toBe("refactor.build.review.fix.nits.fixing")
     })
 
-    it("runs the nit-fix turn under the strays plus .gtd/** as its write access", async () => {
-      const write = ["src/a.ts", ".gtd/**"]
+    it("runs the nit-fix turn under the strays, test files and .gtd/** as its write access", async () => {
+      const write = ["src/a.ts", ...testFileGlobs, ".gtd/**"]
       const h = await driveReviewed(shape({ strays: ["src/a.ts", "src/a.test.ts"] }), {
         notes: ["add — typo"],
         answers: { "note-1": { answer: "nit", p: 0.9 } },
@@ -979,7 +1146,7 @@ describe("reviewedRefactor", () => {
         notes: ["add — typo"],
         answers: { "note-1": { answer: "nit", p: 0.9 } },
         reds: 2,
-        turns: { "refactor.build.fix": [change("src/a.test.ts", "x", "y")] },
+        turns: { "refactor.build.fix": [change("src/a.test.ts", "x", undefined, "deleted")] },
       })
       expect(h.names).toContain("refactor.build.fix")
       expect((h.result as Error).message).toContain("refactor-tests")
@@ -1031,11 +1198,11 @@ describe("reviewedRefactor's tail prompts", () => {
     ],
     ["refactor.build.health.describe", { findings: true, reds: 6 }],
   ] as const)(
-    "%s names every stray and bans test files and new flag reads",
+    "%s names every stray and bans new test files and new flag reads",
     async (name, script) => {
       const prompt = await promptAt(name, script as ReviewedScript)
       for (const stray of strays) expect(prompt).toContain(`\`${stray}\``)
-      expect(prompt).toContain("never a test file")
+      expect(prompt).toContain("never add or delete a test file")
       expect(prompt).toContain("no new flag read")
     },
   )