@pmelab/gtd 27.1.0 → 27.3.0

package/dist/workflows/feature.mjs

@@ -1,6 +1,7 @@
-import { answered, changes, changesSince, glob, hasThreadFor, head, human, judge, numeric, read, refuse, removeScript, requireAnswers, requireProgress, requireReplies, requireRevert, requireThreadsClosed, restoreScript, revertScript, run, scope, start, vars } from "../flows.mjs";
+import { answered, changes, changesSince, glob, hasThreadFor, head, human, judge, numeric, quote, read, refuse, removeScript, requireAnswers, requireProgress, requireReplies, requireRevert, requireThreadsClosed, restoreScript, revertScript, run, scope, start, vars } from "../flows.mjs";
 import { review as review$1 } from "../workflow-kit.mjs";
-import { $ as unwindFailedMessage, A as architectureDecomposePrompt, B as designSystem, C as fixRisks, D as agentWithSkills, E as reviewing, F as buildReviewFixNitsPrompt, G as packagesItemBuildingPrompt, I as buildReviewTriageMessage, J as reviewEditsCapture, K as packagesItemFixSuitePrompt, L as builderSystem, M as buildReviewAnswerQuestionsPrompt, N as buildReviewAwaitAfterDeferMessage, O as architectSystem, P as buildReviewCollectingPrompt, Q as startGateBlockedMessage, R as deferNotesScript, S as fixCheck, T as reviewMissing, V as designTriagePrompt, W as idleMessage, X as reviewNotesCapture, Z as reviewerSystem, _ as FEEDBACK, b as awaitReview, c as refusePendingHandOff, d as defaults, et as unwindFailure, f as envDefaults, g as ARCHITECTURE, h as healthy, i as skills, j as architectureGateAnswerMessage, k as architectureAuthorPrompt, l as tail, m as gate, n as summary, o as closeReview, q as reviewEditNotesCapture, r as access, t as steering, u as shipped, v as REQUIREMENTS, w as planner, x as coder, y as REVIEW, z as designGateAnswerMessage } from "../chunks/reserved-BL9krPao.mjs";
+import { A as architectureAuthorPrompt, B as designGateAnswerMessage, C as fixRisks, D as reviewing, F as buildReviewCollectingPrompt, H as designTriagePrompt, I as buildReviewFixNitsPrompt, J as packagesItemFixSuitePrompt, K as idleMessage, L as buildReviewTriageMessage, M as architectureGateAnswerMessage, N as buildReviewAnswerQuestionsPrompt, O as agentWithSkills, P as buildReviewAwaitAfterDeferMessage, Q as reviewEditsCapture, R as builderSystem, T as reviewMissing, V as designSystem, X as refactorFixPrompt, Y as refactorBuildingPrompt, Z as reviewEditNotesCapture, _ as REQUIREMENTS, b as coder, c as envDefaults, d as gate, et as reviewNotesCapture, h as FEEDBACK, i as skills, it as unwindFailure, j as architectureDecomposePrompt, k as architectSystem, m as ARCHITECTURE, n as summary, nt as startGateBlockedMessage, o as shipped, p as healthy, q as packagesItemBuildingPrompt, r as access, rt as unwindFailedMessage, s as defaults, t as steering, tt as reviewerSystem, v as REVIEW, w as planner, x as fixCheck, y as awaitReview, z as deferNotesScript } from "../chunks/reserved-BPdVZkgv.mjs";
+import { a as tail, i as refusePendingHandOff, n as closeReview } from "../chunks/tail-iLAMoigl.mjs";
 //#region src/workflows/feature/steps.ts
 /** Turn the sketch since `base` into `.gtd/REQUIREMENTS.md`. */
 const triage = (base) => agentWithSkills("triage", designTriagePrompt(base), {
@@ -281,7 +282,7 @@ const triage$1 = (severities) => async (notes) => {
 		return [n.id, severity.tier === "could" ? "defer" : "edit"];
 	}));
 };
-const isCode = (path) => path !== ".gtd" && !path.startsWith(".gtd/");
+const isCode$1 = (path) => path !== ".gtd" && !path.startsWith(".gtd/");
 /**
 * A reviewer writes `.gtd/REVIEW.md` over everything since `base`, a human
 * reviews and signs off or comments, and each note is judged: edits go to
@@ -294,7 +295,7 @@ const review = (base, escalations = { rounds: 0 }) => {
 	return review$1(base, {
 		file: REVIEW,
 		feedback: REQUIREMENTS,
-		isCode,
+		isCode: isCode$1,
 		reviewing: (b, carry) => {
 			deferred = [];
 			return reviewing(b, carry);
@@ -404,7 +405,120 @@ const ordinaryStart = async () => {
 };
 const feature = shipped(ordinaryStart);
 //#endregion
+//#region src/workflows/feature/refactor.ts
+const REFACTOR_PACKAGE = ".gtd/REFACTOR.md";
+const isCode = (path) => path !== ".gtd" && !path.startsWith(".gtd/");
+const requireWithin = (allowed) => {
+	const outside = changes().map((c) => c.path).filter((path) => isCode(path) && !allowed.includes(path));
+	if (outside.length === 0) return;
+	refuse(`gtd land: refactor-scope: the refactor may change only its stray paths — revert these:\n${outside.map((path) => `  - ${path}`).join("\n")}`);
+};
+const flagExpression = (pattern) => {
+	if (pattern.trim() === "") throw new Error("gtd: refactorFlagPattern must not be blank");
+	let expression;
+	try {
+		expression = new RegExp(pattern, "g");
+	} catch (error) {
+		throw new Error(`gtd: refactorFlagPattern is not a valid regular expression: ${String(error)}`);
+	}
+	if (expression.test("")) throw new Error("gtd: refactorFlagPattern must not match the empty string");
+	return expression;
+};
+const countFlags = (text, expression, into) => {
+	let zeroLength = false;
+	for (const [name] of text.matchAll(expression)) if (name === "") zeroLength = true;
+	else into.set(name, (into.get(name) ?? 0) + 1);
+	return zeroLength;
+};
+const listPaths = (paths) => paths.map((path) => `  - ${path}`).join("\n");
+const requireNoNewFlags = (pattern, since) => {
+	const expression = flagExpression(pattern);
+	const before = /* @__PURE__ */ new Map();
+	const after = /* @__PURE__ */ new Map();
+	const unreadable = [];
+	const zeroLength = [];
+	for (const { path, status, before: was, after: now } of changesSince(since)) {
+		if (!isCode(path)) continue;
+		const oldSide = status === "added" ? "" : was;
+		const newSide = status === "deleted" ? "" : now;
+		if (oldSide === void 0 || newSide === void 0) {
+			unreadable.push(path);
+			continue;
+		}
+		countFlags(oldSide, expression, before);
+		if (countFlags(newSide, expression, after)) zeroLength.push(path);
+	}
+	if (unreadable.length > 0) refuse(`gtd land: refactor-flags: cannot compare flag reads in:\n${listPaths(unreadable)}`);
+	if (zeroLength.length > 0) refuse(`gtd land: refactor-flags: refactorFlagPattern (${pattern}) produced a zero-length match in:\n${listPaths(zeroLength)}`);
+	const raised = [...after].filter(([name, count]) => count > (before.get(name) ?? 0));
+	if (raised.length === 0) return;
+	refuse(`gtd land: refactor-flags: the refactor may not introduce or add reads of a flag (${pattern}):\n${raised.map(([name, count]) => `  - ${name}: ${before.get(name) ?? 0} → ${count}`).join("\n")}`);
+};
+const packageLines = (strays, pattern, reference) => [
+	"# Behaviour-neutral refactor",
+	"",
+	"## Scope (read-only)",
+	"",
+	...strays.map((path) => `- \`${path}\``),
+	"",
+	"This list is fixed when the package is derived: editing it here widens or narrows nothing.",
+	"",
+	"## Rules",
+	"",
+	"- The suite's outcome must not change",
+	"- Change only the paths above; a test file only when it is one of them",
+	`- Introduce no flag read and add no second read of an existing one (\`${pattern}\`)`,
+	"",
+	"## Reference",
+	"",
+	reference === void 0 ? "None." : `Reading material only, never applied: \`git show ${reference} -- ${strays.map(quote).join(" ")}\``,
+	""
+];
+const deriveScript = (lines) => `mkdir -p .gtd
+printf '%s\\n' ${lines.map(quote).join(" ")} > ${quote(REFACTOR_PACKAGE)}
+`;
+const refactorFirst = async (shape, options = {}) => {
+	if (shape.choice !== "refactor-first" || shape.unreadable.length > 0) return false;
+	const pattern = vars.refactorFlagPattern ?? defaults.refactorFlagPattern;
+	const expression = flagExpression(pattern);
+	const { strays } = shape;
+	const zeroLength = strays.filter((path) => countFlags(read(path) ?? "", expression, /* @__PURE__ */ new Map()));
+	if (zeroLength.length > 0) throw new Error(`gtd: refactorFlagPattern (${pattern}) produces a zero-length match in:\n${listPaths(zeroLength)}`);
+	const reference = options.reference?.trim() ? options.reference : void 0;
+	return scope({
+		name: "refactor",
+		access: { write: [...strays, ".gtd/**"] }
+	}, async () => {
+		await run("deriving", deriveScript(packageLines(strays, pattern, reference)), {
+			label: "Deriving the refactor package",
+			file: REFACTOR_PACKAGE
+		});
+		const from = head();
+		const guard = () => {
+			requireWithin(strays);
+			requireNoNewFlags(pattern, from);
+		};
+		await agentWithSkills("building", refactorBuildingPrompt(REFACTOR_PACKAGE, strays, pattern, reference), {
+			label: "Refactoring",
+			model: coder(),
+			system: builderSystem()
+		});
+		guard();
+		await healthy(async () => {
+			await agentWithSkills("fix.suite.fixing", refactorFixPrompt(strays, pattern), {
+				label: "Fixing the check",
+				file: FEEDBACK,
+				model: coder(),
+				system: builderSystem()
+			});
+			guard();
+		}, { describeGuard: guard });
+		await run("closing", removeScript([REFACTOR_PACKAGE]), { label: "Closing out the refactor" });
+		return true;
+	});
+};
+//#endregion
 //#region src/workflows/feature/index.ts
 var feature_default = feature;
 //#endregion
-export { access, afterTail, answerProductQuestions, answerReviewQuestions, answerTechnicalQuestions, architecture, author, build, buildTail, collecting, declaredTests, decompose, feature_default as default, defaults, deferNotes, design, envDefaults, feature, fixNits, fixSuite, nextPackage, ordinaryStart, packageItem, packages, planAndBuild, reUnwind, requireDeclaredTests, skills, steering, summary, triage, unwind };
+export { REFACTOR_PACKAGE, access, afterTail, answerProductQuestions, answerReviewQuestions, answerTechnicalQuestions, architecture, author, build, buildTail, collecting, declaredTests, decompose, feature_default as default, defaults, deferNotes, design, envDefaults, feature, fixNits, fixSuite, nextPackage, ordinaryStart, packageItem, packages, planAndBuild, reUnwind, refactorFirst, requireDeclaredTests, requireNoNewFlags, requireWithin, skills, steering, summary, triage, unwind };

package/dist/workflows/fix.mjs

@@ -1,6 +1,7 @@
 import { read, refuse, removeScript, run, scope, start } from "../flows.mjs";
 import { d as reviewNotes, f as reviewRisks } from "../chunks/steering-DVILanVf.mjs";
-import { D as agentWithSkills, H as finisherSystem, U as fixReviewNotesPrompt, a as REVIEW_ORIG, d as defaults, f as envDefaults, i as skills, n as summary, p as baseline, r as access, s as handOffTail, t as steering, u as shipped, x as coder, y as REVIEW } from "../chunks/reserved-BL9krPao.mjs";
+import { O as agentWithSkills, U as finisherSystem, W as fixReviewNotesPrompt, b as coder, c as envDefaults, i as skills, l as baseline, n as summary, o as shipped, r as access, s as defaults, t as steering, v as REVIEW } from "../chunks/reserved-BPdVZkgv.mjs";
+import { r as handOffTail, t as REVIEW_ORIG } from "../chunks/tail-iLAMoigl.mjs";
 //#region src/workflows/fix/fix.ts
 /**
 * Fix every note a human left in a handed-off `.gtd/REVIEW.md` and every

package/dist/workflows/review.mjs

@@ -1,5 +1,6 @@
 import { start } from "../flows.mjs";
-import { Y as reviewGateBlockedMessage, c as refusePendingHandOff, d as defaults, f as envDefaults, i as skills, m as gate, n as summary, r as access, s as handOffTail, t as steering, u as shipped } from "../chunks/reserved-BL9krPao.mjs";
+import { $ as reviewGateBlockedMessage, c as envDefaults, d as gate, i as skills, n as summary, o as shipped, r as access, s as defaults, t as steering } from "../chunks/reserved-BPdVZkgv.mjs";
+import { i as refusePendingHandOff, r as handOffTail } from "../chunks/tail-iLAMoigl.mjs";
 //#region src/workflows/review/review.ts
 /**
 * Pure review of everything since `reviewBase`: a green gate, the quality

package/dist/workflows/rollout.mjs

@@ -0,0 +1,33 @@
+import { agent, changesSince, head, read, refuse, scope, vars } from "../flows.mjs";
+import { a as flagShipped, b as coder, c as envDefaults, d as gate, i as skills, n as summary, r as access, s as defaults, t as steering } from "../chunks/reserved-BPdVZkgv.mjs";
+import { i as requireFlag, n as flipProblems } from "../chunks/registry-CP3YuV9j.mjs";
+//#region src/workflows/rollout/rollout.ts
+const flippingPrompt = (name, registry) => `Roll out the release flag "${name}": in ${registry}, set \`defaultOn: true\` on its entry. Change nothing else — no other entry, no other field, no other file, no comments.`;
+const suiteBlockedMessage = () => "The suite is red after the rollout. Fix it by hand — a rollout may only touch the flag's registry entry — then land.";
+const rolloutFlow = async () => {
+	const registry = vars.flagRegistry ?? "";
+	const name = vars.flag ?? "";
+	requireFlag("rollout", registry, name, false);
+	const base = head();
+	const before = read(registry) ?? "";
+	const guard = () => {
+		const strays = changesSince(base).paths.filter((path) => path !== registry && path !== ".gtd/FEEDBACK.md");
+		if (strays.length > 0) refuse(`gtd land: rollout-only: ${strays.join(", ")} changed — rollout may only set defaultOn: true on "${name}" in ${registry}`);
+		const problems = flipProblems(before, read(registry) ?? "", name);
+		if (problems.length > 0) refuse(`gtd land: rollout-only: other edits in ${registry}: ${problems.join("; ")}`);
+	};
+	await scope("rollout", async () => {
+		await agent("flipping", flippingPrompt(name, registry), {
+			label: `Rolling out ${name}`,
+			model: coder()
+		});
+		guard();
+		await gate("suite", suiteBlockedMessage(), guard);
+	});
+};
+const rollout = flagShipped(rolloutFlow);
+//#endregion
+//#region src/workflows/rollout/index.ts
+var rollout_default = rollout;
+//#endregion
+export { access, rollout_default as default, defaults, envDefaults, rollout, rolloutFlow, skills, steering, summary };