@pmelab/gtd 19.0.0 → 20.0.1

package/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "gtd",
-  "version": "19.0.0",
+  "version": "20.0.1",
   "description": "Drive the gtd loop inside Claude Code: agent turns run as subagents, gtd decides every beat",
   "author": {
     "name": "Philipp Melab"

package/README.md

@@ -46,9 +46,9 @@ enforces it at the OS level. See
 
 > **A repository's `gtd.config.ts` is code, and gtd runs it.** A custom workflow
 > is a TypeScript module, and every gtd command that looks at workflow state —
-> `gtd next` and `gtd lsp` included, not just `gtd land` — evaluates it. Treat
-> it like a Makefile or a `package.json` script: don't run gtd in a checkout you
-> don't trust.
+> `gtd next`, `gtd lsp`, `gtd door` and `gtd doors` included, not just
+> `gtd land` — evaluates it. Treat it like a Makefile or a `package.json`
+> script: don't run gtd in a checkout you don't trust.
 
 ## Quick start
 
@@ -307,14 +307,14 @@ Then, in any repository:
 ```
 
 That starts a process from your requirements and drives it until it needs you.
-`/gtd fix` and `/gtd review [base]` take the two side doors described below.
-Every human rest opens Claude Code's own question dialog, with a link to
-`gtd ui` for the step; review there, then answer **I'm done, continue**. When
-the process finishes, **Yes, open the pull request** (or `/gtd ship`) squashes
-it into one commit and opens it. A process can change hands at any gate: **Hand
-off to someone else** (or `/gtd throw @dev`) opens a draft pull request assigned
-to them, and `/gtd catch <pr>` picks it up exactly where it waits, so whoever
-wrote the requirements can hand the architecture to someone else. See
+`/gtd fix` and `/gtd review [base]` take the two doors described below. Every
+human rest opens Claude Code's own question dialog, with a link to `gtd ui` for
+the step; review there, then answer **I'm done, continue**. When the process
+finishes, **Yes, open the pull request** (or `/gtd ship`) squashes it into one
+commit and opens it. A process can change hands at any gate: **Hand off to
+someone else** (or `/gtd throw @dev`) opens a draft pull request assigned to
+them, and `/gtd catch <pr>` picks it up exactly where it waits, so whoever wrote
+the requirements can hand the architecture to someone else. See
 [Inside Claude Code](https://github.com/pmelab/gtd/blob/main/docs/driver.md#inside-claude-code-the-gtd-mod).
 
 ### Then let an agent build your own
@@ -332,28 +332,28 @@ you what you want before it starts driving. You get one prompt to paste, not a
 state name to choose. The four commands: **`gtd-build`** drives beats until the
 process rests; **`gtd-edit`** opens the steering file the process is waiting on
 right now — falling back to `.gtd/TODO.md` when the resting state declares none;
-**`gtd-review <commitish>`** starts a review round over that commitish and
-drives it; **`gtd-fix`** enters the fix process and drives it. The
-`.gtd/TODO.md` fallback is also how you begin: on a clean repository the edit
-command opens the empty `.gtd/TODO.md`, and whatever you write there is the
-first sketch the whole process gets planned from. As a final step, if it finds
-an LSP-capable editor, the briefing also offers to wire up live diagnostics and
-review actions in it — asking first and naming the exact file, and merging
-rather than overwriting your editor's config. That editor integration also adds
-a footnote at the exact cursor position with one code action, landing the cursor
-in the new, empty definition ready to type, and jumps between a footnote's
-marker and its definition both ways — so leaving a comment for the next agent
-turn never means hand-typing the `[^name]` syntax yourself. In a review file, a
-`./path#42-70` hunk pointer is also a clickable link straight to that file and
-range, no go-to-definition required. A footnote can also hold a `H:`/`A:`
-conversation (a thread — see [configuration](docs/configuration.md)); the editor
-outlines threads, flags the open ones, and a `gtd: reply` code action adds your
-empty `- H:` entry and puts the cursor there;
-`gtd check <mode> <file> --open-threads` lists the ones still waiting on you,
-and a review question gets its answer at the review gate again, not a lap. The
-same conversation works as bare `// H: …` / `// A: …` line comments (`#`, `--`,
-`;` by language) in files the process changed; `gtd check --open-threads` alone
-lists the open ones (editor-only — the phone UI does not show them).
+**`gtd-door <name> [args...]`** starts a process through a door (`gtd-door fix`,
+`gtd-door review [base]`) and drives it. The `.gtd/TODO.md` fallback is also how
+you begin: on a clean repository the edit command opens the empty
+`.gtd/TODO.md`, and whatever you write there is the first sketch the whole
+process gets planned from. As a final step, if it finds an LSP-capable editor,
+the briefing also offers to wire up live diagnostics and review actions in it —
+asking first and naming the exact file, and merging rather than overwriting your
+editor's config. That editor integration also adds a footnote at the exact
+cursor position with one code action, landing the cursor in the new, empty
+definition ready to type, and jumps between a footnote's marker and its
+definition both ways — so leaving a comment for the next agent turn never means
+hand-typing the `[^name]` syntax yourself. In a review file, a `./path#42-70`
+hunk pointer is also a clickable link straight to that file and range, no
+go-to-definition required. A footnote can also hold a `H:`/`A:` conversation (a
+thread — see [configuration](docs/configuration.md)); the editor outlines
+threads, flags the open ones, and a `gtd: reply` code action adds your empty
+`- H:` entry and puts the cursor there; `gtd check <mode> <file> --open-threads`
+lists the ones still waiting on you, and a review question gets its answer at
+the review gate again, not a lap. The same conversation works as bare `// H: …`
+/ `// A: …` line comments (`#`, `--`, `;` by language) in files the process
+changed; `gtd check --open-threads` alone lists the open ones (editor-only — the
+phone UI does not show them).
 
 ### The workflow it ships with
 
@@ -422,8 +422,8 @@ noted in steps 3 and 4 below.
    them once, with no re-review after the fix. A clean turn means approval only
    when that lens found nothing at all. This lap is where code quality is looked
    at, and every round pays for it. It never replaces step 4 — your review stays
-   the final gate, and nothing here skips it. The `gtd --entry fix-precheck`
-   side door (below) repairs a red baseline through this same lap.
+   the final gate, and nothing here skips it. The `fix` door (below) repairs a
+   red baseline through this same lap.
 
    A red suite that keeps failing past a few fix attempts escalates instead of
    retrying forever: an agent turn reads the failing output and writes
@@ -478,15 +478,17 @@ the agent may overturn the answer. See
 [Configuration](https://github.com/pmelab/gtd/blob/main/docs/configuration.md)
 for its `ui:` settings.
 
-Two side doors skip step 1. `gtd --entry fix-precheck` repairs a red baseline as
-its own reviewed commit instead of starting a process. And
+The bundled workflows are named `feature` (the ordinary start above), `fix` and
+`review`. Two doors start the other two and skip step 1. `gtd door fix` repairs
+a red baseline as its own reviewed commit instead of starting a process. And
 
 ```bash
-gtd --entry review-gate.check --var reviewBase=<commitish>
+gtd door review <commitish>
 ```
 
 starts a pure review of everything from `<commitish>` to HEAD — straight to step
-4, no planning and no building.
+4, no planning and no building. `gtd doors` lists every door; a `gtd.config.ts`
+can add its own. `gtd --workflow <name>` starts any workflow by name.
 
 The workflow itself is a plain async TypeScript function: a `gtd.config.ts` at
 the repository root replaces it, and the pieces the bundled one is built from

package/claude/hooks/access.ts

@@ -1,5 +1,3 @@
-import { isAbsolute, relative, resolve } from "node:path"
-
 import { globMatches } from "../../src/replay/Glob.js"
 
 export type AccessDef = { read: string[] | null; write: string[] | null }
@@ -12,10 +10,19 @@ const WRITE: Record<string, string> = {
   NotebookEdit: "notebook_path",
 }
 
+// Hand-rolled because a hooks module may not import `node:path`.
+const segments = (p: string): string[] =>
+  p.split("/").reduce<string[]>((out, s) => {
+    if (s === "..") out.pop()
+    else if (s && s !== ".") out.push(s)
+    return out
+  }, [])
+
 // Repo-relative form of a path; undefined when it lies outside the repo.
 const inRepo = (p: string, root: string): string | undefined => {
-  const rel = relative(root, isAbsolute(p) ? p : resolve(root, p))
-  return rel === ".." || rel.startsWith("../") || isAbsolute(rel) ? undefined : rel
+  const base = segments(root)
+  const target = segments(p.startsWith("/") ? p : `${root}/${p}`)
+  return base.every((s, i) => target[i] === s) ? target.slice(base.length).join("/") : undefined
 }
 
 const deny = (verb: string, path: string, globs: string[]) =>

package/claude/hooks/doors.ts

@@ -0,0 +1,34 @@
+// Doors are the workflow's named shortcuts into a process (`gtd doors`). gtd
+// prints the script that starts one; running it is the driver's job, as with
+// every git write gtd plans. The mod hardcodes no door: it asks gtd.
+
+import type { ShipIo, Shipped } from "./ship"
+
+export type Door = {
+  name: string
+  workflow: string
+  args: { name: string; optional: boolean }[]
+}
+
+const fail = (text: string): Shipped => ({ ok: false, text })
+
+// Every door the repository offers; none when gtd cannot say.
+export async function doors(io: ShipIo): Promise<Door[]> {
+  const listed = await io.run(["gtd", "doors", "--json"])
+  if (listed.code !== 0) return []
+  try {
+    return JSON.parse(listed.out) as Door[]
+  } catch {
+    return []
+  }
+}
+
+export async function enter(io: ShipIo, name: string, args: string[]): Promise<Shipped> {
+  const argv = ["gtd", "door", name, ...args]
+  const planned = await io.run(argv)
+  if (planned.code !== 0)
+    return fail(planned.err.trim() || `${argv.join(" ")} exited ${planned.code}`)
+  const started = await io.run(["sh", "-c", planned.out])
+  if (started.code !== 0) return fail(`The door script failed.\n${started.err.trim()}`)
+  return { ok: true, text: `Started ${name}.` }
+}

package/claude/hooks/drive.ts

@@ -7,6 +7,7 @@ import type { AccessDef } from "./access"
 export type Beat = {
   kind: string
   idle?: boolean | string
+  initial?: boolean | string
   state?: string
   label?: string
   file?: string

package/claude/hooks/register.tsx

@@ -6,7 +6,7 @@ import { accessDenial } from "./access"
 import type { AccessDef } from "./access"
 import { afterReload, drive, isTrue } from "./drive"
 import type { Beat, Io, Landing, Turn, TurnEnd } from "./drive"
-import { enter } from "./entry"
+import { doors, enter } from "./doors"
 import { subagentModel } from "./models"
 import { personaSpec, resumable } from "./persona"
 import { JUDGE_SYSTEM, judgePrompt, toVerdicts } from "./judge"
@@ -257,11 +257,11 @@ async function start($: $, landTurn?: string) {
 async function begin($: $, requirements: string) {
   await findRoot($)
   const b = JSON.parse(await gtd($, ["next", "--json"])) as Beat
-  if (b.state === "idle" && !isTrue(b.idle)) {
+  if (isTrue(b.initial) && !isTrue(b.idle)) {
     const paths = (b.changes ?? []).map((c) => c.path).join(", ")
     return `The working tree has uncommitted changes (${paths}); gtd would start from those. Commit, stash or revert them, or run /gtd to start from them.`
   }
-  if (b.state !== "idle") {
+  if (!isTrue(b.initial)) {
     return `A gtd process is already underway at ${b.state}. Run /gtd to continue it.`
   }
   const file = b.file ?? ".gtd/TODO.md"
@@ -381,7 +381,7 @@ async function throwNow($: $, target: string | undefined) {
     state: b.state,
     label: b.label,
     content: b.content,
-    isIdle: b.state === "idle" && isTrue(b.idle),
+    isIdle: isTrue(b.idle),
   }
   const thrown = await throwTo(shipIo($), rest, target, new Date().toISOString()).catch(
     (err: unknown) => ({ ok: false, text: String(err) }),
@@ -401,9 +401,9 @@ async function throwNow($: $, target: string | undefined) {
   }
 }
 
-async function enterNow($: $, door: "fix" | "review", base: string | undefined) {
+async function enterNow($: $, door: string, args: string[]) {
   if ((await read($, run)).isRunning) return "Stop the loop first: /gtd stop."
-  const entered = await enter(shipIo($), door, base)
+  const entered = await enter(shipIo($), door, args)
   if (entered.ok) await start($)
   return entered.text
 }
@@ -655,9 +655,6 @@ async function command($: $, arg: string): Promise<string | undefined> {
   switch (verb) {
     case "status":
       return gtd($, ["next"])
-    case "fix":
-    case "review":
-      return enterNow($, verb, rest[0])
     case "throw":
       void throwNow($, rest[0])
       return undefined
@@ -671,14 +668,16 @@ async function command($: $, arg: string): Promise<string | undefined> {
     case "":
       return resume($)
     default:
-      return begin($, arg)
+      return (await doors(shipIo($))).some((d) => d.name === verb)
+        ? enterNow($, verb, rest)
+        : begin($, arg)
   }
 }
 
 async function resume($: $) {
   const b = JSON.parse(await gtd($, ["next", "--json"])) as Beat
-  if (b.state === "idle" && isTrue(b.idle)) {
-    return "Nothing is in progress. Start a process with /gtd <requirements>, or sketch the change in .gtd/TODO.md and run /gtd."
+  if (isTrue(b.idle)) {
+    return `Nothing is in progress. Start a process with /gtd <requirements>, or sketch the change in ${b.file ?? ".gtd/TODO.md"} and run /gtd.`
   }
   await start($)
   return undefined
@@ -726,7 +725,7 @@ export const register: Register = (on) => {
       name: "gtd",
       description: "Drive gtd until it rests on you; pass requirements to start a new process",
       argumentHint:
-        "[requirements | fix | review [base] | stop | status | ship [-n] | throw [@user] | catch <pr|branch>]",
+        "[requirements | <door> [args] | stop | status | ship [-n] | throw [@user] | catch <pr|branch>]",
       immediate: true,
     })
     return next(e)

package/claude/hooks/ship.ts

@@ -162,8 +162,9 @@ async function squash(
   }
   // `gtd summary` also describes a process still underway; shipping that
   // would publish half of it.
-  const state = (await io.run(["gtd", "next", "--json=state"])).out.trim()
-  if (state !== "idle") {
+  const initial = (await io.run(["gtd", "next", "--json=initial"])).out.trim()
+  if (initial !== "true") {
+    const state = (await io.run(["gtd", "next", "--json=state"])).out.trim()
     return fail(`The gtd process is still underway (at ${state}). Finish it, then ship.`)
   }
   const range = await processRange(git, summary.out)