@pluv/client 0.23.0 → 0.24.1

package/.turbo/turbo-build.log

@@ -1,5 +1,5 @@
 
-> @pluv/client@0.23.0 build /home/runner/work/pluv/pluv/packages/client
+> @pluv/client@0.24.1 build /home/runner/work/pluv/pluv/packages/client
 > tsup src/index.ts --format esm,cjs --dts
 
 CLI Building entry: src/index.ts
@@ -8,11 +8,11 @@
 CLI Target: es6
 ESM Build start
 CJS Build start
-ESM dist/index.mjs 41.86 KB
-ESM ⚡️ Build success in 124ms
-CJS dist/index.js 43.13 KB
-CJS ⚡️ Build success in 140ms
+CJS dist/index.js 43.49 KB
+CJS ⚡️ Build success in 150ms
+ESM dist/index.mjs 42.22 KB
+ESM ⚡️ Build success in 151ms
 DTS Build start
-DTS ⚡️ Build success in 3033ms
+DTS ⚡️ Build success in 3226ms
 DTS dist/index.d.mts 14.60 KB
 DTS dist/index.d.ts  14.60 KB

package/CHANGELOG.md

@@ -1,5 +1,20 @@
 # @pluv/client
 
+## 0.24.1
+
+### Patch Changes
+
+- ba299e2: Fixed "others" state in the PluvClient not getting cleared when the user's websocket connection is closed, creating "ghost users" during some reconnects.
+  - @pluv/crdt@0.24.1
+  - @pluv/types@0.24.1
+
+## 0.24.0
+
+### Patch Changes
+
+- @pluv/crdt@0.24.0
+- @pluv/types@0.24.0
+
 ## 0.23.0
 
 ### Patch Changes

package/dist/index.js

@@ -188,6 +188,13 @@ var OtherNotifier = class {
   constructor() {
     this.subjects = /* @__PURE__ */ new Map();
   }
+  clear() {
+    const connectionIds = Array.from(this.subjects.keys());
+    connectionIds.forEach((connectionId) => {
+      this.subject(connectionId).next(null);
+      this.subjects.delete(connectionId);
+    });
+  }
   subject(name) {
     const subject = this.subjects.get(name);
     if (subject) return subject;
@@ -271,6 +278,9 @@ var UsersManager = class {
   removeUser(connectionId) {
     this._others.delete(connectionId);
   }
+  removeUsers() {
+    this._others.clear();
+  }
   setMyself(connectionId, user) {
     this._myself = {
       connectionId,
@@ -810,6 +820,10 @@ var PluvRoom = class extends AbstractRoom {
     this._clearTimeout(this._timeouts.reconnect);
     this._detachWindowListeners();
     this._usersManager.removeMyself();
+    this._usersManager.removeUsers();
+    this._otherNotifier.clear();
+    this._stateNotifier.subjects.myself.next(null);
+    this._stateNotifier.subjects.others.next([]);
     const canClose = [WebSocket.CONNECTING, WebSocket.OPEN].some(
       (readyState) => {
         var _a2;
@@ -1097,8 +1111,6 @@ var PluvRoom = class extends AbstractRoom {
       this._logDebug("WebSocket event received: ", message.type, message);
     }
     this._eventNotifier.subject(message.type).next(message);
-    const { connectionId } = message;
-    if (!connectionId) return;
     switch (message.type) {
       case "$EXIT": {
         this._handleExit(message);

package/dist/index.mjs

@@ -159,6 +159,13 @@ var OtherNotifier = class {
   constructor() {
     this.subjects = /* @__PURE__ */ new Map();
   }
+  clear() {
+    const connectionIds = Array.from(this.subjects.keys());
+    connectionIds.forEach((connectionId) => {
+      this.subject(connectionId).next(null);
+      this.subjects.delete(connectionId);
+    });
+  }
   subject(name) {
     const subject = this.subjects.get(name);
     if (subject) return subject;
@@ -242,6 +249,9 @@ var UsersManager = class {
   removeUser(connectionId) {
     this._others.delete(connectionId);
   }
+  removeUsers() {
+    this._others.clear();
+  }
   setMyself(connectionId, user) {
     this._myself = {
       connectionId,
@@ -781,6 +791,10 @@ var PluvRoom = class extends AbstractRoom {
     this._clearTimeout(this._timeouts.reconnect);
     this._detachWindowListeners();
     this._usersManager.removeMyself();
+    this._usersManager.removeUsers();
+    this._otherNotifier.clear();
+    this._stateNotifier.subjects.myself.next(null);
+    this._stateNotifier.subjects.others.next([]);
     const canClose = [WebSocket.CONNECTING, WebSocket.OPEN].some(
       (readyState) => {
         var _a2;
@@ -1068,8 +1082,6 @@ var PluvRoom = class extends AbstractRoom {
       this._logDebug("WebSocket event received: ", message.type, message);
     }
     this._eventNotifier.subject(message.type).next(message);
-    const { connectionId } = message;
-    if (!connectionId) return;
     switch (message.type) {
       case "$EXIT": {
         this._handleExit(message);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pluv/client",
-  "version": "0.23.0",
+  "version": "0.24.1",
   "description": "@pluv/io frontend client",
   "author": "leedavidcs",
   "license": "MIT",
@@ -18,15 +18,15 @@
   },
   "dependencies": {
     "wonka": "^6.3.4",
-    "@pluv/crdt": "^0.23.0",
-    "@pluv/types": "^0.23.0"
+    "@pluv/crdt": "^0.24.1",
+    "@pluv/types": "^0.24.1"
   },
   "devDependencies": {
     "eslint": "^8.57.0",
     "tsup": "^8.2.4",
     "typescript": "^5.5.4",
-    "@pluv/tsconfig": "^0.23.0",
-    "eslint-config-pluv": "^0.23.0"
+    "@pluv/tsconfig": "^0.24.1",
+    "eslint-config-pluv": "^0.24.1"
   },
   "scripts": {
     "build": "tsup src/index.ts --format esm,cjs --dts",

package/src/OtherNotifier.ts

@@ -8,6 +8,15 @@ export type OtherNotifierSubscriptionCallback<TIO extends IOLike> = (value: Id<U
 export class OtherNotifier<TIO extends IOLike> {
     public subjects = new Map<string, Subject<Id<UserInfo<TIO>> | null>>();
 
+    public clear(): void {
+        const connectionIds = Array.from(this.subjects.keys());
+
+        connectionIds.forEach((connectionId) => {
+            this.subject(connectionId).next(null);
+            this.subjects.delete(connectionId);
+        });
+    }
+
     public subject<TEvent extends string>(name: TEvent): Subject<Id<UserInfo<TIO>> | null> {
         const subject = this.subjects.get(name);
 

package/src/PluvRoom.ts

@@ -534,7 +534,12 @@ export class PluvRoom<
         this._clearTimeout(this._timeouts.reconnect);
 
         this._detachWindowListeners();
+
         this._usersManager.removeMyself();
+        this._usersManager.removeUsers();
+        this._otherNotifier.clear();
+        this._stateNotifier.subjects.myself.next(null);
+        this._stateNotifier.subjects.others.next([]);
 
         const canClose = [WebSocket.CONNECTING, WebSocket.OPEN].some(
             (readyState) => readyState === this._state.webSocket?.readyState,
@@ -968,10 +973,6 @@ export class PluvRoom<
 
         this._eventNotifier.subject(message.type as keyof InferIOOutput<TIO>).next(message as any);
 
-        const { connectionId } = message;
-
-        if (!connectionId) return;
-
         switch (message.type) {
             case "$EXIT": {
                 this._handleExit(message);

package/src/UsersManager.ts

@@ -85,6 +85,10 @@ export class UsersManager<TIO extends IOLike, TPresence extends JsonObject = {}>
         this._others.delete(connectionId);
     }
 
+    public removeUsers(): void {
+        this._others.clear();
+    }
+
     public setMyself(connectionId: string, user: Id<InferIOAuthorizeUser<InferIOAuthorize<TIO>>>): void {
         this._myself = {
             connectionId,