@plusscommunities/pluss-maintenance-aws-forms 2.1.41 → 2.1.42

package/db/maintenance/addMaintenanceJob.js

@@ -100,6 +100,7 @@ module.exports = async (
     requestToSave.jobId = (requestToSave.jobNo || 0) + "";
   }
 
+  requestToSave.priority = "Low";
   await updateRef(values.tableNameMaintenance, requestToSave);
   return requestToSave.id;
 };

package/feature.config.js

@@ -211,6 +211,7 @@ exports.serverless = {
         { name: "jobId", type: "S" },
         { name: "jobNo", type: "N" },
         { name: "userID", type: "S" },
+        { name: "AssigneeId", type: "S" },
       ],
       id: "id",
       indexes: [
@@ -239,6 +240,13 @@ exports.serverless = {
             { name: "userID", type: "RANGE" },
           ],
         },
+        {
+          name: "MaintenanceSiteAssigneeIndex",
+          keys: [
+            { name: "site", type: "HASH" },
+            { name: "AssigneeId", type: "RANGE" },
+          ],
+        },
       ],
     },
     {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@plusscommunities/pluss-maintenance-aws-forms",
-  "version": "2.1.41",
+  "version": "2.1.42",
   "description": "Extension package to enable maintenance on Pluss Communities Platform",
   "scripts": {
     "gc": "node ../../tools/gc ./",
@@ -17,7 +17,7 @@
     "copy:set": "run(){ target='\\@plusscommunities\\/pluss-maintenance-aws'; ext=${1:-default}; [ $ext == 'default' ] && replace=$target || replace=$target'-'$ext; echo 'Setting target to '$replace; test -f values.config.$ext.js && cp -f values.config.$ext.js values.config.js; sed -i '' -e 's/'$target'.*\"/'$replace'\"/g' package.json; }; run",
     "copy:deploy": "for file in `ls ./values.config.*.js`; do dup=`echo $file | sed 's/.*values\\.config\\.\\(.*\\)\\.js/\\1/'`; npm run copy:set $dup; npm run deploy; done; npm run copy:set; npm run gs;",
     "copy:betaupload": "npm run betapach; for file in `ls ./values.config.*.js`; do dup=`echo $file | sed 's/.*values\\.config\\.\\(.*\\)\\.js/\\1/'`; npm run copy:set $dup; npm run betaupload; done; npm run copy:set;",
-    "copy:upload": "npm run patch; for file in `ls ./values.config.*.js`; do dup=`echo $file | sed 's/.*values\\.config\\.\\(.*\\)\\.js/\\1/'`; npm run copy:set $dup; npm run upload; done; npm run copy:set;",
+    "copy:upload": "for file in `ls ./values.config.*.js`; do dup=`echo $file | sed 's/.*values\\.config\\.\\(.*\\)\\.js/\\1/'`; npm run copy:set $dup; npm run upload; done; npm run copy:set;",
     "test": "jest tests -i"
   },
   "author": "Thorbjorn Kappel Davis",

package/requests/getRequests.js

@@ -5,6 +5,20 @@ const validateSiteAccess = require("@plusscommunities/pluss-core-aws/helper/auth
 const indexQuery = require("@plusscommunities/pluss-core-aws/db/common/indexQuery");
 const { values } = require("../values.config");
 
+// Normalise legacy/null status to "Open" (null = very old jobs, "Unassigned" = pre-rename)
+const STATUS_OPEN = "Open";
+const normalizeStatus = (status) =>
+  !status || status === "Unassigned" ? STATUS_OPEN : status;
+
+// HACK: Lax "complete" match handles minor label variations across sites
+const isCompleted = (status) =>
+  status && status.toLowerCase().includes("complete");
+
+// Priority defaults to "Low" when not set (not set on creation)
+const DEFAULT_PRIORITY = "Low";
+const normalizePriority = (priority) =>
+  priority == null ? DEFAULT_PRIORITY : priority;
+
 module.exports = async (event) => {
   const qParams = event.queryStringParameters;
   const logId = log("getRequests", "Params", qParams);
@@ -59,6 +73,13 @@ module.exports = async (event) => {
             ":userId": userId,
           },
         };
+
+  // Use the assignee GSI when filtering by assignee (avoids fetching the entire site's jobs)
+  if (qParams.assignee && (authorised || assigneeTracking)) {
+    query.IndexName = "MaintenanceSiteAssigneeIndex";
+    query.KeyConditionExpression = "site = :site AND AssigneeId = :assigneeId";
+    query.ExpressionAttributeValues[":assigneeId"] = qParams.assignee;
+  }
   log("getRequests", "query", query, logId);
 
   // check whether pagination is applied
@@ -77,13 +98,17 @@ module.exports = async (event) => {
 
   // filter on status
   if (qParams.status) {
-    jobs = jobs.filter((j) => qParams.status.includes(j.status));
+    if (qParams.status === "Incomplete") {
+      jobs = jobs.filter((j) => !isCompleted(normalizeStatus(j.status)));
+    } else {
+      jobs = jobs.filter((j) => qParams.status.includes(normalizeStatus(j.status)));
+    }
     log("getRequests", "FilteredOnStatus", jobs.length, logId);
   }
 
-  // filter on priority
+  // filter on priority (normalise null to the default)
   if (qParams.priority) {
-    jobs = jobs.filter((j) => qParams.priority.includes(j.priority));
+    jobs = jobs.filter((j) => qParams.priority.includes(normalizePriority(j.priority)));
     log("getRequests", "FilterOnPriority", jobs.length, logId);
   }
 
@@ -93,12 +118,6 @@ module.exports = async (event) => {
     log("getRequests", "FilteredOnType", jobs.length, logId);
   }
 
-  // filter on assignee (for users with tracking permission)
-  if (qParams.assignee) {
-    jobs = jobs.filter((j) => j.AssigneeId === qParams.assignee);
-    log("getRequests", "FilteredOnAssigneeFilter", jobs.length, logId);
-  }
-
   // filter to assigned jobs
   if (!authorised && assigneeTracking) {
     jobs = jobs.filter((j) => j.AssigneeId === userId || j.userID === userId);