@plusscommunities/pluss-core-aws 2.0.25-beta.4 → 2.0.25-beta.6

package/helper/hqPublishing.js

@@ -22,6 +22,7 @@ const moment = require("moment");
 const indexQueryRecursive = require("../db/common/indexQueryRecursive");
 const updateRef = require("../db/common/updateRef");
 const editRef = require("../db/common/editRef");
+const { log } = require("./index");
 
 // Raw DocumentClient for atomic-increment operations that editRef can't do
 // safely under concurrent stream-handler invocations.
@@ -311,8 +312,8 @@ const cascadeHqRetract = async (hqSourceRow, tableName, options = {}) => {
  * @param {string} templateId — the `Id` of the contentLibrary row.
  * @param {string} contentLibraryTable — entity-agnostic; caller passes the
  *   table name (without prefix).
- * @returns {Promise<boolean>} `true` if increment applied; `false` if table
- *   doesn't exist (graceful skip).
+ * @returns {Promise<boolean>} `true` if increment applied; `false` on graceful
+ *   skip (table not shipped yet, or no template with that Id exists).
  */
 const incrementTemplateUseCount = async (templateId, contentLibraryTable) => {
 	if (!templateId || !contentLibraryTable) {
@@ -321,11 +322,16 @@ const incrementTemplateUseCount = async (templateId, contentLibraryTable) => {
 	const params = {
 		TableName: `${process.env.tablePrefix}${contentLibraryTable}`,
 		Key: { Id: templateId },
-		UpdateExpression:
-			"ADD UseCount :inc SET LastUsedTimestamp = :now",
+		UpdateExpression: "ADD UseCount :inc SET LastUsedTimestamp = :now",
+		// Guard against minting a phantom row: ADD on a missing key would CREATE
+		// it with UseCount=1. Only increment a template that actually exists; a
+		// stale/bogus TemplateId is skipped (ConditionalCheckFailed below).
+		ConditionExpression: "attribute_exists(Id)",
 		ExpressionAttributeValues: {
 			":inc": 1,
-			":now": moment.utc().unix(),
+			// epoch ms — the contentLibrary timestamp convention (matches
+			// UpdatedAt). Was .unix() (seconds); reconciled to .valueOf().
+			":now": moment().utc().valueOf(),
 		},
 	};
 	try {
@@ -336,16 +342,21 @@ const incrementTemplateUseCount = async (templateId, contentLibraryTable) => {
 			// Graceful degradation while Story C (contentLibrary table) is
 			// unshipped — see AC-B.3. Not an error; the rest of the stream
 			// handler should continue.
-			console.log(
-				"incrementTemplateUseCount: contentLibrary table not found — skipped (Story C not yet shipped)",
+			log(
+				"incrementTemplateUseCount",
+				"TableNotFound",
+				"contentLibrary table not found — skipped",
 			);
 			return false;
 		}
+		if (error?.code === "ConditionalCheckFailedException") {
+			// TemplateId references no existing template — skip rather than
+			// create a phantom row. Not an error; continue the stream handler.
+			log("incrementTemplateUseCount", "NoSuchTemplate", { templateId });
+			return false;
+		}
 		// Anything else is genuinely unexpected — surface it.
-		console.error(
-			"incrementTemplateUseCount: unexpected error",
-			error,
-		);
+		log("incrementTemplateUseCount", "Error", error);
 		throw error;
 	}
 };

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@plusscommunities/pluss-core-aws",
-	"version": "2.0.25-beta.4",
+	"version": "2.0.25-beta.6",
 	"description": "Core extension package for Pluss Communities platform",
 	"scripts": {
 		"betapatch": "npm version prepatch --preid=beta",