@plusscommunities/pluss-core-aws 2.0.25-beta.1 → 2.0.25-beta.3

package/helper/hqPublishing.js

@@ -19,7 +19,7 @@
 
 const AWS = require("aws-sdk");
 const moment = require("moment");
-const indexQuery = require("../db/common/indexQuery");
+const indexQueryRecursive = require("../db/common/indexQueryRecursive");
 const updateRef = require("../db/common/updateRef");
 const editRef = require("../db/common/editRef");
 
@@ -94,12 +94,18 @@ const findCopiesByHqSourceId = async (
 	if (!hqSourceId) {
 		return [];
 	}
-	const result = await indexQuery(tableName, {
+	// indexQueryRecursive paginates LastEvaluatedKey internally and returns a
+	// flat array — required because a single GSI query response caps at 1 MiB
+	// and large-content HQ fan-outs to ~50 client sites can exceed that. With
+	// the non-recursive indexQuery, propagateHqEdit + cascadeHqRetract would
+	// silently miss copies on page 2+, leaving them stale after edits and
+	// visible after retractions.
+	const items = await indexQueryRecursive(tableName, {
 		IndexName: indexName,
 		KeyConditionExpression: "HqSourceId = :sid",
 		ExpressionAttributeValues: { ":sid": hqSourceId },
 	});
-	return result?.Items || [];
+	return items || [];
 };
 
 /**
@@ -136,7 +142,14 @@ const fanOutHqSource = async (hqSourceRow, tableName) => {
 		return [];
 	}
 	const copyId = `hqcopy-${hqSourceRow.Id}`;
-	const now = moment.utc().unix();
+	// IMPORTANT: milliseconds (.valueOf), not seconds (.unix). Newsletter
+	// rows written by addNewsletterEntry.js use `moment.utc().valueOf()` for
+	// UnixTimestamp. UnixTimestampReverse-keyed feed queries (the standard
+	// Pluss list pattern) would otherwise rank HQ copies ~1000× ahead of
+	// locally-authored posts forever — MAX_SAFE_INTEGER minus a number 10^9
+	// is vastly larger than MAX_SAFE_INTEGER minus 10^12. Keep parity with
+	// the canonical addNewsletterEntry convention.
+	const now = moment.utc().valueOf();
 
 	const writes = targets.map((targetSiteId) => {
 		// Spread + override pattern: keep all content fields, swap identity
@@ -215,9 +228,17 @@ const propagateHqEdit = async (
 	}
 	propagated.Changed = moment.utc().unix();
 
+	// IMPORTANT: pass a fresh shallow copy per call. `editRef` synchronously
+	// mutates its `updates` argument (`updates[keyCol] = id` inside the Promise
+	// constructor) AFTER taking a `cloneDeep` snapshot. Across parallel
+	// `Promise.all(map(...))` invocations, iteration N's `cloneDeep` would
+	// capture iteration N-1's `RowId` mutation, then later overwrite copy N's
+	// `RowId` during the get-merge-put, writing copy N's content back to copy
+	// N-1's key (and leaving copy N's own row untouched). Per-call `{...propagated}`
+	// gives each invocation an isolated payload it can mutate safely.
 	await Promise.all(
 		copies.map((copy) =>
-			editRef(tableName, "RowId", copy.RowId, propagated),
+			editRef(tableName, "RowId", copy.RowId, { ...propagated }),
 		),
 	);
 	return copies.length;
@@ -256,9 +277,13 @@ const cascadeHqRetract = async (hqSourceRow, tableName, options = {}) => {
 		Deleted: true,
 		Changed: moment.utc().unix(),
 	};
+	// Per-call shallow copy — see propagateHqEdit for the editRef-mutation-race
+	// rationale. Even though `deletionUpdate` is tiny, the same RowId clobber
+	// happens here: under sharing, only the FIRST copy actually receives
+	// `Deleted: true`; subsequent writes land at the wrong RowId.
 	await Promise.all(
 		copies.map((copy) =>
-			editRef(tableName, "RowId", copy.RowId, deletionUpdate),
+			editRef(tableName, "RowId", copy.RowId, { ...deletionUpdate }),
 		),
 	);
 	return copies.length;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@plusscommunities/pluss-core-aws",
-	"version": "2.0.25-beta.1",
+	"version": "2.0.25-beta.3",
 	"description": "Core extension package for Pluss Communities platform",
 	"scripts": {
 		"betapatch": "npm version prepatch --preid=beta",