@plusscommunities/pluss-core-aws 2.0.22 → 2.0.23-beta.0

package/helper/rates/checkRateLimit.js

@@ -0,0 +1,56 @@
+const moment = require("moment");
+const { log } = require("..");
+const getRef = require("../../db/common/getRef");
+const updateRef = require("../../db/common/updateRef");
+
+/**
+ *
+ * @param {String} rateLimitId - Id of rates to check
+ * @param {Number} timeframe - Timeframe to check for number of calls given in ms
+ * @param {Numer} limit - Number of calls allowed in the given timeframe
+ * @param {Boolean} noSave - true if this call should not be recorded. Used for when checking multiple timeframes such as X calls in a minute and X calls in a day.
+ * @returns {Boolean} true if this call is fine. false if the call should be restricted due to rate limits.
+ */
+module.exports = async (rateLimitId, timeframe, limit, noSave) => {
+  const logId = log("checkRateLimit", "Input", {
+    rateLimitId,
+    timeframe,
+    limit,
+  });
+
+  // get rate limit item
+  const item = await getRef("ratelimit", "Id", rateLimitId);
+  const now = moment().valueOf();
+  const minTime = now - timeframe;
+
+  const history = item && item.History ? item.History : [];
+
+  if (history) {
+    // check history for entries to determine whether limit is surpassed
+    const entriesInTimeLimit = history.filter((e) => e > minTime);
+    log(
+      "checkRateLimit",
+      "entriesInTimeLimit",
+      entriesInTimeLimit.length,
+      logId
+    );
+    if (entriesInTimeLimit.length >= limit) {
+      // Limit surpassed
+      log("checkRateLimit", "Return", false, logId);
+      return false;
+    }
+  }
+
+  // check whether to save the current entry - used for when checking multiple timeframes such as X calls in a minute and X calls in a day
+  if (!noSave) {
+    history.push(now);
+    updateRef("ratelimit", {
+      Id: rateLimitId,
+      LastSent: now,
+      History: history,
+    });
+  }
+  // Limit is fine
+  log("checkRateLimit", "Return", true, logId);
+  return true;
+};

package/notification/sendNotifications.js

@@ -1,8 +1,11 @@
 const { Expo } = require("expo-server-sdk");
 const _ = require("lodash");
 const moment = require("moment");
+const crypto = require("crypto");
 const getUser = require("../db/users/getUser");
 const getNotificationSetting = require("../db/notifications/getNotificationSetting");
+const checkRateLimit = require("../helper/rates/checkRateLimit");
+const { getMultiRowId } = require("../helper");
 const { log } = require("../helper");
 
 const SendNotification = async (tokens, message, type, key, params, config) => {
@@ -118,6 +121,49 @@ module.exports = async (
     value,
     config,
   });
+
+  // Notification deduplication to prevent duplicate push notifications
+  // Use a 5-minute deduplication window to prevent the same notification
+  // from being sent multiple times for the same recipients and entity
+
+  // Use MD5 hash of sorted recipients for consistent, size-limited identifier
+  const recipientHash = crypto
+    .createHash("md5")
+    .update(receiverKeys.sort().join(","))
+    .digest("hex")
+    .substring(0, 8); // 8 hex chars = 4.3 billion combinations
+
+  const notificationKey = getMultiRowId([
+    "notification",
+    recipientHash, // Fixed 8-character recipient identifier
+    type,
+    key, // Use entity ID instead of message for proper uniqueness
+  ]);
+
+  log("sendNotifications - core", "notificationKey", notificationKey, logId);
+  const canSend = await checkRateLimit(
+    notificationKey,
+    300000, // 5 minutes in milliseconds
+    1, // Allow only 1 notification in the timeframe
+    false // Save this check to prevent duplicates
+  );
+
+  if (!canSend) {
+    log(
+      "sendNotifications",
+      "duplicateSkipped",
+      {
+        notificationKey,
+        recipientHash,
+        type,
+        entityKey: key,
+        recipientCount: receiverKeys.length,
+      },
+      logId
+    );
+    return; // Skip sending duplicate notification
+  }
+
   const tokens = [];
   const promises = [];
   receiverKeys.forEach((uid) => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@plusscommunities/pluss-core-aws",
-  "version": "2.0.22",
+  "version": "2.0.23-beta.0",
   "description": "Core extension package for Pluss Communities platform",
   "scripts": {
     "betapatch": "npm version prepatch --preid=beta",