@plumpslabs/kuma 2.1.2 → 2.1.3

package/dist/index.js

@@ -2303,7 +2303,7 @@ function getGitChangedFiles() {
   }
 }
 async function handleCodeReviewer(params) {
-  const { files: inputFiles, focus = "correctness", customCriteria, format = "text" } = params;
+  const { files: inputFiles, focus = "correctness", customCriteria, format = "text", convention } = params;
   let files = inputFiles ?? [];
   let isAutoDetected = false;
   if (files.length === 0) {
@@ -2362,6 +2362,9 @@ Pass an explicit 'files' array to review specific files.`;
           checkOverEngineering(filePath, content, allIssues);
           break;
       }
+      if (convention === "matcha") {
+        checkMatchaConventions(filePath, content, allIssues);
+      }
     } catch (err) {
       allIssues.push({
         file: filePath,
@@ -2389,6 +2392,7 @@ Pass an explicit 'files' array to review specific files.`;
       filesReviewed,
       filesRequested: files.length,
       focus,
+      convention,
       autoDetected: isAutoDetected,
       ...customCriteria ? { customCriteria } : {}
     };
@@ -2915,8 +2919,8 @@ function collectBlockLines(lines, startIdx) {
   let depth = 0;
   let started = false;
   const block = [];
-  for (let j = startIdx; j < lines.length; j++) {
-    const line = lines[j];
+  for (let i = startIdx; i < lines.length; i++) {
+    const line = lines[i];
     block.push(line);
     for (const ch of line) {
       if (ch === "{") {
@@ -2933,6 +2937,73 @@ function extractBodyAfter(lines, match) {
   if (startIdx < 0) return "";
   return collectBlockLines(lines, startIdx).join("\n");
 }
+function checkMatchaConventions(filePath, content, issues) {
+  const lines = content.split("\n");
+  const text = content.replace(/\/\/.*$/gm, "").replace(/\/\*[\s\S]*?\*\//g, "");
+  for (let i = 0; i < lines.length; i++) {
+    const line = stripCommentsAndStrings(lines[i]);
+    const lineNum = i + 1;
+    if (/\b(?:const|let|var)\s+\w+\s*=\s*(?:[2-9]|\d{2,})\b/.test(line)) {
+      if (!/eslint-disable/.test(lines[i])) {
+        issues.push({
+          file: filePath,
+          line: lineNum,
+          severity: "info",
+          rule: "matcha/no-hardcoded-values",
+          message: "Possible hardcoded numeric value (magic number)",
+          suggestion: "Extract to a named constant"
+        });
+      }
+    }
+    const envMatch = line.match(/process\.env\.([A-Z0-9_]+)/);
+    if (envMatch) {
+      const envName = envMatch[1];
+      if (!envName.includes("_")) {
+        issues.push({
+          file: filePath,
+          line: lineNum,
+          severity: "warning",
+          rule: "matcha/env-prefix",
+          message: `Environment variable "${envName}" doesn't seem to have a prefix`,
+          suggestion: "Use an APPNAME_ prefix for environment variables"
+        });
+      }
+    }
+  }
+  const interfaceNames = [];
+  for (let i = 0; i < lines.length; i++) {
+    const m = lines[i].match(/^\s*(export\s+)?interface\s+(\w+)/);
+    if (m) interfaceNames.push(m[2]);
+  }
+  for (const iface of interfaceNames) {
+    const implCount = (text.match(new RegExp(`implements\\s+.*\\b${iface}\\b`, "g")) || []).length;
+    if (implCount <= 1) {
+      const lineNum = lines.findIndex((l) => l.includes(`interface ${iface}`)) + 1;
+      issues.push({
+        file: filePath,
+        line: lineNum,
+        severity: "info",
+        rule: "matcha/no-premature-abstraction",
+        message: `Interface "${iface}" has only 1 implementation \u2014 premature abstraction?`,
+        suggestion: "Wait for a 2nd use case before abstracting"
+      });
+    }
+  }
+  const funcBodies = findBlockBodies(lines, /^\s*(export\s+)?(async\s+)?function\s+\w+/);
+  for (const { body, nameLine, name } of funcBodies) {
+    const nonEmptyLines = body.split("\n").filter((l) => l.trim()).length;
+    if (nonEmptyLines > 40) {
+      issues.push({
+        file: filePath,
+        line: nameLine,
+        severity: "warning",
+        rule: "matcha/single-responsibility",
+        message: `Function "${name}" is ${nonEmptyLines} lines long \u2014 might be doing >1 thing`,
+        suggestion: "Extract into smaller, focused functions"
+      });
+    }
+  }
+}
 function formatReviewOutput(issues, filesReviewed, totalFiles, focus, customCriteria, autoDetected) {
   const errors = issues.filter((i) => i.severity === "error");
   const warnings = issues.filter((i) => i.severity === "warning");
@@ -5973,9 +6044,9 @@ function handleCodewhaleSecondary(root, results) {
     });
   }
 }
-function runInit(types, projectRoot) {
-  const root = projectRoot ?? getProjectRoot();
-  const selected = types.length > 0 ? types : ALL_CONFIG_TYPES;
+function runInit(options) {
+  const root = options.projectRoot ?? getProjectRoot();
+  const selected = options.types.length > 0 ? options.types : ALL_CONFIG_TYPES;
   const results = [];
   const selectedSet = new Set(selected);
   const agentsMdSelected = AGENTS_MD_TYPES.filter((t) => selectedSet.has(t));
@@ -5989,12 +6060,16 @@ function runInit(types, projectRoot) {
         agentsMdHandled = true;
         const combinedContent = getCombinedAgentsMd(new Set(agentsMdSelected));
         if (fs16.existsSync(fullPath)) {
-          const existingContent = fs16.readFileSync(fullPath, "utf-8");
-          if (existingContent.includes("_Generated by Kuma MCP_")) {
+          if (options.skipExisting) {
             results.push({ type, filePath: relativePath, action: "skipped" });
           } else {
-            fs16.writeFileSync(fullPath, existingContent.trimEnd() + "\n\n" + combinedContent, "utf-8");
-            results.push({ type, filePath: relativePath, action: "appended" });
+            const existingContent = fs16.readFileSync(fullPath, "utf-8");
+            if (existingContent.includes("_Generated by Kuma MCP_")) {
+              results.push({ type, filePath: relativePath, action: "skipped" });
+            } else {
+              fs16.writeFileSync(fullPath, existingContent.trimEnd() + "\n\n" + combinedContent, "utf-8");
+              results.push({ type, filePath: relativePath, action: "appended" });
+            }
           }
         } else {
           const dir = path16.dirname(fullPath);
@@ -6011,6 +6086,10 @@ function runInit(types, projectRoot) {
       } else {
         const template = getTemplate();
         if (fs16.existsSync(fullPath)) {
+          if (options.skipExisting) {
+            results.push({ type, filePath: relativePath, action: "skipped" });
+            continue;
+          }
           const existingContent = fs16.readFileSync(fullPath, "utf-8");
           if (existingContent.includes("_Generated by Kuma MCP_")) {
             if (type === "antigravity") {
@@ -6110,6 +6189,8 @@ Usage:
   npx @plumpslabs/kuma              Start MCP server (default)
   npx @plumpslabs/kuma init         Generate AI agent config files
   npx @plumpslabs/kuma init --all   Generate ALL config files
+  npx @plumpslabs/kuma init --merge Append to existing files (default)
+  npx @plumpslabs/kuma init --skip-existing Skip generation if file exists
   npx @plumpslabs/kuma init --claude --cursor  Generate specific files
   npx @plumpslabs/kuma init --help  Show this help
 
@@ -6183,9 +6264,20 @@ async function main() {
         }
       }
     }
-    const results = runInit(selectedTypes, process.cwd());
+    const skipExisting = requestedFlags.includes("--skip-existing");
+    const merge = requestedFlags.includes("--merge");
+    const results = runInit({ types: selectedTypes, projectRoot: process.cwd(), skipExisting });
     const output = formatInitResults(results);
     console.log(output);
+    const fs17 = await import("fs");
+    const path17 = await import("path");
+    const matchaSkills = path17.resolve(process.cwd(), "skills/matcha/SKILL.md");
+    const matchaAgents = path17.resolve(process.cwd(), ".agents/skills/matcha/SKILL.md");
+    const matchaCursor = path17.resolve(process.cwd(), ".cursor/rules/matcha.mdc");
+    const matchaWindsurf = path17.resolve(process.cwd(), ".windsurf/rules/matcha.md");
+    if (fs17.existsSync(matchaSkills) || fs17.existsSync(matchaAgents) || fs17.existsSync(matchaCursor) || fs17.existsSync(matchaWindsurf)) {
+      console.error("\n\u{1F375} Hey, I see matcha is installed \u2014 they pair well together!");
+    }
     process.exit(0);
   }
   sessionMemory.init({

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@plumpslabs/kuma",
-  "version": "2.1.2",
+  "version": "2.1.3",
   "description": "Zero-setup safety toolkit for AI coding agents. MCP server with code review, git analysis, file editing, session memory, and static analysis — works with Claude Code, Cursor, Gemini CLI.",
   "type": "module",
   "main": "dist/index.js",
@@ -56,7 +56,7 @@
     "git-diff",
     "cli"
   ],
-"repository": {
+  "repository": {
     "type": "git",
     "url": "git+https://github.com/plumpslabs/kuma.git"
   },
@@ -65,4 +65,4 @@
   },
   "homepage": "https://github.com/plumpslabs/kuma#readme",
   "license": "MIT"
-}
+}