@plumeria/eslint-plugin 0.2.1 → 0.2.3

package/lib/index.d.ts

@@ -2,6 +2,7 @@ import { ESLint, Linter, Rule } from 'eslint';
 
 declare const plugin: ESLint.Plugin & {
   rules: {
+    'no-destructure': Rule.RuleModule;
     'no-inner-call': Rule.RuleModule;
     'no-unused-keys': Rule.RuleModule;
     'sort-properties': Rule.RuleModule;

package/lib/index.js

@@ -1,11 +1,13 @@
 'use strict';
 
+const noDestructure = require('./rules/no-destructure.js');
 const noInnerCall = require('./rules/no-inner-call.js');
 const noUnusedKeys = require('./rules/no-unused-keys.js');
 const sortProperties = require('./rules/sort-properties.js');
 const validateValues = require('./rules/validate-values.js');
 
 const rules = {
+  'no-destructure': noDestructure,
   'no-inner-call': noInnerCall,
   'no-unused-keys': noUnusedKeys,
   'sort-properties': sortProperties,
@@ -16,6 +18,7 @@ const configs = {
   recommended: {
     plugins: ['@plumeria'],
     rules: {
+      '@plumeria/no-destructure': 'error',
       '@plumeria/no-inner-call': 'error',
       '@plumeria/no-unused-keys': 'warn',
       '@plumeria/sort-properties': 'warn',
@@ -32,6 +35,7 @@ const flatConfigs = {
       },
     },
     rules: {
+      '@plumeria/no-destructure': 'error',
       '@plumeria/no-inner-call': 'error',
       '@plumeria/no-unused-keys': 'warn',
       '@plumeria/sort-properties': 'warn',

package/lib/rules/no-destructure.js

@@ -0,0 +1,54 @@
+/**
+ * @fileoverview Restrict destructure css.create and css.global
+ * Compatible with eslint 8 and below or 9 and above
+ */
+
+'use strict';
+
+/** @type {import('eslint').Rule.RuleModule} */
+module.exports = {
+  meta: {
+    type: 'problem',
+    docs: {
+      description: 'Disallow destructuring css.create and css.global',
+      recommended: true,
+    },
+    messages: {
+      noDestructure:
+        'Do not destructure "{{name}}" from "css". Use dot notation instead.',
+    },
+    schema: [],
+  },
+  create(context) {
+    const isCssIdentifier = (node) =>
+      node.type === 'Identifier' && node.name === 'css';
+
+    return {
+      VariableDeclarator(node) {
+        if (
+          node.id.type === 'ObjectPattern' &&
+          node.init &&
+          isCssIdentifier(node.init)
+        ) {
+          const forbiddenKeys = ['create', 'global'];
+          const violated = node.id.properties.filter(
+            (prop) =>
+              prop.type === 'Property' &&
+              prop.key.type === 'Identifier' &&
+              forbiddenKeys.includes(prop.key.name),
+          );
+
+          if (violated.length > 0) {
+            for (const prop of violated) {
+              context.report({
+                node: prop,
+                messageId: 'noDestructure',
+                data: { name: prop.key.name },
+              });
+            }
+          }
+        }
+      },
+    };
+  },
+};

package/lib/rules/no-inner-call.js

@@ -52,8 +52,7 @@ module.exports = {
                 propertyName === 'create' ||
                 propertyName === 'global' ||
                 propertyName === 'keyframes' ||
-                propertyName === 'defineVars' ||
-                propertyName === 'defineTheme'
+                propertyName.startsWith('define')
               ) {
                 context.report({
                   node,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@plumeria/eslint-plugin",
-  "version": "0.2.1",
+  "version": "0.2.3",
   "description": "Zero-runtime, expressive CSS-in-JS library for TypeScript.",
   "repository": "github:zss-in-js/plumeria",
   "license": "MIT",

package/readme.md

@@ -7,6 +7,7 @@ Below are the available rules and the recommended configuration.
 
 The `plugin:@plumeria/recommended` config enables the following:
 
+- `@plumeria/no-destructure`: **error**
 - `@plumeria/no-inner-call`: **error**
 - `@plumeria/no-unused-keys`: **warn**
 - `@plumeria/sort-properties`: **warn**
@@ -20,6 +21,10 @@ export default [plumeria.flatConfigs.recommended];
 
 ## Rules
 
+### no-destructure
+
+Disallow destructuring `css.create` and `css.global`.
+
 ### no-inner-call
 
 Disallow calling `css.create`, `css.global`, etc. inside functions.