@plumeria/codemod 19.15.0 → 20.0.0

package/dist/transforms/adopt-styles.js

@@ -105,6 +105,12 @@ exports.adoptStyles = {
                 (current.parent.name?.name === 'className' ||
                     current.parent.name?.name === styleProp));
         };
+        const lone = (node) => node?.type === 'LogicalExpression' &&
+            node.operator === '||' &&
+            node.right.type === 'Identifier' &&
+            node.right.name === 'undefined'
+            ? [node.left]
+            : undefined;
         const joinedElements = (node) => {
             if (node?.type === 'TemplateLiteral' && node.expressions.length > 1) {
                 const spaced = node.quasis.every((quasi, index) => index === 0 || index === node.quasis.length - 1
@@ -117,7 +123,7 @@ exports.adoptStyles = {
                 node.callee.property?.name !== 'join' ||
                 node.arguments.length !== 1 ||
                 node.arguments[0].value !== ' ')
-                return undefined;
+                return lone(node);
             const joined = node.callee.object;
             if (joined?.type === 'ArrayExpression')
                 return joined.elements.filter(Boolean);

package/dist/transforms/release-styles.js

@@ -76,6 +76,13 @@ const walk = (node, visit) => {
 const needsFilter = (node) => node.type === 'LogicalExpression' ||
     node.type === 'ConditionalExpression' ||
     node.type === 'SpreadElement';
+const mayBeFalsy = (node) => {
+    if (node.type === 'LogicalExpression')
+        return node.operator === '&&' || mayBeFalsy(node.right);
+    if (node.type === 'ConditionalExpression')
+        return mayBeFalsy(node.consequent) || mayBeFalsy(node.alternate);
+    return node.type === 'Literal' && !node.value;
+};
 exports.__private = { memberPath, isCreate, needsFilter };
 exports.releaseStyles = {
     meta: {
@@ -101,6 +108,7 @@ exports.releaseStyles = {
             styleType: 'A released style is a class name.',
             folded: 'This only named a style key, which the export has resolved.',
             read: 'Read this style by the name the export gave it.',
+            falsy: 'className takes a string or undefined, so a condition that can be false reads as undefined.',
             functionStyle: 'Use the CSS Module class and pass function arguments as custom properties.',
             unsupportedFunctionStyle: 'This function style call cannot be converted without changing its behavior.',
         },
@@ -923,6 +931,18 @@ exports.releaseStyles = {
                 const text = expression ? resolveText(expression) : undefined;
                 if (!complete && expression && text === undefined)
                     return;
+                if (!carried &&
+                    expression &&
+                    text !== undefined &&
+                    mayBeFalsy(expression)) {
+                    context.report({
+                        node: expression,
+                        messageId: 'falsy',
+                        fix: (fixer) => fixer.replaceText(expression, `(${text}) || undefined`),
+                    });
+                    takeProp();
+                    return;
+                }
                 const foldsKey = expression?.type === 'MemberExpression' &&
                     expression.computed &&
                     expression.property.type === 'Identifier' &&

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@plumeria/codemod",
-  "version": "19.15.0",
+  "version": "20.0.0",
   "description": "Codemods for Plumeria: migrate a CSS Modules codebase in, export it back out, and rename the styling prop",
   "author": "Refirst 11",
   "license": "MIT",
@@ -37,7 +37,7 @@
     "get-tsconfig": "^4.14.2",
     "postcss": "8.5.26",
     "postcss-selector-parser": "^7.1.1",
-    "zss-engine": "2.10.0"
+    "zss-engine": "3.0.1"
   },
   "publishConfig": {
     "access": "public",