@plumeria/codemod 18.5.4 → 19.0.0

package/README.md

@@ -247,6 +247,9 @@ src/Card.tsx
         The value of `color` cannot be represented statically.
   12:3  spread-create
         Top-level spreads cannot name a CSS Module class.
+  19:16  style-type-reference
+        `css.StaticStyles` has no CSS Modules equivalent, and the import that
+        declares it does not survive the export of Card.tsx.
 ```
 
 Constructs that cannot be resolved statically — dynamic values, computed keys,
@@ -255,6 +258,17 @@ together with every file whose definitions they still need. A target
 `*.module.css` that already exists is reported as `target-exists` and will not be
 overwritten.
 
+The export removes the `@plumeria/core` import, so a reference to `Style`,
+`StyleProps`, `WithoutProperties`, `StaticStyles` or `AtomicClassNameFor` is left
+without the import that declares it. Those are reported as
+`style-type-reference`, whether the type names a component prop, a type alias or
+a variable annotation.
+
+A module that declares nothing but style prop types is the one shape this does
+not reach: it defines no styles, so there is no stylesheet for the report to hold
+onto, and its consumer will not compile after the export. Keep the prop type in
+the file that defines the styles and the export reports it instead.
+
 Several `css.create` calls in one file are not reported: they are written to the
 same stylesheet, and a key an earlier call claimed is renamed.
 

package/dist/release.js

@@ -78,6 +78,13 @@ const findSources = (targets) => {
     return found.sort();
 };
 const STYLE_PROP = 'classStyle';
+const STYLE_TYPES = new Set([
+    'Style',
+    'StyleProps',
+    'WithoutProperties',
+    'StaticStyles',
+    'AtomicClassNameFor',
+]);
 const memberOf = (node) => {
     if (node?.type !== 'MemberExpression' || node.object.type !== 'Identifier')
         return undefined;
@@ -438,6 +445,69 @@ function planRelease(targets) {
                 },
             ]);
         });
+        const styleTypeNamespaces = new Set();
+        const styleTypeLocals = new Set();
+        for (const node of ast.body) {
+            if (node.type !== 'ImportDeclaration' ||
+                node.source.value !== '@plumeria/core')
+                continue;
+            for (const specifier of node.specifiers) {
+                if (specifier.type === 'ImportNamespaceSpecifier' ||
+                    specifier.type === 'ImportDefaultSpecifier') {
+                    styleTypeNamespaces.add(specifier.local.name);
+                    continue;
+                }
+                if (specifier.type !== 'ImportSpecifier')
+                    continue;
+                const imported = specifier.imported.name ?? specifier.imported.value;
+                if (STYLE_TYPES.has(imported))
+                    styleTypeLocals.add(specifier.local.name);
+            }
+        }
+        const styleTypeUses = [];
+        walk(ast.body, (node) => {
+            if (node.type !== 'TSTypeReference')
+                return;
+            const name = node.typeName;
+            if (name?.type === 'TSQualifiedName' &&
+                name.left?.type === 'Identifier' &&
+                styleTypeNamespaces.has(name.left.name) &&
+                name.right?.type === 'Identifier' &&
+                STYLE_TYPES.has(name.right.name)) {
+                styleTypeUses.push({
+                    line: node.loc.start.line,
+                    column: node.loc.start.column + 1,
+                    name: `${name.left.name}.${name.right.name}`,
+                });
+                return;
+            }
+            if (name?.type === 'Identifier' && styleTypeLocals.has(name.name))
+                styleTypeUses.push({
+                    line: node.loc.start.line,
+                    column: node.loc.start.column + 1,
+                    name: name.name,
+                });
+        });
+        if (styleTypeUses.length > 0) {
+            const held = new Set();
+            walk(ast.body, (node) => {
+                if (node.type !== 'Identifier')
+                    return;
+                const owner = owners.get(node.name);
+                if (owner)
+                    held.add(owner.source);
+            });
+            for (const use of styleTypeUses)
+                for (const target of held)
+                    note(target, [
+                        {
+                            line: use.line,
+                            column: use.column,
+                            kind: 'style-type-reference',
+                            hint: `\`${use.name}\` has no CSS Modules equivalent, and the import that declares it does not survive the export of ${path.basename(source)}.`,
+                        },
+                    ]);
+        }
         walk(ast.body, (node) => {
             if (node.type !== 'JSXAttribute' ||
                 node.name?.name !== STYLE_PROP ||

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@plumeria/codemod",
-  "version": "18.5.4",
+  "version": "19.0.0",
   "description": "Codemods for Plumeria: migrate a CSS Modules codebase in, export it back out, and rename the styling prop",
   "author": "Refirst 11",
   "license": "MIT",