@plot-pm/board 0.16.3 → 0.17.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@plot-pm/board",
-  "version": "0.16.3",
+  "version": "0.17.0",
   "description": "Local Kanban board for Plot — a glanceable view of plan phases from docs/plans, with sprint and story filters",
   "type": "module",
   "license": "MIT",
@@ -24,7 +24,6 @@
     "dist/board-server.mjs",
     "plot-agent-monitor.sh",
     "plot-agent-manifest.sh",
-    "plot-build-monitor.sh",
     "plot-monitor-subject.sh",
     "plot-approve.sh",
     "plot-budget.sh",
@@ -41,7 +40,6 @@
     "plot-release-refs.sh",
     "plot-state-receipt.sh",
     "plot-tmp.sh",
-    "plot-transcript-quiet.sh",
     "plot-worker-state.sh"
   ],
   "scripts": {
@@ -63,6 +61,7 @@
     "@types/react": "^19.2.0",
     "@types/react-dom": "^19.2.0",
     "@vitejs/plugin-react": "^6.0.0",
+    "@vitest/coverage-v8": "4.1.11",
     "class-variance-authority": "^0.7.1",
     "clsx": "^2.1.1",
     "esbuild": "^0.28.0",
@@ -75,7 +74,7 @@
     "typescript": "^5.9.0",
     "vite": "^8.1.0",
     "vite-plugin-singlefile": "^2.3.0",
-    "vitest": "^4.1.10",
+    "vitest": "4.1.11",
     "zod": "^4.4.0"
   },
   "engines": {

package/plot-agent-manifest.sh

@@ -43,41 +43,6 @@ manifest_string() { # $1=manifest $2=field → prints the value, or nothing
   printf '%s' "$value"
 }
 
-# A non-negative integer field, or `0`. The node call itself only ever prints
-# a clean digit string or "0", so a failed call is the one case needing a
-# shell-side fallback.
-manifest_count() { # $1=manifest $2=field → prints a count
-  local manifest="$1"
-  [ -n "$manifest" ] && [ -f "$manifest" ] || { printf '0'; return 0; }
-  node -e '
-    const fs = require("fs");
-    try {
-      const manifest = JSON.parse(fs.readFileSync(process.argv[1], "utf8"));
-      const n = manifest[process.argv[2]];
-      process.stdout.write(Number.isInteger(n) && n >= 0 ? String(n) : "0");
-    } catch { process.stdout.write("0"); }
-  ' "$manifest" "$2" 2>/dev/null || printf '0'
-}
-
-# Raise a non-negative integer field by one, leaving every other field verbatim.
-#
-# THROUGH A TEMP FILE AND A RENAME, the shape every writer here takes: a reader
-# never sees a partial manifest. A write that fails leaves the file alone and
-# reports it; an absent manifest is not a failure.
-raise_manifest_count() { # $1=manifest $2=field
-  local manifest="$1" tmp="$1.plot-count-tmp"
-  [ -n "$manifest" ] && [ -f "$manifest" ] || return 0
-  node -e '
-    const fs = require("fs");
-    const [file, field, tmp] = process.argv.slice(1);
-    const manifest = JSON.parse(fs.readFileSync(file, "utf8"));
-    const n = manifest[field];
-    manifest[field] = (Number.isInteger(n) && n >= 0 ? n : 0) + 1;
-    fs.writeFileSync(tmp, JSON.stringify(manifest, null, 2) + "\n");
-  ' "$manifest" "$2" "$tmp" 2>/dev/null || { rm -f "$tmp"; return 1; }
-  mv -f "$tmp" "$manifest" 2>/dev/null || { rm -f "$tmp"; return 1; }
-}
-
 # Clear `branch` when a slice finishes, so the window before the next one is
 # observable.
 #

package/plot-config.sh

@@ -144,6 +144,16 @@
 #                       it does today and names `no-brief-command` as the
 #                       reason, so a project that has never set the key behaves
 #                       exactly as before.
+#   Agent runner        command | sdk: how the JS loop runs a worker's prompt.
+#                       Absent = command.
+#   Agent models        `role = model` list (`worker = sonnet`); a charter wins.
+#   Agent max turns     turns one SDK run may take. Absent = 150.
+#   Slice max runs      SDK runs one slice may start. Absent = 12.
+#   Agent context window  an SDK run's `autoCompactWindow`. Absent = 200000.
+#   Agent max spend     dollars one SDK run may spend (`maxBudgetUsd`); the
+#                       run then ends `spend-limit`. Absent = no limit, never 0.
+#   Slice max spend     dollars one slice's runs may total, read from the
+#                       slice-spend record before each run. Absent = no limit.
 # Plot 2 posture keys (repo-declared ceremony bounds; all optional):
 #   Plan PRs            required | never | optional   (never = hard gate)
 #   Implementation home this repo | <repo/path list> | none
@@ -202,10 +212,7 @@ cmd="${1:?Usage: plot-config.sh get <key> [default]}"
 key="${2:?Usage: plot-config.sh get <key> [default]}"
 default="${3:-}"
 
-if [ "$cmd" != "get" ]; then
-  echo "plot-config: unknown subcommand '$cmd' (only 'get' is supported)" >&2
-  exit 1
-fi
+[ "$cmd" = "get" ] || { echo "plot-config: unknown subcommand '$cmd' (only 'get' is supported)" >&2; exit 1; }
 
 # THE CALLER'S ROOT IS TAKEN WHERE IT OFFERS ONE. `git rev-parse` is ~5 ms and
 # this script runs once per config key, so a caller reading several keys pays
@@ -219,11 +226,8 @@ fi
 # exported stale path would otherwise make every config read answer from a
 # repository that is not this one, silently. Asking git is the safe answer and
 # stays the default for every caller that offers nothing.
-if [ -n "${PLOT_REPO_ROOT:-}" ] && [ -d "$PLOT_REPO_ROOT" ]; then
-  root="$PLOT_REPO_ROOT"
-else
-  root=$(git rev-parse --show-toplevel 2>/dev/null) || root="."
-fi
+root="${PLOT_REPO_ROOT:-}"
+[ -n "$root" ] && [ -d "$root" ] || root=$(git rev-parse --show-toplevel 2>/dev/null) || root="."
 
 # Find the first repo-root file that contains a ## Plot Config section.
 # CLAUDE.md wins for backwards compatibility; AGENTS.md is the modern fallback.
@@ -261,8 +265,4 @@ if [ -n "$config_file" ]; then
         s/^[[:space:]]+//; s/[[:space:]]+$//')  # trim ends
 fi
 
-if [ -n "$value" ]; then
-  printf '%s\n' "$value"
-else
-  printf '%s\n' "$default"
-fi
+printf '%s\n' "${value:-$default}"

package/plot-dispatch.sh

@@ -1374,14 +1374,12 @@ start_worker() {
   #
   # EVERY WORKER IS BORN MONITORED, AND THAT IS ENFORCED HERE OR NOWHERE.
   #
-  # Two monitors start INSIDE the wrapper, as its children, immediately before
-  # the agent: one watches the desk (`plot-agent-monitor.sh`), one watches the
-  # run (`plot-build-monitor.sh`). Each has a subject the other does not and a
-  # cadence it cannot share — minutes on the host, seconds on a run but only
-  # while one is live. The PROCESS is no longer a third monitor's subject:
-  # since `bug/the-loop-reports-idle` the loop's own watcher judges `idle`
-  # (`plot-worker-state.sh`'s `plot_worker_idle_watch_pass`), and the wrapper
-  # itself reports `gone`/`clear` after `wait "$agent"` returns, below.
+  # The AgentMonitor starts INSIDE the wrapper, as its child, immediately
+  # before the agent, watching the desk. The PROCESS is no longer a monitor's
+  # subject: since `bug/the-loop-reports-idle` the loop's own watcher judges `idle`
+  # (`board/plot-worker-loop.mjs`'s `idleVerdict`, built from the domain's
+  # `idleNow`), and the wrapper itself reports `gone`/`clear` after
+  # `wait "$agent"` returns, below.
   #
   # WHY INSIDE THE WRAPPER RATHER THAN BESIDE IT. The wrapper already outlives
   # its agent by construction — it must, or there would be no exit code to
@@ -1481,14 +1479,8 @@ start_worker() {
     fi
   fi
 
-  local agent_monitor='' build_monitor=''
+  local agent_monitor=''
   [ -x "$script_dir/plot-agent-monitor.sh" ] && agent_monitor="$script_dir/plot-agent-monitor.sh"
-  # THE THIRD MONITOR, born the same way and for the same reason. It watches the
-  # RUN — a Build is its own entity in the spec, so a monitor per entity is the
-  # pattern rather than an exception to it. Its cadence is the WorkerMonitor's
-  # 30 s rather than the AgentMonitor's 300 s, and it can afford that against a
-  # HOST because it asks nothing while no run is live.
-  [ -x "$script_dir/plot-build-monitor.sh" ] && build_monitor="$script_dir/plot-build-monitor.sh"
   local stamp_now
   stamp_now=$(date -u +%Y-%m-%dT%H:%M:%SZ)
   # THE THREE NAMES THE CHARTER DECLARED, and they travel as env vars for the
@@ -1563,11 +1555,10 @@ start_worker() {
       PLOT_MANIFEST_FILE="$manifest_dir/$session.json" \
       PLOT_STAMP_STARTED="$stamp_now" \
       PLOT_AGENT_MONITOR="$agent_monitor" \
-      PLOT_BUILD_MONITOR="$build_monitor" \
       PLOT_EXIT_FILE="$wt/.plot-worker.exit" PLOT_PID_FILE="$wt/.plot-worker.pid" \
       PLOT_WRAPPER_PID_FILE="$wt/.plot-worker.wrapper.pid" \
       PLOT_SCRIPT_DIR="$script_dir" \
-      exec nohup sh -c 'printf "%s" "$$" > "$PLOT_WRAPPER_PID_FILE"; wmon=""; amon=""; bmon=""; if [ -n "$PLOT_AGENT_MONITOR" ]; then "$PLOT_AGENT_MONITOR" & amon=$!; fi; if [ -n "$PLOT_BUILD_MONITOR" ]; then "$PLOT_BUILD_MONITOR" & bmon=$!; fi; PATH="$PLOT_SCRIPT_DIR:$PATH"; export PATH; ( '"$cmd"' ) & agent=$!; trap "" TERM; printf "%s" "$agent" > "$PLOT_PID_FILE"; if [ -f "$PLOT_MANIFEST_FILE" ]; then awk -v pid="$agent" -v started="$PLOT_STAMP_STARTED" -v wrapper="$$" -v wmon="$wmon" -v amon="$amon" -v bmon="$bmon" '"'"'
+      exec nohup sh -c 'printf "%s" "$$" > "$PLOT_WRAPPER_PID_FILE"; wmon=""; amon=""; if [ -n "$PLOT_AGENT_MONITOR" ]; then "$PLOT_AGENT_MONITOR" & amon=$!; fi; PATH="$PLOT_SCRIPT_DIR:$PATH"; export PATH; ( '"$cmd"' ) & agent=$!; trap "" TERM; printf "%s" "$agent" > "$PLOT_PID_FILE"; if [ -f "$PLOT_MANIFEST_FILE" ]; then awk -v pid="$agent" -v started="$PLOT_STAMP_STARTED" -v wrapper="$$" -v wmon="$wmon" -v amon="$amon" '"'"'
         BEGIN { relaunch = 0; count = 1; stamped = 0 }
         FNR == NR {
           if ($0 ~ /^  "pid": "[^"]*",$/) {
@@ -1585,7 +1576,6 @@ start_worker() {
           print "  \"wrapperPid\": \"" wrapper "\","
           print "  \"workerMonitorPid\": \"" wmon "\","
           print "  \"agentMonitorPid\": \"" amon "\","
-          print "  \"buildMonitorPid\": \"" bmon "\","
           if (relaunch) {
             print "  \"previousPid\": \"" displaced "\","
             print "  \"relaunches\": " count ","
@@ -1595,7 +1585,6 @@ start_worker() {
         $0 ~ /^  "wrapperPid": "[^"]*",$/ { next }
         $0 ~ /^  "workerMonitorPid": "[^"]*",$/ { next }
         $0 ~ /^  "agentMonitorPid": "[^"]*",$/ { next }
-        $0 ~ /^  "buildMonitorPid": "[^"]*",$/ { next }
         relaunch && $0 ~ /^  "previousPid": "[^"]*",$/ { next }
         relaunch && $0 ~ /^  "relaunches": [0-9]+,$/ { next }
         relaunch && $0 ~ /^  "startedAt": "[^"]*"$/ { print "  \"startedAt\": \"" started "\""; next }
@@ -3043,7 +3032,9 @@ esac
 # merged PR outlives the branch it was cut from.
 #
 # `NONE` AND SILENCE ARE DIFFERENT ANSWERS. `NONE` means the host was asked and
-# has never seen a PR for that branch — a typo, which is `blocked`. A host that
+# has never seen a PR for that branch. For a name in `plot-fleet-scan.sh
+# --slice-names` — a slice of any live plan, not deferred — that is a slice
+# nobody started, which is `waiting`; for any other name it is `blocked`. A host that
 # could not be asked is neither permission nor proof of a typo, so it HOLDS the
 # branch at `waiting`. Both refuse; only one tells the operator to fix the plan.
 
@@ -3172,13 +3163,27 @@ declare -a waits_freed=()
 # already sets: a dry run that offers what a real run would refuse is worse than
 # no dry run — it is the same wrong answer with a reassurance attached.
 run_waits_preflight() { # → prints refusals; fills waits_held, adds to n_skipped
-  local br prereq answer held
+  local br prereq answer held slice_names=""
   while IFS=$'\t' read -r br prereq; do
     [ -n "$br" ] || continue
     answer=$(prereq_answer "$prereq")
     case "$answer" in
       merged) continue ;;
-      none)   held=blocked ;;
+      # A slice somebody may still start has no PR until its work starts: a
+      # wait, not a typo (#1305). The set is the scan's, of the whole estate,
+      # so a slice of ANOTHER plan reads as it does on the board. Asked once,
+      # and only when the host answered `none`.
+      # ABSENT IS NOT FALSE. A scan that failed or printed nothing leaves the
+      # set unread, and an unread set holds the branch at `waiting` exactly as
+      # an unaskable host does: telling an operator to fix a correct plan is its
+      # own defect. stderr stays visible, and the refusal names the failure.
+      none)   [ -n "$slice_names" ] || slice_names=$'\n'"$("$script_dir/plot-fleet-scan.sh" --slice-names)"$'\n' || slice_names=$'\n\n'
+              case "$slice_names" in
+                $'\n\n') held=waiting
+                          echo "plot-fleet-scan.sh --slice-names gave no answer: $prereq has no PR, held as waiting rather than called a typo" ;;
+                *$'\n'"$prereq"$'\n'*) held=waiting ;;
+                *) held=blocked ;;
+              esac ;;
       *)      held=waiting ;;
     esac
     # `--allow-waiting` SAYS SO ON THE LINE IT OVERRIDES, ONCE PER PREREQUISITE
@@ -3267,9 +3272,7 @@ worker_state_field() {
 #
 # `worker=` still travels in the footer. It says how this repo is configured,
 # which remains a fact about the repo even where it no longer explains a count.
-print_summary() { # $1=dispatched $2=reused $3=skipped $4=started
-  echo "summary: dispatched=$1 reused=$2 skipped=$3 started=$4 brief=missing worker=$(worker_state_field) brief_asked=${n_brief_asked:-0}"
-}
+# The line is printed once, at the end of the run.
 
 # ---------------------------------------------------------------------------
 # Parallel-agents cap: warn and raise when exceeded
@@ -4225,7 +4228,7 @@ book_started ${claimed_now[@]+"${claimed_now[@]}"} || true
 # appears before the footer.
 check_and_update_cap "$n_started"
 
-print_summary "$n_dispatched" "$n_reused" "$n_skipped" "$n_started"
+echo "summary: dispatched=$n_dispatched reused=$n_reused skipped=$n_skipped started=$n_started brief=missing worker=$(worker_state_field) brief_asked=${n_brief_asked:-0}"
 
 # THE RECEIPT IS SPENT HERE, on the fan-out COMPLETING — never at the gate.
 # `plot-controller-gate.sh` clears on a receipt and LEAVES it, so a run that