@plcmp/pl-virtual-scroll 1.0.2 → 1.0.4

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@plcmp/pl-virtual-scroll",
-    "version": "1.0.2",
+    "version": "1.0.4",
     "description": "Component for lazy list render.",
     "main": "pl-virtual-scroll.js",
     "repository": {

package/pl-virtual-scroll.js

@@ -100,33 +100,36 @@ class PlVirtualScroll extends PlElement {
                     setTimeout(() => this.render(), 0);
                 }
                 break;
+
             case 'splice': {
                 let { index: spliceIndex } = mutation;
-                // if mutation is not root try to apply effects to children (need when pushing to array inside array)
-                if (rest.length > 0) {
-                    let path = [this.as, ...rest].join('.');
-                    this.phyPool[index].ctx.applyEffects({ ...mutation, path });
-                } else {
-                    this.phyPool.forEach((i) => {
-                        if (i.index !== null && i.index >= spliceIndex && i.index < this.items.length) {
-                            if (this.items[i.index] instanceof PlaceHolder) this.items.load?.(this.items[i.index]);
-
-                            i.ctx.replace(this.items[i.index]);
-                            i.ctx.applyEffects(undefined);
-                            i.ctx._ti.applyBinds();
-                        } else if (i.index >= this.items.length) {
-                            i.index = null;
-                            i.offset = -10000;
-                            fixOffset(i);
-                        }
-                    });
-                }
+                if (Number(index) >= 0) {
+                    // if mutation is not root try to apply effects to children (need when pushing to array inside array)
+                    if (rest.length > 0) {
+                        let path = [this.as, ...rest].join('.');
+                        this.phyPool[index].ctx.applyEffects({...mutation, path});
+                    } else {
+                        this.phyPool.forEach((i) => {
+                            if (i.index !== null && i.index >= spliceIndex && i.index < this.items.length) {
+                                if (this.items[i.index] instanceof PlaceHolder) this.items.load?.(this.items[i.index]);
+
+                                i.ctx.replace(this.items[i.index]);
+                                i.ctx.applyEffects(undefined);
+                                i.ctx._ti.applyBinds();
+                            } else if (i.index >= this.items.length) {
+                                i.index = null;
+                                i.offset = -10000;
+                                fixOffset(i);
+                            }
+                        });
+                    }
 
-                // TODO: add more Heuristic to scroll list if visible elements that not changed? like insert rows before
-                //      visible area
+                    // TODO: add more Heuristic to scroll list if visible elements that not changed? like insert rows before
+                    //      visible area
 
-                // refresh all PHY if they can be affected
-                setTimeout(() => this.render(), 0);
+                    // refresh all PHY if they can be affected
+                    setTimeout(() => this.render(), 0);
+                }
 
                 break;
             }
@@ -211,8 +214,9 @@ class PlVirtualScroll extends PlElement {
                         : 32; // TODO: replace w/o constant
                 const predictedStart = Math.min(Math.ceil(this.canvas.parentNode.scrollTop / heightForStart), this.items.length - 1);
                 firstShadow = lastShadow = this.renderItem(predictedStart, unused.pop(), this.canvas.parentNode.scrollTop);
-                used.unshift(firstShadow);
             }
+
+            used.unshift(firstShadow);
         }
 
         // render forward