@playwright/test 1.37.0-alpha-aug-7-2023 → 1.37.0-alpha-aug-8-2023

package/lib/isomorphic/teleReceiver.js

@@ -51,8 +51,12 @@ class TeleReporterReceiver {
       this._onConfigure(params.config);
       return;
     }
+    if (method === 'onProject') {
+      this._onProject(params.project);
+      return;
+    }
     if (method === 'onBegin') {
-      this._onBegin(params.projects);
+      this._onBegin();
       return;
     }
     if (method === 'onTestBegin') {
@@ -92,35 +96,35 @@ class TeleReporterReceiver {
     this._config = this._parseConfig(config);
     this._reporter.onConfigure(this._config);
   }
-  _onBegin(projects) {
-    var _this$_reporter$onBeg, _this$_reporter;
-    for (const project of projects) {
-      let projectSuite = this._rootSuite.suites.find(suite => suite.project().id === project.id);
-      if (!projectSuite) {
-        projectSuite = new TeleSuite(project.name, 'project');
-        this._rootSuite.suites.push(projectSuite);
-        projectSuite.parent = this._rootSuite;
-      }
-      const p = this._parseProject(project);
-      projectSuite.project = () => p;
-      this._mergeSuitesInto(project.suites, projectSuite);
+  _onProject(project) {
+    let projectSuite = this._rootSuite.suites.find(suite => suite.project().id === project.id);
+    if (!projectSuite) {
+      projectSuite = new TeleSuite(project.name, 'project');
+      this._rootSuite.suites.push(projectSuite);
+      projectSuite.parent = this._rootSuite;
+    }
+    const p = this._parseProject(project);
+    projectSuite.project = () => p;
+    this._mergeSuitesInto(project.suites, projectSuite);
 
-      // Remove deleted tests when listing. Empty suites will be auto-filtered
-      // in the UI layer.
-      if (this._listOnly) {
-        const testIds = new Set();
-        const collectIds = suite => {
-          suite.tests.map(t => t.testId).forEach(testId => testIds.add(testId));
-          suite.suites.forEach(collectIds);
-        };
-        project.suites.forEach(collectIds);
-        const filterTests = suite => {
-          suite.tests = suite.tests.filter(t => testIds.has(t.id));
-          suite.suites.forEach(filterTests);
-        };
-        filterTests(projectSuite);
-      }
+    // Remove deleted tests when listing. Empty suites will be auto-filtered
+    // in the UI layer.
+    if (this._listOnly) {
+      const testIds = new Set();
+      const collectIds = suite => {
+        suite.tests.map(t => t.testId).forEach(testId => testIds.add(testId));
+        suite.suites.forEach(collectIds);
+      };
+      project.suites.forEach(collectIds);
+      const filterTests = suite => {
+        suite.tests = suite.tests.filter(t => testIds.has(t.id));
+        suite.suites.forEach(filterTests);
+      };
+      filterTests(projectSuite);
     }
+  }
+  _onBegin() {
+    var _this$_reporter$onBeg, _this$_reporter;
     (_this$_reporter$onBeg = (_this$_reporter = this._reporter).onBegin) === null || _this$_reporter$onBeg === void 0 ? void 0 : _this$_reporter$onBeg.call(_this$_reporter, this._rootSuite);
   }
   _onTestBegin(testId, payload) {

package/lib/matchers/toMatchSnapshot.js

@@ -35,7 +35,7 @@ class SnapshotHelper {
     var _mime$getType;
     this.testInfo = void 0;
     this.snapshotName = void 0;
-    this.expectedPath = void 0;
+    this.legacyExpectedPath = void 0;
     this.previousPath = void 0;
     this.snapshotPath = void 0;
     this.actualPath = void 0;
@@ -102,7 +102,7 @@ class SnapshotHelper {
     this.snapshotPath = snapshotPathResolver(...inputPathSegments);
     const inputFile = testInfo._getOutputPath(...inputPathSegments);
     const outputFile = testInfo._getOutputPath(...outputPathSegments);
-    this.expectedPath = (0, _util.addSuffixToFilePath)(inputFile, '-expected');
+    this.legacyExpectedPath = (0, _util.addSuffixToFilePath)(inputFile, '-expected');
     this.previousPath = (0, _util.addSuffixToFilePath)(outputFile, '-previous');
     this.actualPath = (0, _util.addSuffixToFilePath)(outputFile, '-actual');
     this.diffPath = (0, _util.addSuffixToFilePath)(outputFile, '-diff');
@@ -181,13 +181,15 @@ class SnapshotHelper {
     if (diffError) output.push(indent(diffError, '  '));
     if (log !== null && log !== void 0 && log.length) output.push((0, _util.callLogText)(log));else output.push('');
     if (expected !== undefined) {
-      writeFileSync(this.expectedPath, expected);
+      // Copy the expectation inside the `test-results/` folder for backwards compatibility,
+      // so that one can upload `test-results/` directory and have all the data inside.
+      writeFileSync(this.legacyExpectedPath, expected);
       this.testInfo.attachments.push({
         name: (0, _util.addSuffixToFilePath)(this.snapshotName, '-expected'),
         contentType: this.mimeType,
-        path: this.expectedPath
+        path: this.snapshotPath
       });
-      output.push(`Expected: ${_utilsBundle.colors.yellow(this.expectedPath)}`);
+      output.push(`Expected: ${_utilsBundle.colors.yellow(this.snapshotPath)}`);
     }
     if (previous !== undefined) {
       writeFileSync(this.previousPath, previous);

package/lib/reporters/blob.js

@@ -46,7 +46,7 @@ class BlobReporter extends _teleEmitter.TeleReporterEmitter {
     var _config$shard;
     const metadata = {
       version: currentBlobReportVersion,
-      projectSuffix: process.env.PWTEST_BLOB_SUFFIX,
+      name: process.env.PWTEST_BLOB_REPORT_NAME,
       shard: (_config$shard = config.shard) !== null && _config$shard !== void 0 ? _config$shard : undefined
     };
     this._messages.push({
@@ -91,7 +91,7 @@ class BlobReporter extends _teleEmitter.TeleReporterEmitter {
   }
   _computeReportName(config) {
     let reportName = 'report';
-    if (process.env.PWTEST_BLOB_SUFFIX) reportName += (0, _utils.sanitizeForFilePath)(process.env.PWTEST_BLOB_SUFFIX);
+    if (process.env.PWTEST_BLOB_REPORT_NAME) reportName += `-${(0, _utils.sanitizeForFilePath)(process.env.PWTEST_BLOB_REPORT_NAME)}`;
     if (config.shard) {
       const paddedNumber = `${config.shard.current}`.padStart(`${config.shard.total}`.length, '0');
       reportName += `-${paddedNumber}`;

package/lib/reporters/html.js

@@ -187,6 +187,7 @@ class HtmlBuilder {
     const data = new Map();
     for (const projectJson of rawReports) {
       for (const file of projectJson.suites) {
+        var _projectJson$project$;
         const fileName = file.location.file;
         const fileId = file.fileId;
         let fileEntry = data.get(fileId);
@@ -211,7 +212,7 @@ class HtmlBuilder {
           testFileSummary
         } = fileEntry;
         const testEntries = [];
-        this._processJsonSuite(file, fileId, projectJson.project.name, [], testEntries);
+        this._processJsonSuite(file, fileId, projectJson.project.name, (_projectJson$project$ = projectJson.project.metadata) === null || _projectJson$project$ === void 0 ? void 0 : _projectJson$project$.reportName, [], testEntries);
         for (const test of testEntries) {
           testFile.tests.push(test.testCase);
           testFileSummary.tests.push(test.testCaseSummary);
@@ -304,12 +305,12 @@ class HtmlBuilder {
   _addDataFile(fileName, data) {
     this._dataZipFile.addBuffer(Buffer.from(JSON.stringify(data)), fileName);
   }
-  _processJsonSuite(suite, fileId, projectName, path, outTests) {
+  _processJsonSuite(suite, fileId, projectName, reportName, path, outTests) {
     const newPath = [...path, suite.title];
-    suite.suites.map(s => this._processJsonSuite(s, fileId, projectName, newPath, outTests));
-    suite.tests.forEach(t => outTests.push(this._createTestEntry(t, projectName, newPath)));
+    suite.suites.map(s => this._processJsonSuite(s, fileId, projectName, reportName, newPath, outTests));
+    suite.tests.forEach(t => outTests.push(this._createTestEntry(t, projectName, reportName, newPath)));
   }
-  _createTestEntry(test, projectName, path) {
+  _createTestEntry(test, projectName, reportName, path) {
     const duration = test.results.reduce((a, r) => a + r.duration, 0);
     this._tests.set(test.testId, test);
     const location = test.location;
@@ -321,6 +322,7 @@ class HtmlBuilder {
         testId: test.testId,
         title: test.title,
         projectName,
+        reportName,
         location,
         duration,
         annotations: test.annotations,
@@ -333,6 +335,7 @@ class HtmlBuilder {
         testId: test.testId,
         title: test.title,
         projectName,
+        reportName,
         location,
         duration,
         annotations: test.annotations,

package/lib/reporters/junit.js

@@ -56,7 +56,7 @@ class JUnitReporter extends _empty.default {
     const duration = (0, _utils.monotonicTime)() - this.startTime;
     const children = [];
     for (const projectSuite of this.suite.suites) {
-      for (const fileSuite of projectSuite.suites) children.push(this._buildTestSuite(projectSuite.title, fileSuite));
+      for (const fileSuite of projectSuite.suites) children.push(await this._buildTestSuite(projectSuite.title, fileSuite));
     }
     const tokens = [];
     const self = this;
@@ -78,27 +78,27 @@ class JUnitReporter extends _empty.default {
     if (this.outputFile) {
       (0, _utils.assert)(this.config.configFile || _path.default.isAbsolute(this.outputFile), 'Expected fully resolved path if not using config file.');
       const outputFile = this.config.configFile ? _path.default.resolve(_path.default.dirname(this.config.configFile), this.outputFile) : this.outputFile;
-      _fs.default.mkdirSync(_path.default.dirname(outputFile), {
+      await _fs.default.promises.mkdir(_path.default.dirname(outputFile), {
         recursive: true
       });
-      _fs.default.writeFileSync(outputFile, reportString);
+      await _fs.default.promises.writeFile(outputFile, reportString);
     } else {
       console.log(reportString);
     }
   }
-  _buildTestSuite(projectName, suite) {
+  async _buildTestSuite(projectName, suite) {
     let tests = 0;
     let skipped = 0;
     let failures = 0;
     let duration = 0;
     const children = [];
-    suite.allTests().forEach(test => {
+    for (const test of suite.allTests()) {
       ++tests;
       if (test.outcome() === 'skipped') ++skipped;
       if (!test.ok()) ++failures;
       for (const result of test.results) duration += result.duration;
-      this._addTestCase(suite.title, test, children);
-    });
+      await this._addTestCase(suite.title, test, children);
+    }
     this.totalTests += tests;
     this.totalSkipped += skipped;
     this.totalFailures += failures;
@@ -118,7 +118,7 @@ class JUnitReporter extends _empty.default {
     };
     return entry;
   }
-  _addTestCase(suiteName, test, entries) {
+  async _addTestCase(suiteName, test, entries) {
     var _properties$children2;
     const entry = {
       name: 'testcase',
@@ -175,10 +175,13 @@ class JUnitReporter extends _empty.default {
       systemErr.push(...result.stderr.map(item => item.toString()));
       for (const attachment of result.attachments) {
         if (!attachment.path) continue;
+        const attachmentPath = _path.default.relative(this.config.rootDir, attachment.path);
         try {
-          const attachmentPath = _path.default.relative(this.config.rootDir, attachment.path);
-          if (_fs.default.existsSync(attachment.path)) systemOut.push(`\n[[ATTACHMENT|${attachmentPath}]]\n`);else systemErr.push(`\nWarning: attachment ${attachmentPath} is missing`);
-        } catch (e) {}
+          await _fs.default.promises.access(attachment.path);
+          systemOut.push(`\n[[ATTACHMENT|${attachmentPath}]]\n`);
+        } catch {
+          systemErr.push(`\nWarning: attachment ${attachmentPath} is missing`);
+        }
       }
     }
     // Note: it is important to only produce a single system-out/system-err entry

package/lib/reporters/merge.js

@@ -73,7 +73,7 @@ async function extractAndParseReports(dir, shardFiles, stringPool, printStatus)
     printStatus(`extracting: ${(0, _util.relativeFilePath)(absolutePath)}`);
     const zipFile = new _utils.ZipFile(absolutePath);
     const entryNames = await zipFile.entries();
-    for (const entryName of entryNames) {
+    for (const entryName of entryNames.sort()) {
       const content = await zipFile.read(entryName);
       if (entryName.endsWith('.jsonl')) {
         const parsedEvents = parseEvents(content);
@@ -82,6 +82,7 @@ async function extractAndParseReports(dir, shardFiles, stringPool, printStatus)
         // as a post-processing step.
         internalizer.traverse(parsedEvents);
         shardEvents.push({
+          file,
           metadata: findMetadata(parsedEvents, file),
           parsedEvents
         });
@@ -102,28 +103,47 @@ function findMetadata(events, file) {
   return metadata;
 }
 async function mergeEvents(dir, shardReportFiles, printStatus) {
+  const stringPool = new _stringInternPool.StringInternPool();
   const events = [];
   const configureEvents = [];
-  const beginEvents = [];
+  const projectEvents = [];
   const endEvents = [];
-  const stringPool = new _stringInternPool.StringInternPool();
-  const shardEvents = await extractAndParseReports(dir, shardReportFiles, stringPool, printStatus);
-  shardEvents.sort((a, b) => {
-    var _a$metadata$shard$cur, _a$metadata$shard, _b$metadata$shard$cur, _b$metadata$shard;
+  const blobs = await extractAndParseReports(dir, shardReportFiles, stringPool, printStatus);
+  // Sort by (report name; shard; file name), so that salt generation below is deterministic when:
+  // - report names are unique;
+  // - report names are missing;
+  // - report names are clashing between shards.
+  blobs.sort((a, b) => {
+    var _a$metadata$name, _b$metadata$name, _a$metadata$shard$cur, _a$metadata$shard, _b$metadata$shard$cur, _b$metadata$shard;
+    const nameA = (_a$metadata$name = a.metadata.name) !== null && _a$metadata$name !== void 0 ? _a$metadata$name : '';
+    const nameB = (_b$metadata$name = b.metadata.name) !== null && _b$metadata$name !== void 0 ? _b$metadata$name : '';
+    if (nameA !== nameB) return nameA.localeCompare(nameB);
     const shardA = (_a$metadata$shard$cur = (_a$metadata$shard = a.metadata.shard) === null || _a$metadata$shard === void 0 ? void 0 : _a$metadata$shard.current) !== null && _a$metadata$shard$cur !== void 0 ? _a$metadata$shard$cur : 0;
     const shardB = (_b$metadata$shard$cur = (_b$metadata$shard = b.metadata.shard) === null || _b$metadata$shard === void 0 ? void 0 : _b$metadata$shard.current) !== null && _b$metadata$shard$cur !== void 0 ? _b$metadata$shard$cur : 0;
-    return shardA - shardB;
+    if (shardA !== shardB) return shardA - shardB;
+    return a.file.localeCompare(b.file);
   });
-  const allTestIds = new Set();
+  const saltSet = new Set();
   printStatus(`merging events`);
   for (const {
-    parsedEvents
-  } of shardEvents) {
+    file,
+    parsedEvents,
+    metadata
+  } of blobs) {
+    // Generate unique salt for each blob.
+    const sha1 = (0, _utils.calculateSha1)(metadata.name || _path.default.basename(file)).substring(0, 16);
+    let salt = sha1;
+    for (let i = 0; saltSet.has(salt); i++) salt = sha1 + '-' + i;
+    saltSet.add(salt);
+    new IdsPatcher(stringPool, metadata.name, salt).patchEvents(parsedEvents);
     for (const event of parsedEvents) {
-      if (event.method === 'onConfigure') configureEvents.push(event);else if (event.method === 'onBegin') beginEvents.push(event);else if (event.method === 'onEnd') endEvents.push(event);else if (event.method === 'onBlobReportMetadata') new ProjectNamePatcher(allTestIds, stringPool, event.params.projectSuffix || '').patchEvents(parsedEvents);else events.push(event);
+      if (event.method === 'onConfigure') configureEvents.push(event);else if (event.method === 'onProject') projectEvents.push(event);else if (event.method === 'onEnd') endEvents.push(event);else if (event.method !== 'onBlobReportMetadata' && event.method !== 'onBegin') events.push(event);
     }
   }
-  return [mergeConfigureEvents(configureEvents), mergeBeginEvents(beginEvents), ...events, mergeEndEvents(endEvents), {
+  return [mergeConfigureEvents(configureEvents), ...projectEvents, {
+    method: 'onBegin',
+    params: undefined
+  }, ...events, mergeEndEvents(endEvents), {
     method: 'onExit',
     params: undefined
   }];
@@ -150,23 +170,6 @@ function mergeConfigureEvents(configureEvents) {
     }
   };
 }
-function mergeBeginEvents(beginEvents) {
-  if (!beginEvents.length) throw new Error('No begin events found');
-  const projects = [];
-  for (const event of beginEvents) {
-    const shardProjects = event.params.projects;
-    for (const shardProject of shardProjects) {
-      const mergedProject = projects.find(p => p.id === shardProject.id);
-      if (!mergedProject) projects.push(shardProject);else mergeJsonSuites(shardProject.suites, mergedProject);
-    }
-  }
-  return {
-    method: 'onBegin',
-    params: {
-      projects
-    }
-  };
-}
 function mergeConfigs(to, from) {
   return {
     ...to,
@@ -180,17 +183,6 @@ function mergeConfigs(to, from) {
     workers: to.workers + from.workers
   };
 }
-function mergeJsonSuites(jsonSuites, parent) {
-  for (const jsonSuite of jsonSuites) {
-    const existingSuite = parent.suites.find(s => s.title === jsonSuite.title);
-    if (!existingSuite) {
-      parent.suites.push(jsonSuite);
-    } else {
-      mergeJsonSuites(jsonSuite.suites, existingSuite);
-      existingSuite.tests.push(...jsonSuite.tests);
-    }
-  }
-}
 function mergeEndEvents(endEvents) {
   const result = {
     status: 'passed'
@@ -213,12 +205,11 @@ async function sortedShardFiles(dir) {
 function printStatusToStdout(message) {
   process.stdout.write(`${message}\n`);
 }
-class ProjectNamePatcher {
-  constructor(_allTestIds, _stringPool, _projectNameSuffix) {
-    this._testIds = new Set();
-    this._allTestIds = _allTestIds;
+class IdsPatcher {
+  constructor(_stringPool, _reportName, _salt) {
     this._stringPool = _stringPool;
-    this._projectNameSuffix = _projectNameSuffix;
+    this._reportName = _reportName;
+    this._salt = _salt;
   }
   patchEvents(events) {
     for (const event of events) {
@@ -227,8 +218,8 @@ class ProjectNamePatcher {
         params
       } = event;
       switch (method) {
-        case 'onBegin':
-          this._onBegin(params.config, params.projects);
+        case 'onProject':
+          this._onProject(params.project);
           continue;
         case 'onTestBegin':
         case 'onStepBegin':
@@ -241,39 +232,19 @@ class ProjectNamePatcher {
           continue;
       }
     }
-    for (const testId of this._testIds) this._allTestIds.add(testId);
-  }
-  _onBegin(config, projects) {
-    for (const project of projects) project.name += this._projectNameSuffix;
-    this._updateProjectIds(projects);
-    for (const project of projects) project.suites.forEach(suite => this._updateTestIds(suite));
   }
-  _updateProjectIds(projects) {
-    const usedNames = new Set();
-    for (const p of projects) {
-      for (let i = 0; i < projects.length; ++i) {
-        const candidate = p.name + (i ? i : '');
-        if (usedNames.has(candidate)) continue;
-        p.id = candidate;
-        usedNames.add(candidate);
-        break;
-      }
-    }
+  _onProject(project) {
+    var _project$metadata;
+    project.metadata = (_project$metadata = project.metadata) !== null && _project$metadata !== void 0 ? _project$metadata : {};
+    project.metadata.reportName = this._reportName;
+    project.id = this._stringPool.internString(project.id + this._salt);
+    project.suites.forEach(suite => this._updateTestIds(suite));
   }
   _updateTestIds(suite) {
-    suite.tests.forEach(test => {
-      test.testId = this._mapTestId(test.testId);
-      this._testIds.add(test.testId);
-    });
+    suite.tests.forEach(test => test.testId = this._mapTestId(test.testId));
     suite.suites.forEach(suite => this._updateTestIds(suite));
   }
   _mapTestId(testId) {
-    testId = testId + this._projectNameSuffix;
-    // Consider a setup project running on each shard. In this case we'll have
-    // the same testId (from setup project) in multiple blob reports.
-    // To avoid reporters being confused by clashing test ids, we automatically
-    // make them unique and produce a separate test from each blob.
-    while (this._allTestIds.has(testId)) testId = testId + '1';
-    return this._stringPool.internString(testId);
+    return this._stringPool.internString(testId + this._salt);
   }
 }

package/lib/reporters/teleEmitter.js

@@ -47,12 +47,16 @@ class TeleReporterEmitter {
   }
   onBegin(suite) {
     const projects = suite.suites.map(projectSuite => this._serializeProject(projectSuite));
-    this._messageSink({
-      method: 'onBegin',
+    for (const project of projects) this._messageSink({
+      method: 'onProject',
       params: {
-        projects
+        project
       }
     });
+    this._messageSink({
+      method: 'onBegin',
+      params: undefined
+    });
   }
   onTestBegin(test, result) {
     result[idSymbol] = (0, _utils.createGuid)();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@playwright/test",
-  "version": "1.37.0-alpha-aug-7-2023",
+  "version": "1.37.0-alpha-aug-8-2023",
   "description": "A high-level API to automate web browsers",
   "repository": "github:Microsoft/playwright",
   "homepage": "https://playwright.dev",
@@ -41,7 +41,7 @@
   "license": "Apache-2.0",
   "dependencies": {
     "@types/node": "*",
-    "playwright-core": "1.37.0-alpha-aug-7-2023"
+    "playwright-core": "1.37.0-alpha-aug-8-2023"
   },
   "optionalDependencies": {
     "fsevents": "2.3.2"

package/types/test.d.ts

@@ -164,7 +164,7 @@ export interface FullProject<TestArgs = {}, WorkerArgs = {}> {
    * Filter to only run tests with a title matching one of the patterns. For example, passing `grep: /cart/` should only
    * run tests with "cart" in the title. Also available globally and in the [command line](https://playwright.dev/docs/test-cli) with the `-g`
    * option. The regular expression will be tested against the string that consists of the test file name,
-   * `test.describe` name (if any) and the test name divided by spaces, e.g. `my-test.spec.ts my suite my test`.
+   * `test.describe` name (if any) and the test name divided by spaces, e.g. `my-test.spec.ts my-suite my-test`.
    *
    * `grep` option is also useful for [tagging tests](https://playwright.dev/docs/test-annotations#tag-tests).
    */
@@ -791,7 +791,9 @@ interface TestConfig {
 
   /**
    * Filter to only run tests with a title matching one of the patterns. For example, passing `grep: /cart/` should only
-   * run tests with "cart" in the title. Also available in the [command line](https://playwright.dev/docs/test-cli) with the `-g` option.
+   * run tests with "cart" in the title. Also available in the [command line](https://playwright.dev/docs/test-cli) with the `-g` option. The
+   * regular expression will be tested against the string that consists of the test file name, `test.describe` name (if
+   * any) and the test name divided by spaces, e.g. `my-test.spec.ts my-suite my-test`.
    *
    * `grep` option is also useful for [tagging tests](https://playwright.dev/docs/test-annotations#tag-tests).
    *
@@ -1540,7 +1542,9 @@ export interface FullConfig<TestArgs = {}, WorkerArgs = {}> {
   globalTimeout: number;
   /**
    * Filter to only run tests with a title matching one of the patterns. For example, passing `grep: /cart/` should only
-   * run tests with "cart" in the title. Also available in the [command line](https://playwright.dev/docs/test-cli) with the `-g` option.
+   * run tests with "cart" in the title. Also available in the [command line](https://playwright.dev/docs/test-cli) with the `-g` option. The
+   * regular expression will be tested against the string that consists of the test file name, `test.describe` name (if
+   * any) and the test name divided by spaces, e.g. `my-test.spec.ts my-suite my-test`.
    *
    * `grep` option is also useful for [tagging tests](https://playwright.dev/docs/test-annotations#tag-tests).
    *
@@ -6406,7 +6410,7 @@ interface TestProject {
    * Filter to only run tests with a title matching one of the patterns. For example, passing `grep: /cart/` should only
    * run tests with "cart" in the title. Also available globally and in the [command line](https://playwright.dev/docs/test-cli) with the `-g`
    * option. The regular expression will be tested against the string that consists of the test file name,
-   * `test.describe` name (if any) and the test name divided by spaces, e.g. `my-test.spec.ts my suite my test`.
+   * `test.describe` name (if any) and the test name divided by spaces, e.g. `my-test.spec.ts my-suite my-test`.
    *
    * `grep` option is also useful for [tagging tests](https://playwright.dev/docs/test-annotations#tag-tests).
    */