@playwright/test 1.35.0-alpha-jun-5-2023 → 1.35.0-alpha-jun-7-2023

package/.eslintrc.js

@@ -1,3 +1,15 @@
+const path = require('path');
+
 module.exports = {
-  extends: "../.eslintrc-with-ts-config.js",
+  extends: '../.eslintrc.js',
+  parser: "@typescript-eslint/parser",
+  plugins: ["@typescript-eslint", "notice"],
+  parserOptions: {
+    ecmaVersion: 9,
+    sourceType: "module",
+    project: path.join(__dirname, '..', '..', 'tsconfig.json'),
+  },
+  rules: {
+    '@typescript-eslint/no-floating-promises': 'error',
+  },
 };

package/ThirdPartyNotices.txt

@@ -99,7 +99,6 @@ This project incorporates components from the projects listed below. The origina
 -	color-name@1.1.4 (https://github.com/colorjs/color-name)
 -	convert-source-map@1.8.0 (https://github.com/thlorenz/convert-source-map)
 -	debug@4.3.4 (https://github.com/debug-js/debug)
--	define-lazy-prop@2.0.0 (https://github.com/sindresorhus/define-lazy-prop)
 -	diff-sequences@27.5.1 (https://github.com/facebook/jest)
 -	electron-to-chromium@1.4.337 (https://github.com/kilian/electron-to-chromium)
 -	enquirer@2.3.6 (https://github.com/enquirer/enquirer)
@@ -115,11 +114,9 @@ This project incorporates components from the projects listed below. The origina
 -	has-flag@3.0.0 (https://github.com/sindresorhus/has-flag)
 -	has-flag@4.0.0 (https://github.com/sindresorhus/has-flag)
 -	is-binary-path@2.1.0 (https://github.com/sindresorhus/is-binary-path)
--	is-docker@2.2.1 (https://github.com/sindresorhus/is-docker)
 -	is-extglob@2.1.1 (https://github.com/jonschlinkert/is-extglob)
 -	is-glob@4.0.3 (https://github.com/micromatch/is-glob)
 -	is-number@7.0.0 (https://github.com/jonschlinkert/is-number)
--	is-wsl@2.2.0 (https://github.com/sindresorhus/is-wsl)
 -	jest-diff@27.5.1 (https://github.com/facebook/jest)
 -	jest-get-type@27.5.1 (https://github.com/facebook/jest)
 -	jest-matcher-utils@27.2.5 (https://github.com/facebook/jest)
@@ -133,7 +130,6 @@ This project incorporates components from the projects listed below. The origina
 -	ms@2.1.2 (https://github.com/zeit/ms)
 -	node-releases@2.0.10 (https://github.com/chicoxyzzy/node-releases)
 -	normalize-path@3.0.0 (https://github.com/jonschlinkert/normalize-path)
--	open@8.4.0 (https://github.com/sindresorhus/open)
 -	picocolors@1.0.0 (https://github.com/alexeyraspopov/picocolors)
 -	picomatch@2.3.1 (https://github.com/micromatch/picomatch)
 -	pirates@4.0.4 (https://github.com/danez/pirates)
@@ -3105,20 +3101,6 @@ SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 =========================================
 END OF debug@4.3.4 AND INFORMATION
 
-%% define-lazy-prop@2.0.0 NOTICES AND INFORMATION BEGIN HERE
-=========================================
-MIT License
-
-Copyright (c) Sindre Sorhus <sindresorhus@gmail.com> (sindresorhus.com)
-
-Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-=========================================
-END OF define-lazy-prop@2.0.0 AND INFORMATION
-
 %% diff-sequences@27.5.1 NOTICES AND INFORMATION BEGIN HERE
 =========================================
 MIT License
@@ -3395,20 +3377,6 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
 =========================================
 END OF is-binary-path@2.1.0 AND INFORMATION
 
-%% is-docker@2.2.1 NOTICES AND INFORMATION BEGIN HERE
-=========================================
-MIT License
-
-Copyright (c) Sindre Sorhus <sindresorhus@gmail.com> (https://sindresorhus.com)
-
-Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-=========================================
-END OF is-docker@2.2.1 AND INFORMATION
-
 %% is-extglob@2.1.1 NOTICES AND INFORMATION BEGIN HERE
 =========================================
 The MIT License (MIT)
@@ -3487,20 +3455,6 @@ THE SOFTWARE.
 =========================================
 END OF is-number@7.0.0 AND INFORMATION
 
-%% is-wsl@2.2.0 NOTICES AND INFORMATION BEGIN HERE
-=========================================
-MIT License
-
-Copyright (c) Sindre Sorhus <sindresorhus@gmail.com> (sindresorhus.com)
-
-Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-=========================================
-END OF is-wsl@2.2.0 AND INFORMATION
-
 %% jest-diff@27.5.1 NOTICES AND INFORMATION BEGIN HERE
 =========================================
 MIT License
@@ -3834,20 +3788,6 @@ THE SOFTWARE.
 =========================================
 END OF normalize-path@3.0.0 AND INFORMATION
 
-%% open@8.4.0 NOTICES AND INFORMATION BEGIN HERE
-=========================================
-MIT License
-
-Copyright (c) Sindre Sorhus <sindresorhus@gmail.com> (https://sindresorhus.com)
-
-Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-=========================================
-END OF open@8.4.0 AND INFORMATION
-
 %% picocolors@1.0.0 NOTICES AND INFORMATION BEGIN HERE
 =========================================
 ISC License
@@ -4284,6 +4224,6 @@ END OF yallist@3.1.1 AND INFORMATION
 
 SUMMARY BEGIN HERE
 =========================================
-Total Packages: 149
+Total Packages: 145
 =========================================
 END OF SUMMARY

package/lib/cli.js

@@ -126,7 +126,10 @@ async function runTests(args, opts) {
   config.cliPassWithNoTests = !!opts.passWithNoTests;
   const runner = new _runner.Runner(config);
   let status;
-  if (opts.ui) status = await runner.uiAllTests();else if (process.env.PWTEST_WATCH) status = await runner.watchAllTests();else status = await runner.runAllTests();
+  if (opts.ui || opts.uiHost || opts.uiPort) status = await runner.uiAllTests({
+    host: opts.uiHost,
+    port: opts.uiPort ? +opts.uiPort : undefined
+  });else if (process.env.PWTEST_WATCH) status = await runner.watchAllTests();else status = await runner.runAllTests();
   await (0, _utils.stopProfiling)('runner');
   if (status === 'interrupted') process.exit(130);
   process.exit(status === 'passed' ? 0 : 1);
@@ -262,7 +265,7 @@ function restartWithExperimentalTsEsm(configFile) {
   return true;
 }
 const kTraceModes = ['on', 'off', 'on-first-retry', 'on-all-retries', 'retain-on-failure'];
-const testOptions = [['--browser <browser>', `Browser to use for tests, one of "all", "chromium", "firefox" or "webkit" (default: "chromium")`], ['-c, --config <file>', `Configuration file, or a test directory with optional "playwright.config.{m,c}?{js,ts}"`], ['--debug', `Run tests with Playwright Inspector. Shortcut for "PWDEBUG=1" environment variable and "--timeout=0 --max-failures=1 --headed --workers=1" options`], ['--forbid-only', `Fail if test.only is called (default: false)`], ['--fully-parallel', `Run all tests in parallel (default: false)`], ['--global-timeout <timeout>', `Maximum time this test suite can run in milliseconds (default: unlimited)`], ['-g, --grep <grep>', `Only run tests matching this regular expression (default: ".*")`], ['-gv, --grep-invert <grep>', `Only run tests that do not match this regular expression`], ['--headed', `Run tests in headed browsers (default: headless)`], ['--ignore-snapshots', `Ignore screenshot and snapshot expectations`], ['--list', `Collect all the tests and report them, but do not run`], ['--max-failures <N>', `Stop after the first N failures`], ['--no-deps', 'Do not run project dependencies'], ['--output <dir>', `Folder for output artifacts (default: "test-results")`], ['--pass-with-no-tests', `Makes test run succeed even if no tests were found`], ['--project <project-name...>', `Only run tests from the specified list of projects (default: run all projects)`], ['--quiet', `Suppress stdio`], ['--repeat-each <N>', `Run each test N times (default: 1)`], ['--reporter <reporter>', `Reporter to use, comma-separated, can be ${_config.builtInReporters.map(name => `"${name}"`).join(', ')} (default: "${_config.defaultReporter}")`], ['--retries <retries>', `Maximum retry count for flaky tests, zero for no retries (default: no retries)`], ['--shard <shard>', `Shard tests and execute only the selected shard, specify in the form "current/all", 1-based, for example "3/5"`], ['--timeout <timeout>', `Specify test timeout threshold in milliseconds, zero for unlimited (default: ${_config.defaultTimeout})`], ['--trace <mode>', `Force tracing mode, can be ${kTraceModes.map(mode => `"${mode}"`).join(', ')}`], ['--ui', `Run tests in interactive UI mode`], ['-u, --update-snapshots', `Update snapshots with actual results (default: only create missing snapshots)`], ['-j, --workers <workers>', `Number of concurrent workers or percentage of logical CPU cores, use 1 to run in a single worker (default: 50%)`], ['-x', `Stop after the first failure`]];
+const testOptions = [['--browser <browser>', `Browser to use for tests, one of "all", "chromium", "firefox" or "webkit" (default: "chromium")`], ['-c, --config <file>', `Configuration file, or a test directory with optional "playwright.config.{m,c}?{js,ts}"`], ['--debug', `Run tests with Playwright Inspector. Shortcut for "PWDEBUG=1" environment variable and "--timeout=0 --max-failures=1 --headed --workers=1" options`], ['--forbid-only', `Fail if test.only is called (default: false)`], ['--fully-parallel', `Run all tests in parallel (default: false)`], ['--global-timeout <timeout>', `Maximum time this test suite can run in milliseconds (default: unlimited)`], ['-g, --grep <grep>', `Only run tests matching this regular expression (default: ".*")`], ['-gv, --grep-invert <grep>', `Only run tests that do not match this regular expression`], ['--headed', `Run tests in headed browsers (default: headless)`], ['--ignore-snapshots', `Ignore screenshot and snapshot expectations`], ['--list', `Collect all the tests and report them, but do not run`], ['--max-failures <N>', `Stop after the first N failures`], ['--no-deps', 'Do not run project dependencies'], ['--output <dir>', `Folder for output artifacts (default: "test-results")`], ['--pass-with-no-tests', `Makes test run succeed even if no tests were found`], ['--project <project-name...>', `Only run tests from the specified list of projects (default: run all projects)`], ['--quiet', `Suppress stdio`], ['--repeat-each <N>', `Run each test N times (default: 1)`], ['--reporter <reporter>', `Reporter to use, comma-separated, can be ${_config.builtInReporters.map(name => `"${name}"`).join(', ')} (default: "${_config.defaultReporter}")`], ['--retries <retries>', `Maximum retry count for flaky tests, zero for no retries (default: no retries)`], ['--shard <shard>', `Shard tests and execute only the selected shard, specify in the form "current/all", 1-based, for example "3/5"`], ['--timeout <timeout>', `Specify test timeout threshold in milliseconds, zero for unlimited (default: ${_config.defaultTimeout})`], ['--trace <mode>', `Force tracing mode, can be ${kTraceModes.map(mode => `"${mode}"`).join(', ')}`], ['--ui', `Run tests in interactive UI mode`], ['--ui-host <host>', 'Host to serve UI on; specifying this option opens UI in a browser tab'], ['--ui-port <port>', 'Port to serve UI on, 0 for any free port; specifying this option opens UI in a browser tab'], ['-u, --update-snapshots', `Update snapshots with actual results (default: only create missing snapshots)`], ['-j, --workers <workers>', `Number of concurrent workers or percentage of logical CPU cores, use 1 to run in a single worker (default: 50%)`], ['-x', `Stop after the first failure`]];
 addTestCommand(_program.default);
 addShowReportCommand(_program.default);
 addListFilesCommand(_program.default);

package/lib/common/process.js

@@ -57,7 +57,7 @@ process.on('message', async message => {
     } = message.params;
     setTtyParams(process.stdout, processParams.stdoutParams);
     setTtyParams(process.stderr, processParams.stderrParams);
-    (0, _utils.startProfiling)();
+    void (0, _utils.startProfiling)();
     const {
       create
     } = require(runnerScript);

package/lib/index.js

@@ -95,12 +95,12 @@ const playwrightFixtures = {
     scope: 'worker',
     option: true
   }],
-  connectOptions: [({}, use) => {
+  connectOptions: [async ({}, use) => {
     // Usually, when connect options are specified (e.g, in the config or in the environment),
     // all launch() calls are turned into connect() calls.
     // However, when running in "reuse browser" mode and connecting to the reusable server,
     // only the default "browser" fixture should turn into reused browser.
-    use(process.env.PW_TEST_REUSE_CONTEXT ? undefined : connectOptionsFromEnv());
+    await use(process.env.PW_TEST_REUSE_CONTEXT ? undefined : connectOptionsFromEnv());
   }, {
     scope: 'worker',
     option: true

package/lib/matchers/toMatchSnapshot.js

@@ -149,6 +149,11 @@ class SnapshotHelper {
     if (isWriteMissingMode) {
       writeFileSync(this.snapshotPath, actual);
       writeFileSync(this.actualPath, actual);
+      this.testInfo.attachments.push({
+        name: (0, _util.addSuffixToFilePath)(this.snapshotName, '-actual'),
+        contentType: this.mimeType,
+        path: this.actualPath
+      });
     }
     const message = `A snapshot doesn't exist at ${this.snapshotPath}${isWriteMissingMode ? ', writing actual.' : '.'}`;
     if (this.updateSnapshots === 'all') {
@@ -283,6 +288,7 @@ async function toHaveScreenshot(pageOrLocator, nameOrOptions = {}, optOptions =
     caret: (_config$caret = config === null || config === void 0 ? void 0 : config.caret) !== null && _config$caret !== void 0 ? _config$caret : 'hide',
     ...helper.allOptions,
     mask: helper.allOptions.mask || [],
+    maskColor: helper.allOptions.maskColor,
     name: undefined,
     threshold: undefined,
     maxDiffPixels: undefined,

package/lib/reporters/github.js

@@ -52,7 +52,7 @@ class GitHubReporter extends _base.BaseReporter {
     return false;
   }
   async onEnd(result) {
-    super.onEnd(result);
+    await super.onEnd(result);
     this._printAnnotations();
   }
   onError(error) {

package/lib/reporters/html.js

@@ -8,7 +8,6 @@ exports.showHTMLReport = showHTMLReport;
 exports.startHtmlReportServer = startHtmlReportServer;
 var _utilsBundle = require("playwright-core/lib/utilsBundle");
 var _fs = _interopRequireDefault(require("fs"));
-var _utilsBundle2 = require("../utilsBundle");
 var _path = _interopRequireDefault(require("path"));
 var _stream = require("stream");
 var _utils = require("playwright-core/lib/utils");
@@ -37,7 +36,6 @@ class HtmlReporter {
   constructor(options) {
     this.config = void 0;
     this.suite = void 0;
-    this._montonicStartTime = 0;
     this._options = void 0;
     this._outputFolder = void 0;
     this._attachmentsBaseURL = void 0;
@@ -49,7 +47,6 @@ class HtmlReporter {
     return false;
   }
   onBegin(config, suite) {
-    this._montonicStartTime = (0, _utils.monotonicTime)();
     this.config = config;
     const {
       outputFolder,
@@ -89,7 +86,6 @@ class HtmlReporter {
     };
   }
   async onEnd() {
-    const duration = (0, _utils.monotonicTime)() - this._montonicStartTime;
     const projectSuites = this.suite.suites;
     const reports = projectSuites.map(suite => {
       const rawReporter = new _raw.default();
@@ -98,10 +94,7 @@ class HtmlReporter {
     });
     await (0, _utils.removeFolders)([this._outputFolder]);
     const builder = new HtmlBuilder(this._outputFolder, this._attachmentsBaseURL);
-    this._buildResult = await builder.build({
-      ...this.config.metadata,
-      duration
-    }, reports);
+    this._buildResult = await builder.build(this.config.metadata, reports);
   }
   async onExit() {
     if (process.env.CI || !this._buildResult) return;
@@ -153,9 +146,9 @@ async function showHTMLReport(reportFolder, host = 'localhost', port, testId) {
   console.log('');
   console.log(_utilsBundle.colors.cyan(`  Serving HTML report at ${url}. Press Ctrl+C to quit.`));
   if (testId) url += `#?testId=${testId}`;
-  await (0, _utilsBundle2.open)(url, {
+  await (0, _utilsBundle.open)(url, {
     wait: true
-  }).catch(() => console.log(`Failed to open browser on ${url}`));
+  }).catch(() => {});
   await new Promise(() => {});
 }
 function startHtmlReportServer(folder) {
@@ -257,7 +250,7 @@ class HtmlBuilder {
       projectNames: rawReports.map(r => r.project.name),
       stats: {
         ...[...data.values()].reduce((a, e) => addStats(a, e.testFileSummary.stats), emptyStats()),
-        duration: metadata.duration
+        duration: metadata.totalTime
       }
     };
     htmlReport.files.sort((f1, f2) => {

package/lib/reporters/internalReporter.js

@@ -10,6 +10,7 @@ var _babelBundle = require("../transform/babelBundle");
 var _test = require("../common/test");
 var _multiplexer = require("./multiplexer");
 var _base = require("./base");
+var _utils = require("playwright-core/lib/utils");
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 /**
  * Copyright (c) Microsoft Corporation.
@@ -32,12 +33,14 @@ class InternalReporter {
     this._multiplexer = void 0;
     this._deferred = [];
     this._config = void 0;
+    this._montonicStartTime = 0;
     this._multiplexer = new _multiplexer.Multiplexer(reporters);
   }
   onConfigure(config) {
     this._config = config;
   }
   onBegin(config, suite) {
+    this._montonicStartTime = (0, _utils.monotonicTime)();
     this._multiplexer.onBegin(config, suite);
     const deferred = this._deferred;
     this._deferred = null;
@@ -80,7 +83,9 @@ class InternalReporter {
     this._addSnippetToTestErrors(test, result);
     this._multiplexer.onTestEnd(test, result);
   }
-  async onEnd() {}
+  async onEnd() {
+    this._config.config.metadata.totalTime = (0, _utils.monotonicTime)() - this._montonicStartTime;
+  }
   async onExit(result) {
     if (this._deferred) {
       // onBegin was not reported, emit it.

package/lib/reporters/merge.js

@@ -28,6 +28,7 @@ function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { de
 
 async function createMergedReport(config, dir, reporterDescriptions, resolvePaths) {
   const shardFiles = await sortedShardFiles(dir);
+  if (shardFiles.length === 0) throw new Error(`No report files found in ${dir}`);
   const events = await mergeEvents(dir, shardFiles);
   if (resolvePaths) patchAttachmentPaths(events, dir);
   const reporters = await (0, _reporters.createReporters)(config, 'merge', reporterDescriptions);
@@ -69,7 +70,9 @@ function mergeBeginEvents(beginEvents) {
     configFile: undefined,
     globalTimeout: 0,
     maxFailures: 0,
-    metadata: {},
+    metadata: {
+      totalTime: 0
+    },
     rootDir: '',
     version: '',
     workers: 0,
@@ -97,7 +100,8 @@ function mergeConfigs(to, from) {
     ...from,
     metadata: {
       ...to.metadata,
-      ...from.metadata
+      ...from.metadata,
+      totalTime: to.metadata.totalTime + from.metadata.totalTime
     },
     workers: to.workers + from.workers
   };

package/lib/runner/dispatcher.js

@@ -88,7 +88,7 @@ class Dispatcher {
     this._checkFinished();
 
     // 5. We got a free worker - perhaps we can immediately start another job?
-    this._scheduleJob();
+    void this._scheduleJob();
   }
   async _startJobInWorker(index, job) {
     let worker = this._workerSlots[index].worker;
@@ -156,7 +156,7 @@ class Dispatcher {
       busy: false
     });
     // 2. Schedule enough jobs.
-    for (let i = 0; i < this._workerSlots.length; i++) this._scheduleJob();
+    for (let i = 0; i < this._workerSlots.length; i++) void this._scheduleJob();
     this._checkFinished();
     // 3. More jobs are scheduled when the worker becomes free, or a new job is added.
     // 4. Wait for all jobs to finish.
@@ -306,13 +306,13 @@ class Dispatcher {
       // - we are here not because something failed
       // - no unrecoverable worker error
       if (!remaining.length && !failedTestIds.size && !params.fatalErrors.length && !params.skipTestsDueToSetupFailure.length && !params.fatalUnknownTestIds && !params.unexpectedExitError) {
-        if (this._isWorkerRedundant(worker)) worker.stop();
+        if (this._isWorkerRedundant(worker)) void worker.stop();
         doneWithJob();
         return;
       }
 
       // When worker encounters error, we will stop it and create a new one.
-      worker.stop(true /* didFail */);
+      void worker.stop(true /* didFail */);
 
       const massSkipTestsFromRemaining = (testIds, errors, onlyStartedTests) => {
         remaining = remaining.filter(test => {
@@ -409,7 +409,7 @@ class Dispatcher {
         });
         this._queuedOrRunningHashCount.set(testGroup.workerHash, this._queuedOrRunningHashCount.get(testGroup.workerHash) + 1);
         // Perhaps we can immediately start the new job if there is a worker available?
-        this._scheduleJob();
+        void this._scheduleJob();
       }
 
       // This job is over, we just scheduled another one.

package/lib/runner/runner.js

@@ -93,12 +93,12 @@ class Runner {
     }));
     return await (0, _watchMode.runWatchModeLoop)(config);
   }
-  async uiAllTests() {
+  async uiAllTests(options) {
     const config = this._config;
     (0, _webServerPlugin.webServerPluginsForConfig)(config).forEach(p => config.plugins.push({
       factory: p
     }));
-    return await (0, _uiMode.runUIMode)(config);
+    return await (0, _uiMode.runUIMode)(config, options);
   }
 }
 exports.Runner = Runner;

package/lib/runner/uiMode.js

@@ -12,6 +12,7 @@ var _teleEmitter = require("../reporters/teleEmitter");
 var _reporters = require("./reporters");
 var _tasks = require("./tasks");
 var _utilsBundle = require("../utilsBundle");
+var _utilsBundle2 = require("playwright-core/lib/utilsBundle");
 var _list = _interopRequireDefault(require("../reporters/list"));
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 /**
@@ -33,7 +34,7 @@ function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { de
 class UIMode {
   constructor(config) {
     this._config = void 0;
-    this._page = void 0;
+    this._transport = void 0;
     this._testRun = void 0;
     this.globalCleanup = void 0;
     this._globalWatcher = void 0;
@@ -59,17 +60,12 @@ class UIMode {
     };
     this._originalStdoutWrite = process.stdout.write;
     this._originalStderrWrite = process.stderr.write;
-    this._globalWatcher = new Watcher('deep', () => this._dispatchEvent({
-      method: 'listChanged'
-    }));
+    this._globalWatcher = new Watcher('deep', () => this._dispatchEvent('listChanged', {}));
     this._testWatcher = new Watcher('flat', events => {
       const collector = new Set();
       events.forEach(f => (0, _compilationCache.collectAffectedTestFiles)(f.file, collector));
-      this._dispatchEvent({
-        method: 'testFilesChanged',
-        params: {
-          testFileNames: [...collector]
-        }
+      this._dispatchEvent('testFilesChanged', {
+        testFileNames: [...collector]
       });
     });
   }
@@ -92,61 +88,57 @@ class UIMode {
     this.globalCleanup = globalCleanup;
     return status;
   }
-  async showUI() {
-    this._page = await (0, _server.showTraceViewer)([], 'chromium', {
+  async showUI(options) {
+    const exitPromise = new _utils.ManualPromise();
+    let queue = Promise.resolve();
+    this._transport = {
+      dispatch: async (method, params) => {
+        if (method === 'exit') {
+          exitPromise.resolve();
+          return;
+        }
+        if (method === 'watch') {
+          this._watchFiles(params.fileNames);
+          return;
+        }
+        if (method === 'open' && params.location) {
+          (0, _utilsBundle2.open)('vscode://file/' + params.location).catch(e => this._originalStderrWrite.call(process.stderr, String(e)));
+          return;
+        }
+        if (method === 'resizeTerminal') {
+          process.stdout.columns = params.cols;
+          process.stdout.rows = params.rows;
+          process.stderr.columns = params.cols;
+          process.stderr.columns = params.rows;
+          return;
+        }
+        if (method === 'stop') {
+          void this._stopTests();
+          return;
+        }
+        queue = queue.then(() => this._queueListOrRun(method, params));
+        await queue;
+      },
+      onclose: () => exitPromise.resolve()
+    };
+    await (0, _server.showTraceViewer)([], 'chromium', {
       app: 'uiMode.html',
-      headless: (0, _utils.isUnderTest)() && process.env.PWTEST_HEADED_FOR_TEST !== '1'
+      headless: (0, _utils.isUnderTest)() && process.env.PWTEST_HEADED_FOR_TEST !== '1',
+      transport: this._transport,
+      host: options.host,
+      port: options.port,
+      openInBrowser: options.host !== undefined || options.port !== undefined
     });
     if (!process.env.PWTEST_DEBUG) {
       process.stdout.write = chunk => {
-        this._dispatchEvent({
-          method: 'stdio',
-          params: chunkToPayload('stdout', chunk)
-        });
+        this._dispatchEvent('stdio', chunkToPayload('stdout', chunk));
         return true;
       };
       process.stderr.write = chunk => {
-        this._dispatchEvent({
-          method: 'stdio',
-          params: chunkToPayload('stderr', chunk)
-        });
+        this._dispatchEvent('stdio', chunkToPayload('stderr', chunk));
         return true;
       };
     }
-    const exitPromise = new _utils.ManualPromise();
-    this._page.on('close', () => exitPromise.resolve());
-    let queue = Promise.resolve();
-    this._page.exposeBinding('sendMessage', false, async (source, data) => {
-      const {
-        method,
-        params
-      } = data;
-      if (method === 'exit') {
-        exitPromise.resolve();
-        return;
-      }
-      if (method === 'watch') {
-        this._watchFiles(params.fileNames);
-        return;
-      }
-      if (method === 'open' && params.location) {
-        (0, _utilsBundle.open)('vscode://file/' + params.location).catch(e => this._originalStderrWrite.call(process.stderr, String(e)));
-        return;
-      }
-      if (method === 'resizeTerminal') {
-        process.stdout.columns = params.cols;
-        process.stdout.rows = params.rows;
-        process.stderr.columns = params.cols;
-        process.stderr.columns = params.rows;
-        return;
-      }
-      if (method === 'stop') {
-        this._stopTests();
-        return;
-      }
-      queue = queue.then(() => this._queueListOrRun(method, params));
-      await queue;
-    });
     await exitPromise;
     if (!process.env.PWTEST_DEBUG) {
       process.stdout.write = this._originalStdoutWrite;
@@ -157,14 +149,12 @@ class UIMode {
     if (method === 'list') await this._listTests();
     if (method === 'run') await this._runTests(params.testIds);
   }
-  _dispatchEvent(message) {
-    // eslint-disable-next-line no-console
-    this._page.mainFrame().evaluateExpression(dispatchFuncSource, {
-      isFunction: true
-    }, message).catch(e => this._originalStderrWrite.call(process.stderr, String(e)));
+  _dispatchEvent(method, params) {
+    var _this$_transport$send, _this$_transport;
+    (_this$_transport$send = (_this$_transport = this._transport).sendEvent) === null || _this$_transport$send === void 0 ? void 0 : _this$_transport$send.call(_this$_transport, method, params);
   }
   async _listTests() {
-    const listReporter = new _teleEmitter.TeleReporterEmitter(e => this._dispatchEvent(e));
+    const listReporter = new _teleEmitter.TeleReporterEmitter(e => this._dispatchEvent(e.method, e.params));
     const reporter = new _internalReporter.InternalReporter([listReporter]);
     this._config.cliListOnly = true;
     this._config.testIdMatcher = undefined;
@@ -188,7 +178,7 @@ class UIMode {
     this._config.cliListOnly = false;
     this._config.testIdMatcher = id => !testIdSet || testIdSet.has(id);
     const reporters = await (0, _reporters.createReporters)(this._config, 'ui');
-    reporters.push(new _teleEmitter.TeleReporterEmitter(e => this._dispatchEvent(e)));
+    reporters.push(new _teleEmitter.TeleReporterEmitter(e => this._dispatchEvent(e.method, e.params)));
     const reporter = new _internalReporter.InternalReporter(reporters);
     const taskRunner = (0, _tasks.createTaskRunnerForWatch)(this._config, reporter);
     const testRun = new _tasks.TestRun(this._config, reporter);
@@ -209,7 +199,7 @@ class UIMode {
     };
     await run;
   }
-  async _watchFiles(fileNames) {
+  _watchFiles(fileNames) {
     const files = new Set();
     for (const fileName of fileNames) {
       files.add(fileName);
@@ -223,15 +213,12 @@ class UIMode {
     await ((_this$_testRun2 = this._testRun) === null || _this$_testRun2 === void 0 ? void 0 : _this$_testRun2.run);
   }
 }
-const dispatchFuncSource = String(message => {
-  window.dispatch(message);
-});
-async function runUIMode(config) {
+async function runUIMode(config, options) {
   var _uiMode$globalCleanup;
   const uiMode = new UIMode(config);
   const status = await uiMode.runGlobalSetup();
   if (status !== 'passed') return status;
-  await uiMode.showUI();
+  await uiMode.showUI(options);
   return (await ((_uiMode$globalCleanup = uiMode.globalCleanup) === null || _uiMode$globalCleanup === void 0 ? void 0 : _uiMode$globalCleanup.call(uiMode))) || 'passed';
 }
 function chunkToPayload(type, chunk) {
@@ -260,7 +247,7 @@ class Watcher {
     if (JSON.stringify(this._watchedFiles) === JSON.stringify(watchedFiles)) return;
     if (reportPending) this._reportEventsIfAny();
     this._watchedFiles = watchedFiles;
-    (_this$_fsWatcher = this._fsWatcher) === null || _this$_fsWatcher === void 0 ? void 0 : _this$_fsWatcher.close().then(() => {});
+    void ((_this$_fsWatcher = this._fsWatcher) === null || _this$_fsWatcher === void 0 ? void 0 : _this$_fsWatcher.close());
     this._fsWatcher = undefined;
     this._collector.length = 0;
     clearTimeout(this._throttleTimer);

package/lib/util.js

@@ -296,13 +296,30 @@ function envWithoutExperimentalLoaderOptions() {
 // https://devblogs.microsoft.com/typescript/announcing-typescript-5-0-beta/#moduleresolution-bundler
 const kExtLookups = new Map([['.js', ['.jsx', '.ts', '.tsx']], ['.jsx', ['.tsx']], ['.cjs', ['.cts']], ['.mjs', ['.mts']], ['', ['.js', '.ts', '.jsx', '.tsx', '.cjs', '.mjs', '.cts', '.mts']]]);
 function resolveImportSpecifierExtension(resolved) {
-  if (_fs.default.existsSync(resolved)) return resolved;
+  if (fileExists(resolved)) return resolved;
   for (const [ext, others] of kExtLookups) {
     if (!resolved.endsWith(ext)) continue;
     for (const other of others) {
       const modified = resolved.substring(0, resolved.length - ext.length) + other;
-      if (_fs.default.existsSync(modified)) return modified;
+      if (fileExists(modified)) return modified;
     }
     break; // Do not try '' when a more specific extesion like '.jsx' matched.
   }
+  // try directory imports last
+  if (dirExists(resolved)) {
+    const dirImport = _path.default.join(resolved, 'index');
+    return resolveImportSpecifierExtension(dirImport);
+  }
+}
+function fileExists(resolved) {
+  var _fs$statSync;
+  return (_fs$statSync = _fs.default.statSync(resolved, {
+    throwIfNoEntry: false
+  })) === null || _fs$statSync === void 0 ? void 0 : _fs$statSync.isFile();
+}
+function dirExists(resolved) {
+  var _fs$statSync2;
+  return (_fs$statSync2 = _fs.default.statSync(resolved, {
+    throwIfNoEntry: false
+  })) === null || _fs$statSync2 === void 0 ? void 0 : _fs$statSync2.isDirectory();
 }