@playwright/test 1.35.0-alpha-jun-5-2023 → 1.35.0-alpha-jun-6-2023

package/.eslintrc.js

@@ -1,3 +1,15 @@
+const path = require('path');
+
 module.exports = {
-  extends: "../.eslintrc-with-ts-config.js",
+  extends: '../.eslintrc.js',
+  parser: "@typescript-eslint/parser",
+  plugins: ["@typescript-eslint", "notice"],
+  parserOptions: {
+    ecmaVersion: 9,
+    sourceType: "module",
+    project: path.join(__dirname, '..', '..', 'tsconfig.json'),
+  },
+  rules: {
+    '@typescript-eslint/no-floating-promises': 'error',
+  },
 };

package/ThirdPartyNotices.txt

@@ -99,7 +99,6 @@ This project incorporates components from the projects listed below. The origina
 -	color-name@1.1.4 (https://github.com/colorjs/color-name)
 -	convert-source-map@1.8.0 (https://github.com/thlorenz/convert-source-map)
 -	debug@4.3.4 (https://github.com/debug-js/debug)
--	define-lazy-prop@2.0.0 (https://github.com/sindresorhus/define-lazy-prop)
 -	diff-sequences@27.5.1 (https://github.com/facebook/jest)
 -	electron-to-chromium@1.4.337 (https://github.com/kilian/electron-to-chromium)
 -	enquirer@2.3.6 (https://github.com/enquirer/enquirer)
@@ -115,11 +114,9 @@ This project incorporates components from the projects listed below. The origina
 -	has-flag@3.0.0 (https://github.com/sindresorhus/has-flag)
 -	has-flag@4.0.0 (https://github.com/sindresorhus/has-flag)
 -	is-binary-path@2.1.0 (https://github.com/sindresorhus/is-binary-path)
--	is-docker@2.2.1 (https://github.com/sindresorhus/is-docker)
 -	is-extglob@2.1.1 (https://github.com/jonschlinkert/is-extglob)
 -	is-glob@4.0.3 (https://github.com/micromatch/is-glob)
 -	is-number@7.0.0 (https://github.com/jonschlinkert/is-number)
--	is-wsl@2.2.0 (https://github.com/sindresorhus/is-wsl)
 -	jest-diff@27.5.1 (https://github.com/facebook/jest)
 -	jest-get-type@27.5.1 (https://github.com/facebook/jest)
 -	jest-matcher-utils@27.2.5 (https://github.com/facebook/jest)
@@ -133,7 +130,6 @@ This project incorporates components from the projects listed below. The origina
 -	ms@2.1.2 (https://github.com/zeit/ms)
 -	node-releases@2.0.10 (https://github.com/chicoxyzzy/node-releases)
 -	normalize-path@3.0.0 (https://github.com/jonschlinkert/normalize-path)
--	open@8.4.0 (https://github.com/sindresorhus/open)
 -	picocolors@1.0.0 (https://github.com/alexeyraspopov/picocolors)
 -	picomatch@2.3.1 (https://github.com/micromatch/picomatch)
 -	pirates@4.0.4 (https://github.com/danez/pirates)
@@ -3105,20 +3101,6 @@ SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 =========================================
 END OF debug@4.3.4 AND INFORMATION
 
-%% define-lazy-prop@2.0.0 NOTICES AND INFORMATION BEGIN HERE
-=========================================
-MIT License
-
-Copyright (c) Sindre Sorhus <sindresorhus@gmail.com> (sindresorhus.com)
-
-Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-=========================================
-END OF define-lazy-prop@2.0.0 AND INFORMATION
-
 %% diff-sequences@27.5.1 NOTICES AND INFORMATION BEGIN HERE
 =========================================
 MIT License
@@ -3395,20 +3377,6 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
 =========================================
 END OF is-binary-path@2.1.0 AND INFORMATION
 
-%% is-docker@2.2.1 NOTICES AND INFORMATION BEGIN HERE
-=========================================
-MIT License
-
-Copyright (c) Sindre Sorhus <sindresorhus@gmail.com> (https://sindresorhus.com)
-
-Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-=========================================
-END OF is-docker@2.2.1 AND INFORMATION
-
 %% is-extglob@2.1.1 NOTICES AND INFORMATION BEGIN HERE
 =========================================
 The MIT License (MIT)
@@ -3487,20 +3455,6 @@ THE SOFTWARE.
 =========================================
 END OF is-number@7.0.0 AND INFORMATION
 
-%% is-wsl@2.2.0 NOTICES AND INFORMATION BEGIN HERE
-=========================================
-MIT License
-
-Copyright (c) Sindre Sorhus <sindresorhus@gmail.com> (sindresorhus.com)
-
-Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-=========================================
-END OF is-wsl@2.2.0 AND INFORMATION
-
 %% jest-diff@27.5.1 NOTICES AND INFORMATION BEGIN HERE
 =========================================
 MIT License
@@ -3834,20 +3788,6 @@ THE SOFTWARE.
 =========================================
 END OF normalize-path@3.0.0 AND INFORMATION
 
-%% open@8.4.0 NOTICES AND INFORMATION BEGIN HERE
-=========================================
-MIT License
-
-Copyright (c) Sindre Sorhus <sindresorhus@gmail.com> (https://sindresorhus.com)
-
-Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-=========================================
-END OF open@8.4.0 AND INFORMATION
-
 %% picocolors@1.0.0 NOTICES AND INFORMATION BEGIN HERE
 =========================================
 ISC License
@@ -4284,6 +4224,6 @@ END OF yallist@3.1.1 AND INFORMATION
 
 SUMMARY BEGIN HERE
 =========================================
-Total Packages: 149
+Total Packages: 145
 =========================================
 END OF SUMMARY

package/lib/common/process.js

@@ -57,7 +57,7 @@ process.on('message', async message => {
     } = message.params;
     setTtyParams(process.stdout, processParams.stdoutParams);
     setTtyParams(process.stderr, processParams.stderrParams);
-    (0, _utils.startProfiling)();
+    void (0, _utils.startProfiling)();
     const {
       create
     } = require(runnerScript);

package/lib/index.js

@@ -95,12 +95,12 @@ const playwrightFixtures = {
     scope: 'worker',
     option: true
   }],
-  connectOptions: [({}, use) => {
+  connectOptions: [async ({}, use) => {
     // Usually, when connect options are specified (e.g, in the config or in the environment),
     // all launch() calls are turned into connect() calls.
     // However, when running in "reuse browser" mode and connecting to the reusable server,
     // only the default "browser" fixture should turn into reused browser.
-    use(process.env.PW_TEST_REUSE_CONTEXT ? undefined : connectOptionsFromEnv());
+    await use(process.env.PW_TEST_REUSE_CONTEXT ? undefined : connectOptionsFromEnv());
   }, {
     scope: 'worker',
     option: true

package/lib/matchers/toMatchSnapshot.js

@@ -149,6 +149,11 @@ class SnapshotHelper {
     if (isWriteMissingMode) {
       writeFileSync(this.snapshotPath, actual);
       writeFileSync(this.actualPath, actual);
+      this.testInfo.attachments.push({
+        name: (0, _util.addSuffixToFilePath)(this.snapshotName, '-actual'),
+        contentType: this.mimeType,
+        path: this.actualPath
+      });
     }
     const message = `A snapshot doesn't exist at ${this.snapshotPath}${isWriteMissingMode ? ', writing actual.' : '.'}`;
     if (this.updateSnapshots === 'all') {

package/lib/reporters/github.js

@@ -52,7 +52,7 @@ class GitHubReporter extends _base.BaseReporter {
     return false;
   }
   async onEnd(result) {
-    super.onEnd(result);
+    await super.onEnd(result);
     this._printAnnotations();
   }
   onError(error) {

package/lib/reporters/html.js

@@ -8,7 +8,6 @@ exports.showHTMLReport = showHTMLReport;
 exports.startHtmlReportServer = startHtmlReportServer;
 var _utilsBundle = require("playwright-core/lib/utilsBundle");
 var _fs = _interopRequireDefault(require("fs"));
-var _utilsBundle2 = require("../utilsBundle");
 var _path = _interopRequireDefault(require("path"));
 var _stream = require("stream");
 var _utils = require("playwright-core/lib/utils");
@@ -153,7 +152,7 @@ async function showHTMLReport(reportFolder, host = 'localhost', port, testId) {
   console.log('');
   console.log(_utilsBundle.colors.cyan(`  Serving HTML report at ${url}. Press Ctrl+C to quit.`));
   if (testId) url += `#?testId=${testId}`;
-  await (0, _utilsBundle2.open)(url, {
+  await (0, _utilsBundle.open)(url, {
     wait: true
   }).catch(() => console.log(`Failed to open browser on ${url}`));
   await new Promise(() => {});

package/lib/reporters/merge.js

@@ -28,6 +28,7 @@ function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { de
 
 async function createMergedReport(config, dir, reporterDescriptions, resolvePaths) {
   const shardFiles = await sortedShardFiles(dir);
+  if (shardFiles.length === 0) throw new Error(`No report files found in ${dir}`);
   const events = await mergeEvents(dir, shardFiles);
   if (resolvePaths) patchAttachmentPaths(events, dir);
   const reporters = await (0, _reporters.createReporters)(config, 'merge', reporterDescriptions);

package/lib/runner/dispatcher.js

@@ -88,7 +88,7 @@ class Dispatcher {
     this._checkFinished();
 
     // 5. We got a free worker - perhaps we can immediately start another job?
-    this._scheduleJob();
+    void this._scheduleJob();
   }
   async _startJobInWorker(index, job) {
     let worker = this._workerSlots[index].worker;
@@ -156,7 +156,7 @@ class Dispatcher {
       busy: false
     });
     // 2. Schedule enough jobs.
-    for (let i = 0; i < this._workerSlots.length; i++) this._scheduleJob();
+    for (let i = 0; i < this._workerSlots.length; i++) void this._scheduleJob();
     this._checkFinished();
     // 3. More jobs are scheduled when the worker becomes free, or a new job is added.
     // 4. Wait for all jobs to finish.
@@ -306,13 +306,13 @@ class Dispatcher {
       // - we are here not because something failed
       // - no unrecoverable worker error
       if (!remaining.length && !failedTestIds.size && !params.fatalErrors.length && !params.skipTestsDueToSetupFailure.length && !params.fatalUnknownTestIds && !params.unexpectedExitError) {
-        if (this._isWorkerRedundant(worker)) worker.stop();
+        if (this._isWorkerRedundant(worker)) void worker.stop();
         doneWithJob();
         return;
       }
 
       // When worker encounters error, we will stop it and create a new one.
-      worker.stop(true /* didFail */);
+      void worker.stop(true /* didFail */);
 
       const massSkipTestsFromRemaining = (testIds, errors, onlyStartedTests) => {
         remaining = remaining.filter(test => {
@@ -409,7 +409,7 @@ class Dispatcher {
         });
         this._queuedOrRunningHashCount.set(testGroup.workerHash, this._queuedOrRunningHashCount.get(testGroup.workerHash) + 1);
         // Perhaps we can immediately start the new job if there is a worker available?
-        this._scheduleJob();
+        void this._scheduleJob();
       }
 
       // This job is over, we just scheduled another one.

package/lib/runner/uiMode.js

@@ -12,6 +12,7 @@ var _teleEmitter = require("../reporters/teleEmitter");
 var _reporters = require("./reporters");
 var _tasks = require("./tasks");
 var _utilsBundle = require("../utilsBundle");
+var _utilsBundle2 = require("playwright-core/lib/utilsBundle");
 var _list = _interopRequireDefault(require("../reporters/list"));
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 /**
@@ -93,7 +94,7 @@ class UIMode {
     return status;
   }
   async showUI() {
-    this._page = await (0, _server.showTraceViewer)([], 'chromium', {
+    this._page = await (0, _server.openTraceViewerApp)([], 'chromium', {
       app: 'uiMode.html',
       headless: (0, _utils.isUnderTest)() && process.env.PWTEST_HEADED_FOR_TEST !== '1'
     });
@@ -116,7 +117,7 @@ class UIMode {
     const exitPromise = new _utils.ManualPromise();
     this._page.on('close', () => exitPromise.resolve());
     let queue = Promise.resolve();
-    this._page.exposeBinding('sendMessage', false, async (source, data) => {
+    await this._page.exposeBinding('sendMessage', false, async (source, data) => {
       const {
         method,
         params
@@ -130,7 +131,7 @@ class UIMode {
         return;
       }
       if (method === 'open' && params.location) {
-        (0, _utilsBundle.open)('vscode://file/' + params.location).catch(e => this._originalStderrWrite.call(process.stderr, String(e)));
+        (0, _utilsBundle2.open)('vscode://file/' + params.location).catch(e => this._originalStderrWrite.call(process.stderr, String(e)));
         return;
       }
       if (method === 'resizeTerminal') {
@@ -141,7 +142,7 @@ class UIMode {
         return;
       }
       if (method === 'stop') {
-        this._stopTests();
+        void this._stopTests();
         return;
       }
       queue = queue.then(() => this._queueListOrRun(method, params));
@@ -209,7 +210,7 @@ class UIMode {
     };
     await run;
   }
-  async _watchFiles(fileNames) {
+  _watchFiles(fileNames) {
     const files = new Set();
     for (const fileName of fileNames) {
       files.add(fileName);
@@ -260,7 +261,7 @@ class Watcher {
     if (JSON.stringify(this._watchedFiles) === JSON.stringify(watchedFiles)) return;
     if (reportPending) this._reportEventsIfAny();
     this._watchedFiles = watchedFiles;
-    (_this$_fsWatcher = this._fsWatcher) === null || _this$_fsWatcher === void 0 ? void 0 : _this$_fsWatcher.close().then(() => {});
+    void ((_this$_fsWatcher = this._fsWatcher) === null || _this$_fsWatcher === void 0 ? void 0 : _this$_fsWatcher.close());
     this._fsWatcher = undefined;
     this._collector.length = 0;
     clearTimeout(this._throttleTimer);

package/lib/util.js

@@ -296,13 +296,30 @@ function envWithoutExperimentalLoaderOptions() {
 // https://devblogs.microsoft.com/typescript/announcing-typescript-5-0-beta/#moduleresolution-bundler
 const kExtLookups = new Map([['.js', ['.jsx', '.ts', '.tsx']], ['.jsx', ['.tsx']], ['.cjs', ['.cts']], ['.mjs', ['.mts']], ['', ['.js', '.ts', '.jsx', '.tsx', '.cjs', '.mjs', '.cts', '.mts']]]);
 function resolveImportSpecifierExtension(resolved) {
-  if (_fs.default.existsSync(resolved)) return resolved;
+  if (fileExists(resolved)) return resolved;
   for (const [ext, others] of kExtLookups) {
     if (!resolved.endsWith(ext)) continue;
     for (const other of others) {
       const modified = resolved.substring(0, resolved.length - ext.length) + other;
-      if (_fs.default.existsSync(modified)) return modified;
+      if (fileExists(modified)) return modified;
     }
     break; // Do not try '' when a more specific extesion like '.jsx' matched.
   }
+  // try directory imports last
+  if (dirExists(resolved)) {
+    const dirImport = _path.default.join(resolved, 'index');
+    return resolveImportSpecifierExtension(dirImport);
+  }
+}
+function fileExists(resolved) {
+  var _fs$statSync;
+  return (_fs$statSync = _fs.default.statSync(resolved, {
+    throwIfNoEntry: false
+  })) === null || _fs$statSync === void 0 ? void 0 : _fs$statSync.isFile();
+}
+function dirExists(resolved) {
+  var _fs$statSync2;
+  return (_fs$statSync2 = _fs.default.statSync(resolved, {
+    throwIfNoEntry: false
+  })) === null || _fs$statSync2 === void 0 ? void 0 : _fs$statSync2.isDirectory();
 }

package/lib/utilsBundle.js

@@ -3,7 +3,7 @@
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
-exports.stoppable = exports.sourceMapSupport = exports.pirates = exports.open = exports.json5 = exports.enquirer = exports.chokidar = void 0;
+exports.stoppable = exports.sourceMapSupport = exports.pirates = exports.json5 = exports.enquirer = exports.chokidar = void 0;
 /**
  * Copyright (c) Microsoft Corporation.
  *
@@ -22,8 +22,6 @@ exports.stoppable = exports.sourceMapSupport = exports.pirates = exports.open =
 
 const json5 = require('./utilsBundleImpl').json5;
 exports.json5 = json5;
-const open = require('./utilsBundleImpl').open;
-exports.open = open;
 const pirates = require('./utilsBundleImpl').pirates;
 exports.pirates = pirates;
 const sourceMapSupport = require('./utilsBundleImpl').sourceMapSupport;