@playpilot/tpi 6.4.2 → 6.4.4

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@playpilot/tpi",
-	"version": "6.4.2",
+	"version": "6.4.4",
 	"type": "module",
 	"scripts": {
 		"dev": "vite dev",

package/src/lib/api/externalPages.ts

@@ -29,7 +29,6 @@ export async function fetchLinkInjections(
   // We use separate requests when running the AI or setting the editor session vs when only getting the results.
   // For regular requests we use a GET endpoint, but when saving data we POST to the same url.
   if (Object.entries(params).length) {
-    // Additional params are added when re-running AI. These are necessary for the API
     if (params.run_ai) {
       params.hash = hash
       params.page_text = pageText

package/src/lib/enums/SplitTest.ts

@@ -4,9 +4,4 @@ export const SplitTest = {
     numberOfVariants: 2,
     variantNames: ['Separated', 'Inline'] as string[],
   },
-  PostersScrollReveal: {
-    key: 'posters_scroll_reveal',
-    numberOfVariants: 2,
-    variantNames: ['Default', 'With Posters'] as string[],
-  },
 } as const

package/src/lib/genre.ts

@@ -0,0 +1,7 @@
+import genres from '$lib/data/genres.json'
+
+export function genreSlugsToNames(slugs: string[] = []): string[] {
+  return slugs.map((slug) => {
+    return genres.find((genre) => genre.slug === slug)?.name || ''
+  }).filter(Boolean)
+}

package/src/lib/tracking.ts

@@ -1,6 +1,7 @@
 import { hasConsentedTo } from './consent'
 import { mobileBreakpoint } from './constants'
 import { isCrawler } from './crawler'
+import { genreSlugsToNames } from './genre'
 import type { TitleData } from './types/title'
 import { getFullUrlPath } from './url'
 
@@ -29,6 +30,7 @@ export async function track(event: string, title: TitleData | null = null, paylo
       title: title.title,
       title_sid: title.sid,
       title_type: title.type,
+      genres: genreSlugsToNames(title.genres),
       providers: [...new Set(title.providers?.map(p => p.name) || [])],
       ...payload,
     }

package/src/routes/+page.svelte

@@ -234,7 +234,6 @@
 
 {#key linkInjections}
   <UserJourney />
-  <PostersScrollReveal />
 {/key}
 
 <Consent onchange={afterConsent} />

package/src/routes/components/PostersScrollReveal.svelte

@@ -1,7 +1,5 @@
 <script lang="ts">
   import { mobileBreakpoint } from '$lib/constants'
-  import { SplitTest } from '$lib/enums/SplitTest'
-  import { isInSplitTestVariant, trackSplitTestAction, trackSplitTestView } from '$lib/splitTest'
   import { onMount } from 'svelte'
 
   const linksWithPosters = Array.from(document.querySelectorAll<HTMLElement>('[data-playpilot-poster-url]'))
@@ -18,27 +16,11 @@
   onMount(() => {
     if (!isMobile) return
 
-    trackSplitTestView(SplitTest.PostersScrollReveal)
-
     return destroyAllPosters
   })
 
-  $effect(() => {
-    if (!isMobile) return
-    if (!linksWithPosters.length) return
-
-    const onclick = () => trackSplitTestAction(SplitTest.PostersScrollReveal, 'click')
-
-    for(const link of linksWithPosters) link.addEventListener('click', onclick)
-
-    return () => {
-      for(const link of linksWithPosters) link.removeEventListener('click', onclick)
-    }
-  })
-
   function onscroll(): void {
     if (!isMobile) return
-    if (!isInSplitTestVariant(SplitTest.PostersScrollReveal)) return
 
     setScrollTimeout()
 

package/src/tests/lib/genre.test.js

@@ -0,0 +1,23 @@
+import { describe, expect, it } from 'vitest'
+
+import { genreSlugsToNames } from '$lib/genre'
+
+describe('genres.ts', () => {
+  describe('genreSlugsToNames', () => {
+    it('Should return genre names for given slugs', () => {
+      expect(genreSlugsToNames(['101', '103'])).toEqual(['Action', 'Kids'])
+    })
+
+    it('Should exclude slugs that were not found', () => {
+      expect(genreSlugsToNames(['101', 'not-found'])).toEqual(['Action'])
+    })
+
+    it('Should return an empty array if no slugs were found', () => {
+      expect(genreSlugsToNames(['not-found'])).toEqual([])
+    })
+
+    it('Should return an empty array when no slugs were given', () => {
+      expect(genreSlugsToNames([])).toEqual([])
+    })
+  })
+})

package/src/tests/lib/tracking.test.js

@@ -121,7 +121,7 @@ describe('$lib/tracking', () => {
       expect(global.fetch).toHaveBeenCalledWith(
         expect.any(String),
         expect.objectContaining({
-          body: expect.stringContaining(`"original_title":"${title.original_title}","title":"${title.title}","title_sid":"${title.sid}","title_type":"${title.type}"`),
+          body: expect.stringContaining(`"original_title":"${title.original_title}","title":"${title.title}","title_sid":"${title.sid}","title_type":"${title.type}","genres":["Action","Adventure","Sci-Fi","Drama"]`),
         }),
       )
     })

package/src/tests/routes/components/PostersScrollReveal.test.js

@@ -1,14 +1,7 @@
-import { fireEvent, render } from '@testing-library/svelte'
+import { render } from '@testing-library/svelte'
 import { describe, it, expect, vi, beforeEach } from 'vitest'
 import PostersScrollReveal from '../../../routes/components/PostersScrollReveal.svelte'
 import { mobileBreakpoint } from '$lib/constants'
-import { isInSplitTestVariant, trackSplitTestAction } from '$lib/splitTest'
-
-vi.mock('$lib/splitTest', () => ({
-  trackSplitTestView: vi.fn(),
-  trackSplitTestAction: vi.fn(),
-  isInSplitTestVariant: vi.fn(() => true),
-}))
 
 function createPosterLink(top = 0, url = 'poster.jpg') {
   const link = document.createElement('a')
@@ -37,8 +30,6 @@ describe('FloatingPoster', () => {
 
     vi.useFakeTimers()
     vi.resetAllMocks()
-
-    vi.mocked(isInSplitTestVariant).mockReturnValue(true)
   })
 
   it('Should create poster when link is in viewport', async () => {
@@ -147,16 +138,4 @@ describe('FloatingPoster', () => {
     window.dispatchEvent(new Event('scroll'))
     expect(document.querySelector('[data-playpilot-poster]')).toBeTruthy()
   })
-
-  it('Should fire split test tracking on click', async () => {
-    createPosterLink(500)
-
-    render(PostersScrollReveal)
-
-    window.dispatchEvent(new Event('scroll'))
-
-    await fireEvent.click(/** @type {HTMLElement} */ (document.querySelector('[data-playpilot-poster]')))
-
-    expect(trackSplitTestAction).toHaveBeenCalled()
-  })
 })