@player-ui/player 0.10.1 → 0.10.2-next.0

package/package.json

@@ -6,12 +6,12 @@
     "types"
   ],
   "name": "@player-ui/player",
-  "version": "0.10.1",
+  "version": "0.10.2-next.0",
   "main": "dist/cjs/index.cjs",
   "dependencies": {
-    "@player-ui/partial-match-registry": "0.10.1",
-    "@player-ui/make-flow": "0.10.1",
-    "@player-ui/types": "0.10.1",
+    "@player-ui/partial-match-registry": "0.10.2-next.0",
+    "@player-ui/make-flow": "0.10.2-next.0",
+    "@player-ui/types": "0.10.2-next.0",
     "@types/dlv": "^1.1.4",
     "dequal": "^2.0.2",
     "dlv": "^1.1.3",

package/src/binding/__tests__/binding.test.ts

@@ -111,3 +111,13 @@ describe("descendent binding", () => {
     ]);
   });
 });
+
+describe("Edge cases", () => {
+  it("Bindings with escaped numbers", () => {
+    expect(new BindingInstance("foo.01.bar").asArray()).toStrictEqual([
+      "foo",
+      "01",
+      "bar",
+    ]);
+  });
+});

package/src/binding/__tests__/parser.bench.ts

@@ -1,6 +1,6 @@
 import { bench, describe } from "vitest";
 import get from "dlv";
-import { getBindingSegments } from "..";
+import { BindingInstance, getBindingSegments } from "..";
 import { testCases, testModel } from "./resolver.test";
 import { parseCustom, ParserSuccessResult } from "../../binding-grammar";
 import { resolveBindingAST } from "../resolver";
@@ -20,3 +20,23 @@ describe("parser benchmarks", () => {
     { iterations: 10000 },
   );
 });
+
+describe("binding creation benchmarks", () => {
+  testCases.map(
+    ([input, expectedOutput]) => {
+      bench(`Resolving binding: ${input}`, () => {
+        const parsedBinding = parseCustom(input);
+        const result = resolveBindingAST(
+          (parsedBinding as ParserSuccessResult).path,
+          {
+            getValue: (path) => get(testModel, getBindingSegments(path) as any),
+            convertToPath: (p) => p,
+            evaluate: () => undefined,
+          },
+        );
+        const bi = new BindingInstance(result.path);
+      });
+    },
+    { iterations: 10000 },
+  );
+});

package/src/binding/binding.ts

@@ -53,7 +53,9 @@ export class BindingInstance {
       }
 
       const tryNum = Number(segment);
-      return isNaN(tryNum) ? segment : tryNum;
+      // test to make sure turning a numerical string to a number doesn't change
+      // the actual value of the string by getting rid of a leading zero
+      return isNaN(tryNum) || String(tryNum) !== segment ? segment : tryNum;
     });
     Object.freeze(this.split);
     this.joined = this.split.join(".");