@playcademy/sandbox 0.10.1-beta.1 → 0.10.1-beta.3

package/dist/cli.js

@@ -1128,7 +1128,7 @@ var package_default;
 var init_package = __esm(() => {
   package_default = {
     name: "@playcademy/sandbox",
-    version: "0.10.1-beta.1",
+    version: "0.10.1-beta.3",
     description: "Local development server for Playcademy game development",
     type: "module",
     exports: {
@@ -11002,6 +11002,35 @@ function scorePlatformAssessmentItem(item, responses) {
     isCorrect: verdicts.length > 0 && verdicts.every(Boolean)
   };
 }
+function reviewStandardRef({
+  framework,
+  identifier
+}) {
+  return { framework, identifier };
+}
+function reportReviewRequiredPairUnavailable(review, administeredItemIdentifiers2, report) {
+  const administered = new Set(administeredItemIdentifiers2);
+  const failures = [];
+  for (const standard of review.standards.filter((entry) => entry.requireBothQuestions)) {
+    const key = assessmentStandardRefKey(standard);
+    const selected = new Set(review.selections.filter((selection) => assessmentStandardRefKey(selection.standard) === key).map((selection) => selection.itemIdentifier));
+    const administeredCount = [...selected].filter((identifier) => administered.has(identifier)).length;
+    if (selected.size < 2 || administeredCount === 1) {
+      failures.push({
+        standard: reviewStandardRef(standard),
+        reason: selected.size < 2 ? "selection_shortage" : "not_administered",
+        requiredCount: 2,
+        selectedCount: selected.size,
+        administeredCount
+      });
+    }
+  }
+  if (failures.length > 0) {
+    try {
+      report({ code: "REVIEW_REQUIRED_PAIR_UNAVAILABLE", failures });
+    } catch {}
+  }
+}
 function reviewStandardFieldsWithinLimits(input) {
   return input.framework.trim().length <= TIMEBACK_ASSESSMENT_REVIEW_REQUEST_LIMITS.standardFieldLength && input.identifier.trim().length <= TIMEBACK_ASSESSMENT_REVIEW_REQUEST_LIMITS.standardFieldLength;
 }
@@ -11031,6 +11060,9 @@ function canonicalRequestStandards(standards) {
   }
   const canonical = new Map;
   for (const input of standards) {
+    if (input.requireBothQuestions !== undefined && typeof input.requireBothQuestions !== "boolean") {
+      throw new Error("review standard requireBothQuestions must be a boolean");
+    }
     const standard = canonicalAssessmentStandardRef(input);
     if (!reviewStandardFieldsWithinLimits(standard)) {
       throw new RangeError(`Review standard fields may contain at most ${TIMEBACK_ASSESSMENT_REVIEW_REQUEST_LIMITS.standardFieldLength} characters`);
@@ -11039,13 +11071,19 @@ function canonicalRequestStandards(standards) {
       throw new Error("Review standards require a framework and identifier");
     }
     const key = assessmentStandardRefKey(standard);
-    if (!canonical.has(key)) {
-      canonical.set(key, standard);
+    if (!canonical.has(key) || input.requireBothQuestions) {
+      canonical.set(key, {
+        ...standard,
+        ...input.requireBothQuestions ? { requireBothQuestions: true } : {}
+      });
     }
   }
-  return [...canonical.values()].toSorted((left, right) => compareCodeUnits(assessmentStandardRefKey(left), assessmentStandardRefKey(right)));
+  return [...canonical.values()];
 }
 function normalizeReviewRequest(request) {
+  if ("requireBothQuestions" in request && request.requireBothQuestions !== undefined) {
+    throw new Error("Set requireBothQuestions on individual review standards, not the review request");
+  }
   const candidateItemsPerStandard = request.candidateItemsPerStandard ?? 1;
   if (!Number.isInteger(candidateItemsPerStandard) || candidateItemsPerStandard <= 0 || candidateItemsPerStandard > TIMEBACK_ASSESSMENT_REVIEW_REQUEST_LIMITS.candidateItemsPerStandard) {
     throw new RangeError(`candidateItemsPerStandard must be a positive integer at most ${TIMEBACK_ASSESSMENT_REVIEW_REQUEST_LIMITS.candidateItemsPerStandard}`);
@@ -11054,17 +11092,22 @@ function normalizeReviewRequest(request) {
   if (standards.length === 0) {
     throw new Error("At least one review standard is required");
   }
-  return { standards, candidateItemsPerStandard };
+  return {
+    standards,
+    candidateItemsPerStandard
+  };
 }
 function reviewRequestFingerprint(request, policy) {
   const normalized = normalizeReviewRequest(request);
+  const requiredStandardKeys = normalized.standards.filter((standard) => standard.requireBothQuestions).map(assessmentStandardRefKey);
   return JSON.stringify({
     kind: "standards-review",
     policy: {
       version: policy.version
     },
     candidateItemsPerStandard: normalized.candidateItemsPerStandard,
-    standardKeys: normalized.standards.map(assessmentStandardRefKey)
+    standardKeys: normalized.standards.map(assessmentStandardRefKey),
+    ...requiredStandardKeys.length > 0 ? { requiredStandardKeys } : {}
   });
 }
 function reviewQuestionLineItemId(parentLineItemId, itemIdentifier) {
@@ -11290,9 +11333,10 @@ function rankedCandidatesByStandard(bank, exposures) {
   return byStandard;
 }
 function reviewSlots(request) {
-  return request.standards.flatMap((standard) => Array.from({ length: request.candidateItemsPerStandard }, () => ({
-    standard,
-    standardKey: assessmentStandardRefKey(standard)
+  return request.standards.flatMap((standard, servingIndex) => Array.from({ length: request.candidateItemsPerStandard }, () => ({
+    standard: reviewStandardRef(standard),
+    standardKey: assessmentStandardRefKey(standard),
+    servingIndex
   })));
 }
 function matchingCandidates(candidatesByStandard, slotCount) {
@@ -11405,7 +11449,7 @@ function fulfillment(request, candidatesByStandard, selections) {
     const selected = selectedByStandard.get(key) ?? 0;
     return selected < request.candidateItemsPerStandard ? [
       {
-        standard,
+        standard: reviewStandardRef(standard),
         requested: request.candidateItemsPerStandard,
         selected,
         eligible: candidatesByStandard.get(key)?.length ?? 0
@@ -11430,10 +11474,10 @@ function fulfillment(request, candidatesByStandard, selections) {
 function selectReviewItems(input) {
   const request = normalizeReviewRequest(input.request);
   const candidatesByStandard = rankedCandidatesByStandard(input.bank, input.exposures);
-  const slots = reviewSlots(request);
+  const slots = reviewSlots(request).toSorted((left, right) => compareCodeUnits(left.standardKey, right.standardKey));
   const boundedCandidates = matchingCandidates(candidatesByStandard, slots.length);
   const selected = preferredDistinctMatching(slots, boundedCandidates);
-  const selections = [...selected.entries()].toSorted(([left], [right]) => left - right).map(([index, itemIdentifier]) => ({
+  const selections = [...selected.entries()].toSorted(([left], [right]) => slots[left].servingIndex - slots[right].servingIndex || left - right).map(([index, itemIdentifier]) => ({
     standard: slots[index].standard,
     itemIdentifier
   }));
@@ -11572,6 +11616,9 @@ function isAssessmentScore(value) {
 function isAssessmentStandardRef(value) {
   return isRecord(value) && typeof value.framework === "string" && value.framework.length > 0 && typeof value.identifier === "string" && value.identifier.length > 0;
 }
+function isAssessmentReviewStandard(value) {
+  return isRecord(value) && isAssessmentStandardRef(value) && (value.requireBothQuestions === undefined || typeof value.requireBothQuestions === "boolean");
+}
 function isReviewFulfillment(value) {
   if (!isRecord(value) || value.status !== "complete" && value.status !== "partial" || !Number.isInteger(value.requestedItemCount) || !Number.isInteger(value.selectedItemCount) || !Array.isArray(value.shortages)) {
     return false;
@@ -11646,7 +11693,7 @@ function isRoutedDiagnosticAttemptMetadata(value, itemSubmissions, responseVersi
   });
 }
 function isReviewAttemptMetadata(value) {
-  return isRecord(value) && typeof value.requestFingerprint === "string" && typeof value.bankRevision === "string" && Array.isArray(value.standards) && value.standards.every(isAssessmentStandardRef) && Number.isInteger(value.candidateItemsPerStandard) && Array.isArray(value.selections) && value.selections.every((selection) => isRecord(selection) && isAssessmentStandardRef(selection.standard) && typeof selection.itemIdentifier === "string") && isReviewFulfillment(value.fulfillment);
+  return isRecord(value) && typeof value.requestFingerprint === "string" && typeof value.bankRevision === "string" && Array.isArray(value.standards) && value.standards.every(isAssessmentReviewStandard) && Number.isInteger(value.candidateItemsPerStandard) && value.requireBothQuestions === undefined && Array.isArray(value.selections) && value.selections.every((selection) => isRecord(selection) && isAssessmentStandardRef(selection.standard) && typeof selection.itemIdentifier === "string") && isReviewFulfillment(value.fulfillment);
 }
 function isOptionalInteger(value) {
   return value === undefined || Number.isInteger(value);
@@ -12344,7 +12391,8 @@ var init_assessment_runtime2 = __esm(() => {
     }),
     StartAssessmentBaseSchema.extend({
       purpose: exports_external.literal("review"),
-      standards: exports_external.array(AssessmentStandardRefSchema2).min(1).max(TIMEBACK_ASSESSMENT_REVIEW_REQUEST_LIMITS.standards),
+      requireBothQuestions: exports_external.never().optional(),
+      standards: exports_external.array(AssessmentStandardRefSchema2.and(exports_external.object({ requireBothQuestions: exports_external.boolean().optional() }))).min(1).max(TIMEBACK_ASSESSMENT_REVIEW_REQUEST_LIMITS.standards),
       candidateItemsPerStandard: exports_external.number().int().positive().max(TIMEBACK_ASSESSMENT_REVIEW_REQUEST_LIMITS.candidateItemsPerStandard).optional()
     }),
     StartAssessmentBaseSchema.extend({
@@ -104518,6 +104566,16 @@ var init_timeback_assessment_runtime_service = __esm(async () => {
         };
       });
       if (accepted.repair) {
+        const { metadata: metadata2 } = accepted.repair.graded;
+        if (metadata2.purpose === "review") {
+          reportReviewRequiredPairUnavailable(metadata2.review, metadata2.itemSubmissions.map((item) => item.itemIdentifier), (error88) => addEvent("assessment.review_required_pair_unavailable", {
+            "app.assessment.attempt_id": params.attemptId,
+            "app.assessment.submission_id": input.submissionId,
+            "app.error.code": error88.code,
+            "app.assessment.review.required_pair_failure_count": error88.failures.length,
+            "app.assessment.review.required_pair_failures": error88.failures.map((failure) => JSON.stringify(failure))
+          }));
+        }
         this.reconcileTranscriptChildren(accepted.repair.context, accepted.repair.graded).catch((error88) => this.recordTranscriptFailure("completion_repair", params.attemptId, error88));
       }
       if (accepted.emission) {

package/dist/server.js

@@ -1127,7 +1127,7 @@ var package_default;
 var init_package = __esm(() => {
   package_default = {
     name: "@playcademy/sandbox",
-    version: "0.10.1-beta.1",
+    version: "0.10.1-beta.3",
     description: "Local development server for Playcademy game development",
     type: "module",
     exports: {
@@ -11001,6 +11001,35 @@ function scorePlatformAssessmentItem(item, responses) {
     isCorrect: verdicts.length > 0 && verdicts.every(Boolean)
   };
 }
+function reviewStandardRef({
+  framework,
+  identifier
+}) {
+  return { framework, identifier };
+}
+function reportReviewRequiredPairUnavailable(review, administeredItemIdentifiers2, report) {
+  const administered = new Set(administeredItemIdentifiers2);
+  const failures = [];
+  for (const standard of review.standards.filter((entry) => entry.requireBothQuestions)) {
+    const key = assessmentStandardRefKey(standard);
+    const selected = new Set(review.selections.filter((selection) => assessmentStandardRefKey(selection.standard) === key).map((selection) => selection.itemIdentifier));
+    const administeredCount = [...selected].filter((identifier) => administered.has(identifier)).length;
+    if (selected.size < 2 || administeredCount === 1) {
+      failures.push({
+        standard: reviewStandardRef(standard),
+        reason: selected.size < 2 ? "selection_shortage" : "not_administered",
+        requiredCount: 2,
+        selectedCount: selected.size,
+        administeredCount
+      });
+    }
+  }
+  if (failures.length > 0) {
+    try {
+      report({ code: "REVIEW_REQUIRED_PAIR_UNAVAILABLE", failures });
+    } catch {}
+  }
+}
 function reviewStandardFieldsWithinLimits(input) {
   return input.framework.trim().length <= TIMEBACK_ASSESSMENT_REVIEW_REQUEST_LIMITS.standardFieldLength && input.identifier.trim().length <= TIMEBACK_ASSESSMENT_REVIEW_REQUEST_LIMITS.standardFieldLength;
 }
@@ -11030,6 +11059,9 @@ function canonicalRequestStandards(standards) {
   }
   const canonical = new Map;
   for (const input of standards) {
+    if (input.requireBothQuestions !== undefined && typeof input.requireBothQuestions !== "boolean") {
+      throw new Error("review standard requireBothQuestions must be a boolean");
+    }
     const standard = canonicalAssessmentStandardRef(input);
     if (!reviewStandardFieldsWithinLimits(standard)) {
       throw new RangeError(`Review standard fields may contain at most ${TIMEBACK_ASSESSMENT_REVIEW_REQUEST_LIMITS.standardFieldLength} characters`);
@@ -11038,13 +11070,19 @@ function canonicalRequestStandards(standards) {
       throw new Error("Review standards require a framework and identifier");
     }
     const key = assessmentStandardRefKey(standard);
-    if (!canonical.has(key)) {
-      canonical.set(key, standard);
+    if (!canonical.has(key) || input.requireBothQuestions) {
+      canonical.set(key, {
+        ...standard,
+        ...input.requireBothQuestions ? { requireBothQuestions: true } : {}
+      });
     }
   }
-  return [...canonical.values()].toSorted((left, right) => compareCodeUnits(assessmentStandardRefKey(left), assessmentStandardRefKey(right)));
+  return [...canonical.values()];
 }
 function normalizeReviewRequest(request) {
+  if ("requireBothQuestions" in request && request.requireBothQuestions !== undefined) {
+    throw new Error("Set requireBothQuestions on individual review standards, not the review request");
+  }
   const candidateItemsPerStandard = request.candidateItemsPerStandard ?? 1;
   if (!Number.isInteger(candidateItemsPerStandard) || candidateItemsPerStandard <= 0 || candidateItemsPerStandard > TIMEBACK_ASSESSMENT_REVIEW_REQUEST_LIMITS.candidateItemsPerStandard) {
     throw new RangeError(`candidateItemsPerStandard must be a positive integer at most ${TIMEBACK_ASSESSMENT_REVIEW_REQUEST_LIMITS.candidateItemsPerStandard}`);
@@ -11053,17 +11091,22 @@ function normalizeReviewRequest(request) {
   if (standards.length === 0) {
     throw new Error("At least one review standard is required");
   }
-  return { standards, candidateItemsPerStandard };
+  return {
+    standards,
+    candidateItemsPerStandard
+  };
 }
 function reviewRequestFingerprint(request, policy) {
   const normalized = normalizeReviewRequest(request);
+  const requiredStandardKeys = normalized.standards.filter((standard) => standard.requireBothQuestions).map(assessmentStandardRefKey);
   return JSON.stringify({
     kind: "standards-review",
     policy: {
       version: policy.version
     },
     candidateItemsPerStandard: normalized.candidateItemsPerStandard,
-    standardKeys: normalized.standards.map(assessmentStandardRefKey)
+    standardKeys: normalized.standards.map(assessmentStandardRefKey),
+    ...requiredStandardKeys.length > 0 ? { requiredStandardKeys } : {}
   });
 }
 function reviewQuestionLineItemId(parentLineItemId, itemIdentifier) {
@@ -11289,9 +11332,10 @@ function rankedCandidatesByStandard(bank, exposures) {
   return byStandard;
 }
 function reviewSlots(request) {
-  return request.standards.flatMap((standard) => Array.from({ length: request.candidateItemsPerStandard }, () => ({
-    standard,
-    standardKey: assessmentStandardRefKey(standard)
+  return request.standards.flatMap((standard, servingIndex) => Array.from({ length: request.candidateItemsPerStandard }, () => ({
+    standard: reviewStandardRef(standard),
+    standardKey: assessmentStandardRefKey(standard),
+    servingIndex
   })));
 }
 function matchingCandidates(candidatesByStandard, slotCount) {
@@ -11404,7 +11448,7 @@ function fulfillment(request, candidatesByStandard, selections) {
     const selected = selectedByStandard.get(key) ?? 0;
     return selected < request.candidateItemsPerStandard ? [
       {
-        standard,
+        standard: reviewStandardRef(standard),
         requested: request.candidateItemsPerStandard,
         selected,
         eligible: candidatesByStandard.get(key)?.length ?? 0
@@ -11429,10 +11473,10 @@ function fulfillment(request, candidatesByStandard, selections) {
 function selectReviewItems(input) {
   const request = normalizeReviewRequest(input.request);
   const candidatesByStandard = rankedCandidatesByStandard(input.bank, input.exposures);
-  const slots = reviewSlots(request);
+  const slots = reviewSlots(request).toSorted((left, right) => compareCodeUnits(left.standardKey, right.standardKey));
   const boundedCandidates = matchingCandidates(candidatesByStandard, slots.length);
   const selected = preferredDistinctMatching(slots, boundedCandidates);
-  const selections = [...selected.entries()].toSorted(([left], [right]) => left - right).map(([index, itemIdentifier]) => ({
+  const selections = [...selected.entries()].toSorted(([left], [right]) => slots[left].servingIndex - slots[right].servingIndex || left - right).map(([index, itemIdentifier]) => ({
     standard: slots[index].standard,
     itemIdentifier
   }));
@@ -11571,6 +11615,9 @@ function isAssessmentScore(value) {
 function isAssessmentStandardRef(value) {
   return isRecord(value) && typeof value.framework === "string" && value.framework.length > 0 && typeof value.identifier === "string" && value.identifier.length > 0;
 }
+function isAssessmentReviewStandard(value) {
+  return isRecord(value) && isAssessmentStandardRef(value) && (value.requireBothQuestions === undefined || typeof value.requireBothQuestions === "boolean");
+}
 function isReviewFulfillment(value) {
   if (!isRecord(value) || value.status !== "complete" && value.status !== "partial" || !Number.isInteger(value.requestedItemCount) || !Number.isInteger(value.selectedItemCount) || !Array.isArray(value.shortages)) {
     return false;
@@ -11645,7 +11692,7 @@ function isRoutedDiagnosticAttemptMetadata(value, itemSubmissions, responseVersi
   });
 }
 function isReviewAttemptMetadata(value) {
-  return isRecord(value) && typeof value.requestFingerprint === "string" && typeof value.bankRevision === "string" && Array.isArray(value.standards) && value.standards.every(isAssessmentStandardRef) && Number.isInteger(value.candidateItemsPerStandard) && Array.isArray(value.selections) && value.selections.every((selection) => isRecord(selection) && isAssessmentStandardRef(selection.standard) && typeof selection.itemIdentifier === "string") && isReviewFulfillment(value.fulfillment);
+  return isRecord(value) && typeof value.requestFingerprint === "string" && typeof value.bankRevision === "string" && Array.isArray(value.standards) && value.standards.every(isAssessmentReviewStandard) && Number.isInteger(value.candidateItemsPerStandard) && value.requireBothQuestions === undefined && Array.isArray(value.selections) && value.selections.every((selection) => isRecord(selection) && isAssessmentStandardRef(selection.standard) && typeof selection.itemIdentifier === "string") && isReviewFulfillment(value.fulfillment);
 }
 function isOptionalInteger(value) {
   return value === undefined || Number.isInteger(value);
@@ -12343,7 +12390,8 @@ var init_assessment_runtime2 = __esm(() => {
     }),
     StartAssessmentBaseSchema.extend({
       purpose: exports_external.literal("review"),
-      standards: exports_external.array(AssessmentStandardRefSchema2).min(1).max(TIMEBACK_ASSESSMENT_REVIEW_REQUEST_LIMITS.standards),
+      requireBothQuestions: exports_external.never().optional(),
+      standards: exports_external.array(AssessmentStandardRefSchema2.and(exports_external.object({ requireBothQuestions: exports_external.boolean().optional() }))).min(1).max(TIMEBACK_ASSESSMENT_REVIEW_REQUEST_LIMITS.standards),
       candidateItemsPerStandard: exports_external.number().int().positive().max(TIMEBACK_ASSESSMENT_REVIEW_REQUEST_LIMITS.candidateItemsPerStandard).optional()
     }),
     StartAssessmentBaseSchema.extend({
@@ -104517,6 +104565,16 @@ var init_timeback_assessment_runtime_service = __esm(async () => {
         };
       });
       if (accepted.repair) {
+        const { metadata: metadata2 } = accepted.repair.graded;
+        if (metadata2.purpose === "review") {
+          reportReviewRequiredPairUnavailable(metadata2.review, metadata2.itemSubmissions.map((item) => item.itemIdentifier), (error88) => addEvent("assessment.review_required_pair_unavailable", {
+            "app.assessment.attempt_id": params.attemptId,
+            "app.assessment.submission_id": input.submissionId,
+            "app.error.code": error88.code,
+            "app.assessment.review.required_pair_failure_count": error88.failures.length,
+            "app.assessment.review.required_pair_failures": error88.failures.map((failure) => JSON.stringify(failure))
+          }));
+        }
         this.reconcileTranscriptChildren(accepted.repair.context, accepted.repair.graded).catch((error88) => this.recordTranscriptFailure("completion_repair", params.attemptId, error88));
       }
       if (accepted.emission) {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@playcademy/sandbox",
-    "version": "0.10.1-beta.1",
+    "version": "0.10.1-beta.3",
     "description": "Local development server for Playcademy game development",
     "type": "module",
     "exports": {