@platformos/platformos-language-server-common 0.0.8 → 0.0.9

package/dist/utils/uri.d.ts

@@ -1,4 +1,5 @@
+import { isPartial } from '@platformos/platformos-common';
+export { isPartial };
 export declare const partialName: (uri: string) => string;
-export declare const isPartial: (uri: string) => boolean;
 export declare const assetName: (uri: string) => string;
 export declare const isAsset: (uri: string) => boolean;

package/dist/utils/uri.js

@@ -1,14 +1,14 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.isAsset = exports.assetName = exports.isPartial = exports.partialName = void 0;
+exports.isAsset = exports.assetName = exports.partialName = exports.isPartial = void 0;
 const platformos_check_common_1 = require("@platformos/platformos-check-common");
+const platformos_common_1 = require("@platformos/platformos-common");
+Object.defineProperty(exports, "isPartial", { enumerable: true, get: function () { return platformos_common_1.isPartial; } });
 const partialName = (uri) => platformos_check_common_1.path.basename(uri, '.liquid');
 exports.partialName = partialName;
-const isPartial = (uri) => /\b(partials|lib)(\\|\/)[^\\\/]*\.liquid/.test(uri);
-exports.isPartial = isPartial;
-// asset urls have their `.liquid`` removed (if present) and require the other extension */
+// asset urls have their `.liquid` removed (if present) and require the other extension
 const assetName = (uri) => platformos_check_common_1.path.basename(uri, '.liquid');
 exports.assetName = assetName;
-const isAsset = (uri) => /\bassets(\\|\/)[^\\\/]/.test(uri);
+const isAsset = (uri) => (0, platformos_common_1.getFileType)(uri) === platformos_common_1.PlatformOSFileType.Asset;
 exports.isAsset = isAsset;
 //# sourceMappingURL=uri.js.map

package/dist/utils/uri.js.map

@@ -1 +1 @@
-{"version":3,"file":"uri.js","sourceRoot":"","sources":["../../src/utils/uri.ts"],"names":[],"mappings":";;;AAAA,iFAA2D;AAEpD,MAAM,WAAW,GAAG,CAAC,GAAW,EAAE,EAAE,CAAC,8BAAI,CAAC,QAAQ,CAAC,GAAG,EAAE,SAAS,CAAC,CAAC;AAA7D,QAAA,WAAW,eAAkD;AACnE,MAAM,SAAS,GAAG,CAAC,GAAW,EAAE,EAAE,CAAC,yCAAyC,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;AAAjF,QAAA,SAAS,aAAwE;AAE9F,2FAA2F;AACpF,MAAM,SAAS,GAAG,CAAC,GAAW,EAAE,EAAE,CAAC,8BAAI,CAAC,QAAQ,CAAC,GAAG,EAAE,SAAS,CAAC,CAAC;AAA3D,QAAA,SAAS,aAAkD;AACjE,MAAM,OAAO,GAAG,CAAC,GAAW,EAAE,EAAE,CAAC,wBAAwB,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;AAA9D,QAAA,OAAO,WAAuD"}
+{"version":3,"file":"uri.js","sourceRoot":"","sources":["../../src/utils/uri.ts"],"names":[],"mappings":";;;AAAA,iFAA2D;AAC3D,qEAA2F;AAElF,0FAFA,6BAAS,OAEA;AAEX,MAAM,WAAW,GAAG,CAAC,GAAW,EAAE,EAAE,CAAC,8BAAI,CAAC,QAAQ,CAAC,GAAG,EAAE,SAAS,CAAC,CAAC;AAA7D,QAAA,WAAW,eAAkD;AAE1E,uFAAuF;AAChF,MAAM,SAAS,GAAG,CAAC,GAAW,EAAE,EAAE,CAAC,8BAAI,CAAC,QAAQ,CAAC,GAAG,EAAE,SAAS,CAAC,CAAC;AAA3D,QAAA,SAAS,aAAkD;AACjE,MAAM,OAAO,GAAG,CAAC,GAAW,EAAE,EAAE,CAAC,IAAA,+BAAW,EAAC,GAAG,CAAC,KAAK,sCAAkB,CAAC,KAAK,CAAC;AAAzE,QAAA,OAAO,WAAkE"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@platformos/platformos-language-server-common",
-  "version": "0.0.8",
+  "version": "0.0.9",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "author": "platformOS",
@@ -27,9 +27,9 @@
     "type-check": "tsc --noEmit -p ./tsconfig.json"
   },
   "dependencies": {
-    "@platformos/liquid-html-parser": "^0.0.8",
-    "@platformos/platformos-check-common": "0.0.8",
-    "@platformos/platformos-graph": "0.0.8",
+    "@platformos/liquid-html-parser": "^0.0.9",
+    "@platformos/platformos-check-common": "0.0.9",
+    "@platformos/platformos-graph": "0.0.9",
     "@vscode/web-custom-data": "^0.4.6",
     "vscode-json-languageservice": "^5.7.1",
     "vscode-languageserver": "^9.0.1",

package/src/ClientCapabilities.ts

@@ -48,7 +48,7 @@ export class ClientCapabilities {
     const direct = this.initializationOptions?.[key];
     if (direct !== undefined) return direct;
 
-    // { themeCheck: { checkOnSave: true } }
+    // { platformosCheck: { checkOnSave: true } }
     const nested = pathGet<T>(this.initializationOptions, key);
     if (nested !== undefined) return nested;
 

package/src/PropertyShapeInference.ts

@@ -14,6 +14,7 @@ import {
   JsonHashLiteral,
   JsonArrayLiteral,
   LiquidExpression,
+  LiquidVariable,
   NodeTypes,
 } from '@platformos/liquid-html-parser';
 
@@ -164,9 +165,13 @@ function getJsonKeyName(key: LiquidExpression): string | undefined {
 }
 
 function inferShapeFromExpression(
-  expr: LiquidExpression,
+  expr: LiquidExpression | LiquidVariable,
   resolveExpression?: ExpressionShapeResolver,
 ): PropertyShape {
+  if (expr.type === NodeTypes.LiquidVariable) {
+    // A filtered expression's output type can't be statically inferred
+    return { kind: 'primitive' };
+  }
   switch (expr.type) {
     case NodeTypes.JsonHashLiteral:
     case NodeTypes.JsonArrayLiteral:

package/src/TypeSystem.spec.ts

@@ -881,5 +881,24 @@ query {
         });
       }
     });
+
+    it('should support explicit push form (assign a = source << value)', async () => {
+      const ast = toLiquidHtmlAST(`{% assign arr = [] %}{% assign arr = arr << "item" %}{{ arr }}`);
+      const variableOutput = ast.children[2];
+      assert(isLiquidVariableOutput(variableOutput));
+      const inferredType = await typeSystem.inferType(
+        variableOutput.markup,
+        ast,
+        'file:///file.liquid',
+      );
+      expect(inferredType).to.have.property('kind', 'shape');
+      if (typeof inferredType !== 'string' && inferredType.kind === 'shape') {
+        expect(inferredType.shape.kind).to.equal('array');
+        expect(inferredType.shape.itemShape).to.deep.equal({
+          kind: 'primitive',
+          primitiveType: 'string',
+        });
+      }
+    });
   });
 });

package/src/TypeSystem.ts

@@ -1,5 +1,6 @@
 import {
   AssignMarkup,
+  AssignPushRhs,
   ComplexLiquidExpression,
   FunctionMarkup,
   LiquidDocParamNode,
@@ -240,7 +241,7 @@ type FilterEntryName = FilterEntry['name'];
 export const Untyped = 'untyped' as const;
 export type Untyped = typeof Untyped;
 
-/** Unknown is for variables that don't exist, type would come from context (e.g. snippet var without LiquidDoc) */
+/** Unknown is for variables that don't exist, type would come from context (e.g. partial var without LiquidDoc) */
 export const Unknown = 'unknown' as const;
 export type Unknown = typeof Untyped;
 
@@ -383,8 +384,15 @@ async function buildSymbolsTable(
     // {% assign x = {a: 1, b: "hello"} %}
     // {% assign x["key"] = value %}
     // {% assign arr << item %}
+    // {% assign arr = source << item %}
     async AssignMarkup(node) {
-      const expression = node.value.expression;
+      // For explicit push form (assign a = source << value), treat as array append
+      const isPushRhs = node.value.type === NodeTypes.AssignPushRhs;
+      const effectiveValue = isPushRhs
+        ? (node.value as AssignPushRhs).pushValue
+        : (node.value as LiquidVariable);
+      const effectiveOperator = isPushRhs ? '<<' : node.operator;
+      const expression = effectiveValue.expression;
       let valueShape: PropertyShape | undefined;
 
       // Resolver for variable references inside JSON literals
@@ -451,7 +459,7 @@ async function buildSymbolsTable(
 
       // Case 2: parse_json / to_hash filter on a string
       if (!valueShape) {
-        const hasParseJsonFilter = node.value.filters?.some(
+        const hasParseJsonFilter = effectiveValue.filters?.some(
           (f: { name: string }) => f.name === 'parse_json' || f.name === 'to_hash',
         );
         if (hasParseJsonFilter) {
@@ -459,8 +467,8 @@ async function buildSymbolsTable(
           if (expression.type === NodeTypes.String) {
             jsonString = expression.value;
           }
-          if (!jsonString && node.value.filters) {
-            const defaultFilter = node.value.filters.find(
+          if (!jsonString && effectiveValue.filters) {
+            const defaultFilter = effectiveValue.filters.find(
               (f: { name: string }) => f.name === 'default',
             );
             if (
@@ -479,7 +487,10 @@ async function buildSymbolsTable(
       }
 
       // Case 3: Infer primitive shape for << and LHS lookup scenarios
-      if (!valueShape && ((node.lookups && node.lookups.length > 0) || node.operator === '<<')) {
+      if (
+        !valueShape &&
+        ((node.lookups && node.lookups.length > 0) || effectiveOperator === '<<')
+      ) {
         if (expression.type === NodeTypes.String) {
           valueShape = { kind: 'primitive', primitiveType: 'string' };
         } else if (expression.type === NodeTypes.Number) {
@@ -537,8 +548,8 @@ async function buildSymbolsTable(
         }
       }
 
-      // Handle << operator (array append)
-      if (node.operator === '<<') {
+      // Handle << operator (array append), including explicit form (assign a = source << value)
+      if (effectiveOperator === '<<') {
         const itemShape: PropertyShape = valueShape ?? { kind: 'primitive' };
         const existingShapes = variableShapes.get(node.name) || [];
         const existingShapeEntry = findLastApplicableShape(existingShapes, node.position.start);
@@ -578,7 +589,7 @@ async function buildSymbolsTable(
       // Default: lazy variable type
       return {
         identifier: node.name,
-        type: lazyVariable(node.value, node.position.start),
+        type: lazyVariable(effectiveValue, node.position.start),
         range: [node.position.end],
       };
     },
@@ -986,7 +997,9 @@ function inferType(
     // The type of the assign markup is the type of the right hand side.
     // {% assign x = y.property | filter1 | filter2 %}
     case NodeTypes.AssignMarkup: {
-      return inferType(thing.value, symbolsTable, objectMap, filtersMap);
+      const assignValue =
+        thing.value.type === NodeTypes.AssignPushRhs ? thing.value.pushValue : thing.value;
+      return inferType(assignValue, symbolsTable, objectMap, filtersMap);
     }
 
     // A variable lookup is expression[.lookup]*

package/src/codeActions/providers/FixAllProvider.spec.ts

@@ -73,7 +73,7 @@ describe('Unit: FixAllProvider', () => {
       isPreferred: false,
       command: {
         title: 'applyFixes',
-        command: 'themeCheck/applyFixes',
+        command: 'platformosCheck/applyFixes',
         arguments: [uri, version, [0, 1, 2]],
       },
     });

package/src/codeActions/providers/FixProvider.spec.ts

@@ -75,7 +75,7 @@ describe('Unit: FixProvider', () => {
         isPreferred: true,
         command: {
           title: 'applyFixes',
-          command: 'themeCheck/applyFixes',
+          command: 'platformosCheck/applyFixes',
           arguments: [uri, 1, [1]],
         },
       });
@@ -87,7 +87,7 @@ describe('Unit: FixProvider', () => {
         isPreferred: false,
         command: {
           title: 'applyFixes',
-          command: 'themeCheck/applyFixes',
+          command: 'platformosCheck/applyFixes',
           arguments: [uri, 1, [1, 2]],
         },
       });
@@ -99,7 +99,7 @@ describe('Unit: FixProvider', () => {
         isPreferred: false,
         command: {
           title: 'applyFixes',
-          command: 'themeCheck/applyFixes',
+          command: 'platformosCheck/applyFixes',
           arguments: [uri, 1, [0, 1, 2]],
         },
       });
@@ -135,7 +135,7 @@ describe('Unit: FixProvider', () => {
         isPreferred: true,
         command: {
           title: 'applyFixes',
-          command: 'themeCheck/applyFixes',
+          command: 'platformosCheck/applyFixes',
           arguments: [uri, 1, [1]],
         },
       });
@@ -147,7 +147,7 @@ describe('Unit: FixProvider', () => {
         isPreferred: false,
         command: {
           title: 'applyFixes',
-          command: 'themeCheck/applyFixes',
+          command: 'platformosCheck/applyFixes',
           arguments: [uri, 1, [0, 1]],
         },
       });
@@ -183,7 +183,7 @@ describe('Unit: FixProvider', () => {
         isPreferred: true,
         command: {
           title: 'applyFixes',
-          command: 'themeCheck/applyFixes',
+          command: 'platformosCheck/applyFixes',
           arguments: [uri, 1, [0]],
         },
       });
@@ -195,7 +195,7 @@ describe('Unit: FixProvider', () => {
         isPreferred: false,
         command: {
           title: 'applyFixes',
-          command: 'themeCheck/applyFixes',
+          command: 'platformosCheck/applyFixes',
           arguments: [uri, 1, [0, 1]],
         },
       });
@@ -230,7 +230,7 @@ describe('Unit: FixProvider', () => {
         isPreferred: true,
         command: {
           title: 'applyFixes',
-          command: 'themeCheck/applyFixes',
+          command: 'platformosCheck/applyFixes',
           arguments: [uri, 1, [0]],
         },
       });
@@ -264,7 +264,7 @@ describe('Unit: FixProvider', () => {
       isPreferred: true,
       command: {
         title: 'applyFixes',
-        command: 'themeCheck/applyFixes',
+        command: 'platformosCheck/applyFixes',
         arguments: [uri, 1, [1]],
       },
     });
@@ -276,7 +276,7 @@ describe('Unit: FixProvider', () => {
       isPreferred: false,
       command: {
         title: 'applyFixes',
-        command: 'themeCheck/applyFixes',
+        command: 'platformosCheck/applyFixes',
         arguments: [uri, 1, [1, 2]],
       },
     });
@@ -288,7 +288,7 @@ describe('Unit: FixProvider', () => {
       isPreferred: false,
       command: {
         title: 'applyFixes',
-        command: 'themeCheck/applyFixes',
+        command: 'platformosCheck/applyFixes',
         arguments: [uri, 1, [0, 1, 2]],
       },
     });

package/src/codeActions/providers/SuggestionProvider.spec.ts

@@ -88,7 +88,7 @@ describe('Unit: SuggestionProvider', () => {
         isPreferred: false,
         command: {
           title: 'applySuggestion',
-          command: 'themeCheck/applySuggestion',
+          command: 'platformosCheck/applySuggestion',
           arguments: [uri, version, anomalyId, 0],
         },
       });
@@ -100,7 +100,7 @@ describe('Unit: SuggestionProvider', () => {
         isPreferred: false,
         command: {
           title: 'applySuggestion',
-          command: 'themeCheck/applySuggestion',
+          command: 'platformosCheck/applySuggestion',
           arguments: [uri, version, anomalyId, 1],
         },
       });

package/src/commands/providers/ApplyFixesProvider.ts

@@ -14,7 +14,7 @@ import { TextDocument } from 'vscode-languageserver-textdocument';
 import { BaseExecuteCommandProvider } from '../BaseExecuteCommandProvider';
 
 /**
- * The ApplyFixesProvider is responsible for handling the `themeCheck/applyFixes` command.
+ * The ApplyFixesProvider is responsible for handling the `platformosCheck/applyFixes` command.
  *
  * To create a command, use the `applyFixCommand` function.
  * The provider will execute the command with the given arguments.
@@ -23,7 +23,7 @@ import { BaseExecuteCommandProvider } from '../BaseExecuteCommandProvider';
  * applies them, and forwards the result to the client using the 'workspace/applyEdit' request.
  */
 export class ApplyFixesProvider extends BaseExecuteCommandProvider {
-  static command = 'themeCheck/applyFixes' as const;
+  static command = 'platformosCheck/applyFixes' as const;
 
   async execute(uri: string, version: number | undefined, ids: number[]) {
     if (!this.clientCapabilities.hasApplyEditSupport) return;

package/src/commands/providers/ApplySuggestionProvider.ts

@@ -14,7 +14,7 @@ import { TextDocument } from 'vscode-languageserver-textdocument';
 import { BaseExecuteCommandProvider } from '../BaseExecuteCommandProvider';
 
 /**
- * The ApplySuggestionProvider is responsible for handling the `themeCheck/applySuggestion` command.
+ * The ApplySuggestionProvider is responsible for handling the `platformosCheck/applySuggestion` command.
  *
  * To create a command, use the `applySuggestionCommand` function.
  * The provider will execute the command with the given arguments.
@@ -23,7 +23,7 @@ import { BaseExecuteCommandProvider } from '../BaseExecuteCommandProvider';
  * applies them, and forwards the result to the client using the 'workspace/applyEdit' request.
  */
 export class ApplySuggestionProvider extends BaseExecuteCommandProvider {
-  static command = 'themeCheck/applySuggestion' as const;
+  static command = 'platformosCheck/applySuggestion' as const;
 
   async execute(
     uri: string,

package/src/commands/providers/RunChecksProvider.ts

@@ -6,7 +6,7 @@ import { DebouncedFunction } from '../../utils';
 import { BaseExecuteCommandProvider } from '../BaseExecuteCommandProvider';
 
 /**
- * The RunChecksProvider runs theme check on all open files.
+ * The RunChecksProvider runs platformos-check on all open files.
  *
  * It is triggered by the cmd+p command in the VS Code extension and is
  * otherwise not used internally, which is why there is no
@@ -16,7 +16,7 @@ import { BaseExecuteCommandProvider } from '../BaseExecuteCommandProvider';
  * `checkOnOpen` are all false.
  */
 export class RunChecksProvider extends BaseExecuteCommandProvider {
-  static command = 'themeCheck/runChecks' as const;
+  static command = 'platformosCheck/runChecks' as const;
 
   constructor(
     protected documentManager: DocumentManager,

package/src/completions/CompletionsProvider.ts

@@ -38,7 +38,7 @@ export interface CompletionProviderDependencies {
   fs?: AbstractFileSystem;
   /** Locator for finding documents by type */
   documentsLocator?: DocumentsLocator;
-  /** Function to find the theme root URI for a given file */
+  /** Function to find the app root URI for a given file */
   findAppRootURI?: FindAppRootURI;
   log?: (message: string) => void;
   /** Callback to notify when unable to infer properties for a variable */

package/src/completions/params/LiquidCompletionParams.ts

@@ -373,8 +373,8 @@ function findCurrentNode(
           finder.current = last(current.args);
         } else if (current.variable && isCovered(cursor, current.variable.position)) {
           finder.current = current.variable;
-        } else if (current.snippet && isCovered(cursor, current.snippet.position)) {
-          finder.current = current.snippet;
+        } else if (current.partial && isCovered(cursor, current.partial.position)) {
+          finder.current = current.partial;
         }
 
         break;
@@ -442,7 +442,8 @@ function findCurrentNode(
       case NodeTypes.ExportMarkup:
       case NodeTypes.RedirectToMarkup:
       case NodeTypes.IncludeFormMarkup:
-      case NodeTypes.SpamProtectionMarkup: {
+      case NodeTypes.SpamProtectionMarkup:
+      case NodeTypes.AssignPushRhs: {
         break;
       }
 

package/src/completions/providers/LiquidTagsCompletionProvider.spec.ts

@@ -38,8 +38,8 @@ endcase`;
 export const tags: TagEntry[] = [
   {
     name: 'render',
-    syntax: "{% render 'snippet' %}",
-    syntax_keywords: [{ keyword: 'snippet', description: '...' }],
+    syntax: "{% render 'partial' %}",
+    syntax_keywords: [{ keyword: 'partial', description: '...' }],
   },
   {
     name: 'for',

package/src/completions/providers/PartialCompletionProvider.spec.ts

@@ -2,7 +2,7 @@ import { describe, beforeEach, it, expect } from 'vitest';
 import { DocumentManager } from '../../documents';
 import { CompletionsProvider } from '../CompletionsProvider';
 
-describe('Module: RenderSnippetCompletionProvider', async () => {
+describe('Module: RenderPartialCompletionProvider', async () => {
   let provider: CompletionsProvider;
 
   beforeEach(async () => {
@@ -20,7 +20,7 @@ describe('Module: RenderSnippetCompletionProvider', async () => {
     });
   });
 
-  it('should complete snippets correctly', async () => {
+  it('should complete partials correctly', async () => {
     await expect(provider).to.complete('{% render "', ['product-card', 'image']);
   });
 });

package/src/completions/providers/RenderPartialParameterCompletionProvider.spec.ts

@@ -3,12 +3,12 @@ import { CompletionsProvider } from '../CompletionsProvider';
 import { DocumentManager } from '../../documents';
 import { DocDefinition } from '@platformos/platformos-check-common';
 
-const uri = 'file:///snippets/product-card.liquid';
+const uri = 'file:///app/views/partials/product-card.liquid';
 
-describe('Module: RenderSnippetParameterCompletionProvider', async () => {
+describe('Module: RenderPartialParameterCompletionProvider', async () => {
   let provider: CompletionsProvider;
-  const mockSnippetName = 'product-card';
-  const mockSnippetDefinition: DocDefinition = {
+  const mockPartialName = 'product-card';
+  const mockPartialDefinition: DocDefinition = {
     uri,
     liquidDoc: {
       parameters: [
@@ -61,16 +61,16 @@ describe('Module: RenderSnippetParameterCompletionProvider', async () => {
         liquidDrops: async () => [],
         tags: async () => [],
       },
-      getDocDefinitionForURI: async (_uri, snippetName) => {
-        if (mockSnippetName === snippetName) {
-          return mockSnippetDefinition;
+      getDocDefinitionForURI: async (_uri, partialName) => {
+        if (mockPartialName === partialName) {
+          return mockPartialDefinition;
         }
       },
     });
   });
 
   it("provide completion options that doesn't already exist in render tag", async () => {
-    await expect(provider).to.complete(`{% render '${mockSnippetName}', █ %}`, [
+    await expect(provider).to.complete(`{% render '${mockPartialName}', █ %}`, [
       'title',
       'border-radius',
       'no-type',
@@ -78,12 +78,12 @@ describe('Module: RenderSnippetParameterCompletionProvider', async () => {
       'no-type-or-description',
     ]);
     await expect(provider).to.complete(
-      `{% render '${mockSnippetName}', title: 'foo', border-radius: 5, █ %}`,
+      `{% render '${mockPartialName}', title: 'foo', border-radius: 5, █ %}`,
       ['no-type', 'no-description', 'no-type-or-description'],
     );
   });
 
-  it('does not provide completion options if the snippet does not exist', async () => {
-    await expect(provider).to.complete(`{% render 'fake-snippet', █ %}`, []);
+  it('does not provide completion options if the partial does not exist', async () => {
+    await expect(provider).to.complete(`{% render 'fake-partial', █ %}`, []);
   });
 });

package/src/completions/providers/RenderPartialParameterCompletionProvider.ts

@@ -28,7 +28,7 @@ export class RenderPartialParameterCompletionProvider implements Provider {
       !parentNode ||
       node.type !== NodeTypes.VariableLookup ||
       parentNode.type !== NodeTypes.RenderMarkup ||
-      parentNode.snippet.type !== 'String'
+      parentNode.partial.type !== 'String'
     ) {
       return [];
     }
@@ -37,7 +37,7 @@ export class RenderPartialParameterCompletionProvider implements Provider {
 
     const partialDefinition = await this.getDocDefinitionForURI(
       params.textDocument.uri,
-      parentNode.snippet.value,
+      parentNode.partial.value,
     );
 
     const liquidDocParams = partialDefinition?.liquidDoc?.parameters;

package/src/completions/providers/TranslationCompletionProvider.ts

@@ -41,10 +41,10 @@ export class TranslationCompletionProvider implements Provider {
     const translations = await this.getTranslationsForURI(params.textDocument.uri);
     const partial = node.value;
 
-    // We only want to show standard translations to complete if the translation
-    // is prefixed by shopify. Otherwise it's too noisy.
+    // We only want to show platformos system translations if the user is already
+    // typing that namespace prefix. Otherwise it's too noisy.
     const options = translationOptions(translations).filter(
-      (option) => !option.path[0]?.startsWith('shopify') || partial.startsWith('shopify'),
+      (option) => !option.path[0]?.startsWith('platformos') || partial.startsWith('platformos'),
     );
 
     const [_currentNode, realAncestors] =

package/src/diagnostics/runChecks.spec.ts

@@ -46,7 +46,7 @@ describe('Module: runChecks', () => {
   let runChecks: ReturnType<typeof makeRunChecks>;
   let fs: MockFileSystem;
   const rootUri = path.normalize('browser:///app');
-  const fileUri = path.join(rootUri, 'app', 'input.liquid');
+  const fileUri = path.join(rootUri, 'app', 'views', 'pages', 'input.liquid');
 
   beforeEach(() => {
     connection = {
@@ -58,7 +58,7 @@ describe('Module: runChecks', () => {
     fs = new MockFileSystem(
       {
         '.pos': '',
-        'app/input.liquid': `{{ 'any' | filter }}`,
+        'app/views/pages/input.liquid': `{{ 'any' | filter }}`,
         '.git/test': 'test',
         'modules/test': 'test',
       },
@@ -140,7 +140,7 @@ describe('Module: runChecks', () => {
   it('should send diagnostics per URI when there are errors', async () => {
     const files = [
       {
-        fileURI: path.join(rootUri, 'app', 'input1.liquid'),
+        fileURI: path.join(rootUri, 'app', 'views', 'pages', 'input1.liquid'),
         fileContents: `{{ 'any' | filter }}`,
         fileVersion: 0,
         diagnostics: [
@@ -163,7 +163,7 @@ describe('Module: runChecks', () => {
         ],
       },
       {
-        fileURI: path.join(rootUri, 'app', 'input2.liquid'),
+        fileURI: path.join(rootUri, 'app', 'views', 'pages', 'input2.liquid'),
         // same but on a new line
         fileContents: `\n{{ 'any' | filter }}`,
         fileVersion: 0,
@@ -192,7 +192,7 @@ describe('Module: runChecks', () => {
       documentManager.open(fileURI, fileContents, fileVersion);
     });
 
-    await runChecks([path.join(rootUri, 'app', 'input1.liquid')]);
+    await runChecks([path.join(rootUri, 'app', 'views', 'pages', 'input1.liquid')]);
 
     files.forEach(({ fileURI, fileVersion, diagnostics }) => {
       expect(connection.sendDiagnostics).toBeCalledWith({
@@ -250,7 +250,7 @@ describe('Module: runChecks', () => {
             source: 'platformos-check',
             code: 'MatchingTranslations',
             codeDescription: { href: expect.any(String) },
-            message: `A default translation for 'hi' does not exist`,
+            message: `A translation for 'hi' does not exist in the en locale`,
             severity: 1,
             range: {
               // 'fr:\n  hello: bonjour\n  hi: salut'

package/src/documentLinks/DocumentLinksProvider.ts

@@ -53,12 +53,12 @@ function documentLinksVisitor(
       if (
         (node.name === 'render' || node.name === 'include') &&
         typeof node.markup !== 'string' &&
-        isLiquidString(node.markup.snippet)
+        isLiquidString(node.markup.partial)
       ) {
-        const snippet = node.markup.snippet;
+        const partial = node.markup.partial;
         return DocumentLink.create(
-          range(textDocument, snippet),
-          await documentsLocator.locate(root, node.name, snippet.value),
+          range(textDocument, partial),
+          await documentsLocator.locate(root, node.name, partial.value),
         );
       }
 
@@ -67,10 +67,10 @@ function documentLinksVisitor(
         typeof node.markup !== 'string' &&
         isLiquidString(node.markup.partial)
       ) {
-        const snippet = node.markup.partial;
+        const partial = node.markup.partial;
         return DocumentLink.create(
-          range(textDocument, snippet),
-          await documentsLocator.locate(root, node.name, snippet.value),
+          range(textDocument, partial),
+          await documentsLocator.locate(root, node.name, partial.value),
         );
       }