@platformos/platformos-language-server-common 0.0.7 → 0.0.9

package/src/json/JSONContributions.ts

@@ -1,10 +1,3 @@
-import {
-  AppBlockSchema,
-  parseJSON,
-  SectionSchema,
-  SourceCodeType,
-  ThemeBlockSchema,
-} from '@platformos/platformos-check-common';
 import {
   CompletionsCollector,
   JSONPath,
@@ -12,30 +5,14 @@ import {
   MarkedString,
 } from 'vscode-json-languageservice';
 import { AugmentedSourceCode, DocumentManager } from '../documents';
-import { GetTranslationsForURI } from '../translations';
 import { JSONCompletionProvider } from './completions/JSONCompletionProvider';
-import { BlockTypeCompletionProvider } from './completions/providers/BlockTypeCompletionProvider';
-import { ReferencedBlockTypeCompletionProvider } from './completions/providers/ReferencedBlockTypeCompletionProvider';
-import { SchemaTranslationsCompletionProvider } from './completions/providers/SchemaTranslationCompletionProvider';
 import { JSONHoverProvider } from './hover/JSONHoverProvider';
-import { SchemaTranslationHoverProvider } from './hover/providers/SchemaTranslationHoverProvider';
 import { TranslationPathHoverProvider } from './hover/providers/TranslationPathHoverProvider';
 import { RequestContext } from './RequestContext';
-import { findSchemaNode } from './utils';
-import { SettingsPropertyCompletionProvider } from './completions/providers/SettingsPropertyCompletionProvider';
-import { SettingsHoverProvider } from './hover/providers/SettingsHoverProvider';
-import { BlockSettingsPropertyCompletionProvider } from './completions/providers/BlockSettingsPropertyCompletionProvider';
-import { BlockSettingsHoverProvider } from './hover/providers/BlockSettingsHoverProvider';
 
 /** The getInfoContribution API will only fallback if we return undefined synchronously */
 const SKIP_CONTRIBUTION = undefined as any;
 
-export type GetThemeBlockSchema = (
-  uri: string,
-  name: string,
-) => Promise<SectionSchema | ThemeBlockSchema | AppBlockSchema | undefined>;
-export type GetThemeBlockNames = (uri: string, includePrivate: boolean) => Promise<string[]>;
-
 /**
  * I'm not a fan of how json-languageservice does its feature contributions. It's too different
  * from everything else we do in here.
@@ -47,28 +24,9 @@ export class JSONContributions implements JSONWorkerContribution {
   private hoverProviders: JSONHoverProvider[];
   private completionProviders: JSONCompletionProvider[];
 
-  constructor(
-    private documentManager: DocumentManager,
-    getDefaultSchemaTranslations: GetTranslationsForURI,
-    getThemeBlockNames: GetThemeBlockNames,
-    getThemeBlockSchema: GetThemeBlockSchema,
-  ) {
-    this.hoverProviders = [
-      new TranslationPathHoverProvider(),
-      new SchemaTranslationHoverProvider(getDefaultSchemaTranslations),
-      new SettingsHoverProvider(getDefaultSchemaTranslations),
-      new BlockSettingsHoverProvider(getDefaultSchemaTranslations, getThemeBlockSchema),
-    ];
-    this.completionProviders = [
-      new SchemaTranslationsCompletionProvider(getDefaultSchemaTranslations),
-      new BlockTypeCompletionProvider(getThemeBlockNames),
-      new ReferencedBlockTypeCompletionProvider(getThemeBlockNames, getThemeBlockSchema),
-      new BlockSettingsPropertyCompletionProvider(
-        getDefaultSchemaTranslations,
-        getThemeBlockSchema,
-      ),
-      new SettingsPropertyCompletionProvider(getDefaultSchemaTranslations),
-    ];
+  constructor(private documentManager: DocumentManager) {
+    this.hoverProviders = [new TranslationPathHoverProvider()];
+    this.completionProviders = [];
   }
 
   async getInfoContribution(uri: string, location: JSONPath): Promise<MarkedString[]> {
@@ -130,21 +88,6 @@ export class JSONContributions implements JSONWorkerContribution {
   async collectDefaultCompletions(_uri: string, _result: CompletionsCollector): Promise<void> {}
 
   private async getContext(doc: AugmentedSourceCode): Promise<RequestContext> {
-    const context: RequestContext = {
-      doc,
-    };
-
-    if (doc.type === SourceCodeType.LiquidHtml && !(doc.ast instanceof Error)) {
-      const schema = await findSchemaNode(doc.ast);
-      if (!schema) return SKIP_CONTRIBUTION;
-      const jsonString = schema?.source.slice(
-        schema.blockStartPosition.end,
-        schema.blockEndPosition.start,
-      );
-      context.schema = schema;
-      context.parsed = parseJSON(jsonString);
-    }
-
-    return context;
+    return { doc };
   }
 }

package/src/json/JSONLanguageService.ts

@@ -1,15 +1,9 @@
-import { LiquidRawTag, NodeTypes } from '@platformos/liquid-html-parser';
 import {
   IsValidSchema,
   JsonValidationSet,
-  Mode,
-  Modes,
   SchemaDefinition,
   SourceCodeType,
-  findCurrentNode,
   isValid,
-  toJSONAST,
-  visit,
 } from '@platformos/platformos-check-common';
 import { JSONDocument, LanguageService, getLanguageService } from 'vscode-json-languageservice';
 import {
@@ -24,21 +18,12 @@ import {
 } from 'vscode-languageserver';
 import { TextDocument } from 'vscode-languageserver-textdocument';
 import { DocumentManager } from '../documents';
-import { GetTranslationsForURI } from '../translations';
-import { JSONContributions, GetThemeBlockNames, GetThemeBlockSchema } from './JSONContributions';
-import { createJSONDocumentLinksVisitor } from './documentLinks/DocumentLinksProvider';
-import { URI } from 'vscode-uri';
-import { FindThemeRootURI } from '../internal-types';
+import { JSONContributions } from './JSONContributions';
 
 export class JSONLanguageService {
-  // We index by Mode here because I don't want to reconfigure the service depending on the URI.
-  // This is because you may be in a "app" context in one folder, and in a "theme" context in another one.
-  // Because theme app extensions and themes do not share a common JSON schema for blocks/*.liquid files,
-  // we need to do this switch on mode here to figure out which language service we will use to power
-  // completions/hover. The mode comes from the theme check config.
-  private services: Record<Mode, LanguageService | null>;
-
-  // One record for all modes since collisions on URIs should point to the same schema
+  private service: LanguageService | null = null;
+
+  // One record for all schemas since collisions on URIs should point to the same schema
   private schemas: Record<string, SchemaDefinition>;
 
   // Setup state
@@ -48,13 +33,7 @@ export class JSONLanguageService {
   constructor(
     private documentManager: DocumentManager,
     private jsonValidationSet: JsonValidationSet,
-    private getDefaultSchemaTranslations: GetTranslationsForURI,
-    private getModeForURI: (uri: string) => Promise<Mode>,
-    private getThemeBlockNames: GetThemeBlockNames,
-    private getThemeBlockSchema: GetThemeBlockSchema,
-    private findThemeRootURI: FindThemeRootURI,
   ) {
-    this.services = Object.fromEntries(Modes.map((mode) => [mode, null])) as typeof this.services;
     this.schemas = {};
     this.initialized = new Promise((resolve) => {
       this.initialize = resolve;
@@ -62,14 +41,12 @@ export class JSONLanguageService {
   }
 
   async setup(clientCapabilities: LSPClientCapabilities) {
-    const promises = Modes.map(async (mode) => {
-      const schemas = await this.jsonValidationSet.schemas(mode);
-      for (const schema of schemas) {
-        this.schemas[schema.uri] = schema;
-      }
-
-      if (!schemas.length) return;
+    const schemas = await this.jsonValidationSet.schemas();
+    for (const schema of schemas) {
+      this.schemas[schema.uri] = schema;
+    }
 
+    if (schemas.length) {
       const service = getLanguageService({
         clientCapabilities,
 
@@ -86,14 +63,7 @@ export class JSONLanguageService {
           },
         },
 
-        contributions: [
-          new JSONContributions(
-            this.documentManager,
-            this.getDefaultSchemaTranslations,
-            this.getThemeBlockNames,
-            this.getThemeBlockSchema,
-          ),
-        ],
+        contributions: [new JSONContributions(this.documentManager)],
       });
 
       service.configure({
@@ -106,17 +76,15 @@ export class JSONLanguageService {
         })),
       });
 
-      this.services[mode] = service;
-    });
+      this.service = service;
+    }
 
-    await Promise.all(promises);
     this.initialize();
   }
 
   async completions(params: CompletionParams): Promise<null | CompletionList | CompletionItem[]> {
     await this.initialized;
-    const mode = await this.getModeForURI(params.textDocument.uri);
-    const service = this.services[mode];
+    const service = this.service;
     if (!service) return null;
     const documents = this.getDocuments(params, service);
     if (!documents) return null;
@@ -126,8 +94,7 @@ export class JSONLanguageService {
 
   async hover(params: HoverParams): Promise<Hover | null> {
     await this.initialized;
-    const mode = await this.getModeForURI(params.textDocument.uri);
-    const service = this.services[mode];
+    const service = this.service;
     if (!service) return null;
     const documents = this.getDocuments(params, service);
     if (!documents) return null;
@@ -135,52 +102,13 @@ export class JSONLanguageService {
     return service.doHover(jsonTextDocument, params.position, jsonDocument);
   }
 
-  async documentLinks(params: DocumentLinkParams): Promise<DocumentLink[]> {
-    await this.initialized;
-    const rootUri = await this.findThemeRootURI(params.textDocument.uri);
-    if (!rootUri) return [];
-
-    const document = this.documentManager.get(params.textDocument.uri);
-    if (!document) return [];
-
-    switch (document.type) {
-      case SourceCodeType.JSON: {
-        if (document.ast instanceof Error) return [];
-        const visitor = await createJSONDocumentLinksVisitor(
-          document.textDocument,
-          URI.parse(rootUri),
-        );
-        return visit(document.ast, visitor);
-      }
-
-      case SourceCodeType.LiquidHtml: {
-        if (document.ast instanceof Error) return [];
-        const textDocument = document.textDocument;
-        const links: DocumentLink[] = [];
-
-        const schema = await document.getSchema();
-        if (schema && !(schema.ast instanceof Error)) {
-          const visitor = await createJSONDocumentLinksVisitor(
-            textDocument,
-            URI.parse(rootUri),
-            schema.offset,
-          );
-          const schemaLinks = await visit(schema.ast, visitor);
-          links.push(...schemaLinks);
-        }
-
-        return links;
-      }
-
-      default:
-        return [];
-    }
+  async documentLinks(_params: DocumentLinkParams): Promise<DocumentLink[]> {
+    return [];
   }
 
   public isValidSchema = async (uri: string, jsonString: string) => {
     await this.initialized;
-    const mode = await this.getModeForURI(uri);
-    const service = this.services[mode];
+    const service = this.service;
     if (!service) return false;
     return isValid(service, uri, jsonString);
   };
@@ -194,40 +122,14 @@ export class JSONLanguageService {
 
     switch (document.type) {
       case SourceCodeType.GraphQL:
+      case SourceCodeType.LiquidHtml:
+      case SourceCodeType.YAML:
         return null;
       case SourceCodeType.JSON: {
         const jsonTextDocument = document.textDocument;
         const jsonDocument = service.parseJSONDocument(jsonTextDocument);
         return [jsonTextDocument, jsonDocument];
       }
-
-      case SourceCodeType.LiquidHtml: {
-        if (document.ast instanceof Error) return null;
-        const textDocument = document.textDocument;
-        const offset = textDocument.offsetAt(params.position);
-        const [_, ancestors] = findCurrentNode(document.ast, offset);
-        const schema = ancestors.find(
-          (node): node is LiquidRawTag =>
-            node.type === NodeTypes.LiquidRawTag && node.name === 'schema',
-        );
-        if (!schema) return null;
-
-        const schemaLineNumber = textDocument.positionAt(schema.blockStartPosition.end).line;
-        // Hacking away "same line numbers" here by prefixing the file with newlines
-        // This way params.position will be at the same line number in this fake jsonTextDocument
-        // Which means that the completions will be at the same line number in the Liquid document
-        const jsonString =
-          Array(schemaLineNumber).fill('\n').join('') +
-          schema.source.slice(schema.blockStartPosition.end, schema.blockEndPosition.start);
-        const jsonTextDocument = TextDocument.create(
-          textDocument.uri,
-          'json',
-          textDocument.version,
-          jsonString,
-        );
-        const jsonDocument = service.parseJSONDocument(jsonTextDocument);
-        return [jsonTextDocument, jsonDocument];
-      }
     }
   }
 

package/src/json/test/test-helpers.ts

@@ -5,10 +5,7 @@ import {
   HoverParams,
 } from 'vscode-languageserver-protocol';
 import { DocumentManager } from '../../documents';
-import { GetThemeBlockNames } from '../JSONContributions';
 import { JSONLanguageService } from '../JSONLanguageService';
-import { SourceCodeType } from '@platformos/platformos-check-common';
-import { GetTranslationsForURI } from '../../translations';
 
 export function getRequestParams(
   documentManager: DocumentManager,
@@ -33,36 +30,8 @@ export function isCompletionList(
   return completions !== null && !Array.isArray(completions);
 }
 
-export function mockJSONLanguageService(
-  rootUri: string,
-  documentManager: DocumentManager,
-  getDefaultSchemaTranslations: GetTranslationsForURI = async () => ({}),
-  getThemeBlockNames: GetThemeBlockNames = async () => [],
-) {
-  return new JSONLanguageService(
-    documentManager,
-    {
-      schemas: async () => [
-        {
-          uri: 'https://shopify.dev/block-schema.json',
-          schema: JSON.stringify({
-            $schema: 'http://json-schema.org/draft-07/schema#',
-          }),
-          fileMatch: ['**/{blocks,sections}/*.liquid'],
-        },
-      ],
-    },
-    getDefaultSchemaTranslations,
-    async () => 'theme',
-    getThemeBlockNames,
-    async (_uri: string, name: string) => {
-      const blockUri = `${rootUri}/blocks/${name}.liquid`;
-      const doc = documentManager.get(blockUri);
-      if (!doc || doc.type !== SourceCodeType.LiquidHtml) {
-        return;
-      }
-      return doc.getSchema();
-    },
-    async () => rootUri,
-  );
+export function mockJSONLanguageService(_rootUri: string, documentManager: DocumentManager) {
+  return new JSONLanguageService(documentManager, {
+    schemas: async () => [],
+  });
 }

package/src/json/utils.ts

@@ -1,30 +1,3 @@
-import { LiquidHtmlNode, LiquidRawTag } from '@platformos/liquid-html-parser';
-import { SourceCodeType, visit, Visitor } from '@platformos/platformos-check-common';
-
 export function fileMatch(uri: string, patterns: RegExp[]): boolean {
   return patterns.some((pattern) => pattern.test(uri));
 }
-
-export function isSectionFile(uri: string): boolean {
-  return /\/sections\/[^/]*\.liquid$/.test(uri);
-}
-
-export function isBlockFile(uri: string): boolean {
-  return /\/blocks\/[^/]*\.liquid$/.test(uri);
-}
-
-export function isSectionOrBlockFile(uri: string): boolean {
-  return isSectionFile(uri) || isBlockFile(uri);
-}
-
-export async function findSchemaNode(ast: LiquidHtmlNode): Promise<LiquidRawTag | undefined> {
-  const nodes = await visit(ast, {
-    async LiquidRawTag(node) {
-      if (node.name === 'schema') {
-        return node;
-      }
-    },
-  } as Visitor<SourceCodeType.LiquidHtml, LiquidRawTag>);
-
-  return nodes[0];
-}

package/src/rename/RenameProvider.ts

@@ -14,10 +14,10 @@ import { HtmlTagNameRenameProvider } from './providers/HtmlTagNameRenameProvider
 import { LiquidVariableRenameProvider } from './providers/LiquidVariableRenameProvider';
 import { Connection } from 'vscode-languageserver';
 import { ClientCapabilities } from '../ClientCapabilities';
-import { FindThemeRootURI } from '../internal-types';
+import { FindAppRootURI } from '../internal-types';
 
 /**
- * RenameProvider is responsible for providing rename support for the theme language server.
+ * RenameProvider is responsible for providing rename support for the platformOS language server.
  *
  * Rename is a pretty abstract concept, it can be renaming a tag name, a variable, a class name, etc.
  */
@@ -28,7 +28,7 @@ export class RenameProvider {
     connection: Connection,
     clientCapabilities: ClientCapabilities,
     private documentManager: DocumentManager,
-    findThemeRootURI: FindThemeRootURI,
+    findAppRootURI: FindAppRootURI,
   ) {
     this.providers = [
       new HtmlTagNameRenameProvider(documentManager),
@@ -36,7 +36,7 @@ export class RenameProvider {
         connection,
         clientCapabilities,
         documentManager,
-        findThemeRootURI,
+        findAppRootURI,
       ),
     ];
   }

package/src/rename/providers/LiquidVariableRenameProvider.spec.ts

@@ -10,7 +10,7 @@ const mockRoot = 'file:';
 
 describe('LiquidVariableRenameProvider', () => {
   const textDocumentUri = `${mockRoot}///app/views/partials/example-partial.liquid`;
-  const findThemeRootURI = async () => mockRoot;
+  const findAppRootURI = async () => mockRoot;
 
   let capabilities: ClientCapabilities;
   let connection: MockConnection;
@@ -39,7 +39,7 @@ describe('LiquidVariableRenameProvider', () => {
 
     beforeEach(() => {
       documentManager = new DocumentManager();
-      provider = new RenameProvider(connection, capabilities, documentManager, findThemeRootURI);
+      provider = new RenameProvider(connection, capabilities, documentManager, findAppRootURI);
 
       textDocument = TextDocument.create(textDocumentUri, 'liquid', 1, documentSource);
       documentManager.open(textDocument.uri, documentSource, 1);
@@ -198,7 +198,7 @@ describe('LiquidVariableRenameProvider', () => {
 
     beforeEach(() => {
       documentManager = new DocumentManager();
-      provider = new RenameProvider(connection, capabilities, documentManager, findThemeRootURI);
+      provider = new RenameProvider(connection, capabilities, documentManager, findAppRootURI);
     });
 
     ['for', 'tablerow'].forEach((tag) => {
@@ -371,7 +371,7 @@ describe('LiquidVariableRenameProvider', () => {
       );
 
       documentManager = new DocumentManager();
-      provider = new RenameProvider(connection, capabilities, documentManager, findThemeRootURI);
+      provider = new RenameProvider(connection, capabilities, documentManager, findAppRootURI);
 
       documentManager.open(textDocumentUri, textDocument.getText(), 1);
     });
@@ -507,5 +507,5 @@ function createSectionWithSource(
 }
 
 function getSectionUri(sectionName: string) {
-  return `${mockRoot}///sections/${sectionName}.liquid`;
+  return `${mockRoot}///app/views/partials/${sectionName}.liquid`;
 }

package/src/rename/providers/LiquidVariableRenameProvider.ts

@@ -30,7 +30,7 @@ import {
 import { TextDocument } from 'vscode-languageserver-textdocument';
 import { ClientCapabilities } from '../../ClientCapabilities';
 import { AugmentedLiquidSourceCode, DocumentManager, isLiquidSourceCode } from '../../documents';
-import { FindThemeRootURI } from '../../internal-types';
+import { FindAppRootURI } from '../../internal-types';
 import { partialName } from '../../utils/uri';
 import { BaseRenameProvider } from '../BaseRenameProvider';
 
@@ -39,7 +39,7 @@ export class LiquidVariableRenameProvider implements BaseRenameProvider {
     private connection: Connection,
     private clientCapabilities: ClientCapabilities,
     private documentManager: DocumentManager,
-    private findThemeRootURI: FindThemeRootURI,
+    private findAppRootURI: FindAppRootURI,
   ) {}
 
   async prepare(
@@ -74,7 +74,7 @@ export class LiquidVariableRenameProvider implements BaseRenameProvider {
     params: RenameParams,
   ): Promise<null | WorkspaceEdit> {
     const document = this.documentManager.get(params.textDocument.uri);
-    const rootUri = await this.findThemeRootURI(params.textDocument.uri);
+    const rootUri = await this.findAppRootURI(params.textDocument.uri);
     const textDocument = document?.textDocument;
 
     if (!rootUri || !textDocument || !node || !ancestors) return null;
@@ -104,8 +104,8 @@ export class LiquidVariableRenameProvider implements BaseRenameProvider {
     });
 
     if (this.clientCapabilities.hasApplyEditSupport && liquidDocParamUpdated) {
-      const themeFiles = this.documentManager.theme(rootUri, true);
-      const liquidSourceCodes = themeFiles.filter(isLiquidSourceCode);
+      const appFiles = this.documentManager.app(rootUri, true);
+      const liquidSourceCodes = appFiles.filter(isLiquidSourceCode);
       const name = partialName(params.textDocument.uri);
 
       await updateRenderTags(this.connection, liquidSourceCodes, name, oldName, params.newName);
@@ -242,7 +242,7 @@ async function updateRenderTags(
     const textDocument = sourceCode.textDocument;
     const edits: TextEdit[] = await visit<SourceCodeType.LiquidHtml, TextEdit>(sourceCode.ast, {
       async RenderMarkup(node: RenderMarkup) {
-        if (node.snippet.type !== NodeTypes.String || node.snippet.value !== partialName) {
+        if (node.partial.type !== NodeTypes.String || node.partial.value !== partialName) {
           return;
         }
 

package/src/renamed/RenameHandler.ts

@@ -2,11 +2,9 @@ import { Connection } from 'vscode-languageserver';
 import { RenameFilesParams } from 'vscode-languageserver-protocol';
 import { ClientCapabilities } from '../ClientCapabilities';
 import { DocumentManager } from '../documents';
-import { FindThemeRootURI } from '../internal-types';
+import { FindAppRootURI } from '../internal-types';
 import { BaseRenameHandler } from './BaseRenameHandler';
 import { AssetRenameHandler } from './handlers/AssetRenameHandler';
-import { BlockRenameHandler } from './handlers/BlockRenameHandler';
-import { SectionRenameHandler } from './handlers/SectionRenameHandler';
 import { PartialRenameHandler } from './handlers/PartialRenameHandler';
 
 /**
@@ -15,7 +13,6 @@ import { PartialRenameHandler } from './handlers/PartialRenameHandler';
  * Stuff we'll handle:
  * - When a partial is renamed, then we'll change all the render calls
  * - When an asset is renamed, then we'll change the asset_url calls
- * - etc.
  */
 export class RenameHandler {
   private handlers: BaseRenameHandler[];
@@ -23,13 +20,11 @@ export class RenameHandler {
     connection: Connection,
     capabilities: ClientCapabilities,
     documentManager: DocumentManager,
-    findThemeRootURI: FindThemeRootURI,
+    findAppRootURI: FindAppRootURI,
   ) {
     this.handlers = [
-      new PartialRenameHandler(documentManager, connection, capabilities, findThemeRootURI),
-      new AssetRenameHandler(documentManager, connection, capabilities, findThemeRootURI),
-      new BlockRenameHandler(documentManager, connection, capabilities, findThemeRootURI),
-      new SectionRenameHandler(documentManager, connection, capabilities, findThemeRootURI),
+      new PartialRenameHandler(documentManager, connection, capabilities, findAppRootURI),
+      new AssetRenameHandler(documentManager, connection, capabilities, findAppRootURI),
     ];
   }