@platformos/platformos-check-common 0.0.8 → 0.0.9

package/src/checks/undefined-object/index.ts

@@ -16,6 +16,7 @@ import {
   FunctionMarkup,
   LiquidTagHashAssign,
   LiquidTagGraphQL,
+  LiquidTagParseJson,
   LiquidTagBackground,
   BackgroundInlineMarkup,
 } from '@platformos/liquid-html-parser';
@@ -76,7 +77,7 @@ export const UndefinedObject: LiquidCheckDefinition = {
       async LiquidTag(node, ancestors) {
         if (isWithinRawTagThatDoesNotParseItsContents(ancestors)) return;
 
-        if (isLiquidTagAssign(node) || isLiquidTagGraphQL(node)) {
+        if (isLiquidTagAssign(node) || isLiquidTagGraphQL(node) || isLiquidTagParseJson(node)) {
           indexVariableScope(node.markup.name, {
             start: node.blockStartPosition.end,
           });
@@ -158,6 +159,7 @@ export const UndefinedObject: LiquidCheckDefinition = {
 
         const parent = last(ancestors);
         if (isLiquidTag(parent) && isLiquidTagCapture(parent)) return;
+        if (isLiquidTag(parent) && isLiquidTagParseJson(parent)) return;
 
         // Skip the jobId variable in background tag markup - it's being defined, not used
         if (isBackgroundInlineMarkup(parent) && parent.jobId === node) return;
@@ -275,6 +277,10 @@ function isLiquidTagGraphQL(node: LiquidTag): node is LiquidTagGraphQL {
   return node.name === NamedTags.graphql && typeof node.markup !== 'string';
 }
 
+function isLiquidTagParseJson(node: LiquidTag): node is LiquidTagParseJson {
+  return node.name === NamedTags.parse_json && typeof node.markup !== 'string';
+}
+
 function isLiquidForTag(node: LiquidTag): node is LiquidTagFor {
   return node.name === NamedTags.for && typeof node.markup !== 'string';
 }

package/src/checks/unused-assign/index.ts

@@ -14,7 +14,7 @@ export const UnusedAssign: LiquidCheckDefinition = {
     name: 'Prevent unused assigns',
     docs: {
       description:
-        'This check exists to prevent bloat in themes by surfacing variable definitions that are not used.',
+        'This check exists to prevent bloat by surfacing variable definitions that are not used.',
       recommended: true,
       url: 'https://documentation.platformos.com/developer-guide/platformos-check/checks/unused-assign',
     },

package/src/checks/valid-json/index.ts

@@ -7,7 +7,7 @@ export const ValidJSON: JSONCheckDefinition = {
     name: 'Enforce valid JSON',
     docs: {
       description:
-        'This check exists to prevent invalid JSON files in themes. Will check against schema if available.',
+        'This check exists to prevent invalid JSON files in apps. Will check against schema if available.',
       recommended: true,
       url: 'https://documentation.platformos.com/developer-guide/platformos-check/checks/json-syntax-error',
     },

package/src/checks/valid-render-partial-argument-types/index.spec.ts

@@ -41,7 +41,7 @@ describe('Module: ValidRenderPartialParamTypes', () => {
 
     for (const test of typeTests) {
       describe(`${test.type} validation`, () => {
-        const makeSnippet = (type: string) => `
+        const makePartial = (type: string) => `
           {% doc %}
             @param {${type}} param - Description
           {% enddoc %}
@@ -57,7 +57,7 @@ describe('Module: ValidRenderPartialParamTypes', () => {
               undefined,
               {},
               {
-                'app/views/partials/card.liquid': makeSnippet(test.type),
+                'app/views/partials/card.liquid': makePartial(test.type),
               },
             );
             expect(offenses).toHaveLength(0);
@@ -73,7 +73,7 @@ describe('Module: ValidRenderPartialParamTypes', () => {
               undefined,
               {},
               {
-                'app/views/partials/card.liquid': makeSnippet(test.type),
+                'app/views/partials/card.liquid': makePartial(test.type),
               },
             );
             expect(offenses).toHaveLength(1);
@@ -226,7 +226,7 @@ describe('Module: ValidRenderPartialParamTypes', () => {
   });
 
   describe('suggestions', () => {
-    const makeSnippet = (type: string) => `
+    const makePartial = (type: string) => `
       {% doc %}
         @param {${type}} param - Description
       {% enddoc %}
@@ -241,7 +241,7 @@ describe('Module: ValidRenderPartialParamTypes', () => {
         undefined,
         {},
         {
-          'app/views/partials/card.liquid': makeSnippet('string'),
+          'app/views/partials/card.liquid': makePartial('string'),
         },
       );
 
@@ -291,7 +291,7 @@ describe('Module: ValidRenderPartialParamTypes', () => {
         undefined,
         {},
         {
-          'app/views/partials/card.liquid': makeSnippet('string'),
+          'app/views/partials/card.liquid': makePartial('string'),
         },
       );
 
@@ -338,7 +338,7 @@ describe('Module: ValidRenderPartialParamTypes', () => {
         undefined,
         {},
         {
-          'app/views/partials/card.liquid': makeSnippet('string'),
+          'app/views/partials/card.liquid': makePartial('string'),
         },
       );
 
@@ -356,7 +356,7 @@ describe('Module: ValidRenderPartialParamTypes', () => {
         undefined,
         {},
         {
-          'app/views/partials/card.liquid': makeSnippet('string'),
+          'app/views/partials/card.liquid': makePartial('string'),
         },
       );
 
@@ -376,7 +376,7 @@ describe('Module: ValidRenderPartialParamTypes', () => {
         undefined,
         {},
         {
-          'app/views/partials/card.liquid': makeSnippet('string'),
+          'app/views/partials/card.liquid': makePartial('string'),
         },
       );
 
@@ -396,7 +396,7 @@ describe('Module: ValidRenderPartialParamTypes', () => {
         undefined,
         {},
         {
-          'app/views/partials/card.liquid': makeSnippet('string'),
+          'app/views/partials/card.liquid': makePartial('string'),
         },
       );
 
@@ -414,7 +414,7 @@ describe('Module: ValidRenderPartialParamTypes', () => {
         undefined,
         {},
         {
-          'app/views/partials/card.liquid': makeSnippet('object'),
+          'app/views/partials/card.liquid': makePartial('object'),
         },
       );
 
@@ -431,7 +431,7 @@ describe('Module: ValidRenderPartialParamTypes', () => {
         undefined,
         {},
         {
-          'app/views/partials/card.liquid': makeSnippet('string'),
+          'app/views/partials/card.liquid': makePartial('string'),
         },
       );
 
@@ -452,7 +452,7 @@ describe('Module: ValidRenderPartialParamTypes', () => {
         undefined,
         {},
         {
-          'app/views/partials/card.liquid': makeSnippet('string'),
+          'app/views/partials/card.liquid': makePartial('string'),
         },
       );
 

package/src/context-utils.ts

@@ -1,8 +1,49 @@
 import { load } from 'js-yaml';
-import { AbstractFileSystem, FileTuple, FileType, UriString } from '@platformos/platformos-common';
+import {
+  AbstractFileSystem,
+  FileTuple,
+  FileType,
+  TranslationProvider,
+  UriString,
+} from '@platformos/platformos-common';
+import { URI } from 'vscode-uri';
 import { join } from './path';
 import { SourceCodeType, App, Translations } from './types';
 
+/**
+ * Returns a function that loads and merges ALL translation files for a given
+ * locale within a specific translations base directory URI
+ * (e.g. `file:///app/translations` or
+ * `file:///modules/common-styling/public/translations`).
+ *
+ * Covers both the single-file layout (`{base}/{locale}.yml`) and the split-file
+ * layout (`{base}/{locale}/*.yml`).
+ *
+ * Only files whose first YAML key matches `locale` are included — this mirrors
+ * how platformOS determines a file's locale from its content, not its path.
+ *
+ * In-memory editor buffers take precedence over the filesystem so that unsaved
+ * changes are reflected immediately.
+ */
+export const makeGetTranslationsForBase = (fs: AbstractFileSystem, app: App) => {
+  const provider = new TranslationProvider(fs);
+  const cache = new Map<string, Promise<Translations>>();
+
+  return (translationBaseUri: string, locale: string): Promise<Translations> => {
+    const key = `${translationBaseUri}::${locale}`;
+    if (!cache.has(key)) {
+      const contentOverride = (uri: string): string | undefined =>
+        app.find((sc) => sc.type === SourceCodeType.YAML && sc.uri === uri)?.source;
+
+      cache.set(
+        key,
+        provider.loadAllTranslationsForBase(URI.parse(translationBaseUri), locale, contentOverride),
+      );
+    }
+    return cache.get(key)!;
+  };
+};
+
 export type FileExists = (uri: string) => Promise<boolean>;
 
 export const makeFileExists = (fs: AbstractFileSystem): FileExists =>

package/src/disabled-checks/index.spec.ts

@@ -34,10 +34,10 @@ describe('Module: DisabledChecks', () => {
   describe(`Comment variant`, () => {
     it('should disable checks for the entire document if comment is placed on the first line', async () => {
       for (const buildComment of commentTypes) {
-        const file = `${buildComment('theme-check-disable LiquidFilter')}
+        const file = `${buildComment('platformos-check-disable LiquidFilter')}
 {% comment %}
   This is some comment about the file...
-  Adding a comment here should not mess with theme-check-disable
+  Adding a comment here should not mess with platformos-check-disable
 {% endcomment %}
 {{ 'asset' | random_filter }}
 {% render 'something' %}`;
@@ -50,7 +50,7 @@ describe('Module: DisabledChecks', () => {
 
     it('should disable all checks even if comment has additional spaces', async () => {
       for (const buildComment of commentTypes) {
-        const file = `${buildComment('  theme-check-disable     ')}
+        const file = `${buildComment('  platformos-check-disable     ')}
 {{ 'asset' | random_filter }}
 {% render 'something' %}`;
 
@@ -63,10 +63,10 @@ describe('Module: DisabledChecks', () => {
       for (const buildComment of commentTypes) {
         const file = `{{ 'asset-1' | random_filter }}
 {% render 'something-1' %}
-${buildComment('theme-check-disable')}
+${buildComment('platformos-check-disable')}
 {{ 'asset-2' | random_filter }}
 {% render 'something-2' %}
-${buildComment('theme-check-enable')}
+${buildComment('platformos-check-enable')}
 {{ 'asset-3' | random_filter }}`;
 
         const offenses = await check({ 'code.liquid': file }, checks);
@@ -79,10 +79,10 @@ ${buildComment('theme-check-enable')}
 
     it('should disable a specific check if check is included in the comment', async () => {
       for (const buildComment of commentTypes) {
-        const file = `${buildComment('theme-check-disable LiquidFilter')}
+        const file = `${buildComment('platformos-check-disable LiquidFilter')}
 {{ 'asset-1' | random_filter }}
 {% render 'something' %}
-${buildComment('theme-check-enable LiquidFilter')}
+${buildComment('platformos-check-enable LiquidFilter')}
 {{ 'asset-2' | random_filter }}`;
 
         const offenses = await check({ 'code.liquid': file }, checks);
@@ -94,10 +94,10 @@ ${buildComment('theme-check-enable LiquidFilter')}
 
     it('should disable multiple checks if checks are separated by a comma (and maybe some spaces)', async () => {
       for (const buildComment of commentTypes) {
-        const file = `${buildComment('theme-check-disable LiquidFilter, RenderMarkup')}
+        const file = `${buildComment('platformos-check-disable LiquidFilter, RenderMarkup')}
 {{ 'asset-1' | random_filter }}
 {% render 'something' %}
-${buildComment('theme-check-enable LiquidFilter,RenderMarkup')}
+${buildComment('platformos-check-enable LiquidFilter,RenderMarkup')}
 {{ 'asset-2' | random_filter }}`;
 
         const offenses = await check({ 'code.liquid': file }, checks);
@@ -108,13 +108,13 @@ ${buildComment('theme-check-enable LiquidFilter,RenderMarkup')}
 
     it('should enable specific checks individually', async () => {
       for (const buildComment of commentTypes) {
-        const file = `${buildComment('theme-check-disable LiquidFilter, RenderMarkup')}
+        const file = `${buildComment('platformos-check-disable LiquidFilter, RenderMarkup')}
 {{ 'asset-1' | random_filter }}
 {% render 'something-1' %}
-${buildComment('theme-check-enable RenderMarkup')}
+${buildComment('platformos-check-enable RenderMarkup')}
 {{ 'asset-2' | random_filter }}
 {% render 'something-2' %}
-${buildComment('theme-check-enable LiquidFilter')}
+${buildComment('platformos-check-enable LiquidFilter')}
 {{ 'asset-3' | random_filter }}
 {% render 'something-3' %}`;
 
@@ -129,10 +129,10 @@ ${buildComment('theme-check-enable LiquidFilter')}
     describe('Mix of general and specific commands', () => {
       it('should not reenable specific check when all checks have been disabled before', async () => {
         for (const buildComment of commentTypes) {
-          const file = `${buildComment('theme-check-disable')}
+          const file = `${buildComment('platformos-check-disable')}
 {{ 'asset-1' | random_filter }}
 {% render 'something-1' %}
-${buildComment('theme-check-enable RenderMarkup')}
+${buildComment('platformos-check-enable RenderMarkup')}
 {{ 'asset-2' | random_filter }}
 {% render 'something-2' %}`;
           const offenses = await check({ 'code.liquid': file }, checks);
@@ -142,10 +142,10 @@ ${buildComment('theme-check-enable RenderMarkup')}
 
       it('should reenable all checks when specific ones have been disabled before', async () => {
         for (const buildComment of commentTypes) {
-          const file = `${buildComment('theme-check-disable LiquidFilter, RenderMarkup')}
+          const file = `${buildComment('platformos-check-disable LiquidFilter, RenderMarkup')}
 {{ 'asset-3' | random_filter }}
 {% render 'something-3' %}
-${buildComment('theme-check-enable')}
+${buildComment('platformos-check-enable')}
 {{ 'asset-4' | random_filter }}
 {% render 'something-4' %}`;
 
@@ -159,7 +159,7 @@ ${buildComment('theme-check-enable')}
 
     describe('disable next line', () => {
       it('should disable the next line if there is one', async () => {
-        const file = `{% # theme-check-disable-next-line %}
+        const file = `{% # platformos-check-disable-next-line %}
 {% render 'something' %}
 {% render 'other-thing' %}`;
 
@@ -168,8 +168,8 @@ ${buildComment('theme-check-enable')}
         expectRenderMarkupOffense(offenses, 'other-thing.liquid');
       });
 
-      it("should not disable the liquid tag's children node if theme check is disabled", async () => {
-        const file = `{% # theme-check-disable-next-line %}
+      it("should not disable the liquid tag's children node if platformos-check is disabled", async () => {
+        const file = `{% # platformos-check-disable-next-line %}
 {% if condition %}
   {% render 'something' %}
 {% endif %}
@@ -183,7 +183,7 @@ ${buildComment('theme-check-enable')}
 
       it('should disable the next line inside a liquid tag if there is one', async () => {
         const file = `{% liquid
-  # theme-check-disable-next-line
+  # platformos-check-disable-next-line
   render 'something'
   render 'other-thing'
 %}`;
@@ -193,10 +193,10 @@ ${buildComment('theme-check-enable')}
         expectRenderMarkupOffense(offenses, 'other-thing.liquid');
       });
 
-      it("should disable the parent node's next node if theme check is disabled as the last child node", async () => {
+      it("should disable the parent node's next node if platformos-check is disabled as the last child node", async () => {
         const file = `{% liquid
   if condition
-    # theme-check-disable-next-line
+    # platformos-check-disable-next-line
   elsif other_condition
   endif
 %}`;
@@ -210,11 +210,11 @@ ${buildComment('theme-check-enable')}
         );
       });
 
-      it('should not disable any checks if theme-check is disabled at the end', async () => {
+      it('should not disable any checks if platformos-check is disabled at the end', async () => {
         const file = `{% liquid
   echo hello
   echo everyone
-  # theme-check-disable-next-line
+  # platformos-check-disable-next-line
 %}`;
 
         const offenses = await check({ 'code.liquid': file }, [UndefinedObject]);
@@ -232,7 +232,7 @@ ${buildComment('theme-check-enable')}
       });
 
       it('should disable the next line if the content is an HTML tag with liquid', async () => {
-        const file = `{% # theme-check-disable-next-line %}
+        const file = `{% # platformos-check-disable-next-line %}
 <div class="{{ foo }}"></div>
 <div class="{{ bar }}"></div>`;
 
@@ -246,7 +246,7 @@ ${buildComment('theme-check-enable')}
       });
 
       it('should not disable the next line if the specified rule does not exist', async () => {
-        const file = `{% # theme-check-disable-next-line FAKE_RULE %}
+        const file = `{% # platformos-check-disable-next-line FAKE_RULE %}
 <div class="{{ foo }}"></div>`;
 
         const offenses = await check({ 'code.liquid': file }, [UndefinedObject]);
@@ -259,39 +259,4 @@ ${buildComment('theme-check-enable')}
       });
     });
   });
-
-  describe('platformos-check prefix', () => {
-    it('should disable checks using platformos-check-disable prefix', async () => {
-      for (const buildComment of commentTypes) {
-        const file = `${buildComment('platformos-check-disable LiquidFilter')}
-{{ 'asset' | random_filter }}
-{% render 'something' %}`;
-
-        const offenses = await check({ 'code.liquid': file }, checks);
-        expect(offenses).to.have.length(1);
-        expectRenderMarkupOffense(offenses, 'something.liquid');
-      }
-    });
-
-    it('should disable all checks using platformos-check-disable prefix', async () => {
-      for (const buildComment of commentTypes) {
-        const file = `${buildComment('platformos-check-disable')}
-{{ 'asset' | random_filter }}
-{% render 'something' %}`;
-
-        const offenses = await check({ 'code.liquid': file }, checks);
-        expect(offenses).to.have.length(0);
-      }
-    });
-
-    it('should disable next line using platformos-check-disable-next-line prefix', async () => {
-      const file = `{% # platformos-check-disable-next-line %}
-{% render 'something' %}
-{% render 'other-thing' %}`;
-
-      const offenses = await check({ 'code.liquid': file }, checks);
-      expect(offenses).to.have.length(1);
-      expectRenderMarkupOffense(offenses, 'other-thing.liquid');
-    });
-  });
 });

package/src/disabled-checks/index.ts

@@ -24,9 +24,7 @@ export function createDisabledChecksModule() {
     node: LiquidTag | LiquidRawTag,
   ) {
     const [_, command, checksJoined] =
-      value
-        .trim()
-        .match(/^(?:(?:platformos|theme)\-check\-(disable-next-line|disable|enable)) ?(.*)/) || [];
+      value.trim().match(/^(?:platformos\-check\-(disable-next-line|disable|enable)) ?(.*)/) || [];
 
     const checks = checksJoined ? checksJoined.split(/,[ ]*/) : [SPECIFIC_CHECK_NOT_DEFINED];
 
@@ -135,7 +133,7 @@ export function findNextLinePosition(
    * E.g. The following disables check for `elsif` tag
    *
    * {% if condition %}
-   *   {% #platformos-check-disable-next-line %}
+   *   {% # platformos-check-disable-next-line %}
    * {% elsif other_condition %}
    *   {{ prouduct }}
    * {% endif %}

package/src/disabled-checks/test-checks.ts

@@ -45,14 +45,14 @@ export const RenderMarkup: LiquidCheckDefinition = {
   create(context) {
     return {
       async RenderMarkup(node) {
-        if (node.snippet.type === NodeTypes.VariableLookup) {
+        if (node.partial.type === NodeTypes.VariableLookup) {
           return;
         }
 
         context.report({
-          message: `'${node.snippet.value}.liquid' can not be rendered`,
-          startIndex: node.snippet.position.start,
-          endIndex: node.snippet.position.end,
+          message: `'${node.partial.value}.liquid' can not be rendered`,
+          startIndex: node.partial.position.start,
+          endIndex: node.partial.position.end,
         });
       },
     };

package/src/ignore.spec.ts

@@ -47,7 +47,7 @@ describe('Function: isIgnored', () => {
     const result = isIgnored(
       toUri('app/views/partials/foo.liquid'),
       config({
-        checkIgnore: ['!snippets/*'],
+        checkIgnore: ['!other-dir/*'],
         globalIgnore: [],
       }),
       checkDef,
@@ -73,7 +73,7 @@ describe('Function: isIgnored', () => {
     const result = isIgnored(
       toUri('app/views/partials/foo.liquid'),
       config({
-        checkIgnore: ['other-snippets/*.liquid'],
+        checkIgnore: ['other-dir/*.liquid'],
         globalIgnore: [],
       }),
       checkDef,
@@ -165,10 +165,10 @@ describe('Function: isIgnored', () => {
 
   it('should work with only global ignore as well', () => {
     const result = isIgnored(
-      toUri('layout/theme.liquid'),
+      toUri('app/views/layouts/layout.liquid'),
       config({
         checkIgnore: [],
-        globalIgnore: ['layout/theme.liquid'],
+        globalIgnore: ['app/views/layouts/layout.liquid'],
       }),
     );
 

package/src/index.ts

@@ -5,6 +5,7 @@ import {
   makeFileSize,
   makeGetDefaultLocale,
   makeGetDefaultTranslations,
+  makeGetTranslationsForBase,
 } from './context-utils';
 import { createDisabledChecksModule } from './disabled-checks';
 import { isIgnored } from './ignore';
@@ -47,6 +48,22 @@ export * from './context-utils';
 export * from './find-root';
 export * from './fixes';
 export * from './ignore';
+export {
+  FILE_TYPE_DIRS,
+  getAppPaths,
+  getFileType,
+  getModulePaths,
+  isApiCall,
+  isAuthorization,
+  isEmail,
+  isKnownLiquidFile,
+  isLayout,
+  isMigration,
+  isPage,
+  isPartial,
+  isSms,
+  PlatformOSFileType,
+} from '@platformos/platformos-common';
 export * from './json';
 export * from './JSONValidator';
 export * as path from './path';
@@ -80,6 +97,7 @@ export async function check(
     fileSize: makeFileSize(fs),
     getDefaultLocale: makeGetDefaultLocale(fs, rootUri),
     getDefaultTranslations: makeGetDefaultTranslations(fs, app, rootUri),
+    getTranslationsForBase: makeGetTranslationsForBase(fs, app),
   };
 
   const { DisabledChecksVisitor, isDisabled } = createDisabledChecksModule();

package/src/liquid-doc/arguments.ts

@@ -121,7 +121,13 @@ export function findTypeMismatchParams(
   const typeMismatchParams: LiquidNamedArgument[] = [];
 
   for (const arg of providedParams) {
-    if (arg.value.type === NodeTypes.VariableLookup) {
+    // Skip if the value is a variable lookup (can't determine type statically)
+    // or if it has filters (graphql args may have filters, output type is unknown)
+    if (arg.value.type === NodeTypes.LiquidVariable) {
+      if (arg.value.expression.type === NodeTypes.VariableLookup || arg.value.filters.length > 0) {
+        continue;
+      }
+    } else if (arg.value.type === NodeTypes.VariableLookup) {
       continue;
     }
 
@@ -212,10 +218,10 @@ function isLastArg(node: RenderMarkup | FunctionMarkup, arg: LiquidNamedArgument
 
 export function getPartialName(node: RenderMarkup | FunctionMarkup): string | undefined {
   if (node.type === NodeTypes.RenderMarkup) {
-    if (!isLiquidString(node.snippet)) {
+    if (!isLiquidString(node.partial)) {
       return;
     }
-    return node.snippet.value;
+    return node.partial.value;
   }
 
   if (node.type === NodeTypes.FunctionMarkup) {

package/src/liquid-doc/liquidDoc.spec.ts

@@ -238,7 +238,7 @@ describe('Unit: extractDocDefinition', () => {
     });
   });
 
-  it('should return snippetDefinition without liquidDoc property if doc header is not present', async () => {
+  it('should return partialDefinition without liquidDoc property if doc header is not present', async () => {
     const ast = toAST(`
       <div>No doc header here</div>
     `);

package/src/liquid-doc/utils.ts

@@ -1,4 +1,4 @@
-import { LiquidExpression, NodeTypes } from '@platformos/liquid-html-parser';
+import { LiquidExpression, LiquidVariable, NodeTypes } from '@platformos/liquid-html-parser';
 import { assertNever } from '../utils';
 import { isPartial } from '../path';
 import { ObjectEntry, UriString } from '../types';
@@ -6,7 +6,7 @@ import { ObjectEntry, UriString } from '../types';
 /**
  * The base set of supported param types for LiquidDoc.
  *
- * This is used in conjunction with objects defined in [liquid docs](https://shopify.dev/docs/api/liquid/objects)
+ * This is used in conjunction with objects defined in [liquid docs](https://documentation.platformos.com/api-reference/liquid/objects)
  * to determine ALL supported param types for LiquidDoc.
  *
  * References `getValidParamTypes`
@@ -35,7 +35,7 @@ export function getDefaultValueForType(type: string | null) {
       return '0';
     case BasicParamTypes.Boolean:
       return 'false';
-    case BasicParamTypes.Object: // Objects don't have a sensible default value (maybe `theme`?)
+    case BasicParamTypes.Object: // Objects don't have a sensible default value
     default:
       return '';
   }
@@ -44,7 +44,15 @@ export function getDefaultValueForType(type: string | null) {
 /**
  * Casts the value of a LiquidNamedArgument to a string representing the type of the value.
  */
-export function inferArgumentType(arg: LiquidExpression): BasicParamTypes {
+export function inferArgumentType(arg: LiquidExpression | LiquidVariable): BasicParamTypes {
+  if (arg.type === NodeTypes.LiquidVariable) {
+    // A variable with filters — delegate to the base expression if there are no filters,
+    // otherwise we can't statically determine the filtered output type.
+    if (arg.filters.length > 0) return BasicParamTypes.Object;
+    const expr = arg.expression;
+    if (expr.type === NodeTypes.BooleanExpression) return BasicParamTypes.Object;
+    return inferArgumentType(expr);
+  }
   switch (arg.type) {
     case NodeTypes.String:
       return BasicParamTypes.String;
@@ -87,7 +95,7 @@ export function filePathSupportsLiquidDoc(uri: UriString) {
 
 /**
  * Dynamically generates a map of LiquidDoc param types using object entries from
- * [liquid docs](https://shopify.dev/docs/api/liquid/objects).
+ * [liquid docs](https://documentation.platformos.com/api-reference/liquid/objects).
  *
  * This is used in conjunction with the base set of supported param.
  *

package/src/path.ts

@@ -1,6 +1,21 @@
 import { RelativePath, UriString } from './types';
 import { URI, Utils } from 'vscode-uri';
-export { isPartial, isLayout, isPage } from '@platformos/platformos-common';
+export {
+  isPartial,
+  isLayout,
+  isPage,
+  isAuthorization,
+  isEmail,
+  isApiCall,
+  isSms,
+  isMigration,
+  isKnownLiquidFile,
+  getFileType,
+  getAppPaths,
+  getModulePaths,
+  PlatformOSFileType,
+  FILE_TYPE_DIRS,
+} from '@platformos/platformos-common';
 
 export { URI, Utils };