@platformos/platformos-check-common 0.0.19 → 0.0.20

package/src/checks/utils.ts

@@ -9,6 +9,7 @@ import {
   AttrUnquoted,
   LiquidHtmlNode,
   LiquidBranch,
+  LiquidLiteralValues,
   LiquidTagFor,
   LiquidTagTablerow,
   LiquidTag,
@@ -16,6 +17,16 @@ import {
 } from '@platformos/liquid-html-parser';
 import { LiquidHtmlNodeOfType as NodeOfType } from '../types';
 
+/**
+ * Names that Liquid resolves as built-in literals before looking up variables
+ * (Liquid::Expression::LITERALS in the backend, `LiquidLiteralValues` in the
+ * parser grammar). Assigning to them succeeds silently, but reading them
+ * always returns the literal, never the assigned value.
+ */
+export const RESERVED_VARIABLE_NAMES: ReadonlySet<string> = new Set(
+  Object.keys(LiquidLiteralValues),
+);
+
 type ElementType<T> = T extends (infer E)[] ? E : never;
 
 export type ValuedHtmlAttribute = AttrSingleQuoted | AttrDoubleQuoted | AttrUnquoted;

package/src/find-root.ts

@@ -3,13 +3,28 @@ import * as path from './path';
 
 type FileExists = (uri: string) => Promise<boolean>;
 
+function isInsideApp(dir: UriString): boolean {
+  let current = dir;
+  while (true) {
+    const parent = path.dirname(current);
+    if (parent === current) return false;
+    if (path.basename(parent) === 'app') return true;
+    current = parent;
+  }
+}
+
 async function isRoot(dir: UriString, fileExists: FileExists) {
   return or(
     fileExists(path.join(dir, '.pos')),
     fileExists(path.join(dir, '.platformos-check.yml')),
     fileExists(path.join(dir, 'app')),
-    // modules/ is a root indicator only when not inside app/ (app/modules/ is a valid subdirectory)
-    and(fileExists(path.join(dir, 'modules')), Promise.resolve(path.basename(dir) !== 'app')),
+    // modules/ is a root indicator only when not inside an app/ subtree.
+    // app/modules/ is a valid subdirectory, and app/views/partials/modules/ is a
+    // legitimate partial organization that should not be mistaken for a project root.
+    and(
+      fileExists(path.join(dir, 'modules')),
+      Promise.resolve(path.basename(dir) !== 'app' && !isInsideApp(dir)),
+    ),
   );
 }
 

package/src/index.ts

@@ -60,11 +60,13 @@ export {
   isFormConfiguration,
   isKnownGraphQLFile,
   isKnownLiquidFile,
+  isKnownYAMLFile,
   isLayout,
   isMigration,
   isPage,
   isPartial,
   isSms,
+  isSupportedSourceFile,
   PlatformOSFileType,
 } from '@platformos/platformos-common';
 export * from './frontmatter';

package/src/types.ts

@@ -315,6 +315,22 @@ export type Translations = {
  *   target: 'file:///app/views/partials/child.liquid'
  * }
  */
+/**
+ * The semantic Liquid construct that created a {@link Reference} edge.
+ *
+ * Optional/additive: older producers may omit it. Lets consumers distinguish a
+ * `{% render %}` edge from an `{% include %}` / `{% function %}` / `{% graphql %}`
+ * / `{% background %}` / asset / layout-association edge without re-parsing.
+ */
+export type ReferenceKind =
+  | 'render'
+  | 'include'
+  | 'function'
+  | 'background'
+  | 'graphql'
+  | 'asset'
+  | 'layout';
+
 export type Reference = {
   source: Location;
   target: Location;
@@ -322,6 +338,9 @@ export type Reference = {
   type:
     | 'direct' // explicit dependency, e.g. {% render 'partial' %}
     | 'indirect'; // indirect dependency
+
+  /** Which Liquid construct produced this edge. Optional for backwards compatibility. */
+  kind?: ReferenceKind;
 };
 
 export type Range = [start: number, end: number]; // represents a range in the source code