@platformatic/wattpm-pprof-capture 3.21.0 → 3.23.0

package/index.js

@@ -2,6 +2,7 @@ import { time, heap, SourceMapper } from '@datadog/pprof'
 import { performance } from 'node:perf_hooks'
 import { workerData } from 'node:worker_threads'
 import { NoProfileAvailableError, NotEnoughELUError, ProfilingAlreadyStartedError, ProfilingNotStartedError } from './lib/errors.js'
+import { SourceMapperWrapper } from './lib/source-mapper-wrapper.js'
 
 const kITC = Symbol.for('plt.runtime.itc')
 
@@ -9,55 +10,6 @@ const kITC = Symbol.for('plt.runtime.itc')
 let sourceMapper = null
 let sourceMapperInitialized = false
 
-/**
- * Wrapper around SourceMapper that fixes Windows path normalization issues.
- *
- * On Windows, V8 profiler returns paths like `file:///D:/path/to/file.js`.
- * The @datadog/pprof library removes `file://` leaving `/D:/path/to/file.js`,
- * but SourceMapper stores paths as `D:\path\to\file.js`.
- *
- * This wrapper normalizes Windows paths to match the internal format.
- */
-class SourceMapperWrapper {
-  constructor (innerMapper) {
-    this.innerMapper = innerMapper
-    this.debug = innerMapper.debug
-  }
-
-  /**
-   * Normalize Windows-style paths from V8 profiler to match SourceMapper format.
-   * Handles paths like `/D:/path/to/file.js` -> `D:\path\to\file.js`
-   */
-  normalizePath (filePath) {
-    if (process.platform !== 'win32') {
-      return filePath
-    }
-
-    // Handle paths like /D:/path/to/file -> D:\path\to\file
-    // This happens because pprof removes 'file://' from 'file:///D:/path/to/file'
-    if (filePath.startsWith('/') && filePath.length > 2 && filePath[2] === ':') {
-      // Remove leading slash and convert forward slashes to backslashes
-      return filePath.slice(1).replace(/\//g, '\\')
-    }
-
-    // Also convert any forward slashes to backslashes on Windows
-    return filePath.replace(/\//g, '\\')
-  }
-
-  hasMappingInfo (inputPath) {
-    const normalized = this.normalizePath(inputPath)
-    return this.innerMapper.hasMappingInfo(normalized)
-  }
-
-  mappingInfo (location) {
-    const normalized = {
-      ...location,
-      file: this.normalizePath(location.file)
-    }
-    return this.innerMapper.mappingInfo(normalized)
-  }
-}
-
 // Track ELU globally (shared across all profiler types)
 let lastELU = null
 let previousELU = performance.eventLoopUtilization()

package/lib/source-mapper-wrapper.js

@@ -0,0 +1,65 @@
+/**
+ * Wrapper around SourceMapper that fixes Windows path normalization issues.
+ *
+ * On Windows, V8 profiler returns paths like `file:///D:/path/to/file.js`.
+ * The @datadog/pprof library removes `file://` leaving `/D:/path/to/file.js`,
+ * but SourceMapper stores paths as `D:\path\to\file.js`.
+ *
+ * This wrapper normalizes Windows paths to match the internal format.
+ */
+export class SourceMapperWrapper {
+  constructor (innerMapper) {
+    this.innerMapper = innerMapper
+    this.debug = innerMapper.debug
+  }
+
+  /**
+   * Normalize Windows-style paths from V8 profiler to match SourceMapper format.
+   * Handles paths like `/D:/path/to/file.js` -> `D:\path\to\file.js`
+   */
+  normalizePath (filePath) {
+    if (process.platform !== 'win32') {
+      return filePath
+    }
+
+    // Handle paths like /D:/path/to/file -> D:\path\to\file
+    // This happens because pprof removes 'file://' from 'file:///D:/path/to/file'
+    if (filePath.startsWith('/') && filePath.length > 2 && filePath[2] === ':') {
+      // Remove leading slash and convert forward slashes to backslashes
+      return filePath.slice(1).replace(/\//g, '\\')
+    }
+
+    // Also convert any forward slashes to backslashes on Windows
+    return filePath.replace(/\//g, '\\')
+  }
+
+  hasMappingInfo (inputPath) {
+    const normalized = this.normalizePath(inputPath)
+    return this.innerMapper.hasMappingInfo(normalized)
+  }
+
+  mappingInfo (location) {
+    const normalized = {
+      ...location,
+      file: this.normalizePath(location.file)
+    }
+
+    const protocols = ['webpack:']
+    const mappedInfo = this.innerMapper.mappingInfo(normalized)
+    // The @datadog/pprof SourceMapper uses path.resolve() which treats webpack: URLs
+    // as relative paths, creating malformed paths like:
+    // /path/to/.next/server/app/api/heavy/webpack:/next/src/app/api/heavy/route.js
+    // We need to extract just the webpack: URL part
+
+    for (const protocol of protocols) {
+      if (!mappedInfo.file) continue
+
+      const webpackIndex = mappedInfo.file.indexOf(protocol)
+      if (webpackIndex > 0) {
+        // Extract just the webpack: URL
+        mappedInfo.file = mappedInfo.file.substring(webpackIndex)
+      }
+    }
+    return mappedInfo
+  }
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@platformatic/wattpm-pprof-capture",
-  "version": "3.21.0",
+  "version": "3.23.0",
   "description": "pprof profiling capture for wattpm",
   "main": "index.js",
   "type": "module",
@@ -26,8 +26,8 @@
     "neostandard": "^0.12.0",
     "pprof-format": "^2.1.0",
     "typescript": "^5.0.0",
-    "@platformatic/foundation": "3.21.0",
-    "@platformatic/service": "3.21.0"
+    "@platformatic/foundation": "3.23.0",
+    "@platformatic/service": "3.23.0"
   },
   "engines": {
     "node": ">=22.19.0"

package/test/source-mapper-wrapper.test.js

@@ -0,0 +1,43 @@
+import { test } from 'node:test'
+import { deepStrictEqual } from 'node:assert'
+import { SourceMapperWrapper } from '../lib/source-mapper-wrapper.js'
+
+class MockSourceMapper {
+  constructor (mapper) {
+    this.mapper = mapper
+  }
+
+  mappingInfo (location) {
+    return this.mapper(location)
+  }
+}
+
+test('should correctly map webpack paths', async () => {
+  const appPath = '/Users/ivan-tymoshenko/projects/platformatic/leads-demo/web/next'
+  const info = {
+    file: `${appPath}/.next/server/app/api/heavy/route.js`,
+    line: 1,
+    column: 42,
+    name: 'a'
+  }
+
+  const mapper = () => {
+    return {
+      file: `${appPath}/.next/server/app/api/heavy/webpack:/next/src/app/api/heavy/route.js`,
+      name: 'fibonacci',
+      line: 6,
+      column: 12
+    }
+  }
+
+  const innerMapper = new MockSourceMapper(mapper)
+  const sourceMapper = new SourceMapperWrapper(innerMapper)
+
+  const mappedInfo = sourceMapper.mappingInfo(info)
+  deepStrictEqual(mappedInfo, {
+    file: 'webpack:/next/src/app/api/heavy/route.js',
+    name: 'fibonacci',
+    line: 6,
+    column: 12
+  })
+})