@platformatic/watt-extra 0.1.7 → 0.1.8

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@platformatic/watt-extra",
-  "version": "0.1.7",
+  "version": "0.1.8",
   "description": "The Platformatic runtime manager",
   "type": "module",
   "scripts": {

package/plugins/alerts.js

@@ -5,9 +5,10 @@ async function alerts (app, _opts) {
   const podHealthWindow =
     app.instanceConfig?.config?.scaler?.podHealthWindow || 60 * 1000
   const alertRetentionWindow =
-    app.instanceConfig?.config?.scaler?.alertRetentionWindow || 30 * 1000
+    app.instanceConfig?.config?.scaler?.alertRetentionWindow || 10 * 1000
+
+  const lastServicesAlertTime = {}
 
-  let lastAlertTime = 0
   async function setupAlerts () {
     // Skip alerts setup if ICC is not configured
     if (!app.env.PLT_ICC_URL) {
@@ -66,12 +67,16 @@ async function alerts (app, _opts) {
 
       if (healthInfo.unhealthy) {
         const currentTime = Date.now()
-        if (currentTime - lastAlertTime < alertRetentionWindow) {
+
+        const serviceId = healthInfo.id
+        const lastAlertTime = lastServicesAlertTime[serviceId]
+
+        if (lastAlertTime && currentTime - lastAlertTime < alertRetentionWindow) {
           app.log.debug('Skipping alert, within retention window')
           return
         }
 
-        lastAlertTime = currentTime
+        lastServicesAlertTime[serviceId] = currentTime
         delete healthInfo.healthConfig
 
         const authHeaders = await app.getAuthorizationHeader()
@@ -96,7 +101,6 @@ async function alerts (app, _opts) {
         }
 
         const alert = await body.json()
-        const serviceId = healthInfo.id
 
         try {
           await app.sendFlamegraphs({

package/test/alerts.test.js

@@ -372,9 +372,9 @@ test('should respect alert retention window', async (t) => {
   })
 
   // Create a health info template
-  const createHealthInfo = (unhealthy = true) => ({
-    id: 'service-1',
-    service: 'service-1',
+  const createHealthInfo = (serviceId, unhealthy = true) => ({
+    id: serviceId,
+    service: serviceId,
     currentHealth: {
       elu: unhealthy ? 0.95 : 0.5,
       heapUsed: 76798040,
@@ -393,22 +393,26 @@ test('should respect alert retention window', async (t) => {
   })
 
   // Send first unhealthy event - should trigger alert
-  app.watt.runtime.emit('application:worker:health', createHealthInfo(true))
-  await sleep(100)
+  app.watt.runtime.emit('application:worker:health', createHealthInfo('service-1', true))
+  await sleep(50)
+
+  // Send second unhealthy event immediately - should trigger alert
+  app.watt.runtime.emit('application:worker:health', createHealthInfo('service-2', true))
+  await sleep(50)
 
   // Send second unhealthy event immediately - should be ignored due to retention window
-  app.watt.runtime.emit('application:worker:health', createHealthInfo(true))
+  app.watt.runtime.emit('application:worker:health', createHealthInfo('service-1', true))
   await sleep(100)
 
-  assert.strictEqual(alertsReceived.length, 1, 'Only one alert should be sent within retention window')
+  assert.strictEqual(alertsReceived.length, 2, 'Only one alert should be sent within retention window')
 
   await sleep(500)
 
   // Send third unhealthy event - should trigger second alert
-  app.watt.runtime.emit('application:worker:health', createHealthInfo(true))
+  app.watt.runtime.emit('application:worker:health', createHealthInfo('service-1', true))
   await sleep(100)
 
-  assert.strictEqual(alertsReceived.length, 2, 'Second alert should be sent after retention window expires')
+  assert.strictEqual(alertsReceived.length, 3, 'Second alert should be sent after retention window expires')
 })
 
 test('should not set up alerts when scaler URL is missing', async (t) => {