@platformatic/service 0.31.0 → 0.32.0

package/help/compile.txt

@@ -10,4 +10,4 @@ plugins in the `outDir` directory.
 If not specified, the configuration specified will be loaded from
 `platformatic.service.json`, `platformatic.service.yml`, or `platformatic.service.tml` in the current directory.
 You can find more details about the configuration format at:
-https://oss.platformatic.dev/docs/reference/service/configuration.
+https://docs.platformatic.dev/docs/reference/service/configuration.

package/lib/load-config.js

@@ -53,10 +53,14 @@ Error: ${err}
     envWhitelist
   })
 
-  const parsingResult = await configManager.parse()
-  if (!parsingResult) {
-    printConfigValidationErrors(configManager)
-    process.exit(1)
+  try {
+    const parsingResult = await configManager.parse()
+    if (!parsingResult) {
+      printConfigValidationErrors(configManager)
+      process.exit(1)
+    }
+  } finally {
+    configManager.stopWatching()
   }
 
   return { configManager, args }

package/lib/plugins/metrics.js

@@ -12,7 +12,6 @@ const Fastify = require('fastify')
 // prometheus. It's an antipattern, so do
 // not use it elsewhere.
 let server = null
-let handler = null
 
 module.exports = fp(async function (app, opts) {
   let port = 9090
@@ -60,7 +59,6 @@ module.exports = fp(async function (app, opts) {
   if (server && server.address().port !== port) {
     await new Promise((resolve) => server.close(resolve))
     server = null
-    handler = null
   }
 
   if (!server) {
@@ -71,12 +69,10 @@ module.exports = fp(async function (app, opts) {
 
   const promServer = Fastify({
     name: 'Prometheus server',
-    serverFactory: (_handler) => {
-      if (handler) {
-        server.off('request', handler)
-      }
-      server.on('request', _handler)
-      handler = _handler
+    serverFactory: (handler) => {
+      server.removeAllListeners('request')
+      server.removeAllListeners('clientError')
+      server.on('request', handler)
       return server
     },
     logger: app.log.child({ name: 'prometheus' })

package/lib/root-endpoint/index.js

@@ -21,7 +21,7 @@ module.exports = async (app, opts) => {
           return reply.sendFile('./index.html')
         }
       }
-      return { message: 'Welcome to Platformatic! Please visit https://oss.platformatic.dev' }
+      return { message: 'Welcome to Platformatic! Please visit https://docs.platformatic.dev' }
     }
   })
 }

package/lib/root-endpoint/public/index.html

@@ -202,7 +202,7 @@
         <h1 class="text-center"><span>Welcome to</span><br/><span class="text-main-green">Platformatic Service</span></h1>
         <h2 class="text-center">Explore our flexible toolkit for building robust APIs.</h2>
         <div class="button-container">
-          <a href="https://oss.platformatic.dev" target="_blank" class="button-link">Documentation</a>
+          <a href="https://docs.platformatic.dev" target="_blank" class="button-link">Documentation</a>
           <a id="openapi-link" target="_blank" class="button-link">OpenAPI Documentation</a>
           <a id="graphql-link" target="_blank" class="button-link">GraphiQL</a>
         </div>

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@platformatic/service",
-  "version": "0.31.0",
+  "version": "0.32.0",
   "description": "",
   "main": "index.js",
   "bin": {
@@ -64,11 +64,11 @@
     "pino-pretty": "^10.0.0",
     "rfdc": "^1.3.0",
     "ua-parser-js": "^1.0.35",
-    "@platformatic/client": "0.31.0",
-    "@platformatic/config": "0.31.0",
-    "@platformatic/swagger-ui-theme": "0.31.0",
-    "@platformatic/types": "0.31.0",
-    "@platformatic/utils": "0.31.0"
+    "@platformatic/client": "0.32.0",
+    "@platformatic/config": "0.32.0",
+    "@platformatic/swagger-ui-theme": "0.32.0",
+    "@platformatic/types": "0.32.0",
+    "@platformatic/utils": "0.32.0"
   },
   "standard": {
     "ignore": [

package/test/https.test.js

@@ -52,7 +52,7 @@ test('supports https options', async ({ teardown, equal, same, plan, comment })
   let res = await (request(`${app.url}/`))
   equal(res.statusCode, 200)
   let body = await res.body.json()
-  same(body, { message: 'Welcome to Platformatic! Please visit https://oss.platformatic.dev' })
+  same(body, { message: 'Welcome to Platformatic! Please visit https://docs.platformatic.dev' })
 
   await app.restart()
 
@@ -60,5 +60,5 @@ test('supports https options', async ({ teardown, equal, same, plan, comment })
   res = await (request(`${app.url}/`))
   equal(res.statusCode, 200)
   body = await res.body.json()
-  same(body, { message: 'Welcome to Platformatic! Please visit https://oss.platformatic.dev' })
+  same(body, { message: 'Welcome to Platformatic! Please visit https://docs.platformatic.dev' })
 })

package/test/lambda.test.js

@@ -38,11 +38,11 @@ test('should respond 200 on root endpoint', async ({ teardown, equal, same, ok }
 
     const ret = await handler(evt)
 
-    equal(ret.body, JSON.stringify({ message: 'Welcome to Platformatic! Please visit https://oss.platformatic.dev' }))
+    equal(ret.body, JSON.stringify({ message: 'Welcome to Platformatic! Please visit https://docs.platformatic.dev' }))
     equal(ret.isBase64Encoded, false)
     ok(ret.headers)
     equal(ret.headers['content-type'], 'application/json; charset=utf-8')
-    equal(ret.headers['content-length'], '80')
+    equal(ret.headers['content-length'], '81')
     ok(ret.headers.date)
     equal(ret.headers.connection, 'keep-alive')
   }

package/test/load-and-reload-files.test.js

@@ -38,7 +38,7 @@ test('load and reload', async ({ teardown, equal, pass, same }) => {
     const res = await request(`${app.url}/`)
     equal(res.statusCode, 200, 'status code')
     const data = await res.body.json()
-    same(data, { message: 'Welcome to Platformatic! Please visit https://oss.platformatic.dev' })
+    same(data, { message: 'Welcome to Platformatic! Please visit https://docs.platformatic.dev' })
   }
 
   await writeFile(file, `
@@ -52,7 +52,7 @@ test('load and reload', async ({ teardown, equal, pass, same }) => {
     const res = await request(`${app.url}/`)
     equal(res.statusCode, 200, 'add status code')
     // The plugin is in Node's module cache, so the new value is not seen.
-    same(await res.body.json(), { message: 'Welcome to Platformatic! Please visit https://oss.platformatic.dev' })
+    same(await res.body.json(), { message: 'Welcome to Platformatic! Please visit https://docs.platformatic.dev' })
   }
 })
 
@@ -161,7 +161,7 @@ test('load and reload ESM', async ({ teardown, equal, pass, same }) => {
     const res = await request(`${app.url}/`)
     equal(res.statusCode, 200, 'status code')
     const data = await res.body.json()
-    same(data, { message: 'Welcome to Platformatic! Please visit https://oss.platformatic.dev' })
+    same(data, { message: 'Welcome to Platformatic! Please visit https://docs.platformatic.dev' })
   }
 
   await writeFile(file, `
@@ -175,6 +175,6 @@ test('load and reload ESM', async ({ teardown, equal, pass, same }) => {
     const res = await request(`${app.url}/`)
     equal(res.statusCode, 200, 'add status code')
     // The plugin is in Node's module cache, so the new value is not seen.
-    same(await res.body.json(), { message: 'Welcome to Platformatic! Please visit https://oss.platformatic.dev' })
+    same(await res.body.json(), { message: 'Welcome to Platformatic! Please visit https://docs.platformatic.dev' })
   }
 })

package/test/metrics.test.js

@@ -154,6 +154,29 @@ test('do not error on restart', async ({ teardown, equal, fail, match }) => {
   testPrometheusOutput(body)
 })
 
+test('restarting 10 times does not leak', async ({ teardown, equal, fail, match }) => {
+  process.on('warning', (warning) => {
+    fail('warning was raised')
+  })
+  const app = await buildServer({
+    server: {
+      hostname: '127.0.0.1',
+      port: 0
+    },
+    metrics: true
+  })
+
+  teardown(async () => {
+    await app.close()
+  })
+
+  await app.start()
+
+  for (let i = 0; i < 10; i++) {
+    await app.restart()
+  }
+})
+
 function testPrometheusOutput (output) {
   let metricBlock = []
   const lines = output.split('\n')

package/test/routes.test.js

@@ -28,7 +28,7 @@ test('should respond 200 on root endpoint', async ({ teardown, equal, same }) =>
     const res = await (request(`${app.url}/`))
     equal(res.statusCode, 200)
     const body = await res.body.json()
-    same(body, { message: 'Welcome to Platformatic! Please visit https://oss.platformatic.dev' })
+    same(body, { message: 'Welcome to Platformatic! Please visit https://docs.platformatic.dev' })
   }
 
   {