@platformatic/service 0.27.0 → 0.28.1

package/fixtures/hello/platformatic.service.json

@@ -8,8 +8,7 @@
     }
   },
   "plugins": {
-    "paths": ["./plugin.js"],
-    "hotReload": false
+    "paths": ["./plugin.js"]
   },
   "service": {
     "openapi": true

package/fixtures/hello/warn-log.service.json

@@ -8,8 +8,7 @@
     }
   },
   "plugins": {
-    "paths": ["./plugin.js"],
-    "hotReload": false
+    "paths": ["./plugin.js"]
   },
   "service": {
     "openapi": true

package/fixtures/hello-client/platformatic.service.json

@@ -8,11 +8,10 @@
     }
   },
   "plugins": {
-    "paths": ["./plugin.js"],
-    "hotReload": false
+    "paths": ["./plugin.js"]
   },
   "clients": [{
-    "path": "./hello",
+    "path": "hello",
     "url": "{PLT_CLIENT_URL}"
   }],
   "metrics": false,

package/fixtures/hello-client-ts/platformatic.service.json

@@ -10,11 +10,10 @@
   },
   "plugins": {
     "paths": ["./plugin.ts"],
-    "typescript": true,
-    "hotReload": false
+    "typescript": true
   },
   "clients": [{
-    "path": "./hello",
+    "path": "hello",
     "url": "{PLT_CLIENT_URL}"
   }],
   "metrics": false,

package/index.d.ts

@@ -1,15 +1,21 @@
-import { FastifyInstance } from "fastify"
+/* eslint-disable @typescript-eslint/triple-slash-reference */
+/// <reference types="@platformatic/types" />
+/// <reference types="mercurius" />
+/// <reference types="@fastify/swagger" />
+import { FastifyInstance } from 'fastify'
+import ConfigManager from '@platformatic/config'
 
-export type pltServiceHandlerBuildServer = {
-  app: FastifyInstance
-  address: string
-  port: number
-  restart: () => Promise<void>
-  listen: FastifyInstance['listen']
-  close: FastifyInstance['close']
-  inject: FastifyInstance['inject']
+declare module '@platformatic/types' {
+  interface PlatformaticApp {
+    configManager: ConfigManager
+    config: object
+  }
 }
 
-declare module '@platformatic/service' {
-  export function buildServer(opts: object, app?: object, ConfigManagerContructor?: object): Promise<pltServiceHandlerBuildServer>
+export function buildServer (opts: object, app?: object, ConfigManagerContructor?: object): Promise<FastifyInstance>
+
+declare module 'fastify' {
+  interface FastifyInstance {
+    restart: () => Promise<void>
+  }
 }

package/index.js

@@ -9,7 +9,6 @@ const setupGraphQL = require('./lib/plugins/graphql.js')
 const setupClients = require('./lib/plugins/clients')
 const setupMetrics = require('./lib/plugins/metrics')
 const setupTsCompiler = require('./lib/plugins/typescript')
-const setupFileWatcher = require('./lib/plugins/file-watcher')
 const setupHealthCheck = require('./lib/plugins/health-check')
 const loadPlugins = require('./lib/plugins/plugins')
 
@@ -54,7 +53,10 @@ async function platformaticService (app, opts, toLoad = []) {
   }
 
   if (isKeyEnabled('watch', config)) {
-    await app.register(setupFileWatcher, { onFilesUpdated })
+    // If file watching is enabled here, that means the service was started
+    // without the runtime because the runtime explicitly disables watching on
+    // services that it starts. Warn the user that things will not go as planned.
+    app.log.warn('service was started with file watching enabled but watching is only available via the runtime')
   }
 
   if (config.server.cors) {
@@ -70,25 +72,6 @@ async function platformaticService (app, opts, toLoad = []) {
   }
 }
 
-async function onFilesUpdated (app) {
-  // Reload the config as well, otherwise we will have problems
-  // in case the files watcher triggers the config watcher too
-  const configManager = app.platformatic.configManager
-  try {
-    app.log.debug('files changed')
-    await configManager.parse()
-    await app.restart()
-    /* c8 ignore next 8 */
-  } catch (err) {
-    app.log.error({
-      err: {
-        message: err.message,
-        stack: err.stack
-      }
-    }, 'failed to reload server')
-  }
-}
-
 platformaticService[Symbol.for('skip-override')] = true
 platformaticService.schema = schema
 platformaticService.configType = 'service'

package/index.test-d.ts

@@ -1,24 +1,16 @@
-import { expectError, expectType } from 'tsd';
-import { FastifyInstance } from 'fastify';
-import { pltServiceHandlerBuildServer } from '.';
+import { expectType } from 'tsd'
+import { FastifyInstance } from 'fastify'
+import { buildServer } from '.'
+import ConfigManager from '@platformatic/config'
+import { OpenAPI } from 'openapi-types'
+import type { MercuriusPlugin } from 'mercurius'
 
-const server: pltServiceHandlerBuildServer = {
-  app: {} as FastifyInstance,
-  address: 'localhost',
-  port: 3000,
-  restart: async () => {},
-  listen: async () => '',
-  close: (async () => undefined) as unknown as FastifyInstance['close'],
-  inject: (async () => undefined) as unknown as FastifyInstance['inject']
-};
+const server = await buildServer({
+})
 
-expectType<pltServiceHandlerBuildServer>(server);
-expectError<pltServiceHandlerBuildServer>({...server, app: 'WRONG' });
-expectError<pltServiceHandlerBuildServer>({...server, address: 42 });
-expectError<pltServiceHandlerBuildServer>({...server, port: 'WRONG' });
-expectError<pltServiceHandlerBuildServer>({...server, restart: 'WRONG' });
-expectError<pltServiceHandlerBuildServer>({...server, listen: 'WRONG' });
-expectError<pltServiceHandlerBuildServer>({...server, listen: async () => ({ address: 42, port: 3000 }), });
-expectError<pltServiceHandlerBuildServer>({...server, listen: async () => ({ address: 'localhost', port: 'WRONG' }), });
-expectError<pltServiceHandlerBuildServer>({...server, stop: 'WRONG' });
-expectError<pltServiceHandlerBuildServer>({...server, inject: 'WRONG' });
+expectType<FastifyInstance>(server)
+expectType<ConfigManager>(server.platformatic.configManager)
+expectType<ConfigManager>(server.platformatic.configManager)
+expectType<OpenAPI.Document>(server.swagger())
+expectType<MercuriusPlugin>(server.graphql)
+expectType<Promise<void>>(server.restart())

package/lib/compile.js

@@ -79,31 +79,6 @@ async function compile (cwd, config, originalLogger) {
   }
 }
 
-// This path is tested but C8 does not see it that way given it needs to work
-// through execa.
-/* c8 ignore next 20 */
-async function compileWatch (cwd, config, originalLogger) {
-  const { execa, logger, tscExecutablePath } = await setup(cwd, config, originalLogger)
-  if (!tscExecutablePath) {
-    return false
-  }
-
-  try {
-    await execa(tscExecutablePath, ['--project', 'tsconfig.json', '--incremental', '--rootDir', '.'], { cwd })
-    logger.info('Typescript compilation completed successfully. Starting watch mode.')
-  } catch (error) {
-    throw new Error('Failed to compile typescript files: ' + error)
-  }
-
-  const child = execa(tscExecutablePath, ['--project', 'tsconfig.json', '--watch', '--incremental'], { cwd })
-  child.stdout.resume()
-  child.stderr.on('data', (data) => {
-    logger.error(data.toString())
-  })
-
-  return { child }
-}
-
 function buildCompileCmd (app) {
   return async function compileCmd (_args) {
     let fullPath = null
@@ -126,5 +101,4 @@ function buildCompileCmd (app) {
 }
 
 module.exports.compile = compile
-module.exports.compileWatch = compileWatch
 module.exports.buildCompileCmd = buildCompileCmd

package/lib/load-config.js

@@ -18,8 +18,7 @@ async function loadConfig (minimistConfig, _args, app, overrides = {}) {
   const args = parseArgs(_args, deepmerge({ all: true })({
     string: ['allow-env'],
     default: {
-      allowEnv: '', // The default is set in ConfigManager
-      hotReload: true
+      allowEnv: '' // The default is set in ConfigManager
     },
     alias: {
       v: 'version',

package/lib/plugins/plugins.js

@@ -2,8 +2,6 @@
 
 const { join, resolve } = require('path')
 const { readFile } = require('fs/promises')
-
-const sandbox = require('fastify-sandbox')
 const fp = require('fastify-plugin')
 
 const { getJSPluginPath, isFileAccessible } = require('../utils')
@@ -34,23 +32,7 @@ async function loadPlugins (app) {
     })
   }
 
-  if (config.plugins.hotReload !== false) {
-    await app.register(sandbox, {
-      path: wrapperPath,
-      options: { paths: config.plugins.paths },
-      customizeGlobalThis (_globalThis) {
-        // Taken from https://github.com/nodejs/undici/blob/fa9fd9066569b6357acacffb806aa804b688c9d8/lib/global.js#L5
-        const globalDispatcher = Symbol.for('undici.globalDispatcher.1')
-        const dispatcher = globalThis[globalDispatcher]
-        /* istanbul ignore else */
-        if (dispatcher) {
-          _globalThis[globalDispatcher] = dispatcher
-        }
-      }
-    })
-  } else {
-    await app.register(require(wrapperPath), { paths: config.plugins.paths })
-  }
+  await app.register(require(wrapperPath), { paths: config.plugins.paths })
 }
 
 module.exports = fp(loadPlugins)

package/lib/plugins/typescript.js

@@ -1,8 +1,6 @@
 'use strict'
 
-const { isKeyEnabled } = require('@platformatic/utils')
 const fp = require('fastify-plugin')
-
 const compiler = require('../compile')
 
 async function setupTsCompiler (app) {
@@ -10,37 +8,9 @@ async function setupTsCompiler (app) {
 
   const configManager = app.platformatic.configManager
   const config = configManager.current
-
-  const isRestartableApp = app.restarted !== undefined
-
-  // to run the plugin without restartable
-  /* c8 ignore next 1 */
-  const persistentRef = isRestartableApp ? app.persistentRef : app
-
   const workingDir = configManager.dirname
 
-  if (isKeyEnabled('watch', config)) {
-    let tsCompilerWatcher = persistentRef.tsCompilerWatcher
-    if (!tsCompilerWatcher) {
-      /* c8 ignore next 5 */
-      const { child } = await compiler.compileWatch(workingDir, config, app.log)
-      app.log.debug('start watching typescript files')
-      tsCompilerWatcher = child
-    }
-    app.decorate('tsCompilerWatcher', tsCompilerWatcher)
-  } else {
-    await compiler.compile(workingDir, config, app.log)
-  }
-
-  app.addHook('onClose', async () => {
-    if (!isRestartableApp || app.closingRestartable) {
-      /* c8 ignore next 4 */
-      if (app.tsCompilerWatcher) {
-        app.tsCompilerWatcher.kill('SIGTERM')
-        app.log.debug('stop watching typescript files')
-      }
-    }
-  })
+  await compiler.compile(workingDir, config, app.log)
 }
 
 module.exports = fp(setupTsCompiler)