@platformatic/service 0.26.0 → 0.26.1

package/index.js

@@ -26,17 +26,6 @@ async function platformaticService (app, opts, toLoad = []) {
     app.register(setupMetrics, config.metrics)
   }
 
-  app.setErrorHandler(async (err, req, reply) => {
-    if (!(err instanceof Error)) {
-      req.log.debug({ err }, 'error encountered within the sandbox, wrapping it')
-      const newError = new Error(err.message)
-      newError.cause = err
-      newError.statusCode = err.statusCode || 500
-      err = newError
-    }
-    throw err
-  })
-
   if (Array.isArray(toLoad)) {
     for (const plugin of toLoad) {
       await app.register(plugin)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@platformatic/service",
-  "version": "0.26.0",
+  "version": "0.26.1",
   "description": "",
   "main": "index.js",
   "bin": {
@@ -55,7 +55,7 @@
     "fastify": "^4.17.0",
     "fastify-metrics": "^10.3.0",
     "fastify-plugin": "^4.5.0",
-    "fastify-sandbox": "^0.13.0",
+    "fastify-sandbox": "^0.13.1",
     "graphql": "^16.6.0",
     "help-me": "^4.2.0",
     "mercurius": "^13.0.0",
@@ -64,10 +64,10 @@
     "pino-pretty": "^10.0.0",
     "rfdc": "^1.3.0",
     "ua-parser-js": "^1.0.35",
-    "@platformatic/swagger-ui-theme": "0.26.0",
-    "@platformatic/config": "0.26.0",
-    "@platformatic/utils": "0.26.0",
-    "@platformatic/client": "0.26.0"
+    "@platformatic/client": "0.26.1",
+    "@platformatic/swagger-ui-theme": "0.26.1",
+    "@platformatic/config": "0.26.1",
+    "@platformatic/utils": "0.26.1"
   },
   "standard": {
     "ignore": [

package/test/fixtures/throw-resolver.js

@@ -0,0 +1,16 @@
+'use strict'
+
+module.exports = async function (app) {
+  app.graphql.extendSchema(`
+    extend type Query {
+      hello: String
+    }
+  `)
+  app.graphql.defineResolvers({
+    Query: {
+      hello: async function (root, args, context) {
+        throw new Error('Kaboooooom!!!')
+      }
+    }
+  })
+}

package/test/graphql.test.js

@@ -156,3 +156,64 @@ test('graphql disabled by default', async ({ teardown, equal, fail }) => {
     equal(err.message, 'Cannot read properties of undefined (reading \'extendSchema\')')
   }
 })
+
+test('graphql errors are correctly propagated in custom resolvers', async ({ teardown, equal, same }) => {
+  const app = await buildServer(buildConfig({
+    server: {
+      hostname: '127.0.0.1',
+      port: 0,
+      healthCheck: {
+        enabled: true,
+        interval: 2000
+      }
+    },
+    service: {
+      graphql: true
+    },
+    plugins: {
+      paths: [join(__dirname, 'fixtures', 'throw-resolver.js')]
+    }
+  }))
+
+  teardown(async () => {
+    await app.close()
+  })
+  await app.start()
+
+  {
+    const res = await request(`${app.url}/graphql`, {
+      method: 'POST',
+      headers: {
+        'content-type': 'application/json'
+      },
+      body: JSON.stringify({
+        query: `
+          query {
+            hello
+          }
+        `
+      })
+    })
+    equal(res.statusCode, 200, 'hello status code')
+    same(await res.body.json(), {
+      data: {
+        hello: null
+      },
+      errors: [
+        {
+          message: 'Kaboooooom!!!',
+          locations: [{
+            line: 3,
+            column: 13
+          }],
+          path: ['hello']
+        }
+      ]
+    }, 'hello response')
+  }
+
+  {
+    const res = await request(`${app.url}/graphiql`)
+    equal(res.statusCode, 200, 'graphiql status code')
+  }
+})