@platformatic/runtime 3.63.0-alpha.3 → 3.64.0

package/lib/scaling-algorithm.js

@@ -83,7 +83,7 @@ export class ScalingAlgorithm {
 
         const newWorkersCount = appMinWorkers - workersCount
         totalWorkersCount += newWorkersCount
-        totalAvailableMemory += newWorkersCount * avgHeapUsed
+        totalAvailableMemory -= newWorkersCount * avgHeapUsed
         continue
       }
 
@@ -96,7 +96,7 @@ export class ScalingAlgorithm {
 
         const removedWorkersCount = workersCount - appMaxWorkers
         totalWorkersCount -= removedWorkersCount
-        totalAvailableMemory -= removedWorkersCount * avgHeapUsed
+        totalAvailableMemory += removedWorkersCount * avgHeapUsed
         continue
       }
 
@@ -111,7 +111,7 @@ export class ScalingAlgorithm {
 
           const removedWorkersCount = 1
           totalWorkersCount -= removedWorkersCount
-          totalAvailableMemory -= removedWorkersCount * avgHeapUsed
+          totalAvailableMemory += removedWorkersCount * avgHeapUsed
         }
       }
     }

package/lib/worker/controller.js

@@ -95,7 +95,8 @@ export class Controller extends EventEmitter {
       worker: workerData?.worker,
       resourceLimits: workerData?.resourceLimits,
       hasManagementApi: !!runtimeConfig.managementApi,
-      fetchApplicationUrl: fetchApplicationUrl.bind(null, applicationConfig)
+      fetchApplicationUrl: fetchApplicationUrl.bind(null, applicationConfig),
+      strictEnv: runtimeConfig.strictEnv
     }
   }
 
@@ -141,7 +142,8 @@ export class Controller extends EventEmitter {
       if (appConfig.config) {
         // Parse the configuration file the first time to obtain the schema
         const unvalidatedConfig = await loadConfiguration(appConfig.config, null, {
-          onMissingEnv: this.#context.fetchApplicationUrl
+          onMissingEnv: this.#context.fetchApplicationUrl,
+          strictEnv: this.#context.strictEnv
         })
         const pkg = await loadConfigurationModule(appConfig.path, unvalidatedConfig)
         this.capability = await pkg.create(appConfig.path, appConfig.config, this.#context)

package/lib/worker/itc.js

@@ -1,6 +1,6 @@
 import { ensureLoggableError, executeInParallel, executeWithTimeout, kTimeout } from '@platformatic/foundation'
 import { getEvents, getLogger, getMessaging, updateGlobals } from '@platformatic/globals'
-import { initializeITCTelemetry, ITC } from '@platformatic/itc'
+import { ITC, initializeITCTelemetry } from '@platformatic/itc'
 import { Unpromise } from '@watchable/unpromise'
 import { once } from 'node:events'
 import { createRequire } from 'node:module'
@@ -112,9 +112,14 @@ async function safeHandleInITC (worker, fn) {
 }
 
 async function closeITC (dispatcher, itc, messaging) {
-  await dispatcher.interceptor.close()
-  itc.close()
-  messaging.close()
+  try {
+    await dispatcher.interceptor.close()
+    itc.close()
+    messaging.close()
+  } finally {
+    const events = getEvents()
+    events.emit('exit')
+  }
 }
 
 export async function sendViaITC (worker, name, message, transferList) {
@@ -183,7 +188,12 @@ export async function setupITC (controller, application, dispatcher, sharedConte
 
             // Reply to the runtime that the start failed, so it can cleanup
             once(itc, 'application:worker:start:processed').then(() => {
-              closeITC(dispatcher, itc, messaging).catch(() => {})
+              closeITC(dispatcher, itc, messaging).catch(err => {
+                logger.error(
+                  { err: ensureLoggableError(err) },
+                  'Failed to close the worker ITC after a failed start.'
+                )
+              })
             })
 
             throw ensureLoggableError(e)
@@ -208,23 +218,32 @@ export async function setupITC (controller, application, dispatcher, sharedConte
       },
 
       async stop ({ force, dependents }) {
-        const status = controller.getStatus()
+        try {
+          const status = controller.getStatus()
 
-        if (!force && status === 'starting') {
-          await once(controller, 'start')
-        }
+          if (!force && status === 'starting') {
+            await once(controller, 'start')
+          }
 
-        if (force || status.startsWith('start')) {
-          // This gives a chance to a capability to perform custom logic
-          const events = getEvents()
-          events.emit('stop')
+          if (force || status.startsWith('start')) {
+            // This gives a chance to a capability to perform custom logic
+            const events = getEvents()
+            events.emit('stop')
 
-          await controller.stop(force, dependents)
+            await controller.stop(force, dependents)
+          }
+        } finally {
+          // Always schedule cleanup, even when stop throws. Otherwise the worker
+          // keeps open handles and runtime shutdown hangs until the grace timeout.
+          once(itc, 'application:worker:stop:processed').then(() => {
+            closeITC(dispatcher, itc, messaging).catch(err => {
+              logger.error(
+                { err: ensureLoggableError(err) },
+                'Failed to close the worker ITC after stop.'
+              )
+            })
+          })
         }
-
-        once(itc, 'application:worker:stop:processed').then(() => {
-          closeITC(dispatcher, itc, messaging).catch(() => {})
-        })
       },
 
       async getDependencies () {

package/lib/worker/main.js

@@ -364,6 +364,16 @@ async function main () {
 
 function stripBasePath (basePath) {
   const kBasePath = Symbol('kBasePath')
+  const absoluteUrlPattern = /^https?:\/\//i
+
+  function prependBasePath (value) {
+    // Absolute and protocol-relative URLs (RFC 7231 Location) must not be rewritten
+    if (typeof value !== 'string' || absoluteUrlPattern.test(value) || value.startsWith('//') || value.startsWith(basePath)) {
+      return value
+    }
+
+    return basePath + value
+  }
 
   subscribe('http.server.request.start', ({ request, response }) => {
     if (request.url.startsWith(basePath)) {
@@ -389,8 +399,8 @@ function stripBasePath (basePath) {
 
       if (headers) {
         for (const key in headers) {
-          if (key.toLowerCase() === 'location' && !headers[key].startsWith(basePath)) {
-            headers[key] = basePath + headers[key]
+          if (key.toLowerCase() === 'location') {
+            headers[key] = prependBasePath(headers[key])
           }
         }
       }
@@ -401,8 +411,8 @@ function stripBasePath (basePath) {
 
   ServerResponse.prototype.setHeader = function (name, value) {
     if (this[kBasePath]) {
-      if (name.toLowerCase() === 'location' && !value.startsWith(basePath)) {
-        value = basePath + value
+      if (name.toLowerCase() === 'location') {
+        value = prependBasePath(value)
       }
     }
     originSetHeader.call(this, name, value)

package/lib/worker/management.js

@@ -70,8 +70,8 @@ export class ManagementClient {
     return this.#send('getMetrics', { format })
   }
 
-  getScheduler () {
-    return this.#send('getScheduler')
+  getSchedulerJobs () {
+    return this.#send('getSchedulerJobs')
   }
 
   pauseSchedulerJob (name) {

package/lib/worker/messaging.js

@@ -114,14 +114,21 @@ export class MessagingITC extends ITC {
         context.meta = { ...options?.meta, ...telemetry?.meta }
       }
 
-      const send = () => executeWithTimeout(super.send(name, message, context), this.#timeout)
-      const response = telemetry ? await telemetry.run(send) : await send()
-
-      if (response === kTimeout) {
-        throw new MessagingError(application, 'Timeout while waiting for a response.')
+      const abortController = new AbortController()
+      const timeout = setTimeout(() => abortController.abort(), this.#timeout).unref()
+      context.signal = abortController.signal
+
+      try {
+        const send = () => super.send(name, message, context)
+        return telemetry ? await telemetry.run(send) : await send()
+      } catch (err) {
+        if (abortController.signal.aborted) {
+          throw new MessagingError(application, 'Timeout while waiting for a response.')
+        }
+        throw err
+      } finally {
+        clearTimeout(timeout)
       }
-
-      return response
     } catch (err) {
       error = err
       throw err
@@ -181,6 +188,12 @@ export class MessagingITC extends ITC {
     channel.postMessage(sanitize(request, transferList), transferList)
   }
 
+  _onRequestSettled (reqId, context) {
+    if (context.trackResponse) {
+      context.channel[kPendingResponses].delete(reqId)
+    }
+  }
+
   _createClosePromise () {
     const { promise, resolve, reject } = Promise.withResolvers()
     this.#closeResolvers = { resolve, reject }

package/lib/worker-scaler.js

@@ -121,20 +121,31 @@ export class DynamicWorkersScaler {
 
     if (config.minWorkers > 1) {
       const update = { application: application.id, workers: config.minWorkers }
-
-      if (!this.#status === 'started') {
-        await this.#runtime.updateApplicationsResources([update])
-      } else {
-        this.#initialUpdates.push(update)
-      }
+      this.#initialUpdates.push(update)
     }
 
     this.#appsConfigs[application.id] = config
     this.#algorithm.addApplication(application.id, config)
   }
 
-  remove (application) {
-    this.#algorithm.removeApplication(application.id)
+  async applyPendingUpdate (applicationId) {
+    if (this.#status !== 'started') {
+      return
+    }
+
+    const update = this.#initialUpdates.find(update => update.application === applicationId)
+    if (!update) {
+      return
+    }
+
+    await this.#runtime.updateApplicationsResources([update])
+    this.#initialUpdates = this.#initialUpdates.filter(pending => pending !== update)
+  }
+
+  remove (applicationId) {
+    delete this.#appsConfigs[applicationId]
+    this.#initialUpdates = this.#initialUpdates.filter(update => update.application !== applicationId)
+    this.#algorithm.removeApplication(applicationId)
   }
 
   async #chechHealth () {
@@ -175,7 +186,7 @@ export class DynamicWorkersScaler {
           shouldCheckForScaling = true
         }
       } catch (err) {
-        this.logger.error({ err }, 'Failed to get health for worker')
+        this.#runtime.logger.error({ err }, 'Failed to get health for worker')
       }
     }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@platformatic/runtime",
-  "version": "3.63.0-alpha.3",
+  "version": "3.64.0",
   "description": "Platformatic runtime",
   "main": "index.js",
   "type": "module",
@@ -39,14 +39,14 @@
     "typescript": "^5.9.3",
     "undici-oidc-interceptor": "^0.9.0",
     "why-is-node-running": "^2.2.2",
-    "@platformatic/composer": "3.63.0-alpha.3",
-    "@platformatic/db": "3.63.0-alpha.3",
-    "@platformatic/gateway": "3.63.0-alpha.3",
-    "@platformatic/node": "3.63.0-alpha.3",
-    "@platformatic/service": "3.63.0-alpha.3",
-    "@platformatic/sql-graphql": "3.63.0-alpha.3",
-    "@platformatic/wattpm-pprof-capture": "3.63.0-alpha.3",
-    "@platformatic/sql-mapper": "3.63.0-alpha.3"
+    "@platformatic/db": "3.64.0",
+    "@platformatic/composer": "3.64.0",
+    "@platformatic/gateway": "3.64.0",
+    "@platformatic/service": "3.64.0",
+    "@platformatic/node": "3.64.0",
+    "@platformatic/sql-graphql": "3.64.0",
+    "@platformatic/wattpm-pprof-capture": "3.64.0",
+    "@platformatic/sql-mapper": "3.64.0"
   },
   "dependencies": {
     "@fastify/accepts": "^5.0.0",
@@ -69,7 +69,7 @@
     "help-me": "^5.0.0",
     "minimist": "^1.2.8",
     "pino": "^10.1.0",
-    "pino-opentelemetry-transport": "^3.0.0",
+    "pino-opentelemetry-transport": "^4.0.2",
     "pino-pretty": "^13.0.0",
     "semgrator": "^0.3.0",
     "sonic-boom": "^4.2.0",
@@ -77,13 +77,13 @@
     "undici": "^7.27.2",
     "undici-thread-interceptor": "^1.3.1",
     "ws": "^8.16.0",
-    "@platformatic/basic": "3.63.0-alpha.3",
-    "@platformatic/foundation": "3.63.0-alpha.3",
-    "@platformatic/generators": "3.63.0-alpha.3",
-    "@platformatic/itc": "3.63.0-alpha.3",
-    "@platformatic/metrics": "3.63.0-alpha.3",
-    "@platformatic/globals": "3.63.0-alpha.3",
-    "@platformatic/telemetry": "3.63.0-alpha.3"
+    "@platformatic/foundation": "3.64.0",
+    "@platformatic/globals": "3.64.0",
+    "@platformatic/generators": "3.64.0",
+    "@platformatic/itc": "3.64.0",
+    "@platformatic/basic": "3.64.0",
+    "@platformatic/metrics": "3.64.0",
+    "@platformatic/telemetry": "3.64.0"
   },
   "engines": {
     "node": ">=22.19.0"

package/schema.json

@@ -1,5 +1,5 @@
 {
-  "$id": "https://schemas.platformatic.dev/@platformatic/runtime/3.63.0-alpha.3.json",
+  "$id": "https://schemas.platformatic.dev/@platformatic/runtime/3.64.0.json",
   "$schema": "http://json-schema.org/draft-07/schema#",
   "title": "Platformatic Runtime Config",
   "type": "object",
@@ -2234,7 +2234,7 @@
               "type": "string"
             }
           ],
-          "default": 10000
+          "default": 30000
         },
         "application": {
           "anyOf": [
@@ -3492,6 +3492,17 @@
     "envfile": {
       "type": "string"
     },
+    "strictEnv": {
+      "anyOf": [
+        {
+          "type": "boolean"
+        },
+        {
+          "type": "string"
+        }
+      ],
+      "description": "When set to true, the configuration loading fails if a {PLT_*} placeholder references an environment variable which is not set. When set to \"warn\", a warning listing the missing variables is logged but the placeholders are still replaced with an empty string. Defaults to false."
+    },
     "sourceMaps": {
       "type": "boolean",
       "default": false