@platformatic/runtime 3.34.1-alpha.3 → 3.35.0

package/lib/errors.js

@@ -40,6 +40,10 @@ export const ApplicationStartTimeoutError = createError(
   `${ERROR_PREFIX}_APPLICATION_START_TIMEOUT`,
   "Application with id '%s' failed to start in %dms."
 )
+export const ApplicationsDependenciesCycleError = createError(
+  `${ERROR_PREFIX}_APPLICATIONS_DEPENDENCIES_CYCLE`,
+  'Detected a cycle in the applications dependencies: %s'
+)
 export const FailedToRetrieveOpenAPISchemaError = createError(
   `${ERROR_PREFIX}_FAILED_TO_RETRIEVE_OPENAPI_SCHEMA`,
   'Failed to retrieve OpenAPI schema for application with id "%s": %s'

package/lib/runtime.js

@@ -46,6 +46,7 @@ import { createChannelCreationHook } from './policies.js'
 import { startPrometheusServer } from './prom-server.js'
 import { startScheduler } from './scheduler.js'
 import { createSharedStore } from './shared-http-cache.js'
+import { topologicalSort } from './utils.js'
 import { version } from './version.js'
 import { DynamicWorkersScaler } from './worker-scaler.js'
 import { HealthSignalsQueue } from './worker/health-signals.js'
@@ -90,6 +91,7 @@ function parseOrigins (origins) {
   })
 }
 
+// Always run operations in parallel to avoid deadlocks when services have dependencies
 const MAX_CONCURRENCY = availableParallelism()
 const MAX_BOOTSTRAP_ATTEMPTS = 5
 const IMMEDIATE_RESTART_MAX_THRESHOLD = 10
@@ -157,7 +159,9 @@ export class Runtime extends EventEmitter {
     this.#meshInterceptor = createThreadInterceptor({
       domain: '.plt.local',
       timeout: this.#config.applicationTimeout,
-      onChannelCreation: this.#channelCreationHook
+      meshTimeout: this.#context.meshTimeout ?? true,
+      onChannelCreation: this.#channelCreationHook,
+      onError: this.#onMeshInterceptorError.bind(this)
     })
     this.logger = abstractLogger // This is replaced by the real logger in init() and eventually removed in close()
     this.#status = undefined
@@ -543,9 +547,21 @@ export class Runtime extends EventEmitter {
     return removed
   }
 
-  async startApplications (applicationsToStart, silent = false) {
+  async startApplications (applications, silent = false) {
+    // For each worker, get its dependencies from the first worker
+    const dependencies = new Map()
+    for (const applicationId of applications) {
+      const worker = await this.#getWorkerByIdOrNext(applicationId, 0)
+
+      dependencies.set(applicationId, await sendViaITC(worker, 'getDependencies'))
+    }
+
+    // Now, topological sort the applications based on their dependencies.
+    // If circular dependencies are detected, an error with proper error code is thrown.
+    applications = topologicalSort(dependencies)
+
     const startInvocations = []
-    for (const application of applicationsToStart) {
+    for (const application of applications) {
       startInvocations.push([application, silent])
     }
 
@@ -1835,7 +1851,16 @@ export class Runtime extends EventEmitter {
     worker[kInterceptorReadyPromise] = this.#meshInterceptor.route(applicationId, worker)
 
     // Wait for initialization
-    await waitEventFromITC(worker, 'init')
+    try {
+      await waitEventFromITC(worker, 'init')
+    } catch (e) {
+      if (e.code !== 'PLT_RUNTIME_APPLICATION_WORKER_EXIT') {
+        this.logger.error({ err: ensureLoggableError(e) }, `Failed to initialize the ${errorLabel}. Replacing it ...`)
+      }
+
+      this.#workers.delete(workerId)
+      return this.#setupWorker(config, applicationConfig, workersCount, applicationId, index, enabled)
+    }
 
     if (applicationConfig.entrypoint) {
       this.#entrypointId = applicationId
@@ -2988,4 +3013,16 @@ export class Runtime extends EventEmitter {
 
     this.#loggerContext.updatePrefixes(ids)
   }
+
+  #onMeshInterceptorError (error) {
+    const worker = error.port
+
+    this.logger.error(
+      { err: ensureLoggableError(error.cause) },
+      `The ${this.#workerExtendedLabel(worker[kApplicationId], worker[kWorkerId])} threw an error during mesh network setup. Replacing it ...`
+    )
+
+    this.emit('application:worker:init:failed', { application: worker[kApplicationId], worker: worker[kWorkerId] })
+    worker.terminate()
+  }
 }

package/lib/utils.js

@@ -1,6 +1,7 @@
 import { createHash } from 'node:crypto'
 import { tmpdir } from 'node:os'
 import { join } from 'node:path'
+import { ApplicationsDependenciesCycleError } from './errors.js'
 
 export function getArrayDifference (a, b) {
   return a.filter(element => {
@@ -17,3 +18,35 @@ export function getRuntimeTmpDir (runtimeDir) {
   const runtimeDirHash = createHash('md5').update(runtimeDir).digest('hex')
   return join(platformaticTmpDir, runtimeDirHash)
 }
+
+// Graph: Map<string, string[]>
+export function topologicalSort (graph) {
+  const result = []
+  const visited = new Set()
+  const path = []
+
+  function visit (node) {
+    if (visited.has(node)) {
+      return
+    }
+
+    if (path.includes(node)) {
+      throw new ApplicationsDependenciesCycleError(path.concat([node]).join(' -> '))
+    }
+
+    path.push(node)
+    for (const dep of graph.get(node)) {
+      visit(dep)
+    }
+    path.pop()
+
+    visited.add(node)
+    result.push(node)
+  }
+
+  for (const node of graph.keys()) {
+    visit(node)
+  }
+
+  return result
+}

package/lib/worker/itc.js

@@ -2,8 +2,8 @@ import { ensureLoggableError, executeInParallel, executeWithTimeout, kTimeout }
 import { ITC } from '@platformatic/itc'
 import { Unpromise } from '@watchable/unpromise'
 import { once } from 'node:events'
-import { Duplex } from 'node:stream'
 import { createRequire } from 'node:module'
+import { Duplex } from 'node:stream'
 import { parentPort, workerData } from 'node:worker_threads'
 import {
   ApplicationExitedError,
@@ -49,7 +49,7 @@ function startSubprocessRepl (port, childManager, clientWs, controller) {
   childManager.on('repl:exit', handleReplExit)
 
   // Forward input from MessagePort to child process
-  port.on('message', (message) => {
+  port.on('message', message => {
     if (message.type === 'input') {
       childManager.send(clientWs, 'replInput', { data: message.data }).catch(() => {
         // Ignore errors if the child process has exited
@@ -212,6 +212,10 @@ export function setupITC (controller, application, dispatcher, sharedContext) {
         })
       },
 
+      async getDependencies () {
+        return controller.capability.getDependencies()
+      },
+
       async build () {
         return controller.capability.build()
       },
@@ -357,13 +361,13 @@ export function setupITC (controller, application, dispatcher, sharedContext) {
         // Create a duplex stream that wraps the MessagePort
         const replStream = new Duplex({
           read () {},
-          write (chunk, encoding, callback) {
+          write (chunk, _, callback) {
             port.postMessage({ type: 'output', data: chunk.toString() })
             callback()
           }
         })
 
-        port.on('message', (message) => {
+        port.on('message', message => {
           if (message.type === 'input') {
             replStream.push(message.data)
           } else if (message.type === 'close') {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@platformatic/runtime",
-  "version": "3.34.1-alpha.3",
+  "version": "3.35.0",
   "description": "",
   "main": "index.js",
   "type": "module",
@@ -35,14 +35,14 @@
     "typescript": "^5.5.4",
     "undici-oidc-interceptor": "^0.5.0",
     "why-is-node-running": "^2.2.2",
-    "@platformatic/composer": "3.34.1-alpha.3",
-    "@platformatic/db": "3.34.1-alpha.3",
-    "@platformatic/node": "3.34.1-alpha.3",
-    "@platformatic/service": "3.34.1-alpha.3",
-    "@platformatic/gateway": "3.34.1-alpha.3",
-    "@platformatic/sql-graphql": "3.34.1-alpha.3",
-    "@platformatic/sql-mapper": "3.34.1-alpha.3",
-    "@platformatic/wattpm-pprof-capture": "3.34.1-alpha.3"
+    "@platformatic/composer": "3.35.0",
+    "@platformatic/db": "3.35.0",
+    "@platformatic/gateway": "3.35.0",
+    "@platformatic/node": "3.35.0",
+    "@platformatic/service": "3.35.0",
+    "@platformatic/sql-graphql": "3.35.0",
+    "@platformatic/sql-mapper": "3.35.0",
+    "@platformatic/wattpm-pprof-capture": "3.35.0"
   },
   "dependencies": {
     "@fastify/accepts": "^5.0.0",
@@ -69,14 +69,14 @@
     "sonic-boom": "^4.2.0",
     "systeminformation": "^5.27.11",
     "undici": "^7.0.0",
-    "undici-thread-interceptor": "^1.0.0",
+    "undici-thread-interceptor": "^1.3.0",
     "ws": "^8.16.0",
-    "@platformatic/basic": "3.34.1-alpha.3",
-    "@platformatic/foundation": "3.34.1-alpha.3",
-    "@platformatic/itc": "3.34.1-alpha.3",
-    "@platformatic/generators": "3.34.1-alpha.3",
-    "@platformatic/metrics": "3.34.1-alpha.3",
-    "@platformatic/telemetry": "3.34.1-alpha.3"
+    "@platformatic/basic": "3.35.0",
+    "@platformatic/foundation": "3.35.0",
+    "@platformatic/generators": "3.35.0",
+    "@platformatic/itc": "3.35.0",
+    "@platformatic/telemetry": "3.35.0",
+    "@platformatic/metrics": "3.35.0"
   },
   "engines": {
     "node": ">=22.19.0"

package/schema.json

@@ -1,5 +1,5 @@
 {
-  "$id": "https://schemas.platformatic.dev/@platformatic/runtime/3.34.1-alpha.3.json",
+  "$id": "https://schemas.platformatic.dev/@platformatic/runtime/3.35.0.json",
   "$schema": "http://json-schema.org/draft-07/schema#",
   "title": "Platformatic Runtime Config",
   "type": "object",