@platformatic/runtime 0.41.1 → 0.41.3

package/fixtures/configs/monorepo-watch.json

@@ -0,0 +1,12 @@
+{
+  "$schema": "https://platformatic.dev/schemas/v0.35.0/runtime",
+  "entrypoint": "service1",
+  "hotReload": true,
+  "services": [
+    {
+      "id": "service1",
+      "path": "../monorepo-watch/service1",
+      "config": "platformatic.service.json"
+    }
+  ]
+}

package/fixtures/monorepo-watch/service1/platformatic.service.json

@@ -0,0 +1,13 @@
+{
+  "$schema": "https://platformatic.dev/schemas/v0.20.0/service",
+  "server": {
+    "hostname": "127.0.0.1",
+    "port": 0
+  },
+  "plugins": {
+    "paths": [
+      "plugin.js"
+    ]
+  },
+  "watch": false
+}

package/fixtures/monorepo-watch/service1/plugin.js

@@ -0,0 +1,8 @@
+'use strict'
+
+/** @param {import('fastify').FastifyInstance} app */
+module.exports = async function (app) {
+  app.get('/', async () => {
+    return { hello: 'world' }
+  })
+}

package/lib/app.js

@@ -85,7 +85,7 @@ class PlatformaticApp {
 
     await this.#initializeConfig()
     this.#originalWatch = this.config.configManager.current.watch
-    this.config.configManager.current.watch = false
+    this.config.configManager.current.watch = { enabled: false }
 
     const { configManager } = this.config
     configManager.update({
@@ -108,7 +108,10 @@ class PlatformaticApp {
       this.#logAndExit(err)
     }
 
-    if (config.plugins !== undefined) {
+    if (
+      config.plugins !== undefined &&
+      this.#originalWatch?.enabled !== false
+    ) {
       this.#startFileWatching()
     }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@platformatic/runtime",
-  "version": "0.41.1",
+  "version": "0.41.3",
   "description": "",
   "main": "index.js",
   "bin": {
@@ -24,8 +24,8 @@
     "standard": "^17.1.0",
     "tsd": "^0.29.0",
     "typescript": "^5.1.6",
-    "@platformatic/sql-graphql": "0.41.1",
-    "@platformatic/sql-mapper": "0.41.1"
+    "@platformatic/sql-graphql": "0.41.3",
+    "@platformatic/sql-mapper": "0.41.3"
   },
   "dependencies": {
     "@hapi/topo": "^6.0.2",
@@ -42,12 +42,12 @@
     "pino": "^8.14.1",
     "pino-pretty": "^10.0.0",
     "undici": "^5.22.1",
-    "@platformatic/composer": "0.41.1",
-    "@platformatic/config": "0.41.1",
-    "@platformatic/db": "0.41.1",
-    "@platformatic/service": "0.41.1",
-    "@platformatic/telemetry": "0.41.1",
-    "@platformatic/utils": "0.41.1"
+    "@platformatic/composer": "0.41.3",
+    "@platformatic/config": "0.41.3",
+    "@platformatic/db": "0.41.3",
+    "@platformatic/service": "0.41.3",
+    "@platformatic/telemetry": "0.41.3",
+    "@platformatic/utils": "0.41.3"
   },
   "standard": {
     "ignore": [

package/test/api.test.js

@@ -61,7 +61,9 @@ test('should get service config', async (t) => {
         join(fixturesDir, 'monorepo', 'serviceAppWithLogger', 'plugin.js')
       ]
     },
-    watch: false
+    watch: {
+      enabled: false
+    }
   })
 })
 

package/test/cli/watch.test.mjs

@@ -282,3 +282,28 @@ test('watches CommonJS files with hotreload on a single service', { timeout: 300
 
   assert.ok(restartedThirdTime)
 })
+
+test('should not watch files if watch = false', async (t) => {
+  const tmpDir = await mkdtemp(join(base, 'watch-'))
+  t.after(() => saferm(tmpDir))
+  t.diagnostic(`using ${tmpDir}`)
+  const configFileSrc = join(fixturesDir, 'configs', 'monorepo-watch.json')
+  const configFileDst = join(tmpDir, 'configs', 'monorepo-watch.json')
+  const appSrc = join(fixturesDir, 'monorepo-watch')
+  const appDst = join(tmpDir, 'monorepo-watch')
+  const cjsPluginFilePath = join(appDst, 'service1', 'plugin.js')
+
+  await Promise.all([
+    cp(configFileSrc, configFileDst),
+    cp(appSrc, appDst, { recursive: true })
+  ])
+
+  await writeFile(cjsPluginFilePath, createCjsLoggingPlugin('v1', false))
+  const { child, url } = await start('-c', configFileDst)
+  t.after(() => child.kill('SIGINT'))
+  await writeFile(cjsPluginFilePath, createCjsLoggingPlugin('v2', true))
+  await sleep(5000)
+  const res = await request(`${url}/version`)
+  const version = await res.body.text()
+  assert.strictEqual(version, 'v1')
+})