@platformatic/runtime 0.29.0 → 0.30.0

package/fixtures/dbApp/platformatic.db.json

@@ -18,5 +18,10 @@
       "versions": true
     },
     "events": false
+  },
+  "plugins": {
+    "paths": [
+      "plugin.js"
+    ]
   }
 }

package/fixtures/dbApp/plugin.js

@@ -0,0 +1,12 @@
+'use strict'
+
+/** @param {import('fastify').FastifyInstance} app */
+module.exports = async function (app) {
+  app.get('/async_crash', async () => {
+    setImmediate(() => {
+      throw new Error('boom')
+    })
+
+    return 'ok'
+  })
+}

package/fixtures/start-command-in-runtime.js

@@ -5,7 +5,8 @@ const { startCommandInRuntime } = require('../lib/unified-api')
 
 async function main () {
   const entrypoint = await startCommandInRuntime(['-c', process.argv[2]])
-  const res = await request(entrypoint)
+  const endpoint = process.argv[3] ?? '/'
+  const res = await request(entrypoint + endpoint)
 
   assert.strictEqual(res.statusCode, 200)
   process.exit(42)

package/lib/api-client.js

@@ -6,11 +6,15 @@ const { randomUUID } = require('node:crypto')
 const MAX_LISTENERS_COUNT = 100
 
 class RuntimeApiClient extends EventEmitter {
+  #exitCode
+  #exitPromise
+
   constructor (worker) {
     super()
     this.setMaxListeners(MAX_LISTENERS_COUNT)
 
     this.worker = worker
+    this.#exitPromise = this.#exitHandler()
     this.worker.on('message', (message) => {
       if (message.operationId) {
         this.emit(message.operationId, message)
@@ -24,7 +28,7 @@ class RuntimeApiClient extends EventEmitter {
 
   async close () {
     await this.#sendCommand('plt:stop-services')
-    await once(this.worker, 'exit')
+    await this.#exitPromise
   }
 
   async restart () {
@@ -59,16 +63,29 @@ class RuntimeApiClient extends EventEmitter {
     const operationId = randomUUID()
 
     this.worker.postMessage({ operationId, command, params })
-    const [message] = await once(this, operationId)
+    const [message] = await Promise.race(
+      [once(this, operationId), this.#exitPromise]
+    )
+
+    if (this.#exitCode !== undefined) {
+      throw new Error('The runtime exited before the operation completed')
+    }
 
     const { error, data } = message
     if (error !== null) {
-      this.emit('error', new Error(error))
-      return
+      throw new Error(error)
     }
 
     return JSON.parse(data)
   }
+
+  async #exitHandler () {
+    this.#exitCode = undefined
+    return once(this.worker, 'exit').then((msg) => {
+      this.#exitCode = msg[0]
+      return msg
+    })
+  }
 }
 
 module.exports = RuntimeApiClient

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@platformatic/runtime",
-  "version": "0.29.0",
+  "version": "0.30.0",
   "description": "",
   "main": "index.js",
   "bin": {
@@ -24,8 +24,8 @@
     "standard": "^17.1.0",
     "tsd": "^0.28.1",
     "typescript": "^5.1.6",
-    "@platformatic/sql-mapper": "0.29.0",
-    "@platformatic/sql-graphql": "0.29.0"
+    "@platformatic/sql-mapper": "0.30.0",
+    "@platformatic/sql-graphql": "0.30.0"
   },
   "dependencies": {
     "@hapi/topo": "^6.0.2",
@@ -40,11 +40,11 @@
     "pino": "^8.14.1",
     "pino-pretty": "^10.0.0",
     "undici": "^5.22.1",
-    "@platformatic/composer": "0.29.0",
-    "@platformatic/config": "0.29.0",
-    "@platformatic/db": "0.29.0",
-    "@platformatic/service": "0.29.0",
-    "@platformatic/utils": "0.29.0"
+    "@platformatic/composer": "0.30.0",
+    "@platformatic/config": "0.30.0",
+    "@platformatic/db": "0.30.0",
+    "@platformatic/service": "0.30.0",
+    "@platformatic/utils": "0.30.0"
   },
   "standard": {
     "ignore": [

package/test/api.test.js

@@ -275,6 +275,16 @@ test('should fail inject request is service is not started', async (t) => {
   }
 })
 
+test('does not wait forever if worker exits during api operation', async (t) => {
+  const configFile = join(fixturesDir, 'configs', 'service-throws-on-start.json')
+  const config = await loadConfig({}, ['-c', configFile], platformaticRuntime)
+  const app = await buildServer(config.configManager.current)
+
+  await assert.rejects(async () => {
+    await app.start()
+  }, /The runtime exited before the operation completed/)
+})
+
 test('should handle a lot of runtime api requests', async (t) => {
   const configFile = join(fixturesDir, 'configs', 'monorepo.json')
   const config = await loadConfig({}, ['-c', configFile], platformaticRuntime)

package/test/cli/compile.test.mjs

@@ -5,6 +5,7 @@ import path from 'node:path'
 import { cliPath } from './helper.mjs'
 import { execa } from 'execa'
 import { mkdtemp, rm, cp, mkdir } from 'node:fs/promises'
+import { setTimeout as sleep } from 'node:timers/promises'
 
 const base = join(import.meta.url, '..', 'tmp')
 
@@ -20,7 +21,6 @@ test('compile without tsconfigs', async () => {
 
 test('compile with tsconfig', async (t) => {
   const tmpDir = await mkdtemp(path.join(base, 'test-runtime-compile-'))
-
   const prev = process.cwd()
   process.chdir(tmpDir)
   t.after(() => {
@@ -28,7 +28,20 @@ test('compile with tsconfig', async (t) => {
   })
 
   t.after(async () => {
-    await rm(tmpDir, { recursive: true, force: true })
+    // We give up after 10s.
+    // This is because on Windows, it's very hard to delete files if the file
+    // system is not collaborating.
+    for (let i = 0; i < 10; i++) {
+      try {
+        await rm(tmpDir, { recursive: true, force: true })
+        break
+      } catch (err) {
+        if (err.code === 'EBUSY') {
+          await sleep(1000)
+          continue
+        }
+      }
+    }
   })
 
   const folder = join(import.meta.url, '..', '..', 'fixtures', 'typescript')

package/test/cli/watch.test.mjs

@@ -1,5 +1,5 @@
 import assert from 'node:assert'
-import { cp, writeFile, mkdtemp, mkdir } from 'node:fs/promises'
+import { cp, writeFile, mkdtemp, mkdir, rm } from 'node:fs/promises'
 import { join } from 'node:path'
 import { test } from 'node:test'
 import { setTimeout as sleep } from 'node:timers/promises'
@@ -49,6 +49,7 @@ function createEsmLoggingPlugin (text, reloaded) {
 
 test('watches CommonJS files', async (t) => {
   const tmpDir = await mkdtemp(join(base, 'watch-'))
+  t.after(() => rm(tmpDir, { recursive: true, force: true }))
   t.diagnostic(`using ${tmpDir}`)
   const configFileSrc = join(fixturesDir, 'configs', 'monorepo.json')
   const configFileDst = join(tmpDir, 'configs', 'monorepo.json')
@@ -78,6 +79,7 @@ test('watches CommonJS files', async (t) => {
 
 test('watches ESM files', async (t) => {
   const tmpDir = await mkdtemp(join(base, 'watch-'))
+  t.after(() => rm(tmpDir, { recursive: true, force: true }))
   t.diagnostic(`using ${tmpDir}`)
   const configFileSrc = join(fixturesDir, 'configs', 'monorepo.json')
   const configFileDst = join(tmpDir, 'configs', 'monorepo.json')
@@ -106,6 +108,7 @@ test('watches ESM files', async (t) => {
 
 test('should not hot reload files with `--hot-reload false', async (t) => {
   const tmpDir = await mkdtemp(join(base, 'watch-'))
+  t.after(() => rm(tmpDir, { recursive: true, force: true }))
   t.diagnostic(`using ${tmpDir}`)
   const configFileSrc = join(fixturesDir, 'configs', 'monorepo.json')
   const configFileDst = join(tmpDir, 'configs', 'monorepo.json')

package/test/start.test.js

@@ -1,5 +1,6 @@
 'use strict'
 const assert = require('node:assert')
+const { spawn } = require('node:child_process')
 const { once } = require('node:events')
 const { join } = require('node:path')
 const { test } = require('node:test')
@@ -143,3 +144,15 @@ test('can start with a custom environment', async (t) => {
   assert.strictEqual(res.statusCode, 200)
   assert.deepStrictEqual(await res.body.json(), { A_CUSTOM_ENV_VAR: 'foobar' })
 })
+
+test('handles uncaught exceptions with db app', async (t) => {
+  // Test for https://github.com/platformatic/platformatic/issues/1193
+  const scriptFile = join(fixturesDir, 'start-command-in-runtime.js')
+  const configFile = join(fixturesDir, 'dbApp', 'platformatic.db.json')
+  const child = spawn(process.execPath, [scriptFile, configFile, '/async_crash'])
+  child.stdout.pipe(process.stdout)
+  child.stderr.pipe(process.stderr)
+  const [exitCode] = await once(child, 'exit')
+
+  assert.strictEqual(exitCode, 42)
+})

package/fixtures/typescript/services/movies/package.json

@@ -1,17 +0,0 @@
-{
-  "scripts": {
-    "start": "npm run clean && platformatic start",
-    "clean": "rm -fr ./dist",
-    "build": "npx tsc",
-    "migrate": "platformatic db migrations apply"
-  },
-  "devDependencies": {
-    "fastify": "^4.18.0"
-  },
-  "dependencies": {
-    "platformatic": "^0.28.1"
-  },
-  "engines": {
-    "node": "^18.8.0 || >=19"
-  }
-}