@platformatic/rdkafka 4.0.1 → 4.1.0

package/deps/librdkafka/tests/test.h

@@ -244,22 +244,22 @@ static RD_INLINE RD_UNUSED void rtrim(char *str) {
         if (test_needs_auth()) {                                               \
                 TEST_SKIP("Mock cluster does not support SSL/SASL\n");         \
                 return RET;                                                    \
-        }                                                                      \
-        if (test_consumer_group_protocol() &&                                  \
-            strcmp(test_consumer_group_protocol(), "classic")) {               \
-                TEST_SKIP(                                                     \
-                    "Mock cluster cannot be used "                             \
-                    "with group.protocol=%s\n",                                \
-                    test_consumer_group_protocol());                           \
-                return RET;                                                    \
         }
 
-
 void test_conf_init(rd_kafka_conf_t **conf,
                     rd_kafka_topic_conf_t **topic_conf,
                     int timeout);
 
 
+typedef struct test_conf_log_interceptor_s test_conf_log_interceptor_t;
+
+test_conf_log_interceptor_t *
+test_conf_set_log_interceptor(rd_kafka_conf_t *conf,
+                              void (*log_cb)(const rd_kafka_t *rk,
+                                             int level,
+                                             const char *fac,
+                                             const char *buf),
+                              const char **debug_contexts);
 
 void test_msg_fmt(char *dest,
                   size_t dest_size,
@@ -323,7 +323,7 @@ struct test_msgver_s {
 
         const char *msgid_hdr; /**< msgid string is in header by this name,
                                 * rather than in the payload (default). */
-};                             /* test_msgver_t; */
+}; /* test_msgver_t; */
 
 /* Message */
 struct test_mv_m {
@@ -592,6 +592,8 @@ void test_verify_rkmessage0(const char *func,
 
 void test_consumer_subscribe(rd_kafka_t *rk, const char *topic);
 
+void test_consumer_subscribe_multi(rd_kafka_t *rk, int topic_count, ...);
+
 void test_consume_msgs_easy_mv0(const char *group_id,
                                 const char *topic,
                                 rd_bool_t txn,
@@ -674,6 +676,29 @@ void test_consumer_verify_assignment0(const char *func,
         test_consumer_verify_assignment0(__FUNCTION__, __LINE__, rk,           \
                                          fail_immediately, __VA_ARGS__)
 
+rd_bool_t test_consumer_verify_assignment_topic_partition_list0(
+    const char *func,
+    int line,
+    rd_kafka_t *rk,
+    const rd_kafka_topic_partition_list_t *expected_assignment);
+#define test_consumer_verify_assignment_topic_partition_list(                  \
+    rk, expected_assignment)                                                   \
+        test_consumer_verify_assignment_topic_partition_list0(                 \
+            __FUNCTION__, __LINE__, rk, expected_assignment)
+
+void test_consumer_wait_assignment_topic_partition_list0(
+    const char *func,
+    int line,
+    rd_kafka_t *rk,
+    rd_bool_t do_poll,
+    const rd_kafka_topic_partition_list_t *expected_assignment,
+    int timeout_ms);
+#define test_consumer_wait_assignment_topic_partition_list(                    \
+    rk, do_poll, expected_assignment, timeout_ms)                              \
+        test_consumer_wait_assignment_topic_partition_list0(                   \
+            __FUNCTION__, __LINE__, rk, do_poll, expected_assignment,          \
+            timeout_ms)
+
 void test_consumer_assign(const char *what,
                           rd_kafka_t *rk,
                           rd_kafka_topic_partition_list_t *parts);
@@ -684,6 +709,14 @@ void test_consumer_unassign(const char *what, rd_kafka_t *rk);
 void test_consumer_incremental_unassign(const char *what,
                                         rd_kafka_t *rk,
                                         rd_kafka_topic_partition_list_t *parts);
+void test_consumer_assign_by_rebalance_protocol(
+    const char *what,
+    rd_kafka_t *rk,
+    rd_kafka_topic_partition_list_t *parts);
+void test_consumer_unassign_by_rebalance_protocol(
+    const char *what,
+    rd_kafka_t *rk,
+    rd_kafka_topic_partition_list_t *parts);
 void test_consumer_assign_partition(const char *what,
                                     rd_kafka_t *rk,
                                     const char *topic,
@@ -698,6 +731,7 @@ void test_consumer_close(rd_kafka_t *rk);
 
 void test_flush(rd_kafka_t *rk, int timeout_ms);
 
+int test_is_forbidden_conf_group_protocol_consumer(const char *name);
 void test_conf_set(rd_kafka_conf_t *conf, const char *name, const char *val);
 char *test_topic_conf_get(const rd_kafka_topic_conf_t *tconf, const char *name);
 int test_conf_match(rd_kafka_conf_t *conf, const char *name, const char *val);
@@ -709,6 +743,7 @@ void test_any_conf_set(rd_kafka_conf_t *conf,
                        const char *name,
                        const char *val);
 
+rd_kafka_topic_partition_list_t *test_topic_partitions(int cnt, ...);
 void test_print_partition_list(
     const rd_kafka_topic_partition_list_t *partitions);
 int test_partition_list_cmp(rd_kafka_topic_partition_list_t *al,
@@ -726,6 +761,11 @@ void test_create_topic(rd_kafka_t *use_rk,
                        const char *topicname,
                        int partition_cnt,
                        int replication_factor);
+void test_create_topic_wait_exists(rd_kafka_t *use_rk,
+                                   const char *topicname,
+                                   int partition_cnt,
+                                   int replication_factor,
+                                   int timeout);
 rd_kafka_resp_err_t test_auto_create_topic_rkt(rd_kafka_t *rk,
                                                rd_kafka_topic_t *rkt,
                                                int timeout_ms);
@@ -760,6 +800,7 @@ void test_prepare_msg(uint64_t testid,
 
 #if WITH_SOCKEM
 void test_socket_enable(rd_kafka_conf_t *conf);
+void *test_socket_find(struct test *test, sockem_t *skm);
 void test_socket_close_all(struct test *test, int reinit);
 int test_socket_sockem_set_all(const char *key, int val);
 void test_socket_sockem_set(int s, const char *key, int value);
@@ -859,6 +900,12 @@ rd_kafka_resp_err_t test_delete_all_test_topics(int timeout_ms);
 void test_mock_cluster_destroy(rd_kafka_mock_cluster_t *mcluster);
 rd_kafka_mock_cluster_t *test_mock_cluster_new(int broker_cnt,
                                                const char **bootstraps);
+
+size_t test_mock_get_matching_request_cnt(
+    rd_kafka_mock_cluster_t *mcluster,
+    rd_bool_t (*match)(rd_kafka_mock_request_t *request, void *opaque),
+    void *opaque);
+
 size_t test_mock_wait_matching_requests(
     rd_kafka_mock_cluster_t *mcluster,
     size_t num,
@@ -866,6 +913,10 @@ size_t test_mock_wait_matching_requests(
     rd_bool_t (*match)(rd_kafka_mock_request_t *request, void *opaque),
     void *opaque);
 
+void test_mock_cluster_member_assignment(rd_kafka_mock_cluster_t *mcluster,
+                                         int member_cnt,
+                                         ...);
+
 int test_error_is_not_fatal_cb(rd_kafka_t *rk,
                                rd_kafka_resp_err_t err,
                                const char *reason);
@@ -873,9 +924,7 @@ int test_error_is_not_fatal_cb(rd_kafka_t *rk,
 
 const char *test_consumer_group_protocol();
 
-int test_consumer_group_protocol_generic();
-
-int test_consumer_group_protocol_consumer();
+int test_consumer_group_protocol_classic();
 
 /**
  * @brief Calls rdkafka function (with arguments)

package/deps/librdkafka/tests/testcpp.cpp

@@ -87,7 +87,7 @@ static int read_config_file(std::string path,
 }
 
 void conf_init(RdKafka::Conf **conf, RdKafka::Conf **topic_conf, int timeout) {
-  const char *tmp;
+  const char *tmp, *group_protocol;
 
   if (conf)
     *conf = RdKafka::Conf::create(RdKafka::Conf::CONF_GLOBAL);
@@ -107,6 +107,11 @@ void conf_init(RdKafka::Conf **conf, RdKafka::Conf **topic_conf, int timeout) {
       Test::Fail("TEST_DEBUG failed: " + errstr);
   }
 
+  if (*conf && (group_protocol = test_consumer_group_protocol())) {
+    if ((*conf)->set("group.protocol", group_protocol, errstr) !=
+        RdKafka::Conf::CONF_OK)
+      Test::Fail("set group.protocol failed: " + errstr);
+  }
 
   if (timeout)
     test_timeout_set(timeout);

package/deps/librdkafka/tests/testcpp.h

@@ -131,6 +131,21 @@ static RD_UNUSED void create_topic(RdKafka::Handle *use_handle,
   test_create_topic(use_rk, topicname, partition_cnt, replication_factor);
 }
 
+/**
+ * @brief Create a topic and wait for it to be available in metadata.
+ */
+static RD_UNUSED void create_topic_wait_exists(RdKafka::Handle *use_handle,
+                                               const char *topicname,
+                                               int partition_cnt,
+                                               int replication_factor,
+                                               int timeout) {
+  rd_kafka_t *use_rk = NULL;
+  if (use_handle != NULL)
+    use_rk = use_handle->c_ptr();
+  test_create_topic_wait_exists(use_rk, topicname, partition_cnt,
+                                replication_factor, timeout);
+}
+
 /**
  * @brief Delete a topic
  */
@@ -142,6 +157,14 @@ static RD_UNUSED void delete_topic(RdKafka::Handle *use_handle,
   test_delete_topic(use_rk, topicname);
 }
 
+/**
+ * @brief
+ */
+static RD_UNUSED bool is_forbidden_conf_group_protocol_consumer(
+    const std::string &name) {
+  return test_is_forbidden_conf_group_protocol_consumer(name.c_str());
+}
+
 /**
  * @brief Get new configuration objects
  */
@@ -152,6 +175,11 @@ static RD_UNUSED void conf_set(RdKafka::Conf *conf,
                                std::string name,
                                std::string val) {
   std::string errstr;
+  if (Test::is_forbidden_conf_group_protocol_consumer(name)) {
+    Test::Say(tostr() << "Skipping setting forbidden configuration " << name
+                      << " for CONSUMER protocol.\n");
+    return;
+  }
   if (conf->set(name, val, errstr) != RdKafka::Conf::CONF_OK)
     Test::Fail("Conf failed: " + errstr);
 }
@@ -163,8 +191,8 @@ static RD_UNUSED void print_TopicPartitions(
                     << " TopicPartition(s):\n");
   for (unsigned int i = 0; i < partitions.size(); i++)
     Test::Say(tostr() << " " << partitions[i]->topic() << "["
-                      << partitions[i]->partition() << "] "
-                      << "offset " << partitions[i]->offset() << ": "
+                      << partitions[i]->partition() << "] " << "offset "
+                      << partitions[i]->offset() << ": "
                       << RdKafka::err2str(partitions[i]->err()) << "\n");
 }
 

package/deps/librdkafka/tests/testshared.h

@@ -62,7 +62,7 @@ extern int test_quick;
 /** @brief Broker version to int */
 #define TEST_BRKVER(A, B, C, D) (((A) << 24) | ((B) << 16) | ((C) << 8) | (D))
 /** @brief return single version component from int */
-#define TEST_BRKVER_X(V, I) (((V) >> (24 - ((I)*8))) & 0xff)
+#define TEST_BRKVER_X(V, I) (((V) >> (24 - ((I) * 8))) & 0xff)
 
 /** @brief Topic Admin API supported by this broker version and later */
 #define TEST_BRKVER_TOPIC_ADMINAPI TEST_BRKVER(0, 10, 2, 0)
@@ -79,6 +79,12 @@ void test_create_topic(rd_kafka_t *use_rk,
                        int partition_cnt,
                        int replication_factor);
 
+void test_create_topic_wait_exists(rd_kafka_t *use_rk,
+                                   const char *topicname,
+                                   int partition_cnt,
+                                   int replication_factor,
+                                   int timeout);
+
 void test_create_partitions(rd_kafka_t *use_rk,
                             const char *topicname,
                             int new_partition_cnt);
@@ -179,10 +185,12 @@ void test_SAY(const char *file, int line, int level, const char *str);
 void test_SKIP(const char *file, int line, const char *str);
 
 void test_timeout_set(int timeout);
+int test_is_forbidden_conf_group_protocol_consumer(const char *name);
 int test_set_special_conf(const char *name, const char *val, int *timeoutp);
 char *test_conf_get(const rd_kafka_conf_t *conf, const char *name);
 const char *test_conf_get_path(void);
 const char *test_getenv(const char *env, const char *def);
+size_t test_read_file(const char *path, char *dst, size_t dst_size);
 
 int test_needs_auth(void);
 
@@ -386,7 +394,7 @@ void test_sub_skip(const char *fmt, ...) RD_FORMAT(printf, 1, 2);
 #ifndef _WIN32
 #define rd_sleep(S) sleep(S)
 #else
-#define rd_sleep(S) Sleep((S)*1000)
+#define rd_sleep(S) Sleep((S) * 1000)
 #endif
 
 /* Make sure __SANITIZE_ADDRESS__ (gcc) is defined if compiled with asan */
@@ -399,4 +407,10 @@ void test_sub_skip(const char *fmt, ...) RD_FORMAT(printf, 1, 2);
 
 int test_run_java(const char *cls, const char **argv);
 int test_waitpid(int pid);
+
+const char *test_consumer_group_protocol();
+
+int test_consumer_group_protocol_classic();
+
+
 #endif /* _TESTSHARED_H_ */

package/deps/librdkafka/tests/tools/stats/to_csv.py

@@ -115,7 +115,7 @@ for linenr, string in enumerate(sys.stdin):
     try:
         top, brokers, topics, toppars = parse(linenr, string)
     except Exception as e:
-        print(f"SKIP {linenr+1}: {e}")
+        print(f"SKIP {linenr + 1}: {e}")
         continue
 
     w_top.write_list(top)

package/deps/librdkafka/tests/xxxx-metadata.cpp

@@ -127,7 +127,7 @@ static void test_metadata_cpp(void) {
     TEST_FAIL("ISRS != 0");
   }
 
-  sleep(1);
+  rd_sleep(1);
 
   /* Second request of metadata: It have to success */
   err = producer->metadata(topic != NULL, topic, &metadata, 5000);

package/deps/librdkafka/vcpkg.json

@@ -1,6 +1,6 @@
 {
     "name": "librdkafka",
-    "version": "2.6.1",
+    "version": "2.12.0",
     "dependencies": [
         {
             "name": "zstd",

package/deps/librdkafka/win32/setup-msys2.ps1

@@ -1,10 +1,16 @@
 # Install (if necessary) and set up msys2.
+$ErrorActionPreference = "Stop"
 
+$url="https://github.com/msys2/msys2-installer/releases/download/2025-06-22/msys2-base-x86_64-20250622.sfx.exe"
+$sha256="df6c053891d0b87c9104c118c0ce22885c3bc350a7659958d6d97a6760ccfa76"
+$cacheKey = "msys2-$sha256-$Env:CACHE_TAG"
+$librdkafkaPath = Get-Location;
 
-$url="https://github.com/msys2/msys2-installer/releases/download/2024-01-13/msys2-base-x86_64-20240113.sfx.exe"
-$sha256="dba7e6d27e6a9ab850f502da44f6bfcd16d4d7b175fc2b25bee37207335cb12f"
-
-
+try {
+    cache restore $cacheKey
+} catch {
+    echo "cache command not found"
+}
 if (!(Test-Path -Path "c:\msys64\usr\bin\bash.exe")) {
     echo "Downloading and installing msys2 to c:\msys64"
 
@@ -22,10 +28,20 @@ if (!(Test-Path -Path "c:\msys64\usr\bin\bash.exe")) {
     echo "Setting up msys"
     c:\msys64\usr\bin\bash -lc ' '
 
+    # Update packages
+    echo "Updating msys2 packages"
+    c:\msys64\usr\bin\bash -lc "pacman --noconfirm -Syuu --overwrite '*'"
+    # Update pacman"
+    c:\msys64\usr\bin\bash -lc "pacman -Sy --noconfirm pacman"
+    # Install needed packages"
+    c:\msys64\usr\bin\bash -lc "pacman --sync --noconfirm --needed mingw-w64-x86_64-gcc mingw-w64-x86_64-make mingw-w64-x86_64-cmake mingw-w64-x86_64-openssl mingw-w64-x86_64-lz4 mingw-w64-x86_64-zstd"
+
+    try {
+        powershell -command "cd $librdkafkaPath; cache store $cacheKey c:\msys64"
+    } catch {
+        echo "cache command not found"
+    }
+
 } else {
     echo "Using previously installed msys2"
 }
-
-# Update packages
-echo "Updating msys2 packages"
-c:\msys64\usr\bin\bash -lc "pacman --noconfirm -Syuu --overwrite '*'"

package/deps/librdkafka/win32/setup-vcpkg.ps1

@@ -1,12 +1,34 @@
 # Set up vcpkg and install required packages.
+$version = "2025.07.25"
+$vpkgHash=(Get-FileHash ".\librdkafka\vcpkg.json").Hash
+$cacheKey = "vcpkg-$version-$Env:triplet-$vpkgHash-$Env:CACHE_TAG"
+$librdkafkaPath = ".\librdkafka";
 
+try {
+    cache restore $cacheKey
+} catch {
+    echo "cache command not found"
+}
 if (!(Test-Path -Path vcpkg/.git)) {
     git clone https://github.com/Microsoft/vcpkg.git
+    cd vcpkg
+    git checkout $version
+    .\bootstrap-vcpkg.bat
+    cd ..
+    cd librdkafka
+    ..\vcpkg\vcpkg integrate install
+    # Install required packages.
+    ..\vcpkg\vcpkg --feature-flags=versions install --triplet $Env:triplet
+    cd ..
+    try {
+        cache store $cacheKey .\vcpkg
+    } catch {
+        echo "cache command not found"
+    }
+} else {
+    cd librdkafka
+    ..\vcpkg\vcpkg integrate install
+    cd ..
+    echo "Using previously installed vcpkg"
 }
 
-cd vcpkg
-git checkout 2024.09.30
-cd ..
-
-.\vcpkg\bootstrap-vcpkg.bat
-

package/deps/librdkafka/win32/tests/tests.vcxproj

@@ -227,7 +227,13 @@
     <ClCompile Include="..\..\tests\0144-idempotence_mock.c" />
     <ClCompile Include="..\..\tests\0145-pause_resume_mock.c" />
     <ClCompile Include="..\..\tests\0146-metadata_mock.c" />
+    <ClCompile Include="..\..\tests\0147-consumer_group_consumer_mock.c" />
+    <ClCompile Include="..\..\tests\0148-offset_fetch_commit_error_mock.c" />
+    <ClCompile Include="..\..\tests\0149-broker-same-host-port.c" />
     <ClCompile Include="..\..\tests\0150-telemetry_mock.c" />
+    <ClCompile Include="..\..\tests\0151-purge-brokers.c" />
+    <ClCompile Include="..\..\tests\0152-rebootstrap.c" />
+    <ClCompile Include="..\..\tests\0153-memberid.c" />
     <ClCompile Include="..\..\tests\8000-idle.cpp" />
     <ClCompile Include="..\..\tests\8001-fetch_from_follower_mock_manual.c" />
     <ClCompile Include="..\..\tests\test.c" />

package/deps/librdkafka/win32/wingetopt.h

@@ -67,10 +67,11 @@ struct option /* specification for a long form option...        */
         int val;          /* its associated status value                */
 };
 
-enum                 /* permitted values for its `has_arg' field...        */
-{ no_argument = 0,   /* option never takes an argument        */
-  required_argument, /* option always requires an argument        */
-  optional_argument  /* option may take an argument                */
+enum /* permitted values for its `has_arg' field...        */
+{
+        no_argument = 0,   /* option never takes an argument        */
+        required_argument, /* option always requires an argument        */
+        optional_argument  /* option may take an argument                */
 };
 
 extern int getopt_long(int nargc,

package/errors.d.ts

@@ -1,4 +1,4 @@
-// ====== Generated from librdkafka 2.6.1 file src-cpp/rdkafkacpp.h ======
+// ====== Generated from librdkafka 2.12.0 file src-cpp/rdkafkacpp.h ======
 export const CODES: { ERRORS: {
   /* Internal errors to rdkafka: */
   /** Begin internal error codes (**-200**) */
@@ -128,6 +128,11 @@ export const CODES: { ERRORS: {
   ERR__AUTO_OFFSET_RESET: number,
   /** Partition log truncation detected (**-139**) */
   ERR__LOG_TRUNCATION: number,
+  /** A different record in the batch was invalid
+  *  and this message failed persisting (**-138**) */
+  ERR__INVALID_DIFFERENT_RECORD: number,
+  /** Broker is going away but client isn't terminating (**-137**) */
+  ERR__DESTROY_BROKER: number,
   /** End internal error codes (**-100**) */
   ERR__END: number,
   /* Kafka broker errors: */
@@ -344,4 +349,25 @@ export const CODES: { ERRORS: {
   ERR_FEATURE_UPDATE_FAILED: number,
   /** Request principal deserialization failed during forwarding (**97**) */
   ERR_PRINCIPAL_DESERIALIZATION_FAILURE: number,
+  /** Unknown Topic Id (**100**) */
+  ERR_UNKNOWN_TOPIC_ID: number,
+  /** The member epoch is fenced by the group coordinator (**110**) */
+  ERR_FENCED_MEMBER_EPOCH: number,
+  /** The instance ID is still used by another member in the
+  *  consumer group (**111**) */
+  ERR_UNRELEASED_INSTANCE_ID: number,
+  /** The assignor or its version range is not supported by the consumer
+  *  group (**112**) */
+  ERR_UNSUPPORTED_ASSIGNOR: number,
+  /** The member epoch is stale (**113**) */
+  ERR_STALE_MEMBER_EPOCH: number,
+  /** Client sent a push telemetry request with an invalid or outdated
+  *  subscription ID (**117**) */
+  ERR_UNKNOWN_SUBSCRIPTION_ID: number,
+  /** Client sent a push telemetry request larger than the maximum size
+  *  the broker will accept (**118**) */
+  ERR_TELEMETRY_TOO_LARGE: number,
+  /** Client metadata is stale,
+  *  client should rebootstrap to obtain new metadata (**129**) */
+  ERR_REBOOTSTRAP_REQUIRED: number,
 }}

package/lib/error.js

@@ -27,7 +27,7 @@ LibrdKafkaError.wrap = errorWrap;
  * @enum {number}
  * @constant
  */
-// ====== Generated from librdkafka 2.6.1 file src-cpp/rdkafkacpp.h ======
+// ====== Generated from librdkafka 2.12.0 file src-cpp/rdkafkacpp.h ======
 LibrdKafkaError.codes = {
 
   /* Internal errors to rdkafka: */
@@ -158,6 +158,11 @@ LibrdKafkaError.codes = {
   ERR__AUTO_OFFSET_RESET: -140,
   /** Partition log truncation detected */
   ERR__LOG_TRUNCATION: -139,
+  /** A different record in the batch was invalid
+  *  and this message failed persisting. */
+  ERR__INVALID_DIFFERENT_RECORD: -138,
+  /** Broker is going away but client isn't terminating */
+  ERR__DESTROY_BROKER: -137,
   /** End internal error codes */
   ERR__END: -100,
   /* Kafka broker errors: */
@@ -373,7 +378,28 @@ LibrdKafkaError.codes = {
   /** Unable to update finalized features due to server error */
   ERR_FEATURE_UPDATE_FAILED: 96,
   /** Request principal deserialization failed during forwarding */
-  ERR_PRINCIPAL_DESERIALIZATION_FAILURE: 97
+  ERR_PRINCIPAL_DESERIALIZATION_FAILURE: 97,
+  /** Unknown Topic Id */
+  ERR_UNKNOWN_TOPIC_ID: 100,
+  /** The member epoch is fenced by the group coordinator */
+  ERR_FENCED_MEMBER_EPOCH: 110,
+  /** The instance ID is still used by another member in the
+  *  consumer group */
+  ERR_UNRELEASED_INSTANCE_ID: 111,
+  /** The assignor or its version range is not supported by the consumer
+  *  group */
+  ERR_UNSUPPORTED_ASSIGNOR: 112,
+  /** The member epoch is stale */
+  ERR_STALE_MEMBER_EPOCH: 113,
+  /** Client sent a push telemetry request with an invalid or outdated
+  *  subscription ID. */
+  ERR_UNKNOWN_SUBSCRIPTION_ID: 117,
+  /** Client sent a push telemetry request larger than the maximum size
+  *  the broker will accept. */
+  ERR_TELEMETRY_TOO_LARGE: 118,
+  /** Client metadata is stale,
+  *  client should rebootstrap to obtain new metadata. */
+  ERR_REBOOTSTRAP_REQUIRED: 129
 };
 
 /**
@@ -405,7 +431,7 @@ function LibrdKafkaError(e) {
       this.origin = 'kafka';
     }
     Error.captureStackTrace(this, this.constructor);
-  } else if (!util.isError(e)) {
+  } else if (!(e instanceof Error || Object.prototype.toString.call(e) === '[object Error]')) {
     // This is the better way
     this.message = e.message;
     this.code = e.code;

package/package.json

@@ -1,16 +1,9 @@
 {
   "name": "@platformatic/rdkafka",
-  "version": "v4.0.1",
+  "version": "4.1.0",
   "description": "Node.js bindings for librdkafka",
-  "librdkafka": "2.6.1",
+  "librdkafka": "2.12.0",
   "main": "lib/index.js",
-  "scripts": {
-    "configure": "node-gyp configure",
-    "build": "node-gyp build --debug",
-    "test": "make test",
-    "install": "node-gyp rebuild",
-    "prepack": "node ./ci/prepublish.js"
-  },
   "keywords": [
     "kafka",
     "librdkafka"
@@ -39,15 +32,22 @@
     "jsdoc": "^4.0.2",
     "jshint": "^2.10.1",
     "mocha": "^11.7.0",
-    "node-gyp": "^10.1.0",
+    "node-gyp": "^11.1.0",
+    "semver": "^7.8.5",
     "taffydb": "^2.7.3",
     "toolkit-jsdoc": "^1.0.0"
   },
   "dependencies": {
     "bindings": "^1.3.1",
-    "nan": "^2.19.0"
+    "nan": "^2.24.0"
   },
   "engines": {
     "node": ">=16"
+  },
+  "scripts": {
+    "configure": "node-gyp configure",
+    "build": "node-gyp build --debug",
+    "test": "make test",
+    "install": "node-gyp rebuild"
   }
 }

package/src/callbacks.cc

@@ -57,7 +57,7 @@ Dispatcher::~Dispatcher() {
   if (callbacks.size() < 1) return;
 
   for (size_t i=0; i < callbacks.size(); i++) {
-    callbacks[i].Reset();
+    delete callbacks[i];
   }
 
   Deactivate();
@@ -100,24 +100,21 @@ void Dispatcher::Dispatch(const int _argc, Local<Value> _argv[]) {
   }
 
   for (size_t i=0; i < callbacks.size(); i++) {
-    v8::Local<v8::Function> f = Nan::New<v8::Function>(callbacks[i]);
-    Nan::Callback cb(f);
-    cb.Call(_argc, _argv);
+    callbacks[i]->Call(_argc, _argv);
   }
 }
 
 void Dispatcher::AddCallback(const v8::Local<v8::Function> &cb) {
-  Nan::Persistent<v8::Function,
-                  Nan::CopyablePersistentTraits<v8::Function> > value(cb);
-  // PersistentCopyableFunction value(func);
+  Nan::Callback *value = new Nan::Callback(cb);
   callbacks.push_back(value);
 }
 
 void Dispatcher::RemoveCallback(const v8::Local<v8::Function> &cb) {
   for (size_t i=0; i < callbacks.size(); i++) {
-    if (callbacks[i] == cb) {
-      callbacks[i].Reset();
+    if (callbacks[i]->GetFunction() == cb) {
+      Nan::Callback *found_callback = callbacks[i];
       callbacks.erase(callbacks.begin() + i);
+      delete found_callback;
       break;
     }
   }

package/src/callbacks.h

@@ -18,10 +18,6 @@
 #include "rdkafkacpp.h"
 #include "src/common.h"
 
-typedef Nan::Persistent<v8::Function,
-  Nan::CopyablePersistentTraits<v8::Function> > PersistentCopyableFunction;
-typedef std::vector<PersistentCopyableFunction> CopyableFunctionList;
-
 namespace NodeKafka {
 
 class KafkaConsumer;
@@ -42,7 +38,7 @@ class Dispatcher {
   void Deactivate();
 
  protected:
-  CopyableFunctionList callbacks;
+  std::vector<Nan::Callback*> callbacks;  // NOLINT
 
   uv_mutex_t async_lock;