@platformatic/metrics 3.72.0 → 4.0.0-alpha.1

package/index.js

@@ -197,9 +197,6 @@ export function collectHttpClientMetrics (registry) {
     name: 'http_client_request_duration_seconds',
     help: 'outgoing HTTP client request duration in seconds',
     labelNames: ['method', 'status_code', 'dispatcher_stats_url', 'error_type'],
-    collect: function () {
-      process.nextTick(() => this.reset())
-    },
     registers: [registry]
   })
 
@@ -271,17 +268,11 @@ function collectHttpServerMetrics (registry, metricsConfig) {
     getCustomLabels,
     histogram: {
       name: 'http_request_all_duration_seconds',
-      help: 'request duration in seconds summary for all requests',
-      collect: function () {
-        process.nextTick(() => this.reset())
-      }
+      help: 'request duration in seconds summary for all requests'
     },
     summary: {
       name: 'http_request_all_summary_seconds',
-      help: 'request duration in seconds histogram for all requests',
-      collect: function () {
-        process.nextTick(() => this.reset())
-      }
+      help: 'request duration in seconds histogram for all requests'
     }
   })
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@platformatic/metrics",
-  "version": "3.72.0",
+  "version": "4.0.0-alpha.1",
   "description": "Platformatic Capability Metrics",
   "main": "index.js",
   "type": "module",
@@ -15,10 +15,10 @@
   },
   "homepage": "https://github.com/platformatic/platformatic#readme",
   "dependencies": {
-    "@platformatic/globals": "3.72.0",
     "@platformatic/http-metrics": "^0.3.0",
     "@platformatic/promotel": "^0.2.0",
-    "@platformatic/prom-client": "^1.0.0"
+    "@platformatic/prom-client": "^1.0.0",
+    "@platformatic/globals": "4.0.0-alpha.1"
   },
   "devDependencies": {
     "cleaner-spec-reporter": "^0.5.0",
@@ -26,7 +26,7 @@
     "neostandard": "^0.12.0"
   },
   "engines": {
-    "node": ">=22.19.0"
+    "node": ">=24.20.0"
   },
   "scripts": {
     "test": "node --test --test-reporter=cleaner-spec-reporter --test-concurrency=1 --test-timeout=2000000 test/*.test.js",

package/test/index.test.js

@@ -138,7 +138,26 @@ test('httpMetrics observes outgoing HTTP client request errors', async t => {
   assert.strictEqual(count.labels.error_type, 'UND_ERR_SOCKET')
 })
 
-test('httpMetrics histogram resets after metric collection', async t => {
+test('httpMetrics client histogram is not reset after metric collection', async t => {
+  const result = await collectMetrics('test-service', 1, { httpMetrics: true, httpClientMetrics: true })
+  t.after(() => clearRegistry(result.registry))
+
+  const request = { method: 'GET', origin: 'http://dependency.internal', path: '/' }
+  channel('undici:request:create').publish({ request })
+  channel('undici:request:headers').publish({ request, response: { statusCode: 200 } })
+  channel('undici:request:trailers').publish({ request })
+
+  await result.registry.metrics()
+
+  await nextTick()
+
+  const metrics = await result.registry.getMetricsAsJSON()
+  const histogram = metrics.find(m => m.name === 'http_client_request_duration_seconds')
+  const count = histogram.values.find(v => v.metricName === 'http_client_request_duration_seconds_count')
+  assert.strictEqual(count.value, 1, 'client histogram count should be preserved')
+})
+
+test('httpMetrics histogram is not reset after metric collection', async t => {
   const result = await collectMetrics('test-service', 1, { httpMetrics: true })
   t.after(() => clearRegistry(result.registry))
 
@@ -163,11 +182,11 @@ test('httpMetrics histogram resets after metric collection', async t => {
 
   const sum = histogramAfter.values.find(v => v.metricName === 'http_request_all_duration_seconds_sum')
   const count = histogramAfter.values.find(v => v.metricName === 'http_request_all_duration_seconds_count')
-  assert.strictEqual(sum?.value || 0, 0, 'histogram sum should be reset to 0')
-  assert.strictEqual(count?.value || 0, 0, 'histogram count should be reset to 0')
+  assert.ok(Math.abs(sum.value - 0.6) < 1e-9, 'histogram sum should be preserved')
+  assert.strictEqual(count.value, 3, 'histogram count should be preserved')
 })
 
-test('httpMetrics summary resets after metric collection', async t => {
+test('httpMetrics summary is not reset after metric collection', async t => {
   const result = await collectMetrics('test-service', 1, { httpMetrics: true })
   t.after(() => clearRegistry(result.registry))
 
@@ -192,8 +211,8 @@ test('httpMetrics summary resets after metric collection', async t => {
 
   const sum = summaryAfter.values.find(v => v.metricName === 'http_request_all_summary_seconds_sum')
   const count = summaryAfter.values.find(v => v.metricName === 'http_request_all_summary_seconds_count')
-  assert.strictEqual(sum?.value || 0, 0, 'summary sum should be reset to 0')
-  assert.strictEqual(count?.value || 0, 0, 'summary count should be reset to 0')
+  assert.ok(Math.abs(sum.value - 0.75) < 1e-9, 'summary sum should be preserved')
+  assert.strictEqual(count.value, 3, 'summary count should be preserved')
 })
 
 // Tests for buildCustomLabelsConfig