@platformatic/metrics 2.55.0 → 2.56.0

package/index.js

@@ -16,7 +16,7 @@ async function collectMetrics (serviceId, workerId, metricsConfig = {}, registry
   const httpResponseCallbacks = []
 
   const labels = { ...metricsConfig.labels, serviceId }
-  if (workerId) {
+  if (workerId >= 0) {
     labels.workerId = workerId
   }
   registry.setDefaultLabels(labels)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@platformatic/metrics",
-  "version": "2.55.0",
+  "version": "2.56.0",
   "description": "Platformatic Stackable Metrics",
   "main": "index.js",
   "type": "commonjs",
@@ -25,7 +25,7 @@
     "neostandard": "^0.12.0"
   },
   "scripts": {
-    "test": "npm run lint",
+    "test": "npm run lint && borp",
     "lint": "eslint"
   }
 }

package/test/index.test.js

@@ -0,0 +1,61 @@
+'use strict'
+
+const assert = require('node:assert')
+const { test } = require('node:test')
+const { collectMetrics, client } = require('..')
+
+test('returns expected structure', async () => {
+  const result = await collectMetrics('test-service', 1, {})
+
+  assert.ok(result.registry)
+  assert.equal(typeof result.startHttpTimer, 'function')
+  assert.equal(typeof result.endHttpTimer, 'function')
+})
+
+test('accepts custom registry', async () => {
+  const customRegistry = new client.Registry()
+  const result = await collectMetrics('test-service', 1, {}, customRegistry)
+
+  assert.strictEqual(result.registry, customRegistry)
+})
+
+test('with defaultMetrics enabled', async () => {
+  const result = await collectMetrics('test-service', 1, {
+    defaultMetrics: true
+  })
+
+  const metrics = await result.registry.getMetricsAsJSON()
+  assert.ok(metrics.length > 0)
+})
+
+test('thread cpu metrics are created when defaultMetrics is enabled', async () => {
+  const result = await collectMetrics('test-service', 1, {
+    defaultMetrics: true
+  })
+
+  const metrics = await result.registry.getMetricsAsJSON()
+  const metricNames = metrics.map(m => m.name)
+
+  assert.ok(metricNames.includes('thread_cpu_user_system_seconds_total'))
+  assert.ok(metricNames.includes('thread_cpu_system_seconds_total'))
+  assert.ok(metricNames.includes('thread_cpu_seconds_total'))
+  assert.ok(metricNames.includes('thread_cpu_percent_usage'))
+})
+
+test('workerId is properly included in labels when zero', async () => {
+  const result = await collectMetrics('test-service', 0, { defaultMetrics: true })
+  const [{ values }] = await result.registry.getMetricsAsJSON()
+  assert.strictEqual(values[0].labels.workerId, 0)
+})
+
+test('workerId is properly included in labels when positive', async () => {
+  const result = await collectMetrics('test-service', 42, { defaultMetrics: true })
+  const [{ values }] = await result.registry.getMetricsAsJSON()
+  assert.strictEqual(values[0].labels.workerId, 42)
+})
+
+test('workerId is NOT included in labels when negative', async () => {
+  const result = await collectMetrics('test-service', -42, { defaultMetrics: true })
+  const [{ values }] = await result.registry.getMetricsAsJSON()
+  assert.strictEqual(values[0].labels.workerId, undefined)
+})